Commit Graph

1590 Commits

Author SHA1 Message Date
niklas.enbom@webrtc.org
87885e8409 This CL will look a bit strange. Essentially I've removed sanity checks for > 1 channel and then fixed the bugs that remained. Will add testing in a separate CL.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1623 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:48:59 +00:00
phoglund@webrtc.org
2726cd22c9 Reconfigured which tests run on the integration test build bot.
The VoE Volume Test is flaky and is probably very hard to fix. The video auto tests are ready to be enabled, except the full stack test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1622 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 12:13:58 +00:00
kjellander@webrtc.org
4ef5d493c7 Enabling and disabling tests
* audio_coding_module_test: enabling on Windows.
* audio_conference_mixer_unittests: enabling on Windows.
* audio_device_test_api: disabling on Mac, since this test is failing but not reporting failure. See issue 257 for more details.
* media_file_unittests: enabling on Windows.
* rtp_rtcp_unittests: enabling on Windows.
* test_bwe: enabling on Windows.
* test_fec: enabling on all platforms. See CL 369008 and 379010.
* test_support_unittests: enabling on all platforms.
* udp_transport_unittests: enabling on Windows.
* video_codecs_test_framework_unittests: adding disabled test on all platforms.
* video_codecs_test_framework_integrationtests: enabling on all platforms.
* video_processing_unittests: enabling on Windows, since issue 247 is fixed.

BUG=
TEST=Tried out on the master during after-office hours.

Review URL: http://webrtc-codereview.appspot.com/379011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1621 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 08:33:47 +00:00
bjornv@webrtc.org
530963925e Solves buffer overrun crash on Windows [issue 258].
Removed function calls not tested. Added a TODO on activating them when refactoring signal_processing.
Review URL: https://webrtc-codereview.appspot.com/379012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1620 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 08:10:46 +00:00
andrew@webrtc.org
14979ed4e6 Revert libyuv to r121.
TBR=stefan@webrtc.org
BUG=267
TEST=libyuv_unittest

Review URL: https://webrtc-codereview.appspot.com/387001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1619 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 05:13:02 +00:00
andrew@webrtc.org
2aa40aa087 Roll Chromium 114939->120526.
Dependencies:
gyp 1107->1187
libjpeg_turbo 95800->119959
jsoncpp 246->248
libyuv 121->164

Updates clang to version 3.1 (trunk 149419).

BUG=
TEST=build on Linux, Mac, Win. video_processing_unittest, libyuv_unittests, (jpeg_test doesn't work before this change), vie_auto_test.

Review URL: https://webrtc-codereview.appspot.com/386002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1618 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 04:14:58 +00:00
andrew@webrtc.org
daacee81b8 Use better reference files with audioproc_unittest.
The files are shorter (7 s) with one set provided for each sample rate.

Will be accompanied by the following set of files in the resource bundle:
far8_stereo.pcm
far16_stereo.pcm
far32_stereo.pcm
near8_stereo.pcm
near16_stereo.pcm
near32_stereo.pcm

BUG=114
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/380003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1617 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 00:01:04 +00:00
henrike@webrtc.org
2660460b89 Fixes flakyness in CPU unittest
Review URL: https://webrtc-codereview.appspot.com/377005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1616 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:33:54 +00:00
wu@webrtc.org
06c7dbae14 Disable flaky test AudioProcessingTest.TestVoiceActivityDetectionWithObserver.
BUG=263
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/380009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1615 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:13:21 +00:00
wu@webrtc.org
50099af75f Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss.
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001 Coverity fix for issues 10325,10326.
Review URL: https://webrtc-codereview.appspot.com/377001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 19:02:54 +00:00
phoglund@webrtc.org
56b85c6ba8 Reduced potential for flakiness in voice detection tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1612 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 18:48:33 +00:00
wu@webrtc.org
13e0345b35 Fix uninitialized variable error in Relase mode.
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/377007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1611 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 16:19:15 +00:00
mflodman@webrtc.org
517e5e3846 NetEQ switch fix.
Review URL: https://webrtc-codereview.appspot.com/381006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1610 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 15:04:00 +00:00
stefan@webrtc.org
94355e0a59 Fix crash in SessionInfo::BuildSoftNackList.
BUG=259
TEST=

Review URL: https://webrtc-codereview.appspot.com/377006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1609 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:06:39 +00:00
mflodman@webrtc.org
a39621ee1b Disabling APM test for invalid enum values.
Review URL: https://webrtc-codereview.appspot.com/378006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1608 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:00:12 +00:00
mflodman@webrtc.org
ec31bc1321 Fixed APM tests.
TEST=ApmTest.*

Review URL: https://webrtc-codereview.appspot.com/380008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1607 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 12:42:45 +00:00
mflodman@webrtc.org
657b2a4965 Added return due to gcc complaints in r1604.
TBR=andrew

TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.

Review URL: https://webrtc-codereview.appspot.com/384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
phoglund@webrtc.org
86ce46d4ff Cleaned up and completed current dashboard milestone.
Left to do:
- Directory reorganization.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/384003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1605 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:55:12 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
kjellander@webrtc.org
5eeaa38573 Improved readability of tests in master.cfg and enabling some tests
Focused responsibility of supported tests in master.cfg instead of being in utils.py (hard to overview and maintain).

Enabled the following empty tests on all platforms:
- audio_conference_mixer_unittests
- cng_unittests
- g711_unittests
- g722_unittests
- pcm16b_unittests
- media_file_unittests
- udp_transport_unittests
- webrtc_utility_unittests

Removed "headless tests" concept since everything is now compiled in the make all step (no need for compile only, no execution tests).
Removed audio_device_test_func test since not a proper test (dev tool) that was configured as headless.

BUG=
TEST=Ran local master and successfully built and executed all tests with Mac build slave.

Review URL: http://webrtc-codereview.appspot.com/384002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1603 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 09:41:26 +00:00
andrew@webrtc.org
4942832928 Fix "may be used uninitialized" warning.
TBR=marpan@webrtc.org
BUG=
TEST=build on Linux/Release and rtp_rtcp_unittests

Review URL: https://webrtc-codereview.appspot.com/381004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1602 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 05:23:51 +00:00
marpan@webrtc.org
b783a55df3 Unit test for forward_error_correction.
Review URL: https://webrtc-codereview.appspot.com/358006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1601 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:46:35 +00:00
marpan@webrtc.org
307c1ff20c Fix for issue #254: windows crash of test_fec.
Review URL: https://webrtc-codereview.appspot.com/379010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:45:22 +00:00
andrew@webrtc.org
dde977ec83 AudioFrame payload shouldn't be mutable.
This requires making Mute() non-const, which is correct anyway.

BUG=
TEST=voe_auto_test on Linux

Review URL: https://webrtc-codereview.appspot.com/376001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1599 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 17:47:32 +00:00
kjellander@webrtc.org
ce0a6ff43d Restoring previous vie_auto_test.gypi structure due to problems on Mac
Now the unit test is included in the vie_auto_test target and executed when the automated flag is used.

TBR=mflodman
BUG=
TEST=vie_auto_test --automated --gtest_filter=FrameDropPrimitivesTest.FixOutputFileForComparison

Review URL: https://webrtc-codereview.appspot.com/381003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1598 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 14:06:46 +00:00
kjellander@webrtc.org
918a8bf40c External transport is modified to never drop packets from the first frame.
Refactoring of FrameDropHandler: It now also tracks when frames are leaving the encoder and is being sent to external transport.

Previous 'Sent' state is now renamed to 'Created'.

NOTICE: The test seems to be a little flaky on Linux so it's not ready for buildbots yet. Since this might be caused by unstable production code further investigation should be performed to clear out the flakiness. I will file an issue for this when this CL is submitted (since I don't have any code to refer to before that). Usually the flakiness is caused by a decoded/rendered callback that is left out for the last frame, but I have seen other flaky failures too, which means it's not as simple as ignoring the last frame.
These errors occur even if 400kbps bit rate and 0% PL and 0 delay is configured.

BUG=
TEST=vie_auto_test --automated --gtest_filter="ViEVideoVerificationTest.RunsFullStackWithoutErrors" in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1597 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 12:40:28 +00:00
henrik.lundin@webrtc.org
683833442a Fix for warning in GCC 4.6
Upstream copy of a fix provided in http://codereview.chromium.org/9309007/.

BUG=none
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/383002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1596 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 12:33:50 +00:00
henrik.lundin@webrtc.org
82e1c8d0e7 Fix for issue 253
Initializing a few arrays to avoid compiler warnings under
the O3 flag.

BUG=http://code.google.com/p/webrtc/issues/detail?id=253

Review URL: https://webrtc-codereview.appspot.com/380005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1595 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 09:46:01 +00:00
pwestin@webrtc.org
fdf21c8c55 Removed dead version code.
Review URL: https://webrtc-codereview.appspot.com/377003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1594 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:46:58 +00:00
pwestin@webrtc.org
4ea57e5e26 Changed VP8 to follow the style guide a little bit more.
Review URL: https://webrtc-codereview.appspot.com/379003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1593 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:21:47 +00:00
xians@webrtc.org
9b3474aff8 Disable the unused API interfaces for VoE chromium build.
Review URL: https://webrtc-codereview.appspot.com/377002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1592 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:59:11 +00:00
stefan@webrtc.org
07b45a5dc4 Added API for getting the send-side estimated bandwidth.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/372006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:37:48 +00:00
leozwang@webrtc.org
ac7e89ff1c Correct and update LICENSE
Review URL: https://webrtc-codereview.appspot.com/382001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1590 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 23:04:48 +00:00
kma@webrtc.org
de66b91274 In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl,
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 18:39:44 +00:00
phoglund@webrtc.org
2b87891901 Implemented build status tracking.
Left to do:
- UI for presenting the data
- Directory structure reorganization

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/382003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1588 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 17:08:03 +00:00
henrikg@webrtc.org
fede80c0b8 Updated test web page info for PeerConnection v2.
Different loopback pages are needed for v1 and v2.

Also removed obsolete comment.
Review URL: https://webrtc-codereview.appspot.com/375005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1587 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 13:10:48 +00:00
phoglund@webrtc.org
d4f0a0e2bc Refactored the dashboard in order to add new functionality and added some new functionality.
Note that all files were moved to a new directory. The diffs won't be 100% friendly because of this.

Extracted common handling for OAuth on both sides of the connection in order to add a new build status
data handler. This data handler will be used to report build status data. Don't look too closely at the
details of what data is transferred as this will change in the next patch. We will also extract data from
a different page in a slightly different way, but there won't be huge differences.

In particular, we won't look at the /one_box_per_builder page on the master but rather at the transposed
grid (/tgrid) on the build master since we also need the revision number. The regular expressions to
extract the data will be slightly more complex.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1586 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 10:59:23 +00:00
andrew@webrtc.org
7fe219f681 Add some additional checks for corrupt payload.
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.

BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.

Review URL: https://webrtc-codereview.appspot.com/369015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 02:40:37 +00:00
mallinath@webrtc.org
1f238fd316 Update libsrtp revision in DEPS to chrome/deps/../libsrtp@119742.
Review URL: https://webrtc-codereview.appspot.com/381001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1584 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 01:27:15 +00:00
kma@webrtc.org
727a0a03a1 Fixed a bug in assembly code in aecm_core.c (hasn't caused a problem yet).
Did apm unit test. Bit exact.
Review URL: https://webrtc-codereview.appspot.com/366010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1583 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 00:05:22 +00:00
frkoenig@google.com
d8f58a4ab0 Cross platform build fix for SSIM (part 2)
Data alignment fix for SSIM.

WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128.  By declaring the 
variable as __m128i it will always be 128 bytes aligned.

Related to issue 239013.
http://webrtc-codereview.appspot.com/239013/
Review URL: https://webrtc-codereview.appspot.com/375004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1582 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 17:49:38 +00:00
bjornv@webrtc.org
26e8a58130 VAD refactor: Create() and Free()
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.

TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 14:42:50 +00:00
henrik.lundin@webrtc.org
dd478e2081 Fix for warning in GCC 4.6
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/.

Review URL: https://webrtc-codereview.appspot.com/369024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 13:12:41 +00:00
xians@webrtc.org
79af734807 This patch fixes the converity warnings in voice engine.
Review URL: https://webrtc-codereview.appspot.com/373017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1579 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 12:22:14 +00:00
stefan@webrtc.org
91c630851a Fix potential VCMReceiver crash.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 10:49:08 +00:00
henrika@webrtc.org
2919e95c2a Resolves Coverty issue #10347.
Uninitialized member (UNINIT_CTOR).
Review URL: https://webrtc-codereview.appspot.com/369023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1577 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 08:45:03 +00:00
marpan@webrtc.org
cdba1a836b test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file.
Review URL: https://webrtc-codereview.appspot.com/373016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 00:36:14 +00:00
andrew@webrtc.org
293d22b39b Add a new macro for bit-exact audioproc tests.
Enable bit-exact test for all fixed-point configs.

BUG=114
TEST=audioproc_unittest on all platforms.

Review URL: https://webrtc-codereview.appspot.com/369018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1575 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 22:04:26 +00:00
andrew@webrtc.org
72fe2443ea Fix neteq watchlist.
TBR=henrik.lundin@webrtc.org
BUG=
TEST=watchlists.py

Review URL: https://webrtc-codereview.appspot.com/369020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1574 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 21:57:43 +00:00