Commit Graph

303 Commits

Author SHA1 Message Date
stefan@webrtc.org
4c059d87b3 Add metric for number of packets discarded by JB due to not being decodable
Also fixes a couple of bugs related to sequence number wrap found while
testing.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/218001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@732 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 07:35:37 +00:00
wu@webrtc.org
77d7d5455e Replace the DestroyDeviceInfo with a virtual destructor.
Review URL: http://webrtc-codereview.appspot.com/212005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@731 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-12 16:57:53 +00:00
wu@webrtc.org
ea89922b56 Add VideoCaptureFactory so that we don't need to expose VideoCaptureImpl.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/213002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@727 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 17:13:51 +00:00
andrew@webrtc.org
199f4defd3 Rename all .cc files which include Objective-C headers to .mm.
This allows the Mac Make build to pass. We were hacking it in XCode with "-x objective-c++", but gyp/Make doesn't seem to accept that flag.

Also switch Objective-C #includes to #imports.

There is one file missing from this: vie_autotest_main.cc, because it's required on multiple platforms. I'm not immediately sure what the best approach is there, but the Objective-C headers should be somehow hidden.
Review URL: http://webrtc-codereview.appspot.com/153005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@726 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 15:43:35 +00:00
stefan@webrtc.org
791eec7424 Add API to get the number of packets discarded by the video jitter buffer due to being too late.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/200001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@723 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 07:53:43 +00:00
stefan@webrtc.org
06887aebae Fixes two bugs when decoding with packet losses.
Disable _missingFrame bit since we can't set it correctly with FEC.

No longer return more than one decoded frame per Decode() call.
This is a work-around for a bug where the frame info map was popped more often than items were added to the map.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/215001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@722 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 14:17:46 +00:00
kjellander@webrtc.org
25e0b8e3a0 Python output flag and keyframe interval flags.
Refactored main method into using 6 helper methods for better overview.

Review URL: http://webrtc-codereview.appspot.com/207001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@710 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-07 07:52:00 +00:00
kjellander@webrtc.org
a31b254084 Python output flag and keyframe interval flags.
Refactored main method into using 6 helper methods for better overview.

Review URL: http://webrtc-codereview.appspot.com/207001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@709 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-07 06:50:22 +00:00
henrike@webrtc.org
bf54ef9bb7 Removed code under a non-existing define.
Review URL: http://webrtc-codereview.appspot.com/193006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@706 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 18:14:25 +00:00
andrew@webrtc.org
b2d4921f3b Remove trailing whitespace in AudioDevice.
(That I introduced...)
Review URL: http://webrtc-codereview.appspot.com/198002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@703 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 16:34:36 +00:00
kjellander@webrtc.org
35a1756502 First version of video quality measurement program and test framework.
See https://docs.google.com/a/google.com/document/d/1w6Nrxw6yTg_sDu18Ux8oZPEMo5F_R-zt62udrmmTeOc/edit?hl=en_US
for background, details and additional instructions on usage.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/175001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@700 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 06:44:54 +00:00
kma@webrtc.org
af57de006a Some code style changes in audio_processing/ns/main/source/ by Astyle,
with a little manual modification.
Review URL: http://webrtc-codereview.appspot.com/201002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@698 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 23:36:01 +00:00
henrik.lundin@webrtc.org
01ca01f6e6 Adding neteq_tests to modules tests
Also moving neteq_tests.gyp and renaming to gypi. Cleaning up a
little in neteq_tests.gypi.

Review URL: http://webrtc-codereview.appspot.com/191004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@696 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 20:38:19 +00:00
kma@webrtc.org
bbc1f10187 Changed modules/audio_processing/utility/Android.mk, to correct a build error in
Android with the change from version r674.
Review URL: http://webrtc-codereview.appspot.com/197003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@694 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 18:09:02 +00:00
kma@webrtc.org
bf39ff4271 Some general optimization in NS.
No big effort in introducing new style.
Speed improved ~2%.
Bit exact.
Will introduce mulpty-and-accumulate and sqrt_floor next, which increase speed another 2% or so.

Note: In function WebRtcNsx_DataAnalysis, did the block separation because I found one "if" case is more frequent than "else" within a for loop; rest is kind of code re-aligning.
Review URL: http://webrtc-codereview.appspot.com/181002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@692 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 17:10:06 +00:00
stefan@webrtc.org
4b6f747373 Fixes a newly introduced bug in the jitter buffer where buffer reallocation
causes corrupt pointers.
Review URL: http://webrtc-codereview.appspot.com/186003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@688 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:58:39 +00:00
stefan@webrtc.org
93d216c23f Fixed bug in jitter buffer which caused the missingFrames bit to never be set.
Also updated the VP8 wrapper to return fully concealed frames (for rendering).

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/190003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@687 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:48:11 +00:00
stefan@webrtc.org
61b4abf1f8 Proper use of frame rate argument in generic_codec_test.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/181005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@686 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:40:21 +00:00
mikhal@webrtc.org
e06be4f678 video coding tests: Adding ssimFrame to interface
Review URL: http://webrtc-codereview.appspot.com/188004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@685 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:43 +00:00
mikhal@webrtc.org
ae7a0522c5 video_coding robustness: Updating hybrid mode's settings
1. Disabling adjustment factor - temporary update. 
2. Enabling a windowed filtered loss for the hybrid mode.  
Review URL: http://webrtc-codereview.appspot.com/192003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@684 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:34 +00:00
marpan@google.com
f1f3fb33b5 Update to rate-mismatch factor in media_opt_util.
Review URL: http://webrtc-codereview.appspot.com/193003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@678 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 19:09:45 +00:00
stefan@webrtc.org
5b91464edf Allow an aggregated partition to spill over to a new packet.
Adds support for the case where the partition 0 and parts of partition 1
are transmitted in packet 1, and the end of partition 2 is transmitted
in packet 2.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/181003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@675 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 10:26:12 +00:00
bjornv@google.com
1ba3dbecbb Adds possibility to log delay estimates in AEC.
Review URL: http://webrtc-codereview.appspot.com/178001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@674 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 08:18:10 +00:00
kma@google.com
c611b1a950 Bit-exact with non-Neon version.
Review URL: http://webrtc-codereview.appspot.com/180002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@660 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-28 16:03:38 +00:00
andrew@webrtc.org
18421f2063 Remove unnecessary include from NS interface.
http://code.google.com/p/webrtc/issues/detail?id=46
Review URL: http://webrtc-codereview.appspot.com/183001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@656 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 19:50:52 +00:00
mikhal@webrtc.org
848fad23c6 video_coding: Updating media opt test - fixing call to protection callback.
Review URL: http://webrtc-codereview.appspot.com/179003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@653 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 16:30:59 +00:00
bjornv@google.com
a2c6ea09b0 Removed a segmentation fault error when processing near_file only.
Review URL: http://webrtc-codereview.appspot.com/174001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@650 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 08:04:45 +00:00
mikhal@webrtc.org
e185e9f68a video_coding: updates to jitter buffer logic: Make sure that every frame is inserted only once to the list.
Review URL: http://webrtc-codereview.appspot.com/165001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@648 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 22:02:40 +00:00
turajs@google.com
cf136186f5 Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@647 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:49:25 +00:00
turajs@google.com
13335ccd7a Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@646 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:47:25 +00:00
turajs@google.com
610f478705 Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@645 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:45:34 +00:00
turajs@google.com
53439d9982 Deleting matlab files
git-svn-id: http://webrtc.googlecode.com/svn/trunk@644 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 21:44:00 +00:00
mikhal@webrtc.org
105ff39dec video coding: updating offline tests.
Additional clean-up to the offline test: Placing test callbacks in a designated file. 
Review URL: http://webrtc-codereview.appspot.com/167002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@642 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 16:41:11 +00:00
turajs@google.com
496ef8aca8 To fix warnings in test files.
Review URL: http://webrtc-codereview.appspot.com/169001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@641 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 15:45:48 +00:00
bjornv@google.com
8e9e83b530 This CL adds guards against division by zero, that should fix http://b/issue?id=5278531
In addition a read outside memory event has been detected and removed.
Also an improper noise weighting has been corrected.
Review URL: http://webrtc-codereview.appspot.com/152001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@640 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 12:39:47 +00:00
bjornv@google.com
dc743a8bba Replaces a use of log2.
I've replaced a log2 operation so it works on Windows.
Review URL: http://webrtc-codereview.appspot.com/171002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@637 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 08:13:53 +00:00
wu@webrtc.org
221b522118 Return the number of /dev/video* without trying to open it.
Consider the case when there're /dev/video0 and /dev/video1. But for somereason the video0 is not in a correct state and can't be open. As a result, current NumberOfDevices will return 1, which is fine. However, we will then never be able to get the device we really want - /dev/video1. Consider the code below, the GetCaptureDevice will fail because it calls into DeviceInfoLinux::GetDeviceName(0, ...) which will again try to open the /dev/video0. So the root cause is the mismatching of the NumberOfDevices and GetDeviceName.

Since we will open the device in DeviceInfoLinux::GetDeviceName anyway, I think we should return the number of /dev/video* in DeviceInfoLinux::NumberOfDevices without trying to open it. Otherwise the DeviceInfoLinux::NumberOfDevices should return more information like which /dev/video* is valid which is not.

bool found = false;
for (int i = 0; i < vie_capture->NumberOfCaptureDevices(); ++i) {
  if (vie_capture->GetCaptureDevice(i, ...) == 0) {
    found = true;
    break;
  }
}
Review URL: http://webrtc-codereview.appspot.com/148004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@635 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 16:57:15 +00:00
bjornv@google.com
65e6ab31eb Temporary log2 remove to build in chrome
git-svn-id: http://webrtc.googlecode.com/svn/trunk@633 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 11:56:46 +00:00
pwestin@webrtc.org
741da942ec Added support for new RTCP message REMB (remote estimated max bitrate)
Review URL: http://webrtc-codereview.appspot.com/149001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@628 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 13:52:04 +00:00
andrew@webrtc.org
86b85db67e Add missing intrinsic casts for VS 2005.
Allows re-enabling SSE optimization on Windows.
Review URL: http://webrtc-codereview.appspot.com/161003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@623 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 18:48:25 +00:00
leozwang@google.com
522f42bb80 Add kPlatformAndroid to platform check function
Review URL: http://webrtc-codereview.appspot.com/161002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@622 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 17:39:05 +00:00
andrew@webrtc.org
ed083d4079 Modify the _vadActivity member of the AudioFrame passed to AudioProcessing.
This saves the user from having to explicitly check stream_has_voice(). It will allow typing detection to function, which relies on this behaviour.
Review URL: http://webrtc-codereview.appspot.com/144004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@621 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 15:28:51 +00:00
andrew@webrtc.org
94c7413b0d Allow echo metrics to be enabled in process_test.
Review URL: http://webrtc-codereview.appspot.com/155002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@620 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 15:17:57 +00:00
henrik.lundin@webrtc.org
4c36d3b424 Fixing windows warnings in rtp_utility
Adding explicit casting to bool to avoid warnings when compiling
in windows.

Review URL: http://webrtc-codereview.appspot.com/140002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@619 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 08:16:20 +00:00
andrew@webrtc.org
d02dc6e682 Removing bwe_standalone from modules.gyp
Review URL: http://webrtc-codereview.appspot.com/144003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@614 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-17 00:44:23 +00:00
wjia@google.com
fdaee9c014 include build/common.gypi directly
Review URL: http://webrtc-codereview.appspot.com/153006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@613 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-17 00:06:08 +00:00
andrew@webrtc.org
7b7c045b75 Fix MSVC issues in AEC to enable SSE2 optimization on Windows.
Variables now declared at top of scope and replacing C casts with intrinsic cast functions.
Review URL: http://webrtc-codereview.appspot.com/160001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@611 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 22:51:57 +00:00
leozwang@google.com
b37ec71dbd Remove delay_estimator_float.c from android build
Review URL: http://webrtc-codereview.appspot.com/161001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@610 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 21:50:36 +00:00
leozwang@google.com
ce95069ade Fix buidling error
Review URL: http://webrtc-codereview.appspot.com/151002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@603 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 22:28:08 +00:00
andrew@webrtc.org
4537c2a464 Remove the UNCONSTR code path from AEC.
Leave the unconstrained filter adaptation in a commented out function. Consider using this for a low-complexity mode.
Review URL: http://webrtc-codereview.appspot.com/146001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@601 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 18:25:14 +00:00