Commit Graph

34 Commits

Author SHA1 Message Date
andrew@webrtc.org
20078e2f9b Support video constraints and use key/value pairs.
- Remove the minre and maxre parameters in favour of setting video
constraints directly.
- In order to support non-boolean values, have constraints passed as
key/value pairs, rather than the leading "-" syntax used earlier to
specify false.

TESTED=Verified that setting various audio and video constraints has
the desired effect, including "true" and "false". Verified that the "hd"
parameter still works.

R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2360005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4931 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-05 02:26:50 +00:00
andrew@webrtc.org
bab2aa5113 Add audio and video parameters for setting media constraints.
- These replace the media parameter, now removed.
- Organize the parameter getting a bit.

To describe the new parameters, I'll just copy the code comments here:
Use "audio" and "video" to set the media stream constraints. "true" and
"false" are recognized and interpreted as bools, for example:
  "?audio=true&video=false" (start an audio-only call).
  "?audio=false" (start a video-only call)
If unspecified, the constraint defaults to True.

audio-specific parsing:
To set certain constraints, pass in a comma-separated list of audio
constraint strings. If preceded by a "-", the constraint will be set to
False, and otherwise to True. There is no validation of constraint
strings. Examples:
  "?audio=googEchoCancellation" (enables echo cancellation)
  "?audio=-googEchoCancellation,googAutoGainControl" (disables echo
      cancellation and enables gain control)

TESTED=Verified that passing true, false and various audio constraints
has the desired effect in apprtc.

R=vikasmarwaha@google.com

Review URL: https://webrtc-codereview.appspot.com/2345004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4919 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 22:37:29 +00:00
vikasmarwaha@webrtc.org
cee0dfb57a Made sure that DTLS/SRTP is set to false in apprtc demo when testing loopback. See crbug/294881 for details.
R=juberti@google.com, mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2268004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4805 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 21:26:07 +00:00
wu@webrtc.org
bc189fb3b9 * Prefer to send ISAC on clank.
* Add url option asc and arc to allow setting preferred audio send/receive codec.

TESTED=mobile as caller and callee:
pc-n7: pc sends opus, n7 sends isac 
pc-n4: pc sends opus, n4 sends isac
pc-pc opus-opus

R=braveyao@webrtc.org, juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/2196006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4742 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-13 20:11:47 +00:00
braveyao@webrtc.org
a80ee74f69 AppRTC: using a footer element instead of div#footer in CSS.
R=dutton@google.com

Review URL: https://webrtc-codereview.appspot.com/2200004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4724 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-11 16:24:07 +00:00
braveyao@webrtc.org
641340944b Show the signaling state and ice connection state in AppRTC by hooking up the peerconnections .onsignalingstatechange and .oniceconnectionstatechange events.
Hopefully this will increase the quality of the "it does not work" reports from users by giving them more information about what is going on under the hood.

R=juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/2174004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4718 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-10 17:37:16 +00:00
braveyao@webrtc.org
be588f9a58 Apprtc Demo: calling createOffer/Answer without failureCallback is deprecated in FF
BUG=2313
Test=Manual test

R=dutton@google.com, juberti@google.com, vikasmarwaha@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2175004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4683 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-05 16:44:55 +00:00
fischman@webrtc.org
4498d013f6 apprtc: rationalize whitespace
- Remove ^M DOS line endings
- Remove trailing whitespace
- Remove leading 2-space indents from files that have carried this indent since   their contents was removed from within enclosing contexts that required it.
- Add a newline to avoid 82-column line.

R=vikasmarwaha@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2112004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4619 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-26 18:01:28 +00:00
fischman@webrtc.org
5a035b4279 apprtc: add ctrl+i Info window showing gathered ICE candidate types
R=vikasmarwaha@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2109004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4617 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-26 17:44:38 +00:00
vikasmarwaha@webrtc.org
83ffb0dd5c Added functionality in apprtc demo to close the capture device on hangup.
BUG=1589
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2018004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4540 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-13 17:53:37 +00:00
mallinath@webrtc.org
5a27e49f35 This CL will add support of passing all turn urls returned by the CEOD to PeerConnection object.
R=juberti@webrtc.org, vikasmarwaha@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1949004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4506 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-08 19:52:08 +00:00
vikasmarwaha@webrtc.org
6e7c203aee Modified apprtc demo code to detect browser by checking user_agent in apprtc.py. Now we will use Mozilla stun server if FF is detected as the browser. The CL is an improvement to r4388.
R=braveyao@webrtc.org, dutton@google.com

Review URL: https://webrtc-codereview.appspot.com/1928004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4491 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 22:05:20 +00:00
braveyao@webrtc.org
10bbfeff5b Apprtc: add 'event' parameter to onkeydown event handler.
BUG=
TEST=Manual test
R=dutton@google.com

Review URL: https://webrtc-codereview.appspot.com/1898005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4425 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-30 09:27:49 +00:00
vikasmarwaha@webrtc.org
b63c29f48c Minor bug fix in r4388, had to change pc_config variable to pcConfig for apprtc demo.
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1856004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4389 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-23 23:13:35 +00:00
vikasmarwaha@webrtc.org
59fb7a60f2 Use Mozilla STUN server in apprtc demo for FF. Currently FF cannot work with Google STUN server as it expects XOR-MAPPED address while Google STUN server provides MAPPED address.
R=dutton@google.com

Review URL: https://webrtc-codereview.appspot.com/1849004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4388 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-23 22:06:51 +00:00
vikasmarwaha@webrtc.org
bb25256775 Added changes in apprtc demo to ignore turn address through query string for FF. Also made sure that the iceServers array doesnot include transport parameter in turn url for FF. Finally removed turn: from the turn_url when creating iceservers for pre-M28 chrome.
R=dutton@google.com, juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/1627006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4259 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-25 14:52:51 +00:00
braveyao@webrtc.org
a19333954d Apprtc CSS: Add flip to local view of FireFox and remove warning of Canary
BUG=1380
TEST=Manual Test
R=juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/1620004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4225 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-13 03:49:03 +00:00
fischman@webrtc.org
fe6b57187d AppRTCDemo: delete hosted android_channel.html now that it's no longer necessary.
This file became redundant with 47220050 which rolled to libjingle opensource in
r327 of talk/examples/android/src/org/appspot/apprtc/GAEChannelClient.java

R=vikasmarwaha@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1606004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4206 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-10 17:22:50 +00:00
braveyao@webrtc.org
5ed7051799 Apprtc: not to start the call until we get Turn response.
BUG=1795
Test=Manual Test

R=fischman@webrtc.org, juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/1528004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4144 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-31 06:29:41 +00:00
vikasmarwaha@webrtc.org
fddf6be339 Updated apprtc to use new TURN format for chrome versions M28 & above.
R=dutton@google.com, juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/1563004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4139 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-29 22:13:19 +00:00
braveyao@webrtc.org
5f8f112a7b Not to request to TURN server for local tests. Follow-up work to issue1197.
BUG=1197
TEST=Manual test
R=dutton@google.com

Review URL: https://webrtc-codereview.appspot.com/1340004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4083 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-22 07:27:05 +00:00
fischman@webrtc.org
5e2a1bbbc6 AppRTC: make requestTurn() failure non-fatal to call establishment.
BUG=1795
R=vikasmarwaha@google.com, vikasmarwaha@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1504005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4063 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 18:32:23 +00:00
vikasmarwaha@webrtc.org
59a06670b5 Updated apprtc demo to interop with firefox.
R=juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/1482004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4040 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 01:05:19 +00:00
vikasmarwaha@webrtc.org
1993a559e8 Added Stereo url paramter to apprtc demo.
R=dutton@google.com

Review URL: https://webrtc-codereview.appspot.com/1418004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4013 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 18:48:09 +00:00
braveyao@webrtc.org
a39a8fec16 Add owner to Apprtc
Review URL: https://webrtc-codereview.appspot.com/1328007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3874 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 02:34:45 +00:00
pbos@webrtc.org
b4a0623e43 Fix of lint script errors in apprtc.py
BUG=

Review URL: https://webrtc-codereview.appspot.com/1285007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3780 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-08 15:59:24 +00:00
vikasmarwaha@webrtc.org
222e9948f5 Migrating Apprtc to use new TURN service which supports time-limited TURN credentials.
Review URL: https://webrtc-codereview.appspot.com/1291004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3773 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-06 05:58:15 +00:00
braveyao@webrtc.org
f354e1f587 Add audio/video only option in apprtc
ISSUE = issue 1507
TEST  = 
Review URL: https://webrtc-codereview.appspot.com/1216007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3692 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-20 00:23:55 +00:00
vikasmarwaha@webrtc.org
ebf49da9b2 Url option to change the resolution.
Review URL: https://webrtc-codereview.appspot.com/1218005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3691 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-19 22:15:55 +00:00
fischman@webrtc.org
a33037ea6c Added an android_channel.html reflector page to allow Android apps to use a
WebView to speak the Channel API from Google AppEngine.

BUG=webrtc:1169

Review URL: https://webrtc-codereview.appspot.com/1145006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3644 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-10 18:28:08 +00:00
phoglund@webrtc.org
5d37139374 Fixed a ton of Python lint errors, enabled python lint checking.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1166004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3627 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 09:59:43 +00:00
braveyao@webrtc.org
488d4c9493 Submit symlink in apprtc from Linux since it fails from Win
Review URL: https://webrtc-codereview.appspot.com/1169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3622 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-06 06:45:14 +00:00
braveyao@webrtc.org
07db4a6918 Add symlink of adapter.js from apprtc to base
Review URL: https://webrtc-codereview.appspot.com/1160004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3621 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-06 03:35:03 +00:00
vikasmarwaha@webrtc.org
98fce15c6f Adding webrtc-sample demos under trunk/samples.
Review URL: https://webrtc-codereview.appspot.com/1126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3578 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-27 23:22:10 +00:00