niklas.enbom@webrtc.org
6c9be123ef
Letting strncpy do its job. Landing and extending http://webrtc-codereview.appspot.com/329010/ on behalf of tbreisacher.
...
Review URL: http://webrtc-codereview.appspot.com/335009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1260 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 08:59:31 +00:00
stefan@webrtc.org
8c5d24266e
Fix VP8 layer 2 sync dependencies.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/333010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1259 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 08:56:04 +00:00
henrik.lundin@webrtc.org
00e730730e
Refactoring RtpFormatVp8Test
...
This is the first change in a series of changes to get new functionality
into the VP8 packetizer.
This first refactors the RtpFormatVp8Test class, without changing the
operation of the tested RtpFormatVp8 class. A test helper class
RtpFormatVp8TestHelper is introduced to reduce code duplication.
Review URL: http://webrtc-codereview.appspot.com/304009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1258 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 08:51:36 +00:00
niklas.enbom@webrtc.org
b2c115c460
Forcing external transport to be on in Chrome.
...
Review URL: http://webrtc-codereview.appspot.com/330010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1257 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 07:38:54 +00:00
mikhal@webrtc.org
61045a4a03
video_coding/jitter_buffer: Account for layer info when searching for the next frame
...
Review URL: http://webrtc-codereview.appspot.com/328003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1256 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 23:24:19 +00:00
andrew@webrtc.org
a38ce09919
Fix last Mac/clang compile error.
...
Fixes "receiver is a forward class and corresponding @interface may
not exist" error.
TEST=build on Mac with -Werror enabled.
TBR=zakkhoyt@webrtc.org
Review URL: http://webrtc-codereview.appspot.com/333012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1255 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 22:23:21 +00:00
andrew@webrtc.org
e858d13ac6
Add a NOOP target for merge libs.
...
Also allow certain components to not be built.
TEST=build merged_lib
Review URL: http://webrtc-codereview.appspot.com/328001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1254 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 22:07:48 +00:00
mikhal@webrtc.org
6f7fbc7fbe
libyuv: Adding psnr/ssim to libyuv and updating unit tests according to latest conventions.
...
Review URL: http://webrtc-codereview.appspot.com/331007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1253 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 17:38:28 +00:00
pwestin@webrtc.org
061fa5b828
Changed handling of padding data.
...
Review URL: http://webrtc-codereview.appspot.com/331008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1252 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 15:56:17 +00:00
henrik.lundin@webrtc.org
dbba1f969f
Packet waiting-time statistics
...
Adding new statistics API to NetEQ, reporting the waiting time
for each frame. The output is raw waiting time for the frames
that have been decoded since the last statistics report (or
maximum 100 frames). The statistics are reset on each query.
Implemented functionality in ACM to query NetEQ for the raw
waiting times, and process it to produce max, average and
median.
Updating common_types.h and VoiceEngine tests to include the
new metrics.
Unit tests are also added for NetEQ and AcmNetEq.
Review URL: http://webrtc-codereview.appspot.com/328011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1251 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 15:45:05 +00:00
henrik.lundin@webrtc.org
219acc6cec
Including Brighten function in namespace VideoProcessing
...
This change is in response to Issue 173.
BUG=http://code.google.com/p/webrtc/issues/detail?id=173
Review URL: http://webrtc-codereview.appspot.com/328012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1250 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 15:33:49 +00:00
bjornv@webrtc.org
c68f80a70a
Refactoring vad_gmm.[c/h].
...
- Changed to stdint.
- Replaced SHIFT macros.
- Variable name changes.
- Style changes.
- Comments updates.
- Added a unit test.
Review URL: http://webrtc-codereview.appspot.com/323011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1249 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 14:08:34 +00:00
mflodman@webrtc.org
42d07f0c58
Render impl fix from refactoring.
...
Review URL: http://webrtc-codereview.appspot.com/329009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1248 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 13:20:36 +00:00
mflodman@webrtc.org
1bdf1dffb4
Refactored ViEImageProcess, ViEImpl and ViENetworkImpl.
...
Review URL: http://webrtc-codereview.appspot.com/331005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1247 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 11:57:47 +00:00
mflodman@webrtc.org
813b4ef2ea
Refactored ViEFileImpl and ViEExternalCodec.
...
Review URL: http://webrtc-codereview.appspot.com/330007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1246 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 10:39:30 +00:00
phoglund@webrtc.org
f3cea2336b
Added an empty voice engine unit test binary in order to get correct coverage measurements. This will make the voice engine show up in the coverage measurements. The empty test is necessary to get the coverage tool to pick it up (and it will be easier to start writing unit tests for the voice engine later).
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/334003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1245 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 10:14:53 +00:00
stefan@webrtc.org
62fdc42e9c
Fix build issue with clang.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/330009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1244 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 09:27:09 +00:00
stefan@webrtc.org
8dc9e4760e
Fixes for selective NACKing.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/332007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1243 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 09:12:50 +00:00
phoglund@webrtc.org
fda17c2b00
Rewrote NetEQ test, made standard suite run googletestified tests too.
...
The standard suite will now also run the googletestified tests.
Removed NetEQ tests from the standard test.
Initial version of new neteq test. Moved fixtures to own folder.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/328010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1242 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 09:07:37 +00:00
tina.legrand@webrtc.org
5efcad1758
We used the wrong syntax for "new", which generated a warning/error building with clang.
...
Review URL: http://webrtc-codereview.appspot.com/336003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1241 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 09:05:55 +00:00
kjellander@webrtc.org
b5b155b8a9
This CL introduces a new directory for WebRTC utility scripts for Valgrind: tools/valgrind-webrtc
...
To be able to re-use as much as possible from Chromium's scripts, I've created two customized scripts for running tests:
- webrtc_tests.py: a customized version of chrome_tests.py with WebRTC tests instead.
- webrtc_tests.sh: a customized version of the chrome_tests.sh wrapper script, to launch the above script.
The webrtc_tests.sh script is setting up PYTHONPATH so that tools/valgrind is available for the webrtc_tests.py script.
The webrtc_tests.py script inherits the chrome_tests.py script as much as possible, to minimize maintenance and maximize readability.
Having this mirrored setup of directories, allows us to use the same directory hierarchy for suppression files too. This CL only adds suppression files for memcheck, but we can add files for tsan later easily.
The suppression file is currently empty for Linux. For Mac I copied all the Chromium third-party suppressions. We will need a lot more added for Mac before Valgrind runs becomes usable for that platform.
The platform specific naming of the suppression files are handled automatically when webrtc_tests.sh is used to launch the tests.
Example:
Plain memcheck (default tool): tools/valgrind-webrtc/webrtc_tests.sh -t system_wrappers
Run ThreadSanitizer: tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t system_wrappers
Previously mentioned AddressSanitizer requires additional scripts to be added and it not covered in this CL.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/322010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1240 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 08:53:41 +00:00
mikhal@webrtc.org
9e4f3830a7
Removing vplib: Following the switch to Libyuv, this CL removes all vplib files.
...
Review URL: http://webrtc-codereview.appspot.com/321003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1239 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 19:24:32 +00:00
mikhal@webrtc.org
0e7d9d862a
Adding layer info consideration when applying FEC protection. In this first version, we hard code protection zero for non-base layer frames. As a future enhancement, an array should be passed from mediaOpt to set the protection per layer. A TODO was added in MediaOpt.
...
Review URL: http://webrtc-codereview.appspot.com/330005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1238 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 19:04:49 +00:00
mikhal@webrtc.org
190e88a6d3
video_coding: When in hybrid mode, don't NACK non-base layer packets
...
Review URL: http://webrtc-codereview.appspot.com/334002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1237 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 18:57:14 +00:00
mikhal@webrtc.org
884d8e7f4b
video_coding: Updating sync state based on the layer flag
...
Review URL: http://webrtc-codereview.appspot.com/333004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1236 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 18:53:05 +00:00
henrik.lundin@webrtc.org
303158588b
Revert "Inject TickTimeInterface into VCM and tests"
...
This CL reverts r1220.
Review URL: http://webrtc-codereview.appspot.com/336002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1235 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 17:55:45 +00:00
henrika@webrtc.org
e32c08a5a6
Removes usage of default parameters and fixes a bug which was found
...
using Clang on Linux.
BUG=none
TEST=none
TBR=pwestin
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1234 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 17:39:48 +00:00
henrike@webrtc.org
4158c35820
Removed the WEBRTC_NO_TRACE macro since the style guide wants us to stear clear of macros and this one doesn't seem to have a purpose at this point.
...
Review URL: http://webrtc-codereview.appspot.com/315006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1233 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 17:28:25 +00:00
mflodman@webrtc.org
8da2417c9d
Refactored ViERenderImpl and ViERTP_RTCPImpl.
...
Review URL: http://webrtc-codereview.appspot.com/329005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1232 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 14:18:41 +00:00
mflodman@webrtc.org
7752d11056
Fix test for external codec.
...
Review URL: http://webrtc-codereview.appspot.com/328007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1231 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 12:29:56 +00:00
phoglund@webrtc.org
86a9f9b946
Fixed build error.
...
Merge branch 'master' into voe_rewrites
Conflicts:
src/voice_engine/main/test/auto_test/standard/after_streaming_fixture.cc
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
Fixed strange build error.
Merge branch 'master' into voe_rewrites
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
Nit fixes
Clarified some comments and method names.
Style fixes.
Removed tab characters.
Merge branch 'master' into voe_rewrites
Conflicts:
src/voice_engine/main/test/auto_test/voe_standard_test.cc
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
Rewrote the hold test.
Abstracted out resource handling and created a new fixture for starting and stopping playing.
Rewrote network-before-streaming.
Revert "Rewrote network-before-streaming."
This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.
Rewrote network-before-streaming.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/333007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1230 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 10:24:46 +00:00
stefan@webrtc.org
b33f9dccd6
Correction to how the VP8 wrapper generates picture ids.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/329006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1229 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 10:24:02 +00:00
phoglund@webrtc.org
188fc35e07
Rewrote the hold and netw-before-streaming tests.
...
Rewrote the hold test.
Abstracted out resource handling and created a new fixture for starting and stopping playing.
Rewrote network-before-streaming.
BUG=
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/331001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1228 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 09:36:03 +00:00
tina.legrand@webrtc.org
398af2337b
Solving issue 178, errorbuild warnings on Mac.
...
This CL continues the work of solving issue 178. A small change in one file.
Review URL: http://webrtc-codereview.appspot.com/330006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1227 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 07:36:07 +00:00
henrike@webrtc.org
cf5bcd1fd2
Removed usage of the deprecated critical section constructor in audio_conference_mixer.
...
Review URL: http://webrtc-codereview.appspot.com/320007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1226 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 23:00:30 +00:00
andrew@webrtc.org
8a44259ea8
Move static consts out of class.
...
Still causing a gtest error on non-Win platforms. This should fix it...
TBR=asapersson@webrtc.org
TEST=build on Linux
Review URL: http://webrtc-codereview.appspot.com/332006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1225 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 21:24:30 +00:00
andrew@webrtc.org
41192469f6
Switch enums to consts to fix gtest error.
...
TBR=asapersson@webrtc.org
TEST=build on Windows
Review URL: http://webrtc-codereview.appspot.com/330008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1224 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 20:55:46 +00:00
henrike@webrtc.org
105e07193e
Removed usage of the deprecated critical section constructor in modules/utility.
...
Review URL: http://webrtc-codereview.appspot.com/321006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1223 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 19:53:46 +00:00
marpan@webrtc.org
57353a33f1
FEC Receiver: Fix to how old packets (e.g., re-tranmitted packets in hybird NACK-FEC mode) are treated.
...
This change avoids having old packets end up on the current packet list for FEC decoding, and so they are immediately sent out to jitter buffer.
The current list of packets for FEC decoding are sent out only when new packet arrives (with time-stamp greater than current).
Review URL: http://webrtc-codereview.appspot.com/322009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1222 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 17:21:09 +00:00
henrik.lundin@webrtc.org
e7d8c56c56
Fix for dual decoder in VCM receiver
...
In VCMReceiver::FrameForDecoding, one of the if-cases could sometimes
extract an incomplete frame without first copying the state to the
dual decoder.
Review URL: http://webrtc-codereview.appspot.com/328006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1221 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 15:40:52 +00:00
henrik.lundin@webrtc.org
a70f945086
Inject TickTimeInterface into VCM and tests
...
The purpose of this change is to introduce dependency injection
of the timer into the video coding module.
Review URL: http://webrtc-codereview.appspot.com/332003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1220 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 14:40:05 +00:00
asapersson@webrtc.org
5249cc8f77
Review URL: http://webrtc-codereview.appspot.com/295010
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1219 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 14:31:37 +00:00
tina.legrand@webrtc.org
9775a30859
Added variable to catch return value.
...
Review URL: http://webrtc-codereview.appspot.com/329004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1218 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 11:15:46 +00:00
kjellander@webrtc.org
08dec7f449
Now using fileutils.h OutputPath to write output to the right directory and ResourcePath to read resource files from the resource bundle.
...
Removed some Valgrind warnings by closing output files. There are still some Valgrind warnings left, that needs to be fixed by a developer with more insight.
Updated all include paths to contain full paths to header files.
Tested in Debug+Release on Linux, Mac and Windows.
All tests ran successfully except the VideoProcessingModuleTest.ContentAnalysis test that fails on Windows with the following error:
unknown file: error: SEH exception with code 0xc0000005
thrown in the test body.
Fixing that is out of scope for this CL.
Review URL: http://webrtc-codereview.appspot.com/266011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1217 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 10:31:38 +00:00
tina.legrand@webrtc.org
554ae1ad4e
Changes to solve warnings on Mac, issue #178 .
...
Review URL: http://webrtc-codereview.appspot.com/320005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1216 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 10:09:04 +00:00
mflodman@webrtc.org
605972edfd
Refactored ViECaptureImpl.
...
Review URL: http://webrtc-codereview.appspot.com/332004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1215 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 08:59:24 +00:00
mflodman@webrtc.org
352dcd8b2d
Refactored vie_file_image.
...
Review URL: http://webrtc-codereview.appspot.com/332002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1214 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 08:52:41 +00:00
leozwang@webrtc.org
ed716e42eb
Add java_files to WATCHLIST
...
Review URL: http://webrtc-codereview.appspot.com/331003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1213 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 23:29:10 +00:00
andrew@webrtc.org
04f5cba069
Switch to new critsect interface for DataLog.
...
The introduction of the new interface broke DataLog in a release build
(with enable_data_logging=1).
TBR=henrike@webrtc.org
TEST=build Linux/Release with enable_data_logging=1
Review URL: http://webrtc-codereview.appspot.com/334001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1212 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 21:33:11 +00:00
henrike@webrtc.org
7136990a3f
Removed usage of the deprecated critical section constructor in udp_transport.
...
Review URL: http://webrtc-codereview.appspot.com/321005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1211 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 19:17:28 +00:00