perkj@webrtc.org
3a93e33c56
Reland "Fix CVO in androidvideocapturer.""
...
This reverts commit b8bcf8cbbf
.
after I fixed a rebase mistake. The fix is the delta between patchset 1 and 2.
The original cl was reviewed here:
https://webrtc-codereview.appspot.com/40759004/
TBR=magjed@webrtc.org
BUG=4145
Review URL: https://webrtc-codereview.appspot.com/45409004
Cr-Commit-Position: refs/heads/master@{#8538}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8538 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 20:19:16 +00:00
perkj@webrtc.org
b8bcf8cbbf
Revert "Fix CVO in androidvideocapturer."
...
This reverts commit 02ed57bf9d
.
https://webrtc-codereview.appspot.com/40759004/
Reason- breaks tests after rebase.
TBR=magjed@webrtc.org
BUG=4145
Review URL: https://webrtc-codereview.appspot.com/39349004
Cr-Commit-Position: refs/heads/master@{#8537}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8537 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 19:48:15 +00:00
perkj@webrtc.org
02ed57bf9d
Fix CVO in androidvideocapturer.
...
This add bool apply_rotation to WebrtcVideoFrame::Init and removes the need for WebrtcVideoFrame::SetRotation.
BUG=4145
R=guoweis@webrtc.org , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40759004
Cr-Commit-Position: refs/heads/master@{#8536}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8536 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 19:10:45 +00:00
magjed@webrtc.org
f09e7b8a4f
WebRtcVideoFrame: DCHECK exclusive ownership for non-const pixel access
...
Add some const safety by DCHECK(HasOneRef()) in non-const GetYPlane. This CL also replaces all incorrect non-const calls with const calls for pixel data access in cricket::VideoFrame. It's easy to call the non-const version of e.g. GetYPlane by mistake, even if only const-access is needed. For example:
const scoped_ptr<cricket::VideoFrame> foo;
const uint8_t* y = foo->GetYPlane();
will actually call the non-const version of GetYPlane.
R=mflodman@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39079004
Cr-Commit-Position: refs/heads/master@{#8507}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8507 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-25 14:50:19 +00:00
magjed@webrtc.org
3864363e2c
cricket::VideoFrame: Refactor CopyToBuffer into base class
...
It’s possible to implement cricket::VideoFrame::CopyToBuffer using the virtual interface. This removes the need for subclasses to implement their own versions. This CL also fixes a bug in cricket::VideoFrame::CopyToPlanes which currently assumes that GetUPitch() == GetVPitch(), otherwise it may segfault.
I think this CL should land regardless, but the main purpose is to pave the way for for planned changes to I420VideoFrame. See https://review.webrtc.org/38879004 .
R=fbarchard@google.com , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39889004
Cr-Commit-Position: refs/heads/master@{#8403}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8403 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-18 09:19:45 +00:00
guoweis@webrtc.org
1226e926e6
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
...
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Committed: https://code.google.com/p/webrtc/source/detail?r=8338
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8339}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8339 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 18:38:53 +00:00
guoweis@webrtc.org
dc7b02277c
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
...
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8337
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8338}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8338 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 18:06:10 +00:00
guoweis@webrtc.org
20e8f22766
CVO capturer feature: allow unrotated frame flows through the capture pipeline.
...
split from https://webrtc-codereview.appspot.com/37029004/
This is based on clean up code change at https://webrtc-codereview.appspot.com/37129004
BUG=4145
R=perkj@webrtc.org , pthatcher@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39799004
Cr-Commit-Position: refs/heads/master@{#8337}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8337 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 17:51:46 +00:00
guoweis@webrtc.org
6c930c7183
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8257
Committed: https://code.google.com/p/webrtc/source/detail?r=8276
Committed: https://code.google.com/p/webrtc/source/detail?r=8277
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8288}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8288 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 01:29:45 +00:00
guoweis@webrtc.org
0c7ec770ff
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8257
Committed: https://code.google.com/p/webrtc/source/detail?r=8276
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8277}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8277 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 21:01:47 +00:00
guoweis@webrtc.org
110443aaac
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8257
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8276}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8276 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 20:00:46 +00:00
magjed@webrtc.org
4b320cf214
Revert "Cleanup: unify rotation to be enum based instead of int for degree."
...
Reason for revert:
Compile error on bots - A subclass of cricket::VideoFrame still uses old GetRotation return type.
BUG=4145
TBR=guoweis,stefan,pthatcher
This reverts commit 3e733a43f5
.
Review URL: https://webrtc-codereview.appspot.com/34159004
Cr-Commit-Position: refs/heads/master@{#8265}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8265 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-06 12:58:46 +00:00
guoweis@webrtc.org
3e733a43f5
Cleanup: unify rotation to be enum based instead of int for degree.
...
Split from https://webrtc-codereview.appspot.com/37029004/
BUG=4145
R=pthatcher@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37129004
Cr-Commit-Position: refs/heads/master@{#8257}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8257 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-05 23:40:43 +00:00
kjellander@webrtc.org
599e299b9d
cricket::VideoFrame int64 to int64_t.
...
Needed for successful compile of ios arm64.
BUG=3898
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30359004
Patch from Zeke Chin <tkchin@webrtc.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7817 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-05 09:42:57 +00:00
magjed@webrtc.org
bdcf38c894
cricket::VideoFrame: Refactor ConvertToRgbBuffer into base class
...
There is also an implementation in Chromium that can be removed if/when this lands:
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
R=fbarchard@google.com , pbos@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32059004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7728 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-21 10:53:00 +00:00
buildbot@webrtc.org
d4e598d57a
(Auto)update libjingle 72097588-> 72159069
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6799 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-29 17:36:52 +00:00
wu@webrtc.org
9dba525627
* Update libjingle to 50389769.
...
* Together with "Add texture support for i420 video frame." from
wuchengli@chromium.org .
https://webrtc-codereview.appspot.com/1413004
RISK=P1
TESTED=try bots
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1967004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4489 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 20:36:57 +00:00
henrike@webrtc.org
28e2075280
Adds trunk/talk folder of revision 359 from libjingles google code to
...
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00