sergeyu@chromium.org
2edb642810
Fix bugs in DesktopRegion::Subtract().
...
Fixed a bug that caused the crash in the linked bug and also couple of
other issues in the same code. Also added more tests.
BUG=crbug.com/295057
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/2259005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4806 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 21:29:18 +00:00
vikasmarwaha@webrtc.org
cee0dfb57a
Made sure that DTLS/SRTP is set to false in apprtc demo when testing loopback. See crbug/294881 for details.
...
R=juberti@google.com , mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2268004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4805 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 21:26:07 +00:00
turaj@webrtc.org
10e6cc7e23
VAD changes ported to ACM2.
...
This CL ports the relevant parts of https://code.google.com/p/webrtc/source/detail?r=4625 to ACM2.
BUG=
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2264004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4804 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 16:38:26 +00:00
turaj@webrtc.org
362a55e7b0
Address Windows 64-bits warnings.
...
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2203004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4803 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 16:25:28 +00:00
pbos@webrtc.org
0e63e76781
Enable FEC for VideoSendStream.
...
Test only checks for FEC without NACK. Test for FEC with NACK postponed
until later.
BUG=2230
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2246004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4802 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 11:56:26 +00:00
stefan@webrtc.org
9c74be7bd1
Disable flaky video capture test.
...
BUG=2405
TBR=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2265005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4801 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 08:52:31 +00:00
stefan@webrtc.org
4f3624d39e
Avoid recursively taking critical section.
...
TEST=trybots
BUG=2261
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2258006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4800 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 07:43:17 +00:00
jiayl@webrtc.org
dd57cd6ed5
Removing the tsan text exclusion since the tests should be passing now.
...
BUG=2299, 2290, 2291
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2260004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4799 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 00:51:53 +00:00
fischman@webrtc.org
d29ab4e17c
Suppress SSL error strings on mac_asan to unbreak that build
...
Example borkedness: http://chromegw/i/client.webrtc/builders/Mac%20Asan/builds/642/steps/libjingle_p2p_unittest/logs/stdio
R=marpan@google.com
Review URL: https://webrtc-codereview.appspot.com/2263004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4798 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 23:54:56 +00:00
fischman@webrtc.org
76fe9309b9
Use link_settings instead of all_dependent_settings to pacify xcode gyp generator
...
Should unbreak e.g. http://chromegw/i/chromium.webrtc.fyi/builders/Mac%20%5Blatest%20WebRTC%20trunk%5D/builds/2396
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2261004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4796 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 21:11:08 +00:00
fischman@webrtc.org
ccddd0a941
Roll webrtc's chromium_revision 217707:224141
...
Also adds -lm for executables depending on isac since the newer clang in the
newer chromium revision requires it, and -lstdc++ for dependencies of the objc lib because newer gyp links with gcc instead of g++ for non-C++-containing libs.
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2177007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4795 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 20:27:32 +00:00
pbos@webrtc.org
6917e19ad4
Rename EngineTest to CallTest.
...
There's no real notion of VideoEngine left in these classes. They're
end-to-end tests built on Call, so CallTest makes more sense.
This also contains a modification to RtpRtcpObserver moving the
responsibility of creating the event that signals when the observation
is complete to RtpRtcpObserver. New tests are about to be introduced and
this will reduce code duplication.
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2258005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4793 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 14:22:12 +00:00
tina.legrand@webrtc.org
a03e34e9ab
Heap-use-after-free in WebRtcNetEQ_RecInRTPStruct
...
Pointer to released memory was not set to NULL, which means
you could get a heap-us-after-free in the code. It happens if one of the slaves of NetEq is deleted, but we keep trying to decode packets.
BUG=
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2259004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4792 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 13:32:14 +00:00
andresp@webrtc.org
ab6549562b
Refactor frame generation code so it can be used by multiple modules.
...
R=pbos@webrtc.org , stefan@webrtc.org , pbos, stefan
BUG=
Review URL: https://webrtc-codereview.appspot.com/2240004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4791 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 12:14:03 +00:00
stefan@webrtc.org
7a30dfdc69
Disable NACK bandwidth statistics test due to being too flaky.
...
Tests for new API currently provide partial coverage, and will soon
provide full coverage.
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2151005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4789 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 12:08:55 +00:00
stefan@webrtc.org
b5a191bfe7
Fixes a flake in network down tests.
...
And reduces the flakiness in NACK tests.
TESTS=trybots
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2258004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4788 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 11:14:35 +00:00
kjellander@webrtc.org
d8a9b86671
Disable tests for TSan v2
...
These are tests that fail and that I haven't been able to suppress.
I assume they're caused by the same bug in TSan v2 as described in
webrtc:2259.
BUG=2259,2334
TEST=Ran the tests similar to the instructions in the bugs, passed 100 iterations.
R=andrew@webrtc.org , hta@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2250004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4787 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 07:15:36 +00:00
wu@webrtc.org
967bfff54d
Update talk to 52534915.
...
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/2251004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4786 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 05:49:50 +00:00
turaj@webrtc.org
532f3dc548
Compile ACM2 and ACM1.
...
First patch set is the same as patch set 3 of http://review.webrtc.org/2237004/
-Make ACM1 to depend on ACM2.
-Remove APIs to set and get background noise mode. There is no VoE call to these
APIs.
-Remove APIs to set and get receive side VAD mode. There is no VoE call to these
APIs, and NetEq 4, doesn't support them.
-Remove callback for in-band DTMF detection. ACM doesn't support in-band DTMF
detection.
-Use acm_common_defs.h everywhere required.
-Complete ACM factory method.
-Update ACMCodecDatabase of ACM2. CNG full-band need to be define-guarded.
Remove dynamic payload-type assignment.
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4785 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 00:12:23 +00:00
andrew@webrtc.org
f3930e941c
Small refactoring of AudioProcessing use in channel.cc.
...
- Apply consistent naming.
- Use a scoped_ptr for rx_audioproc_.
- Remove now unnecessary AudioProcessing::Destroy().
R=bjornv@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2184007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4784 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 22:37:32 +00:00
henrik.lundin@webrtc.org
0d5da25e6c
NetEq4: Making a few more members scoped_ptrs
...
This CL converts a few members in NetEqImpl form regular pointers
to scoped_ptrs.
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2245004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4783 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 21:12:38 +00:00
henrik.lundin@webrtc.org
5a43370cdb
Dedicated speed test for NetEq3
...
This is the same test as was aleready implemented for NetEq3 in r4763.
BUG=1363
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2234004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4782 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 20:58:33 +00:00
kjellander@webrtc.org
7a968a8f07
Add more TSan and Dr Memory suppressions for modules_unittests
...
I'm trying to get these tests green on Windows in
http://build.chromium.org/p/client.webrtc.fyi
BUG=2319,2323
TEST=local runs passing
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2230004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4781 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 19:18:20 +00:00
wu@webrtc.org
8d1e4d6149
Increase the dtmfsender test toleration to 100ms to avoid flaky.
...
BUG=2391
R=marpan@google.com
Review URL: https://webrtc-codereview.appspot.com/2248004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4780 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 18:01:07 +00:00
andrew@webrtc.org
8bf755d5c5
MIPS optimizations for the functions WebRtcSpl_SqrtFloor, WebRtcSpl_CrossCorrelation, WebRtcSpl_ScaleAndAddVectorsWithRound and the inline functions from signal_processing spl_inl.h file.
...
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1791004
Patch from Ljubomir Papuga <lpapuga@mips.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4779 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 17:40:46 +00:00
stefan@webrtc.org
5f1051631a
Fix disabling of tests.
...
BUG=2378
R=pbos@webrtc.org
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2244005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4778 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 15:28:10 +00:00
stefan@webrtc.org
1c77dfd521
Revert r4772 "Compile ACM1 and ACM2."
...
Breaks Android build.
TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2244004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4777 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 12:34:05 +00:00
henrik.lundin@webrtc.org
40d3fc65f5
NetEq4: Make some DSP operation classes member variables
...
This CL reduces the memory allocations by making the instances of
Accelerate, PreemptiveExpand, Normal and Merge member variables in
NetEqImpl.
This change reduced the allocation count by 20,000 in the bit-exactness
test.
BUG=Issue 1363
TEST=out/Debug/modules_unittests
--gtest_filter=NetEqDecodingTest.TestBitExactness
R=andrew@webrtc.org , minyue@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2158004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4776 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 12:19:50 +00:00
stefan@webrtc.org
8db81c5112
Fix races in vcm::Process().
...
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2241004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4775 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 11:57:34 +00:00
pbos@webrtc.org
e75a1bf45f
Break out glue for old->new Transport.
...
Reduces multiple inheritance and code duplication.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2239004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4774 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 11:52:42 +00:00
sjlee@webrtc.org
fe84fda488
Changing 'frame' method to 'bounds' method.
...
BUG=2369
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2223004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4773 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 01:37:31 +00:00
turaj@webrtc.org
367baa6eb3
Compile ACM1 and ACM2.
...
-Make ACM1 to depend on ACM2.
-Remove APIs to set and get background noise mode. There is no VoE call to these APIs.
-Remove APIs to set and get receive side VAD mode. There is no VoE call to these APIs, and NetEq 4, doesn't support them.
-Remove callback for in-band DTMF detection. ACM doesn't support in-band DTMF detection.
-Use acm_common_defs.h everywhere required.
-Complete ACM factory method.
-Update ACMCodecDatabase of ACM2. CNG full-band need to be define-guarded. Remove dynamic payload-type assignment.
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2237004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4772 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-18 00:36:11 +00:00
henrike@webrtc.org
c8dea6a00f
Use the native sample rate for OpenSL recording.
...
BUG=N/A
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2219005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4771 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 18:44:51 +00:00
jiayl@webrtc.org
bf00740c92
Adds a new voice engine warning for the typing noise off state.
...
The old VE_TYPING_NOISE_WARNING is unchanged and fired whenever typing noise is detected.
The new VE_TYPING_NOISE_OFF_WARNING is fired when typing noise was detected and is gone now.
This is necessary for converting the typing state to a PeerConnection stats.
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2209004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4770 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 18:09:20 +00:00
stefan@webrtc.org
da79008ab4
Disabling crashing or flaky tests in peerconnection_unittest.
...
R=kjellander@webrtc.org
TBR=wu@webrtc.org
TESTS=trybots
BUG=2378
Review URL: https://webrtc-codereview.appspot.com/2227004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4767 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 13:11:38 +00:00
pbos@webrtc.org
32d640e03d
Fix typo in r4765.
...
Fixes compile error on all platforms.
BUG=
TEST=compile on tryboys
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2231004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4766 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 10:36:30 +00:00
pbos@webrtc.org
da2c4cede0
Fix dangling pointer _encoder in video_sender.cc.
...
When _codecDataBase.SetSendCodec() fails, the encoder may be deleted.
This is however not reflected in _encoder, which then becomes a dangling
pointer to the deleted object.
BUG=2384
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4765 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 09:38:41 +00:00
pbos@webrtc.org
be63fd644f
Initialize CodecInst structs in test_api_audio.cc.
...
Fixes errors detected by DrMemory on Windows.
BUG=2382
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2228004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4764 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 09:33:17 +00:00
henrik.lundin@webrtc.org
d1fc5d4e17
Dedicated speed test for NetEq4
...
This CL implements a new speed test application for NetEq4.
The application runs a minimum of overhead in order to
highlight the performance of NetEq itself.
BUG=1363
R=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2177006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4763 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 08:38:02 +00:00
stefan@webrtc.org
28a331eede
Add support for multiple report blocks.
...
Use a weighted average of fraction loss for bandwidth estimation.
TEST=trybots and vie_auto_test --automated
BUG=1811
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2198004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4762 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 07:49:56 +00:00
sjlee@webrtc.org
fc10c5c97f
This is related to https://code.google.com/p/webrtc/issues/detail?id=1341
...
BUG=1341
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2225004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4761 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 05:15:37 +00:00
sjlee@webrtc.org
e6ac163145
This is related to https://code.google.com/p/webrtc/issues/detail?id=846
...
BUG=846
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2224004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4760 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 05:15:19 +00:00
sjlee@webrtc.org
c3e51acb30
To use the channel_transport on the iOS platform, some #if directives are changed.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2178005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4759 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 05:14:32 +00:00
andrew@webrtc.org
15e979b571
Call AllowCommandLineReparsing in unit tests.
...
Allows us to ignore flags passed on to us by Chromium build bots
without having to explicitly disable them. (Thanks pbos!)
TESTED=Running modules_unittests with a bogus flag did not result in an
error.
TBR=kjellander
Review URL: https://webrtc-codereview.appspot.com/2222005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4757 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 00:54:09 +00:00
mallinath@webrtc.org
b3af8aea3e
Verify local and remote transport description before
...
negotiation.
TBR=sergeyu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2221004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4756 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-17 00:11:05 +00:00
kjellander@webrtc.org
f6ae62ffa3
Add Win TSan exclude and Dr Memory suppressions
...
To green up the FYI builders.
BUG=2323,2382
TEST=passing local run.
TBR=phoglund
Review URL: https://webrtc-codereview.appspot.com/2218005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4755 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-16 21:16:48 +00:00
kjellander@webrtc.org
eddbfb8cf8
Add more Dr Memory suppressions for common_audio_unittests
...
BUG=2321
TEST=passing local run.
TBR=andrew
Review URL: https://webrtc-codereview.appspot.com/2220004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4754 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-16 20:53:20 +00:00
andresp@webrtc.org
e401c2e391
Split video coding module unit tests into sender and receiver unit tests.
...
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2199005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4753 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-16 20:29:13 +00:00
stefan@webrtc.org
ab800f64bc
Disable flaky libjingle tests under tsan and memcheck.
...
BUG=2380, 2379
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2218004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4752 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-16 15:22:32 +00:00
pbos@webrtc.org
5860de02aa
Implement NACK over RTX for VideoSendStream.
...
BUG=2231
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2197008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4751 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-16 13:01:47 +00:00