Commit Graph

5618 Commits

Author SHA1 Message Date
andresp@webrtc.org
a36ad6929d Add webrtc field trials API.
From now on it is expected that code linking system_wrappers.gyp:system_wrappers
provides an implementation for field_trial API or links with the default one in
system_wrappers.gyp:field_trial_default.

Note: Since there is no use of webrtc::field_trial API inside webrtc this CL on
itself does not forces the clients to actually define it. It however lays the
API and updates the gyp rules to link with so that it is ready to use.

Tested: Introduced a use of field trial in system wrappers and make sure all
bots were building successfully.

BUG=crbug/367114
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6147 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 12:24:04 +00:00
henrika@webrtc.org
9f277350f8 Removes parts of the webrtc::VoEDtmf sub API as part of a clean-up operation where the goal is to remove unused APIs.
BUG=3206
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12299005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6146 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 12:04:29 +00:00
henrika@webrtc.org
f383a1b0f2 Removes parts of the webrtc::VoEVolumeControl sub API as part of a clean-up operation where the goal is to remove unused APIs.
BUG=3206
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12519004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6145 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 11:51:45 +00:00
henrik.lundin@webrtc.org
2fa17015d1 Re-enable NetEqExternalDecoderTest for Android
The test runs without problems now.

BUG=3343
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16519005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6144 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 11:45:22 +00:00
henrik.lundin@webrtc.org
bf93fb3176 Re-enable NetEQ DecoderDatabase test for Android
The test was failing because iLBC is not enabled on Android. Now, the
test is using PCM16B instead.

BUG=3343
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16519004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6143 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 10:42:03 +00:00
mflodman@webrtc.org
b1a66d166c Revert "Audio processing: Feed each processing step its choice of int or float data"
This reverts r6138.

tbr=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6142 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 09:39:56 +00:00
solenberg@webrtc.org
db60434b31 Re-enable the BitrateEstimatorTest cases for the Call API.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6141 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 09:15:19 +00:00
henrik.lundin@webrtc.org
5c49c64de5 Remove all use of AudioFrame::energy_ from AudioCodingModule
Since r6117, the energy is always calculated in the mixer module,
regardless of the value that ACM sets for energy_.

This part of the the aftermath of issue 3255.

BUG=3255
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6140 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 09:06:52 +00:00
bjornv@webrtc.org
06c1d6f3a1 VoEVolumeTest: Adds error return tests.
BUG=367
TESTED=trybots, voe_auto_test
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19469006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6139 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 09:03:33 +00:00
kwiberg@webrtc.org
934a265a47 Audio processing: Feed each processing step its choice of int or float data
Each audio processing step is given a pointer to an AudioBuffer, where
it can read and write int data. This patch adds corresponding
AudioBuffer methods to read and write float data; the buffer will
automatically convert the stored data between int and float as
necessary.

This patch also modifies the echo cancellation step to make use of the
new methods (it was already using floats internally; now it doesn't
have to convert from and to ints anymore).

(The reference data to the ApmTest.Process test had to be modified
slightly; this is because the echo canceller no longer unnecessarily
converts float data to int and then immediately back to float for each
iteration in the loop in EchoCancellationImpl::ProcessCaptureAudio.)

BUG=
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18399005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6138 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 09:01:35 +00:00
pbos@webrtc.org
3d5cb33da4 Remove WEBRTC_TRACE use in video_capture/
Does not touch platform-specific code.

BUG=3153
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6137 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 08:42:07 +00:00
pbos@webrtc.org
4e2806d85f Remove WEBRTC_TRACE uses in video_engine/
Complements fixes by mflodman@.

BUG=3153
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11159004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6136 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 08:02:22 +00:00
kjellander@webrtc.org
98c76a120d Make vie/voe_auto_test accept non-supported flags without error.
With the switch recipes on the buildbots and the deprecation of
the custom script at
https://code.google.com/p/webrtc/source/browse/trunk/webrtc/test/buildbot_tests.py
these tests will start failing when Chromium's runtest.py is passing
--brave-new-test-launcher --test-launcher-bot-mode
to the test.
A similar change was made for most of WebRTC's tests (that depends on
the test_support_main target) in
https://webrtc-codereview.appspot.com/2222005

BUG=chromium:346198
TEST=Successfully launched the executables on Linux and Mac using:
out/Release/voe_auto_test --brave-new-test-launcher --test-launcher-bot-mode --automated --test-launcher-summary-output=/tmp/tmpwhx6Zz
out/Release/vie_auto_test --brave-new-test-launcher --test-launcher-bot-mode --automated --capture_test_ensure_resolution_alignment_in_capture_device=false --test-launcher-summary-output=/tmp/tmpwhx6Zz

R=henrika@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6135 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 06:01:40 +00:00
buildbot@webrtc.org
cd846dd374 (Auto)update libjingle 66924241-> 66927231
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6134 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:58:27 +00:00
buildbot@webrtc.org
da510c5de6 (Auto)update libjingle 66923202-> 66924241
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6132 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:30:56 +00:00
fischman@webrtc.org
d8af5b51c0 Deallocate the result of mach_host_self() when done with it, fixing a
port leak.

The port rights obtained by mach_host_self() and mach_thread_self() need
to be deallocated with mach_port_deallocate(). They consume finite
system-wide resources. This is in contrast to mach_task_self(), which is
a macro that wraps an extern global variable, and must not be
deallocated.

http://crbug.com/105513 shows the sorts of problems that can occur when
these aren't properly deallocated.

R=fischman@webrtc.org, tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15469004

Patch from Mark Mentovai <mark@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6131 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:18:48 +00:00
buildbot@webrtc.org
c14f521b1b (Auto)update libjingle 66887616-> 66900106
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6130 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:52:57 +00:00
henrike@webrtc.org
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
buildbot@webrtc.org
3e01e0b16c (Auto)update libjingle 66867790-> 66887616
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6128 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 17:54:10 +00:00
henrike@webrtc.org
c156174da8 Suppressing all tests for WebRtcVideoEngine2 for Win DrMemory Full.
BUG=3336
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6124 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 16:47:32 +00:00
bjornv@webrtc.org
8d63d0ee70 Enables VolumeTest.DefaultMicrophoneVolumeIsAtMost255
Rewritten the test to only check for valid volume when we have actually received a value from the audio device. To check if we have actually received a volume value is out of the scope for this test.

BUG=webrtc:367
TESTED=trybots
R=tina.legrand@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16499006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6123 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 14:14:56 +00:00
andresp@webrtc.org
93ec9c557b Revert "FieldTrial implementation for webrtc." (rev 6089)
New wiring plans require it to be landed first in chrome for a cleaner roll of webrtc.

BUG=crbug/367114
R=tommi@webrtc.org
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6122 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 14:09:40 +00:00
asapersson@webrtc.org
e41dbee8a6 Reduced kMaxSampleDiffMs (limit to 22fps).
BUG=1577
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6121 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 13:45:13 +00:00
pbos@webrtc.org
023b101f4e Move gflags usage to video_loopback.
gflags aren't used by the test environment and is an unnecessary
dependency. They're only used by the video_loopback target, so moving
them there.

R=mflodman@webrtc.org
BUG=3113

Review URL: https://webrtc-codereview.appspot.com/12379006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6120 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 11:26:40 +00:00
pbos@webrtc.org
b5a22b1464 Revert r6110 and r6109.
Effectively re-landing r6104 as well as r6108 which includes a fix to a
compile error that caused r6104 to be reverted in r6110.

BUG=
TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6119 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 11:07:01 +00:00
henrik.lundin@webrtc.org
c3e8abda7c Deleting all NetEq3 files
NetEq3 is deprecated and replaced by NetEq4
(webrtc/modules/audio_coding/neteq4/).

BUG=2996
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14469007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6118 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 10:40:52 +00:00
henrik.lundin@webrtc.org
4d363ae305 The webrtc::AudioFrame struct contains a variable energy_. Since the energy isn't always calculated when the frame is created, this change makes the CalculateEnergy method in Audio Conference Mixer always calculate the energy.
This part of the the aftermath of issue 3255.

BUG=3255
R=andrew@webrtc.org, henrike@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6117 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:50:02 +00:00
perkj@webrtc.org
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:15:48 +00:00
henrik.lundin@webrtc.org
3a5825909d Deleting all ACM1 files
ACM1 is deprecated and replaced by ACM2
(webrtc/modules/audio_coding/acm2/).

BUG=2996
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18429005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6115 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:08:56 +00:00
stefan@webrtc.org
46e636a3f5 Fix failing test introduced with r6111.
Test was assuming that getting the receive estimate of a stream which hasn't received packets would return an error, new behavior is to return 0.

TBR=wu@webrtc.org
BUG=crbug/371714

Review URL: https://webrtc-codereview.appspot.com/21419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6114 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 23:17:29 +00:00
buildbot@webrtc.org
eaf2bd916b (Auto)update libjingle 66813165-> 66836233
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6113 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 23:12:19 +00:00
mallinath@webrtc.org
d37bcfa882 Changed enums to less generic names.
IPv4/IPv6 will be sent when RegisterUMAObserver is called. This is done
as Initialize is not called through interface.

R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14469006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6112 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 23:10:18 +00:00
stefan@webrtc.org
72885d1c91 Fixes log spam introduced with r6041.
We shouldn't return an error if we don't yet have a valid estimate.

BUG=crbug/371714
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15469006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6111 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 22:09:27 +00:00
buildbot@webrtc.org
17911dca80 (Auto)update libjingle 66798415-> 66813165
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6110 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:42:49 +00:00
henrike@webrtc.org
0df2ea064f Rollback of r6108
BUG=N/A
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6109 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:41:12 +00:00
pbos@webrtc.org
a7f70a487f Initialize bitrates in ValidateCodecFormat.
Attempt to un-break a Visual Studio build (unknown version) that
incorrectly reports that these are potentially uninitialized.

BUG=
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15469005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6108 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:20:40 +00:00
henrike@webrtc.org
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:03:09 +00:00
henrike@webrtc.org
f3a5e6afc4 Suppression for WebRtcVideoChannel2BaseTest.SetSendSsrc.
BUG=3336
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6106 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 17:58:21 +00:00
henrike@webrtc.org
d886e4aaf7 Suppression for test failing on dr memory (in waterfall).
BUG=3336
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6105 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 16:31:21 +00:00
pbos@webrtc.org
d266a2020f Initial wiring of new webrtc API in libjingle.
BUG=1788
R=pthatcher@google.com, pthatcher@webrtc.org
TBR=juberti@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8549005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6104 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 14:32:01 +00:00
henrika@webrtc.org
6b02eea6ac Removes parts of the webrtc::VoEFile sub API as part of a clean-up operation where the goal is to remove unused APIs.
BUG=3206
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6103 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 12:24:10 +00:00
henrika@webrtc.org
1cec3957b8 Removes parts of the webrtc::VoEExternalMedia sub API as part of a clean-up operation where the goal is to remove unused APIs.
BUG=3206
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6102 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 12:19:19 +00:00
kwiberg@webrtc.org
924e81f797 Echo cancellation functions docs: Follow style guide w.r.t. placement of *
The style guide says to use "void* x", not void *x", and the code in
these files already do so, but the comments do not. Fix that.

Also, in the interest of reducing eye strain, I fixed the vertical
alignment in a small number of cases.

BUG=
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6101 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 09:55:19 +00:00
henrika@webrtc.org
66021e0fa2 Removes parts of the webrtc::VoERTP_RTCP sub API as part of a clean-up operation where the goal is to remove unused APIs.
BUG=3206
R=niklas.enbom@webrtc.org, solenberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6100 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 08:53:27 +00:00
turaj@webrtc.org
b9863ce6ba One of the NetEq methods needs to be virtual.
BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6099 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-10 00:58:49 +00:00
turaj@webrtc.org
e14ffaa40b Update DEPS to pull r6096 changes to third_party/openmax_dl/dl/dl.gyp
BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14469005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6098 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 21:40:23 +00:00
mallinath@webrtc.org
0f2a22b3fa Removed sending metrics from PeerConnection about IPv4 and IPv6.
Reasons: 1: There is memcheck failure.
         2: DoInitialize is called before RegisterUMAObserver,
            which means this will be never triggered in real cases.

BUG=3326
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6097 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 21:15:06 +00:00
buildbot@webrtc.org
8a54844333 (Auto)update libjingle 66624678-> 66643715
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6095 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 18:10:55 +00:00
turaj@webrtc.org
17bf9a2c5e Modifying neteq.gyp
|codecs| list is introduced, which is used in both |neteq_dependencies| and AudiDecoder unittests dependencies. This way, AudioDecoder unittests depend only on |codecs| and not on the entire |neteq_dependencies|, which is unnecessary.

TEST=trybots
BUG=
R=andrew@webrtc.org, henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6094 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 18:04:50 +00:00
buildbot@webrtc.org
1cd14a4502 (Auto)update libjingle 66556498-> 66624678
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6093 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 15:01:40 +00:00