wu@webrtc.org
a054569c15
Fix memory leak in datachannel and its test.
...
RISK=P3
TESTED=memcheck build
tools/valgrind-webrtc/webrtc_tests.sh --tool memcheck --test out/Debug/libjingle_peerconnection_unittest --gtest_filter=SctpDataChannelTest*
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1941005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4470 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 22:08:14 +00:00
wu@webrtc.org
0dc0f172a3
sscanf isn't safe with strings that aren't null-terminated. In such case, create a local copy that is null-terminated first.
...
TESTED=GYP_DEFINES=build_for_tool=memcheck gclient runhooks
ninja -C out/Debug/ libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool memcheck --test out/Debug/libjingle_unittest --gtest_filter=Http*
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/1941004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4469 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 21:20:46 +00:00
fischman@webrtc.org
86d7a198ec
ObjC PeerConnection README: note workaround needed for crbug.com/248168
...
BUG=2106
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1940004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4467 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 19:27:54 +00:00
fischman@webrtc.org
1bc1954174
AppRTCDemo: builds using ninja on iOS for simulator and device!
...
Things included in this CL:
- updated READMEs to provide an exact/reproable set of steps for getting the app
running.
- gyp changes to build the iOS AppRTCDemo sample app using gyp+ninja instead of
the hand-crafted Xcode project (which has never worked in its checked-in
form), including a gyp action to sign the sample app for deployment to an iOS
device (the app can also be used in the simulator)
- deleted the busted hand-crafted Xcode project for the sample app
- updated the sample app to match the PeerConnection API that ended up landing
(in a surprising twist of fate, the API landed quite a bit later than the
sample app and this is the first time the CR-time changes in the API are
reflected in the sample app)
- updated the sample app to reflect apprtc.appspot.com HTML/JS changes (equiv to
the AppRTCClient.java changes in http://s10/47299162 )
- picked up the iossim DEPS to enable launching the sample app in the simulator
from the command-line.
- renamed some files to match capitalization of the classes they contain (Ice ->
ICE) per ObjC naming guidelines.
- ran the files involved in this CL through clang-format to deal with xcode
formatting craxy.
BUG=2106
RISK=P2
TESTED=unittest builds with ninja and passes on OS=mac; sample app builds with ninja and runs on simulator and device, though no audio flows from simulator/device (will fix in a follow-up CL)
R=andrew@webrtc.org , justincohen@google.com , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1874005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4466 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 18:29:45 +00:00
wu@webrtc.org
d64719d895
Update libjingle to 50191337.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1885005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4461 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 00:00:07 +00:00
wu@webrtc.org
7fdbb1c832
We don't need to link with libssl.so when we already depend on openssl.
...
This fixes the hidden-symbol linker warnings.
BUG=2149
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1927004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4459 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-31 22:41:36 +00:00
fischman@webrtc.org
caa7024b86
PeerConnectionTest.java: build on android bots as well as linux ones.
...
BUG=1796
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1921005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4455 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-31 21:56:30 +00:00
fischman@webrtc.org
85f07f59ee
PeerConnectionTest.java: use java_home gyp var instead of hardcoding /usr.
...
BUG=1796
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1899005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4433 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-30 18:11:07 +00:00
fischman@webrtc.org
3d496fb046
Roll chromium_revision 205140:214260 to pick up build fixes for ninja iOS device build.
...
TESTED=git try
BUG=2106
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1888005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4431 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-30 17:14:35 +00:00
henrike@webrtc.org
9638564340
Adds no parent to talk folder.
...
BUG=1933
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1896004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4430 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-30 15:51:54 +00:00
fischman@webrtc.org
d6134c7cfd
PeerConnectionTest.java: make the test work for the bots' v4l2loopback.
...
- Make the test agnostic to the actual resolution used, since v4l2_file_player
is playing a non-640x480 file (go/httfw)
- Teach DeviceInfoLinux::FillCapabilityMap() about I420 since that's what
v4l2_file_player is feeding.
Requires https://gist.github.com/fischman/2e9a9b2efd2ad363ef82 be applied to the
v4l2loopback driver code.
BUG=1796
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1891004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4422 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-29 20:43:15 +00:00
fischman@webrtc.org
147d44a450
AppRTCDemo: replace the use of query-string parameters for pre-JB devices.
...
Replaces the use of a query-string parameter with a (once-per-session)
JS-to-Java function call, because query-string parameters on file:// URLs are
busted on ICS and earlier Android releases
(https://code.google.com/p/android/issues/detail?id=17535 ).
Also added channel.html to the list of inputs to cause edits to it to cause a
rebuild of the .apk.
BUG=1949
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1890004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4421 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-29 19:07:33 +00:00
henrike@webrtc.org
ea40bd0cc8
Presubmit script for preventing changes to protected files and add the full list of those files.
...
BUG=2090
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1855004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4419 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-29 18:20:07 +00:00
henrike@webrtc.org
1e09a71126
Update talk folder to revision=49952949
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4413 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-26 19:17:59 +00:00
turaj@webrtc.org
c46967dc53
Revert 4391 "Roll chromium 205140:212975 to support ninja iOS ar..."
...
r4391 results in Mac Release Bot fail: http://chromegw/i/internal.client.webrtc/builders/Mac32%20Release/builds/334/steps/modules_integrationtests
> Roll chromium 205140:212975 to support ninja iOS armv7 build.
>
> In particular, picks up new clang, libvpx, libsrtp, yasm, and gyp.
>
> TESTED=git try on patchset #1
> BUG=2106
> R=henrike@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1849005
TBR=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1874004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4399 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-25 17:48:24 +00:00
fischman@webrtc.org
33584f942c
Introduce a bit of sanity to talk/PRESUBMIT.py's license checking.
...
The comma this allows is a very common variant of the license header (3:1
preferred over the no-comma variant in talk/).
Also pacify pylint a bit, and correct a flagrantly incorrect header I happened
to come across.
BUG=2098,2133
R=henrike@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1866004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4396 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-25 16:43:30 +00:00
fischman@webrtc.org
9fbc558dd4
talk/OWNERS: add libjingle team members from internal webrtc/files/OWNERS
...
BUG=1933
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1867004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4395 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-25 16:22:37 +00:00
fischman@webrtc.org
880c842627
AppRTCDemo: don't render frames that are already outdated.
...
BUG=2121
R=henrike@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1850004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4392 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-24 20:40:03 +00:00
fischman@webrtc.org
87f8a7eb67
Roll chromium 205140:212975 to support ninja iOS armv7 build.
...
In particular, picks up new clang, libvpx, libsrtp, yasm, and gyp.
TESTED=git try on patchset #1
BUG=2106
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1849005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4391 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-24 20:15:43 +00:00
henrike@webrtc.org
8d27a1c723
Makes webrtc and libjingle build from the same gyp-file. Also, the libjingle and webrtc DEPS revisions were mismatching. This cl takes the most recent revision of mismatches. Also disables 64 bit Mac builds for libjingle
...
BUG=1932
TESTED=git try
R=andrew@webrtc.org , fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1851004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4385 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-23 18:15:11 +00:00
henrike@webrtc.org
5c280ecd57
Revert 4382 "Makes webrtc and libjingle build from the same gyp-..."
...
Failures: breaks build bots. Will have to disable Android NDK build for libjingle. The TSAN issues are in webrtc which should be unaffected. Flakey? Here are the failing tests:
http://chromegw/i/internal.client.webrtc/builders/Android%20NDK/builds/303 and http://chromegw/i/internal.client.webrtc/builders/Linux%20Tsan/builds/284
> Makes webrtc and libjingle build from the same gyp-file. Also, the libjingle and webrtc DEPS revisions were mismatching. This cl takes the most recent revision of mismatches. Also disables 64 bit Mac builds for libjingle
>
> BUG=1932
> TESTED=git try
> R=andrew@webrtc.org , fischman@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1836004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1834005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4383 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-23 03:30:32 +00:00
henrike@webrtc.org
5fcddf2334
Makes webrtc and libjingle build from the same gyp-file. Also, the libjingle and webrtc DEPS revisions were mismatching. This cl takes the most recent revision of mismatches. Also disables 64 bit Mac builds for libjingle
...
BUG=1932
TESTED=git try
R=andrew@webrtc.org , fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1836004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4382 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-23 00:27:43 +00:00
henrike@webrtc.org
390fcb7a20
Modified the presubmit checks such that difference license templates are checked for in webrtc and talk folder.
...
BUG=2091
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1833004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4381 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-22 22:32:50 +00:00
henrike@webrtc.org
28654cbc22
Update talk folder to revision=49713299.
...
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1848004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4380 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-22 21:07:49 +00:00
henrike@webrtc.org
0df5b8dfa6
Revert 4372 "Makes webrtc and libjingle build from the same gyp-..."
...
> Makes webrtc and libjingle build from the same gyp-file. Also, the libjingle and webrtc DEPS revisions were mismatching. This cl takes the most recent revision of mismatches.
>
> TESTED=git try
> BUG=1932
> R=andrew@webrtc.org , fischman@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1804004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1835004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4373 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-18 18:58:29 +00:00
henrike@webrtc.org
4e4bf4db8b
Makes webrtc and libjingle build from the same gyp-file. Also, the libjingle and webrtc DEPS revisions were mismatching. This cl takes the most recent revision of mismatches.
...
TESTED=git try
BUG=1932
R=andrew@webrtc.org , fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1804004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4372 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-18 18:33:55 +00:00
henrike@webrtc.org
8c7347124c
talk: DataChannel.java repeated contents. This removes the duplicate.
...
TBR=ajm
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/1825004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4365 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-17 16:28:37 +00:00
henrike@webrtc.org
9de257d00f
Update talk folder to revision=49470012. Same as 375 in libjingle's google code repository.
...
TBR=wu@webrtc.org
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/1824004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4364 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-17 14:42:53 +00:00
henrike@webrtc.org
7b2f955e56
Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README.
...
BUG=1935
R=andrew@webrtc.org , fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1805005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4356 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-16 18:04:56 +00:00
henrike@webrtc.org
723d683ecb
Update talk folder to revision=49260075. Same as 369 in libjingle's google code repository.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1797004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4338 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-12 16:04:50 +00:00
henrike@webrtc.org
28e2075280
Adds trunk/talk folder of revision 359 from libjingles google code to
...
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00