generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,818 Commits 1 Branch 0 Tags 108 MiB
28b54671cb
Commit Graph

190 Commits

Author SHA1 Message Date
stefan@webrtc.org
83599cba77 Reenable WebRtcVideoEngineTestFake.SendReceiveBitratesStats under DrMemory. 
The uninitialized read has been fixed. Suppressing CL: https://code.google.com/p/webrtc/source/detail?r=6073

BUG=11288120
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14529005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6199 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-20 13:16:35 +00:00
henrike@webrtc.org
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in 
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 18:00:26 +00:00
henrike@webrtc.org
c156174da8 Suppressing all tests for WebRtcVideoEngine2 for Win DrMemory Full. 
BUG=3336
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6124 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 16:47:32 +00:00
perkj@webrtc.org
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..." 
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. 
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 18:03:09 +00:00
henrike@webrtc.org
f3a5e6afc4 Suppression for WebRtcVideoChannel2BaseTest.SetSendSsrc. 
BUG=3336
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6106 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 17:58:21 +00:00
henrike@webrtc.org
d886e4aaf7 Suppression for test failing on dr memory (in waterfall). 
BUG=3336
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6105 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 16:31:21 +00:00
pbos@webrtc.org
d266a2020f Initial wiring of new webrtc API in libjingle. 
BUG=1788
R=pthatcher@google.com, pthatcher@webrtc.org
TBR=juberti@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8549005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6104 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 14:32:01 +00:00
kjellander@webrtc.org
9e230eae82 DrMemory: Removing suppression as Dr Memory was fixed. 
According to
https://code.google.com/p/webrtc/issues/detail?id=3275
the issue is now fixed in the drmemory.DEPS of r267732.
Since we don't roll this DEPS (it's automatically updated
as it's a separate solution in the checkout for these bots)
we already have this update.

BUG=3275
TEST=Passing trybot: git try --bot=win_drmemory_light
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6077 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-08 12:24:17 +00:00
henrike@webrtc.org
25a344edc6 WebRtcVideoEngineTestFake.SendReceiveBitratesStats suppressed for "Win DrMemory Full" 
BUG=11288120
R=mikhal@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6073 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-07 16:41:02 +00:00
jiayl@webrtc.org
4220434d37 Implement the Windows screen capturer using the Magnification API. 
The original ScreenCapturerWin is renamed ScreenCapturerWinGdi.

BUG=2789
TESTED=full desktop cast and single monitor cast works on win7 and win8 desktop mode. Have to use GDI capturer on win8 metro mode. Changing display configuration work on the fly.
R=sergeyu@chromium.org, wez@chromium.org

Committed: https://code.google.com/p/webrtc/source/detail?r=6048

Review URL: https://webrtc-codereview.appspot.com/12149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6053 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-05 16:08:47 +00:00
pbos@webrtc.org
f5433753b8 Suppress DrMemory allocator mismatch errors. 
Bot is flooded with these errors, suppressing them to get back to a
normal state, contacting DrMemory team.

R=kjellander@webrtc.org
BUG=3275
TEST=git try -b win_drmemory_light -r 6012

Review URL: https://webrtc-codereview.appspot.com/13419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6013 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-29 12:24:45 +00:00
andrew@webrtc.org
db144429b2 Exclude the new AudioProcessingTest from some sanitizer bots. 
It takes too long.

TBR=kjellander

Review URL: https://webrtc-codereview.appspot.com/12359004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-23 04:16:24 +00:00
kjellander@webrtc.org
0a035c8924 Disable tests in common_video_unittests for Dr Memory. 
These tests takes about 1000 seconds to execute under
Dr Memory Full, causing them to be killed if taking more
than 1200 seconds.
* TestScaler.BiLinearScaleTest
* TestScaler.BoxScaleTest

BUG=3247
TBR=zhaoqin@google.com

Review URL: https://webrtc-codereview.appspot.com/12289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5951 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-22 08:07:03 +00:00
kjellander@webrtc.org
940894d207 DrMemory: Excluding failing tests for Dr Memory Full 
PortAllocatorTest.TestEnableSharedSocketWithNat
fails in libjingle_p2p_unittest.
Example:
http://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/2/steps/memory%20test%3A%20libjingle_p2p_unittest/logs/stdio
Previous experience tells me that disabling only this test
case will make another one in the same test suite fail,
so I'm blanked disabling the whole test.

TBR=phoglund
BUG=3158

Review URL: https://webrtc-codereview.appspot.com/11909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5893 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-13 11:45:43 +00:00
kjellander@webrtc.org
ef79fd7965 DrMemory: Excluding failing tests for Dr Memory Full 
BUG=3158
TEST=None
TBR=kjellander,phoglund

Review URL: https://webrtc-codereview.appspot.com/11899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5892 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-13 08:31:42 +00:00
kjellander@webrtc.org
41e8774113 DrMemory: Excluding failing tests for Dr Memory Full 
The PortTest.TestLocalToTurn of libjingle_p2p_unittest
and DtmfSenderTest.InsertDtmf of libjingle_peerconnection_unittest
failed in the first run on
http://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/
However, I cannot reproduce on my machine, so I'm disabling all
test cases of those tests, assuming the others might fail as well.

BUG=3158
TEST=None
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/11889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5891 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-12 19:53:06 +00:00
kjellander@webrtc.org
ffd242432d DrMemory: Suppress and exclude more tests to green up the full build. 
Exclude failing tests in libjingle tests and suppress
failures in modules_unittests.

Also exclude the following extremely slow tests to make it
possible to get a reasonable execution time for the bot:
* TestScaler.PointScaleTest (81573 ms)
* TestScaler.BiLinearScaleTest (1111554 ms)
* TestScaler.BoxScaleTest (1129625 ms)
* TestVp8Impl.BaseUnitTest (762598 ms)
* VideoProcessorIntegrationTest.ProcessNoLossChangeBitRate (342149 ms)

TBR=phoglund@webrtc.org
BUG=3158, 3183, 3184
TEST=Successful runs on local Windows box:
tools\valgrind-webrtc\webrtc_tests.bat --build-dir out --target Debug --test libjingle_p2p_unittest --tool drmemory_full
tools\valgrind-webrtc\webrtc_tests.bat --build-dir out --target Debug --test libjingle_peerconnection_unittest --tool drmemory_full
tools\valgrind-webrtc\webrtc_tests.bat --build-dir out --target Debug --test modules_unittests --tool drmemory_full

Review URL: https://webrtc-codereview.appspot.com/11819004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5888 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-11 14:16:27 +00:00
kjellander@webrtc.org
e8d1865408 Disable more tests for DrMemory to speed up execution. 
Disable a few more tests on Windows when running under
Dr Memory to get the build time down to a reasonable total.

BUG=None
TEST=None
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/11299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5852 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-07 09:00:12 +00:00
kjellander@webrtc.org
9f57404334 Excluding and suppressing Dr Memory test failures. 
With these tests excluded and failures suppressed
we should be able to bring Dr Memory Full into a
green state in
http://build.chromium.org/p/client.webrtc.fyi/waterfall
so we can move the bots into the main waterfall.

BUG=3158, 3159
TEST=Ran successful runs of the tests that never completed
using the reproduction steps in the issues listed above on
a local Windows box. The tests that just failed weren't tried,
since they cannot have been blocking other possibly failing
tests in the same binary.

R=pbos@webrtc.org
TBR=pbos

Review URL: https://webrtc-codereview.appspot.com/11209004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5850 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-07 08:01:06 +00:00
andrew@webrtc.org
b6dfbed1dc Exclude TwoStreamsSendAndFailUnsignalledRecvInOneToOne from TSAN. 
Example failure:
http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan/builds/1458

TBR=wu@webrtc.org
BUG=2380

Review URL: https://webrtc-codereview.appspot.com/10759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5796 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-26 22:22:46 +00:00
andrew@webrtc.org
b70c8e9dfd Disable flaky WebRtcVideoMediaChannelTests on memcheck and tsan. 
BUG=3096
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5766 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-24 20:57:42 +00:00
kjellander@webrtc.org
08e2dd80a3 Exclude WebRtcVideoMediaChannelTest.AddRemoveCapturerMultipleSources for Valgrind on Mac 
This test seems to crash the bot running memcheck on Mac 10.6 at:
http://build.chromium.org/p/client.webrtc.fyi/builders/Mac%2010.6%20Memcheck
over and over again. I won't file a bug since it's unlikely this
will get fixed as long as Valgrind is not supported on newer OS X
releases.
I mainly wanted to make this bot work better so we can one day start
fixing the leaks it's reporting. One step at the time.

TBR=phoglund
BUG=

Review URL: https://webrtc-codereview.appspot.com/10159005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5719 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-18 21:37:28 +00:00
henrike@webrtc.org
26caf0eb53 Suppresses/disables tsan/memcheck issues due to sync of 63111035. 
BUG=3063
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5706 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-14 22:47:07 +00:00
kjellander@webrtc.org
4a47be0f52 Disable CallTest.ReceivesAndRetransmitsNack for TSan 
The test is failing with:
[ RUN      ] CallTest.ReceivesAndRetransmitsNack
../../webrtc/video/call_tests.cc:479: Failure
Value of: observer.Wait()
  Actual: 3
Expected: kEventSignaled
Which is: 1
[  FAILED  ] CallTest.ReceivesAndRetransmitsNack (122871 ms)

Example:
http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan/builds/1358/steps/memory%20test%3A%20video_engine_tests/logs/stdio

BUG=2908
R=sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5669 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-10 12:50:29 +00:00
mallinath@webrtc.org
d3dc424fe5 Remove posting of ICE messages from WebRTCSession in PeerConnection to signaling thread. 
These callbacks are called from signal thread already. There is no point
in posting messages on the same thread again.

BUG=2922
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5626 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-01 00:05:52 +00:00
henrike@webrtc.org
b898ce9227 Revert of r5622 "disable unit tests" as it should be fixed in r5623. 
BUG=2981
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5624 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-28 23:18:44 +00:00
henrike@webrtc.org
eec3843596 TSAN only disable of two of libjingle's tests for atomic ops as they are failing for TSAN-bot. 
BUG=2981
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9239005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5622 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-28 18:06:42 +00:00
tina.legrand@webrtc.org
125a66adc2 Memory and Tsan tests: Turn off the new-ACM tests 
In this CL https://webrtc-codereview.appspot.com/8829004/, I splitted the tests so that new-ACM runs in separate tests. Almost all of these tests are too slow for the memory and tsan bots, and were already excluded from them. This CL turns off the new-ACM tests from these bots.

BUG=https://code.google.com/p/webrtc/issues/detail?id=2951
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5594 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-21 14:12:00 +00:00
mflodman@webrtc.org
e3842897e2 Adding tsan suppression for error introduced in r5555, causing libjingle_unittest to fail on TSan bot. 
BUG=2931
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8779005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5559 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-17 15:09:39 +00:00
stefan@webrtc.org
505f2a0348 Disabling WebRtcSessionTest.TestIceStatesBundle under memcheck. 
BUG=2924
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8699005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5552 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 12:38:06 +00:00
kjellander@webrtc.org
9cba2e4802 Exclude libjingle_p2p_unittest tests failing TSan Race verifier. 
These tests have been failing for a long time at
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20TsanRV
This bot runs a tool called TSan Race Verifier.
More info about Race Verifiers can be found at
https://code.google.com/p/data-race-test/wiki/RaceVerifier

By excluding the tests like this, they will also be disabled
for the normal TSan bot, where they currently pass. This shouldn't
be a problem since we have a TSan v2 bot running too (which uses
a different set of suppressions), so it should catch any newly
introduced race conditions. The TSan v2 bot will soon replace the
old TSan bot, as v1 is being deprecated.

TBR=mallinath@webrtc.org
BUG=2396
TEST=Passing run on Linux of:
GYP_DEFINES=build_with_tool=tsan gclient runhooks
ninja -C out/Release libjingle_p2p_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan_rv -b out/Release -t libjingle_p2p_unittest

Review URL: https://webrtc-codereview.appspot.com/8329005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5515 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 12:43:40 +00:00
kjellander@webrtc.org
6f8acdc76f Suppressions for libjingle_unittest after roll in r5502 
New errors arrived when rolling libjingle in r5502.
These suppressions are needed to green up the Memcheck and
TSan bots.

BUG=1976,2080
TEST=local runs on Linux:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -b out/Release -t libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool=memcheck -b out/Release -t libjingle_unittest
and trybot:
git try --bot=linux_memcheck,linux_tsan -t libjingle_unittest
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5509 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-08 21:15:59 +00:00
wu@webrtc.org
98aefcd8fe Update tsan suppressions for libjingle_media_unittest. 
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/7559005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5428 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 18:32:43 +00:00
wu@webrtc.org
ca5ff9972e Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=5387

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5427 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 17:37:46 +00:00
wu@webrtc.org
8f19cb9fbc Revert 5387 "Re-enable webrtcvoice/videoengine unittests." 
Missed the result from the last try bot.

> Re-enable webrtcvoice/videoengine unittests.
> 
> TEST=try bots
> BUG=
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7149004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5388 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:31:11 +00:00
wu@webrtc.org
eda6823397 Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5387 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:15:09 +00:00
wjia@webrtc.org
03cfde2d10 Roll Chromium 238260 -> 243863 
R=andrew@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6939004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5385 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 17:48:34 +00:00
pbos@webrtc.org
1d096901ac Move realtime tests to webrtc_perf_tests. 
New binary not to be run on our VMs as they result in flaky tests. These
will instead be run on baremetal machines.

BUG=2710
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-13 12:48:05 +00:00
kjellander@webrtc.org
59d5705385 Fix memory tools error introduced in roll @ r5260 
Turns out that the Chromium revision
https://src.chromium.org/viewvc/chrome?view=rev&revision=237238
introduced a new flag for the memory wrapper scripts.
Due to the way we reuse the chrome_tests.py for WebRTC purposes,
we need to add that flag too.

TEST=linux_tsan bot and locally running:
tools/valgrind-webrtc/webrtc_tests.sh --test test_support_unittests --tool tsan --target Release --build-dir out
from trunk/
BUG=none
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5589006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 14:16:53 +00:00
stefan@webrtc.org
7e9315b42e Adds support for sending redundant payloads over RTX. 
TEST=trybots
BUG=1812
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5209 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-04 10:24:26 +00:00
fbarchard@google.com
b5bc098e20 Clear empty video frames in unittest so DrMemory will allow them to be read without an uninitialized read error. 
BUG=libyuv:263
TESTED=drmemory out\Debug\modules_unittests.exe --gtest_filter=*PreprocessorLogic
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5168 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-25 09:06:33 +00:00
wu@webrtc.org
364f204d16 Update talk to 56698267. 
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/4119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5143 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-20 21:49:41 +00:00
pbos@webrtc.org
9c5fb76662 Exclude AV-sync test from Valgrind platforms. 
Test is performance-dependent and was observed to never sync on the
linux_memcheck bot.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5131 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-18 16:22:50 +00:00
stefan@webrtc.org
b082ade3db Hook up audio/video sync to Call. 
Adds an end-to-end audio/video sync test.

BUG=2530, 2608
TEST=trybots
R=henrika@webrtc.org, mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5128 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-18 11:45:11 +00:00
wu@webrtc.org
e4e5683b41 Clean up tsan suppression file: 
1) remove suppressions that are already fixed.
2) merge duplicated suppressions.

TBR=mallinath
TEST=tsan try bot
BUG=1205,2078,2080

Review URL: https://webrtc-codereview.appspot.com/2949004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5033 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-25 16:29:33 +00:00
wu@webrtc.org
d371a29227 Fix tsan failures for libjingle_unittest. 
1) Change AsyncSocket's SignalReadEvent and SignalWriteEvent's thread mode to multi_threaded_local as they can be accessed from different threads.
2) Protect NATServer::TransEntry::whitelist.
3) Protect PhysicalSocket:error_.

Detail failures can be seen from issue 2080, comment #5.

TBR=fischman@webrtc.org

RISK=P1
TEST=try bots and tsanv2
BUG=2080

Review URL: https://webrtc-codereview.appspot.com/2669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5026 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-23 23:56:09 +00:00
wu@webrtc.org
8804a29951 Add CriticalSection to fakeaudiocapturemodule to protect the variables which will be accessed from process_thread_ and the main thread. 
TEST=try bots
BUG=1205
R=henrike@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5019 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 23:09:20 +00:00
wu@webrtc.org
4d7116be7a Fix tsan failures on filevideocapturer.cc. 
1) init start_time_ns_ before the file_read_thread_ is started to avoid data racing as the start_time_ns_ will also be read by the file_read_thread_.
2) add CriticalSection to protect |finished_| that is accessed by FileReadThread and the main thread

Also remove the suppression for filemediaengine.cc, which has already been fixed in other cl.

TBR=henrike@webrtc.org
TEST=try bots and manual tsan v2 test
BUG=2078

Review URL: https://webrtc-codereview.appspot.com/2509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5018 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 18:41:17 +00:00
mallinath@webrtc.org
50bc553852 Reenable DTLS renegotiation unittest in libjingle. 
This test is failing on memcheck bots. After investigation problem per
say is not in this particular unittest and rather is in suite. So this test
is added to memcheck exclude list.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5011 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-21 17:58:35 +00:00
wu@webrtc.org
3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes. 
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
    #0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
    #0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
    #1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-18 16:27:26 +00:00
wu@webrtc.org
6342066974 Fix tsan failures in channel.cc regarding to the volume settings. 
BUG=2461
TEST=try bots
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4992 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 18:28:55 +00:00
sprang@webrtc.org
603ed98bca Suppress race condition warn in CallTest_ReceivesAndRetransmitsNack_Test 
This test is the one most commonly triggering a race condition in the
event tracing macros. Pending a permanent fix in tracing code,
suppressing tsan warnings for this test.

BUG=2497
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2408004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4986 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 07:49:26 +00:00
wu@webrtc.org
54e729bb73 Remove tsan suppression for the failure that's already fixed. 
TEST=try bot
TBR=mallinath
BUG=1205,2079,2080

Review URL: https://webrtc-codereview.appspot.com/2408005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 23:19:54 +00:00
wu@webrtc.org
853dd07890 Add issue links to the tsanv2 suppressions. 
BUG=2521,2484

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2418004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4984 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 22:50:59 +00:00
kjellander@webrtc.org
83e9c89eeb Exclude more tests for TSan on Windows. 
Apparently more tests were also too slow for the bot
(but ran fine on my own machine). Adding a bunch now
so it should run fine from now on.

TEST=none
BUG=none
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2412004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4978 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 17:32:05 +00:00
kjellander@webrtc.org
d1cfa7149e TSan v2 suppressions and exclusions for libjingle tests. 
Add suppressions for libjingle tests so they pass under TSan v2.
Disable the following tests for TSan v2 (only) since they're failing:
* StunServerTest.TestGood
* JsepPeerConnectionP2PTestClient.*

See build logs at:
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20Tsan%20v2/
for more details.

BUG=1205,2078,2079,2080,2517
TEST=Ran a successful run of each test locally on Linux using:
GYP_DEFINES='tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only"' gclient runhooks
ninja -C out/Release
For each test, run standing in trunk/:
TSAN_OPTIONS="suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7" out/Release/[libjingle_testname]
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2411004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4977 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 16:51:52 +00:00
pbos@webrtc.org
9401524211 Run FullStack tests without render windows. 
Also disables test on valgrind platforms, it has no chance to keep up.

BUG=2278
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4972 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 11:05:37 +00:00
kjellander@webrtc.org
662b1c59c1 Add suppressions for DrMemory and TSan on Windows. 
BUG=2515,2516
TEST=locally running the test as described in the bug.
The TSan excluded test was verified to be the only remaining
test that is too slow for TSan on Windows.

R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2405004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4970 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 10:46:37 +00:00
kjellander@webrtc.org
fc89ba580b Fix build dir flag in webrtc_test.py as passed by runtests.py 
It seems we were hit by the changes in
https://codereview.chromium.org/26184003/
in how we roll with our own wrapper script for the
memory tools.
The build dir flag was changed from --build_dir to
--build-dir, which caused our script to break.

BUG=none
TEST=verified the exact command line executed by the bot succeeds
in my local checkout
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2394005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4959 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-14 18:05:52 +00:00
kjellander@webrtc.org
09418c3320 Add support for --target flag to webrtc_tests.py. 
In https://codereview.chromium.org/26190002 Chromium
started a cleanup of their wrapper script, by adding
the --target flag and start passing build dir similar
to how the bots are setting it (i.e. pass out and not
out/Release).
This CL adds --target support for our wrapper script,
without changing the existing behavior (I'll do a
larger update at a later stage).

BUG=none
TEST=Ran the following successfully:
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Release --target Release --test test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out --target Release --test test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --target Release --test  out/Release/test_support_unittests
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2396004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4957 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-14 17:34:38 +00:00
wu@webrtc.org
ff7b360314 * Remove suppressions that are fixed. 
* Remove duplicated suppression bug_1205_21.

TESTED=try with tsan
BUG=1205
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2368004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4942 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-08 17:32:39 +00:00
wu@webrtc.org
e0d55a0782 Removing suppressions that has been fixed, i.e. r4661. 
Rename suppressions to match the correct issue.

TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2357004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4940 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-07 16:44:38 +00:00
kjellander@webrtc.org
8b7ec82cf4 Exclude P2PTransportChannelSameNatTest.TestConesBehindSameCone for TSan Linux 
I cannot reproduce locally but I can see 10+ consecutive
failing runs at the TSan RV bot at
http://build.chromium.org/p/client.webrtc.fyi/waterfall

TEST=verified the new exclude file is picked up by running:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan_rv -b out/Release -t libjingle_p2p_unittest --gtest_filter=P2PTransportChannel*Test.*
(which runs the test if this file does not exist)
BUG=2396
TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2320004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4869 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-27 20:03:03 +00:00
wu@webrtc.org
6049787252 Add protection to few more methods of AudioDeviceLinuxALSA. Those methods can be called from 
a different thread.

One example is the _playWarning can be changed in AudioDeviceLinuxALSA::Init, which is called on the application's thread. At the same time it can be read via PlayoutWarning() on the VoE's process_thread.

RISK=P2
TESTED=try bots and tsan test:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/libjingle_peerconnection_unittest --gtest_filter=PeerConnectionFactoryTestInternal.CreatePCUsingInternalModules
BUG=1205
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2315004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4866 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-27 18:19:25 +00:00
andrew@webrtc.org
c2ac5ed588 Add more TSAN suppressions for libjingle_media_unittest. 
BUG=2078
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2282004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4830 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-24 18:45:19 +00:00
kjellander@webrtc.org
6e86349273 Disable tests that crash the OS X kernel when run under memcheck. 
These libjingle tests crashes the OS X kernel when run under
memcheck on Mac 10.6. I didn't file bugs for them since it's unlikely
we can fix this anyway. There are several other tests disabled
in the libjingle code with similar comments, without bugs
assigned to them.
See talk/base/physicalsocketserver_unittest.cc for examples.

Affected waterfall: http://build.chromium.org/p/client.webrtc.fyi/waterfall

TEST=none
BUG=none
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2278006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4825 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-24 12:34:51 +00:00
jiayl@webrtc.org
dd57cd6ed5 Removing the tsan text exclusion since the tests should be passing now. 
BUG=2299, 2290, 2291
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2260004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4799 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-20 00:51:53 +00:00
kjellander@webrtc.org
7a968a8f07 Add more TSan and Dr Memory suppressions for modules_unittests 
I'm trying to get these tests green on Windows in
http://build.chromium.org/p/client.webrtc.fyi

BUG=2319,2323
TEST=local runs passing
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2230004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4781 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 19:18:20 +00:00
stefan@webrtc.org
5f1051631a Fix disabling of tests. 
BUG=2378
R=pbos@webrtc.org
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2244005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4778 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 15:28:10 +00:00
stefan@webrtc.org
da79008ab4 Disabling crashing or flaky tests in peerconnection_unittest. 
R=kjellander@webrtc.org
TBR=wu@webrtc.org
TESTS=trybots
BUG=2378

Review URL: https://webrtc-codereview.appspot.com/2227004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4767 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 13:11:38 +00:00
pbos@webrtc.org
be63fd644f Initialize CodecInst structs in test_api_audio.cc. 
Fixes errors detected by DrMemory on Windows.

BUG=2382
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2228004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4764 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 09:33:17 +00:00
kjellander@webrtc.org
f6ae62ffa3 Add Win TSan exclude and Dr Memory suppressions 
To green up the FYI builders.

BUG=2323,2382
TEST=passing local run.
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/2218005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4755 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 21:16:48 +00:00
kjellander@webrtc.org
eddbfb8cf8 Add more Dr Memory suppressions for common_audio_unittests 
BUG=2321
TEST=passing local run.
TBR=andrew

Review URL: https://webrtc-codereview.appspot.com/2220004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4754 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 20:53:20 +00:00
stefan@webrtc.org
ab800f64bc Disable flaky libjingle tests under tsan and memcheck. 
BUG=2380, 2379
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2218004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4752 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 15:22:32 +00:00
pbos@webrtc.org
e07049f19f Lock RTPSender statistics. 
Suppressing these errors in TSan has become tedious. It's better to just
lock them.

BUG=2349
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2197004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4713 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-10 11:29:17 +00:00
pbos@webrtc.org
26b0d77baf Suppress RTPSender race regardless of codec. 
New test uses SendGeneric instead of SendVP8.

BUG=2349
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2194004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4705 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-09 15:34:36 +00:00
pbos@webrtc.org
0181b5f8dd ExternalVideoDecoder for new VideoEngine API. 
Implements the ExternalVideoDecoder interface for VideoReceiveStream.
Also adds a FakeDecoder used in tests, removing the overhead of running
the EngineTest tests with VP8 under Memcheck/TSan, allowing us to enable
them under Memcheck/TSan as well.

BUG=2346,2312
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2172004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4702 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-09 08:26:30 +00:00
andrew@webrtc.org
9080518a39 Restore severity precondition to logging.h. 
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.

Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort

Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled:                          666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled:       673 ms (1.01x)

BUG=2314
R=henrik.lundin@webrtc.org, henrike@webrtc.org, kjellander@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2160005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-05 16:40:43 +00:00
mflodman@webrtc.org
e2d4da6586 Enable EngineTest.ReceivesPliAndRecoversWithNack and fix memcheck suppression filter. 
BUG=2346
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4677 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-04 14:21:57 +00:00
mflodman@webrtc.org
be23b32727 Adding tsan suppression for BUG 2349. 
TSAN found a read/write race for RTPSender::[packets_sent_/payload_bytes_sent)] between RTPSender::SendToNetwork and RTCPSender::SendRTCP.

BUG=2349
R=holmer@google.com

Review URL: https://webrtc-codereview.appspot.com/2168004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4676 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-04 13:36:52 +00:00
mikhal@webrtc.org
3abb82d8df Suppress video engine test 
BUG=2346
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2161005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4670 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 22:19:31 +00:00
kjellander@webrtc.org
c8c32638be Remove JpegEncoder suppression as jpeg is now removed. 
See https://code.google.com/p/webrtc/source/detail?r=4646

BUG=2322
TEST=Ran common_video_unittests with the suppression removed
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2164004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4664 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 18:38:52 +00:00
mflodman@webrtc.org
f5f5da0df1 Adding TSAN suppression for test posix udp transport. 
This is race for reading a bool in the WebRTC test UDP transport and
not in any production code.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4663 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 14:15:21 +00:00
kjellander@webrtc.org
5aedb295d5 Add TSan and Dr Memory suppressions for Windows 
This works enables us to add add more memory tools bots to the
WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
These suppressions will be needed to get the bots green initially.

This CL also updates the PRESUBMIT.py scripts for the previous
memcheck and TSan suppression directories with the trybots we
currently have. It also adds a PRESUBMIT.py script for the
Dr Memory suppressions.

BUG=1938,2319,2321,2322,2323,2324,2328,2329,2330,2333
TEST=Local execution of the tests passes when these suppressions
are used.

R=niklas.enbom@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4653 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-02 11:50:46 +00:00
kjellander@webrtc.org
f8c16b8bf4 Disabling CondVarTest for TSan v2 (take 2) 
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, the TSan v2 bot in our new WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
will hopefully go green.

The define used only exists for TSan v2, so v1 should be
unaffected.

The suppression added in http://review.webrtc.org/2126005/
turns out actually has no effect, so I'm removing it again.
It's probably useless since TSan v2 obviously alters the code's
behavior, causing these errors. Since the errors are not TSan v2
failures, the suppression has no effect.

BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2115005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-29 09:47:18 +00:00
kjellander@webrtc.org
5f8d05add2 Disabling CondVarTest for TSan v2. 
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, our new WebRTC FYI waterfall with a TSan v2 bot will hopefully go green when deployed (see https://codereview.chromium.org/23231004)

The define used only exists for TSan v2, so v1 should be
unaffected.

BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4635 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-28 19:54:33 +00:00
pbos@webrtc.org
2b325e8394 TSan suppression for RampUpTest/* and EngineTest/*Nack*. 
BUG=2312
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2132004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4633 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-28 10:29:10 +00:00
phoglund@webrtc.org
02421fcf0b Corrected documentation on webrtc_test.sh. 
R=kjellander@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/2122004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4628 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-27 14:00:10 +00:00
tina.legrand@webrtc.org
89502c1ca8 Memory and tsan tests: Turning off renamned tests 
In r4625 AudioCodingModuleTest.RunAllTests was broken down to a number of
smaller tests. This CL turns off these tests, as RunAllTests was turned off
before.

TBR=kjellander@webrtc.org

BUG=issue2173

Review URL: https://webrtc-codereview.appspot.com/2121004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4626 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-27 09:38:10 +00:00
henrike@webrtc.org
442709ea96 Disable broken test and add suppressions. 
BUG=2299,1205

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2101004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4606 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-23 21:42:01 +00:00
henrike@webrtc.org
69a774fc42 Suppresses another tsan warning. Warning is reported here: http://chromegw/i/client.webrtc/builders/Linux%20Tsan/builds/460/steps/memory%20test%3A%20libjingle_peerconnection_unittest/logs/D5CAED6268DAACB7 
TBR=wu@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/2096004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4603 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-23 14:38:15 +00:00
henrike@webrtc.org
61b262c427 Disable tests according to issues: 1205,2272,2288,2290,2291 
BUG=1205,2272,2288,2290,2291
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2069005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-22 20:27:49 +00:00
wu@webrtc.org
ebe68aad44 Fix memory leak in portallocatorsessionproxy_unittest. 
Remove the suppressions that have been fixed.

BUG=1972,2263
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2062005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4576 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-20 21:14:39 +00:00
phoglund@webrtc.org
32fe90b3f9 Made all integration tests use consistent naming. 
After decision by pbos@, mflodman@ et. al.

BUG=
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2041004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4565 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-19 11:40:19 +00:00
kjellander@webrtc.org
f3bf5e02c8 Add suppressions file for TSan v2 
This is needed for our tests to pass when run under TSan v2.
More details on TSan v2 can be found at
http://www.chromium.org/developers/testing/threadsanitizer-tsan-v2

BUG=chromium:274414
TEST=ran tests locally standing in trunk/ using:
GYP_DEFINES=tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only" gclient runhooks
ninja -C out/Release
TSAN_OPTIONS=suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7 out/Release/testname
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2057004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4564 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-19 05:33:20 +00:00
wu@webrtc.org
166991fa1f Suppress tsan errors on libjingle_peerconnection_unittest. 
TBR=mallinath
BUG=1205

Review URL: https://webrtc-codereview.appspot.com/2055004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4560 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-16 17:57:44 +00:00
wu@webrtc.org
a2e0901e54 Suppress tsan errors. 
BUG=1205,2079
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2054004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-16 17:00:01 +00:00
wu@webrtc.org
97d1a988b6 Remove suppressions for the cases that's already fixed. 
Rename some of the suppressions to new issue.
Fix leaks in virtualsocket_unittest.

BUG=1972,1976,2100
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2010005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4536 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-13 00:13:26 +00:00
wu@webrtc.org
94349552de Disable P2PTransportChannelTest.* on memcheck and tsan bots due to issue 1972. 
TBR=mallinath
BUG=1972
RISK=P3
TEST=with below cmd lines and disabled tests won't run
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Debug --test libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest* --tool tsan
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Debug --test libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest* --tool memcheck

Review URL: https://webrtc-codereview.appspot.com/1954004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4479 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-02 23:30:50 +00:00