bjornv@webrtc.org
4ade5506eb
Delay Estimator Unit tests
...
This CL includes unit tests to verify correct behavior of the delay estimator used in AEC and AECM.
Tested with audioproc_unittest
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2049 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 09:42:16 +00:00
bjornv@webrtc.org
2e729762c7
New _CreateBinaryDelayEstimator() and removed _history_size()
...
Changed create function to match malloc() in functionality.
Removed unused function.
Tested with audioproc_unittest
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2048 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 08:30:29 +00:00
bjornv@webrtc.org
180f83f8e2
File name change to follow style
...
A unit test should end with *_unittest.* Otherwise the test itself will be evaluated for line coverage.
Tested with audioproc_unittest
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/493008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2045 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 07:01:10 +00:00
andrew@webrtc.org
1bc98bc873
Remove erroneous error trace.
...
It appears this trace is informational, not an error.
Discovered in a plugin log from a ChromeOS device. Just
decided to remove it.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=29356
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/479012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 20:10:47 +00:00
tommi@webrtc.org
7ab51497a7
Remove usage of Atomic32Wrapper from a few places.
...
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 13:33:28 +00:00
hta@webrtc.org
52c0fec34c
Added UDP socket factory function to UdpTransportImpl constructor
...
This is a refactoring in preparation for creating small unit tests for the
udp_transport module.
BUG=
TEST=unittest
Review URL: https://webrtc-codereview.appspot.com/482004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2041 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 12:39:04 +00:00
phoglund@webrtc.org
c3eb178a0d
Will now filter chrome-triggered builds.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/492009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2040 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 11:23:35 +00:00
phoglund@webrtc.org
c440d56e92
Rewired the oath2 symlink and updated tgrid_parser to the new Build Bot version's tgrid syntax.
...
Added back the gviz_api to the tools deps - will remove it from the main project DEPS in a different patch. Rewired those symlinks too.
Made the build status loader algorithm more scalable. It read in the whole database on each load which is probably unsustainable in the long run. Also, it will now forget bots that have offline for more than ~5 revisions.
Fixed a bug in the coverage tracker.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/486002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2039 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 08:49:10 +00:00
andrew@webrtc.org
336d52d817
Roll Chromium 122775:132375 (current Canary).
...
Hijacking the gyp inside_chromium_build finally came back to bite us.
Chrome started using it to control the path to the gold linker, which
broke our build. This change removes use of inside_chromium_build from
WebRTC.
If peerconnection rolls past this point, libjingle.gyp will need to be updated.
BUG=
TEST=build on Linux, Mac, Win
Review URL: https://webrtc-codereview.appspot.com/493007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2038 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 01:19:27 +00:00
marpan@webrtc.org
3e2e7038e6
VPM: Allow for option to compute the content metrics every nth frame.
...
Review URL: https://webrtc-codereview.appspot.com/492006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2034 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 15:58:14 +00:00
kjellander@webrtc.org
050f212881
Updating clean script for new buildbot configurations.
...
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/485008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2033 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 14:41:11 +00:00
kjellander@webrtc.org
3629a3cc0e
Updating master.cfg for updated Mac bot names. This CL completes the changes made in http://webrtc-codereview.appspot.com/493006/ to get the Mac bots back online.
...
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/492008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2032 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 14:34:23 +00:00
kjellander@webrtc.org
5f853620de
Updated Mac hostnames due to network changes.
...
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/493006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2031 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 14:14:46 +00:00
mflodman@webrtc.org
b1fbf016b5
Added timestamp logs, i.e. only tracing.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/482001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2030 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 12:58:49 +00:00
mflodman@webrtc.org
3c611fd4fd
Removed NetEQ Test compile error.
...
BUG=443
TEST=Compiles using clang version 3.1 (trunk 153589)
Review URL: https://webrtc-codereview.appspot.com/493005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2029 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 10:57:27 +00:00
xians@webrtc.org
aef0a61117
webrtc: OTHER_CPLUSPLUSFLAGS should be a list, not a string.
...
Review URL: https://webrtc-codereview.appspot.com/492007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2028 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 09:57:16 +00:00
bjornv@webrtc.org
bfda85f2ee
Safe handling of invalid inputs in delay_estimator.
...
The delay_estimator crash on invalid create inputs when running new unit tests. This can't occur on a higher level unless corresponding enum and defines are incorrectly changed.
The create and free functions are now more like malloc() and free() in design. The complete change to that will be done in a seperate CL.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/492003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2027 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 07:28:29 +00:00
phoglund@webrtc.org
0ea088f92e
Turned off Windows diagnostics.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2026 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 12:22:12 +00:00
phoglund@webrtc.org
a36a4bb340
Disabled flaky voe tests.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2025 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 10:11:15 +00:00
kjellander@webrtc.org
04d452e968
Fixing issues due to Buildbot 0.8.4p1 upgrade.
...
BUG=None
TEST=Tested with local edits on buildmaster and try master.
Review URL: https://webrtc-codereview.appspot.com/490007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2024 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 09:17:05 +00:00
stefan@webrtc.org
9784512bf3
Fix coverity warning and possible memory leak.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/493004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2023 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 07:47:05 +00:00
stefan@webrtc.org
c4892bca3d
Disable libyuv MirrorTest due to crashes on Linux 32 bit.
...
See http://code.google.com/p/webrtc/issues/detail?id=335 for more info.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/487003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2017 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 13:26:22 +00:00
stefan@webrtc.org
5d2514a1f7
Revert 2013 - Upgrade libyuv to r235.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/493003
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/491008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2016 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:55:44 +00:00
mflodman@webrtc.org
a014ecc049
Changed CriticalSectionScoped constructor usage for ADM.
...
Only search and replace for the input to the constructor, no other changes.
BUG=184
TEST=Compiles on all platforms.
Review URL: https://webrtc-codereview.appspot.com/483001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2015 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:15:51 +00:00
bjornv@webrtc.org
7056908774
System delay unit tests
...
Added a system delay test class. Noticed I don't need the ApmTest class at all, which simplified the implementation.
Start at patch set 3. The others are not complete.
BUG=None
TEST=
Review URL: https://webrtc-codereview.appspot.com/475003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2014 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:13:50 +00:00
stefan@webrtc.org
6803fe883f
Upgrade libyuv to r235.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/493003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2013 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:01:32 +00:00
tina.legrand@webrtc.org
16b6b90a82
Split of stereo packets moved
...
In this CL I have rewritten the way we handle stereo packets in VoE.
Before this change we split the packets in the RTP module and added two packets to ACM, one for the left channel and one for the right. This lead to timing problems caused when a different thread called RecOut in between the two calls to add stereo packet to ACM. (RecOut is called to pull audio data, decode packets, on the receiving side).
While doing the change I also took the opportunity to changed some functions so that the data stream is uint8 everywhere.
The list of files in this CL is long, but should be fairly easy to review. It is difficult to see what has been changed in some of the tests, but I can explain offline.
Reviewers:
Björn - /src/modules/audio_coding
Patrik - /src/modules/rtp_rtcp
Patrik -/src/modules/utility
Henrik A - /src/voice_engine
BUG=410
TEST=voe_cmd_test
Review URL: https://webrtc-codereview.appspot.com/473003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2012 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 11:02:38 +00:00
pwestin@webrtc.org
ce33035dee
Cleanup encode call.
...
Review URL: https://webrtc-codereview.appspot.com/491003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2011 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:59:14 +00:00
kjellander@webrtc.org
f1e020ec99
Cleanup script using Python instead of rm command.
...
BUG=None
TEST=Ran the script on all platforms and a Linux master+slave build.
Review URL: https://webrtc-codereview.appspot.com/479008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2010 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:18:10 +00:00
kjellander@webrtc.org
a96eead975
Updating Windows debug try slave hostname
...
BUG=None
TEST=None needed.
Review URL: https://webrtc-codereview.appspot.com/492004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2009 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:16:50 +00:00
kma@webrtc.org
33ced9cc99
Same code change from issue 428004, with uint corrected to uint32_t in WebRtcSpl_MaxAbsValueW32, for a MAC compiler error.
...
Review URL: https://webrtc-codereview.appspot.com/472006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2008 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 17:40:40 +00:00
phoglund@webrtc.org
e1bbdb488e
Rewrote external media test.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/482002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2007 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 14:15:48 +00:00
braveyao@webrtc.org
efbdec0542
Minor fix to severl image path in vie_win_test
...
BUG = NULL
TEST = Manual test with vie_win_test
Review URL: https://webrtc-codereview.appspot.com/479007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2006 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 10:24:18 +00:00
stefan@webrtc.org
c35f5ced92
Enable multi-frame FEC by default for temporal layers <= 2. For two temporal layers we currently only protect the base layer.
...
This also introduces zero column insertion into packet masks when some sequence numbers deliberately haven't been given to the FEC generator.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/477001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2005 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 07:42:25 +00:00
cd@webrtc.org
85b4a1b715
Special version of 'bitrv2' when len is 128:
...
* 5.5% AEC overall speedup for the straight C path.
* 8.6% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/480001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2004 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 21:25:17 +00:00
wu@webrtc.org
5d8c102899
Move those calls that may fail out of the ctor to Init function.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2003 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 16:54:05 +00:00
leozwang@webrtc.org
91ed80e5c3
Correct wrong trace level
...
Review URL: https://webrtc-codereview.appspot.com/487002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2002 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 14:42:20 +00:00
tommi@webrtc.org
98ad0ff1b0
Move the COMPILE_ASSERT macro to its own header file.
...
TEST=n/a
BUG=none
Review URL: https://webrtc-codereview.appspot.com/492002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2001 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 11:53:07 +00:00
andrew@webrtc.org
e713fd0eee
Enable the "unused variable" warning on Windows.
...
- Break out direct_show_base_classes to its own gyp file to have it
treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).
BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)
Review URL: https://webrtc-codereview.appspot.com/489001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 07:13:46 +00:00
wu@webrtc.org
96b3017b33
When GetEncoder or SetSendCodec failed, we should clean up and return error.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/490001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1995 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-06 19:49:28 +00:00
wu@webrtc.org
78075451ed
Don't return fail if the denoising is already enabled/disabled.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/488001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1994 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-06 01:01:16 +00:00
andrew@webrtc.org
231f5d0d25
Remove missing VAD file from source list.
...
BUG=
TEST=gyp run on Windows and build.
TBR=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/479003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1993 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-06 01:00:06 +00:00
phoglund@webrtc.org
a1facdcf0f
Re-enabled video sync tests (new attempt).
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/478001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1992 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 16:59:01 +00:00
bjornv@webrtc.org
2273f325b2
VAD refactoring: Code style changes of local function.
...
Changes applied to local GmmProbability():
* Replaced shift macros with shift operations
* Indentation and braces
* Removed redundant code
* Removed unnecessary type casts
* Name changes
* Adjusted comments
Tested with vad_unittests and audioproc_unittest
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/475002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1991 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 10:22:02 +00:00
pwestin@webrtc.org
cac787842c
New attempt to cleanup TMMBR.
...
Review URL: https://webrtc-codereview.appspot.com/472007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1990 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 08:30:10 +00:00
cd@webrtc.org
70ed0a6f91
No casting and call lower precision trigonometric functions:
...
* 2.2% AEC overall speedup for the straight C path.
* 2.4% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/477002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1989 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 00:38:55 +00:00
leozwang@webrtc.org
f3dc22f7d1
Reformat android related code
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/472004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1988 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 17:15:42 +00:00
tommi@webrtc.org
851becd00c
Remove public virtual voe::SharedData inheritance.
...
This is a fix for coverity issues: 10446, 10445, 10444, 10443.
Although the cl is rather big, there aren't many code changes:
* Instead of an implicit vtable pointer, there is now an explicit |_data| member to access the shared data.
* We don't access the member variables of SharedData directly. There are accessors instead.
* SharedData setters that set values that must be freed, automatically free the previous value and 'addref' if required the new one.
* Lots and lots of 'rewrapping' due to search/replace after the above changes.
BUG=10446, 10445, 10444, 10443
TEST=Run all tests for VoE.
Review URL: https://webrtc-codereview.appspot.com/472009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1987 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 14:57:19 +00:00
pwestin@webrtc.org
ae19720982
Fixed assert strings where string literals are used as booleans.
...
Review URL: https://webrtc-codereview.appspot.com/473002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1986 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 14:43:54 +00:00
pwestin@webrtc.org
27fe1b702e
Added compile time support for direct tracing.
...
Review URL: https://webrtc-codereview.appspot.com/469006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1985 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 08:08:30 +00:00