phoglund@webrtc.org
2b87891901
Implemented build status tracking.
...
Left to do:
- UI for presenting the data
- Directory structure reorganization
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/382003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1588 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 17:08:03 +00:00
henrikg@webrtc.org
fede80c0b8
Updated test web page info for PeerConnection v2.
...
Different loopback pages are needed for v1 and v2.
Also removed obsolete comment.
Review URL: https://webrtc-codereview.appspot.com/375005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1587 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 13:10:48 +00:00
phoglund@webrtc.org
d4f0a0e2bc
Refactored the dashboard in order to add new functionality and added some new functionality.
...
Note that all files were moved to a new directory. The diffs won't be 100% friendly because of this.
Extracted common handling for OAuth on both sides of the connection in order to add a new build status
data handler. This data handler will be used to report build status data. Don't look too closely at the
details of what data is transferred as this will change in the next patch. We will also extract data from
a different page in a slightly different way, but there won't be huge differences.
In particular, we won't look at the /one_box_per_builder page on the master but rather at the transposed
grid (/tgrid) on the build master since we also need the revision number. The regular expressions to
extract the data will be slightly more complex.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1586 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 10:59:23 +00:00
andrew@webrtc.org
7fe219f681
Add some additional checks for corrupt payload.
...
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.
BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.
Review URL: https://webrtc-codereview.appspot.com/369015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 02:40:37 +00:00
mallinath@webrtc.org
1f238fd316
Update libsrtp revision in DEPS to chrome/deps/../libsrtp@119742.
...
Review URL: https://webrtc-codereview.appspot.com/381001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1584 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 01:27:15 +00:00
kma@webrtc.org
727a0a03a1
Fixed a bug in assembly code in aecm_core.c (hasn't caused a problem yet).
...
Did apm unit test. Bit exact.
Review URL: https://webrtc-codereview.appspot.com/366010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1583 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 00:05:22 +00:00
frkoenig@google.com
d8f58a4ab0
Cross platform build fix for SSIM (part 2)
...
Data alignment fix for SSIM.
WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128. By declaring the
variable as __m128i it will always be 128 bytes aligned.
Related to issue 239013.
http://webrtc-codereview.appspot.com/239013/
Review URL: https://webrtc-codereview.appspot.com/375004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1582 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 17:49:38 +00:00
bjornv@webrtc.org
26e8a58130
VAD refactor: Create() and Free()
...
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.
TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 14:42:50 +00:00
henrik.lundin@webrtc.org
dd478e2081
Fix for warning in GCC 4.6
...
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/ .
Review URL: https://webrtc-codereview.appspot.com/369024
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 13:12:41 +00:00
xians@webrtc.org
79af734807
This patch fixes the converity warnings in voice engine.
...
Review URL: https://webrtc-codereview.appspot.com/373017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1579 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 12:22:14 +00:00
stefan@webrtc.org
91c630851a
Fix potential VCMReceiver crash.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/368012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 10:49:08 +00:00
henrika@webrtc.org
2919e95c2a
Resolves Coverty issue #10347 .
...
Uninitialized member (UNINIT_CTOR).
Review URL: https://webrtc-codereview.appspot.com/369023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1577 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 08:45:03 +00:00
marpan@webrtc.org
cdba1a836b
test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file.
...
Review URL: https://webrtc-codereview.appspot.com/373016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 00:36:14 +00:00
andrew@webrtc.org
293d22b39b
Add a new macro for bit-exact audioproc tests.
...
Enable bit-exact test for all fixed-point configs.
BUG=114
TEST=audioproc_unittest on all platforms.
Review URL: https://webrtc-codereview.appspot.com/369018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1575 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 22:04:26 +00:00
andrew@webrtc.org
72fe2443ea
Fix neteq watchlist.
...
TBR=henrik.lundin@webrtc.org
BUG=
TEST=watchlists.py
Review URL: https://webrtc-codereview.appspot.com/369020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1574 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 21:57:43 +00:00
andrew@webrtc.org
40654039cd
Use pointer-based CriticalSectionScoped().
...
The reference-based constructor is deprecated.
BUG=185
TEST=audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1573 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 20:51:15 +00:00
pwestin@webrtc.org
7ca9925068
Addding myself to video codec watch list.
...
Review URL: https://webrtc-codereview.appspot.com/375003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1572 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 15:45:04 +00:00
kma@webrtc.org
89a100092a
A minor change in function WebRtcNetEQ_PacketBufferFindLowestTimestamp for
...
NetEq, for performance reasons.
In Android platform, with an offline testing file, the function cycles was reduced by 25%.
This function was also reformatted.
Review URL: https://webrtc-codereview.appspot.com/367010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1571 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 15:37:33 +00:00
mflodman@webrtc.org
7627843352
Added NULL check in external transport test code.
...
BUG=C-10246
Review URL: https://webrtc-codereview.appspot.com/367022
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1570 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:21:26 +00:00
pwestin@webrtc.org
5dad00be52
Coverty fix: FEC unintended signed extension and resource leaks.
...
Review URL: https://webrtc-codereview.appspot.com/368010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:05:29 +00:00
mflodman@webrtc.org
d3b22c9356
Resolved X11 shared memiory leak.
...
BUG=248
TEST=See bug
Review URL: https://webrtc-codereview.appspot.com/367016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1568 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:44:28 +00:00
bjornv@webrtc.org
0c6f931420
Removed versions in module/audio_processing and common_audio/vad.
...
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:39:08 +00:00
stefan@webrtc.org
2fd1e1e40d
Add unittests for ReceiverFec.
...
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:03:37 +00:00
phoglund@webrtc.org
31ba407ac2
Enabled GCC 4.6 bot.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/369019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1565 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 15:40:21 +00:00
pwestin@webrtc.org
04cf69a714
Coverty: cleanup CheckCSRC.
...
Review URL: https://webrtc-codereview.appspot.com/369014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
2f7740973d
Fixed C errors from GCC 4.6.
...
Fixed errors in .c files.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/373014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1563 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:44:26 +00:00
mflodman@webrtc.org
1f992807eb
Fixed frame scaler bugs.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1562 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:42:53 +00:00
phoglund@webrtc.org
048eb7cda6
Finished rewriting the audio processing test.
...
Partial rewrite of audio processing tests.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1561 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 11:58:41 +00:00
mflodman@webrtc.org
832adebca2
Removed MapWrapper from ViEFrameProviderBase.
...
BUG=C-10189
Review URL: https://webrtc-codereview.appspot.com/356002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1560 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:31:34 +00:00
mflodman@webrtc.org
194a93ac66
Adding ViE NULL checks.
...
BUG=C-10188, C-10246, C-10595
Review URL: https://webrtc-codereview.appspot.com/373013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1559 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:11:22 +00:00
tina.legrand@webrtc.org
cbe1de9aa6
This CL solves three remaining Coverity warnings.
...
A few more members were left uninitialized, and one more size mismatch in a multiplication.
Review URL: https://webrtc-codereview.appspot.com/367001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1558 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:00:46 +00:00
mallinath@webrtc.org
4bcd1776a6
New libsrtp roll @ 119285
...
Review URL: https://webrtc-codereview.appspot.com/375002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1557 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 00:28:32 +00:00
andrew@webrtc.org
53df136240
Add upload and commit checks to a common function.
...
Add HasDescription and HasNoStrayWhitespace checks.
BUG=none
TEST=uploaded a dummy CL with violations.
Review URL: https://webrtc-codereview.appspot.com/372004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1556 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 21:24:23 +00:00
mallinath@webrtc.org
a8c568f0a4
Fix external codec erase in destructor.
...
Review URL: https://webrtc-codereview.appspot.com/368008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1555 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 16:19:03 +00:00
phoglund@webrtc.org
d1a860b415
Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans.
...
Fixed remaining compilation errors in release, etc.
Fixed errors from GCC 4.6 compilation.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/366008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 14:49:28 +00:00
andrew@webrtc.org
42ae41e5a2
Fix enumeral comparison error.
...
TBR=henrike
BUG=
TEST=build on Linux.
Review URL: https://webrtc-codereview.appspot.com/372007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1553 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 19:38:16 +00:00
andrew@webrtc.org
b9d7d934de
Rename interface/ to include/ in audio_processing.
...
BUG=none
TEST=build on Linux.
Review URL: https://webrtc-codereview.appspot.com/367007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1552 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 19:21:13 +00:00
andrew@webrtc.org
24bd58e689
Properly count anonymous mixing participants.
...
When _amountOfMixableParticipants == 1, we skip mixing and saturation
protection. Without this fix, an anonymous participant would only be
properly counted if it was the last added.
For example, if an anonymous participant was added first, followed by
a regular participant, _amoutOfMixableParticipants would == 1 and the
regular participant would not be mixed.
BUG=issue209
TEST=New test added to voe_auto_test to verify, and used voe_cmd_test.
Review URL: https://webrtc-codereview.appspot.com/367006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1551 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 18:57:44 +00:00
andrew@webrtc.org
96bc9c420f
Enable audioproc_unittest on Windows.
...
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/373009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1550 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 17:59:03 +00:00
andrew@webrtc.org
7adda5cb1b
Roll libsrtp 115467:118928.
...
Fix paths to headers in the gyp file.
BUG=243
TEST=
Review URL: https://webrtc-codereview.appspot.com/369013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1549 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 17:50:12 +00:00
henrik.lundin@webrtc.org
dcf006480c
Fix typo in a comment
...
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/369012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1548 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:48:00 +00:00
henrik.lundin@webrtc.org
4679652d57
Implemented a fix for Issue 88.
...
NetEQ now checks for too early CNG packets, and modifies the CNG
sample counter to jump forward in time if needed to combat clock
drift.
Adding a new unittest to reproduce and solve the issue. The
unittest LongCngWithClockDrift verifies that the buffer delay
before and after a long CNG period is almost constant. The test
introduces a clock drift of 25 ms/s.
BUG=http://code.google.com/p/webrtc/issues/detail?id=88
TEST=neteq_unittests NetEqDecodingTest.LongCngWithClockDrift
Review URL: https://webrtc-codereview.appspot.com/372002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1547 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:37:41 +00:00
mflodman@webrtc.org
9b0a820624
Fixed double erase in ViEChannelManager channel map.
...
Review URL: https://webrtc-codereview.appspot.com/369011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1546 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:00:49 +00:00
mflodman@webrtc.org
b11424bc11
Remove ViEShared inheritance for interface impl.
...
Review URL: https://webrtc-codereview.appspot.com/357002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1545 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 13:42:03 +00:00
bjornv@webrtc.org
f4b77fd722
VAD refactor: Mode changed to "int".
...
As part of style this CL includes changing the input aggressiveness mode from int16_t to int. No other style changes made.
Impact on:
- Audio Processing: Changed return value on MapSetting().
- Function test in audio_conference_mixer already uses int. No action.
- NetEq: Function pointer changes and input parameter changes in SetVADMode() and SetVADModeInternal().
- Audio Coding: Uses enum ACMVADMode which is type independent.
- VAD: Two unit tests.
TESTS=vad_unittests, neteq_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1544 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 12:40:00 +00:00
bjornv@webrtc.org
2a4dcd7d15
VAD refactor: WebRtcVad_InitCore().
...
Impact only locally.
- Replaced for loops with memset().
- Added guard against NULL pointer.
- Removed mode as input parameter (never really used).
- Updated unit tests.
- Made struct member init_flag "int".
- Updated function description.
- Updated Copyright notes with 2012.
- Removed some lint warnings.
TESTS=vad_unittests, audioproc_unitest
Review URL: https://webrtc-codereview.appspot.com/369005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1543 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 12:18:12 +00:00
henrike@webrtc.org
567b99be5f
Coverity report: fixes an issue where the returnvalue of a function is not checked.
...
Review URL: https://webrtc-codereview.appspot.com/347013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 23:43:54 +00:00
andrew@webrtc.org
f5d8c3bc3b
Fix audioproc_unittest on Windows.
...
On Windows, files have to be closed before they can be removed.
TBR=bjornv
BUG=none
TEST=audioproc_unittest on Windows.
Review URL: https://webrtc-codereview.appspot.com/369010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1541 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 21:35:39 +00:00
ivinnichenko@webrtc.org
76fa8c956d
disable failing win tests.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/367011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1540 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 21:06:38 +00:00
ivinnichenko@webrtc.org
d22430662d
enable video_processing_unittests for Win
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/368006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1539 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 19:28:21 +00:00