Commit Graph

1767 Commits

Author SHA1 Message Date
turaj@webrtc.org
01ad75888a ilbc: Mark untouched input arrays as const
Review URL: https://webrtc-codereview.appspot.com/662004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2490 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-03 21:35:46 +00:00
stefan@webrtc.org
ddfdfed3b5 Pass capture time (wallclock) to the RTP sender to compute transmission offset
- Change how the transmission offset is calculated, to
  incorporate the time since the frame was captured.
- Break out RtpRtcpClock and move it to system_wrappers.
- Use RtpRtcpClock to set the capture time in ms in the capture module.
  We must use the same clock as in the RTP module to be able to measure
  the time from capture until transmission.
- Enables the RTP header extension for packet transmission time offsets.

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/666006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2489 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-03 13:21:22 +00:00
pwestin@webrtc.org
1853005f37 Change clock to be 64 bits in RTP module
Review URL: https://webrtc-codereview.appspot.com/678011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2488 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-03 10:41:54 +00:00
tommi@webrtc.org
7b61049117 Land: https://webrtc-codereview.appspot.com/678010/
Add -Wno-unused-private-field until all violations are fixed.

This is currently in chromium's build/common.gypi, but I'd like
to remove it from there.
Review URL: https://webrtc-codereview.appspot.com/680006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2485 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-03 08:19:24 +00:00
tommi@webrtc.org
fb933bdb26 Landing: https://webrtc-codereview.appspot.com/680005/
Fix more -Wunused-private-field violations.
Review URL: https://webrtc-codereview.appspot.com/668010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2484 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-03 08:19:12 +00:00
vikasmarwaha@webrtc.org
e85c77bd7c Bump WebRTC version to 3.8.1
Review URL: https://webrtc-codereview.appspot.com/665007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2479 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-02 18:11:06 +00:00
tommi@webrtc.org
cf21b9be87 Fix ChromeOS build by removing an unused variable.
TBR=niklase
Review URL: https://webrtc-codereview.appspot.com/669008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2477 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-02 14:29:58 +00:00
phoglund@webrtc.org
ef8ca6a801 Wrote ClusterFuzz test for WebRTC GetUserMedia.
This initial test is very simple since we are just releasing GetUserMedia in the next release.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/639006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2476 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-02 11:39:22 +00:00
vspasova@webrtc.org
b358bd8f87 A command-line tool based on libyuv to convert a set of RGBA files to a YUV video.
BUG=
TEST=
tgbra_to_i420_converter --frames_dir=<directory_to_rgba_frames> --output_file=<output_yuv_file> --width=<width_of_input_frames> --height=<height_of_input_frames>

<output_yuv_file> should be an empty file because we open it in append mode

Review URL: https://webrtc-codereview.appspot.com/673006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2475 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-07-02 07:43:30 +00:00
marpan@webrtc.org
c5b392e9d6 Updates t resolution adaptation (cama):
-set image type when QM is reset.
  -fix for undoing two stages of spatial downsampling.
  -some adjustments and code clean-up.
  -updates to control parameters and unittest.
Review URL: https://webrtc-codereview.appspot.com/641010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2473 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-29 21:44:55 +00:00
leozwang@webrtc.org
ea5b8b5903 Trival changes in gui layout based on feedback
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/674006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2472 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-29 18:31:45 +00:00
leozwang@webrtc.org
fb59442c40 Change file path to make it work on android
BUG=
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/672007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2471 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-29 18:28:12 +00:00
turaj@webrtc.org
8d59e70434 In this CL four pitch-filters are integrated into a single function. I have kept the interfaces unchanged so there was no need to modify any other file. A test is uploaded to show how this CL is tested. The test engages all the functions affected by this CL and compares their output with the version of iSAC before this change. This CL is bit-exact. Furthermore, I ran iSAC release test and diff results with previous version. The test file will not be commited, as running it requires a hack in old iSAC to. Hence you don't need to code-review it.
test = bit-exact with previous version of iSAC verified by iSAC Release test and the test written specifically to test functions affected by this CL.
Review URL: https://webrtc-codereview.appspot.com/611004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2470 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-29 18:17:53 +00:00
mflodman@webrtc.org
e06ca3cef6 Removed nolint for include guards.
BUG=
TEST=cpplint.py --filter=-build/header_guard src/video_engine

Review URL: https://webrtc-codereview.appspot.com/676008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2469 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-29 13:20:14 +00:00
mflodman@webrtc.org
ab2610ffd9 Removed the last lint warnings in video_engine.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/670006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2468 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-29 10:05:28 +00:00
henrike@webrtc.org
a5fcf7ab41 Fixes broken Chromium build.
BUG=brakes chrome build
TEST=Manually on Linux

Review URL: https://webrtc-codereview.appspot.com/679006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2462 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 12:49:35 +00:00
mflodman@webrtc.org
c802e0ed0c Changed max codec resolution.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/674008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2457 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 07:57:39 +00:00
asapersson@webrtc.org
d2e6779565 Fix for negative transmission time offset.
Review URL: https://webrtc-codereview.appspot.com/671006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2456 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 07:53:15 +00:00
stefan@webrtc.org
5f28498149 First step in refactoring audio/video synchronization. Adds unittests.
BUG=
TEST=stream_synchronization_unittest

Review URL: https://webrtc-codereview.appspot.com/669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2455 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 07:51:16 +00:00
mflodman@webrtc.org
cee447a5bb cpplint passes for vie_performance_monitor, vie_manager_base, vie_impl, vie_renderer, vie_defines and vie_render_manager.
NOLINT is used where API changes would be needed, for include guards and include files in WebRTC root.

Lots of changes, but no real logical changes.

BUG=627
TEST=vie_auto_test + compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2454 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 07:29:46 +00:00
asapersson@webrtc.org
100463e828 Added initial nack configuration for rtp module.
Review URL: https://webrtc-codereview.appspot.com/677007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2453 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 07:21:51 +00:00
mflodman@webrtc.org
1b1cd78dd2 Made cpplint pass for vie_remb, vie_ref_count, vie_sender and vie_receiver.
NOLINT is used for include guards. I took a shortcut for vie_ref_count, the class will be deleted very soon anyway.

BUG=627
TEST=cpplint and compiles

Review URL: https://webrtc-codereview.appspot.com/677008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2452 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-28 06:34:08 +00:00
andrew@webrtc.org
e22beabaf1 [MIPS] Adding support for MIPS architecture for WebRTC.
Small change to typedefs.h to enable MIPS Little Endian port.

TBR=niklas.enbom@webrtc.org
BUG=https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome

Review URL: https://webrtc-codereview.appspot.com/679005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2451 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 22:24:43 +00:00
mflodman@webrtc.org
f5e99db10b Made cpplint pass for vie_channel.* and vie_encoder.*. NOLINT is used for API changes, include guards and include files in WebRTC root.
WebRTC types and webrtc:: will be removed in a follow up.

BUG=627
TEST=vie_auto_test + compiles

Review URL: https://webrtc-codereview.appspot.com/677005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2450 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 09:49:37 +00:00
tina.legrand@webrtc.org
3ddc974039 Handle VAD/DTX in a correct way if running stereo ACM.
BUG=issue573
TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/669006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2449 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 09:25:50 +00:00
andrew@webrtc.org
4ecea3e105 Downmix before resampling in capture and render paths.
We previously had an error when a mono capture device was used with
a stereo codec. This is prevented by avoiding any remixing in
AudioProcessing. Instead, capture side downmixing is now done before
resampling. Upmixing can now be handled properly by AudioCoding,
since the AudioProcessing error condition has been removed.

On the render side, downmixing now occurs before resampling. Ideally
this would be handled still earlier in the chain. Similarly, downmixing
for the AudioProcessing reference data occurs before resampling. This
code has been refactored into RemixAndResample, with a comprehensive
unittest added in output_mixer_unittest.cc.

BUG=issue624
TEST=manually through voe_cmd_test, by using mono and stereo capture
and render devices with mono and stereo codecs. voice_engine_unittest,
voe_auto_test.

Review URL: https://webrtc-codereview.appspot.com/676004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2448 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 03:25:31 +00:00
andrew@webrtc.org
7a281a5634 Fix Android build after test/ -> src/test/
TBR=leozwang@webrtc.org
BUG=none
TEST=Android trybot

Review URL: https://webrtc-codereview.appspot.com/677006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2447 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 03:22:37 +00:00
andrew@webrtc.org
81cf5e4752 Move test to src/test.
- Refer to top-level directories by <(DEPTH), e.g. <(DEPTH)/testing.
- Remove now unneeded third_party_root.

TBR=henrike@webrtc.org
BUG=none
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/669007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2446 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 01:41:54 +00:00
leozwang@webrtc.org
253912c188 Disable a few features to save CPU cycles on android
BUG=
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/677004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2445 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-26 17:08:41 +00:00
marpan@webrtc.org
5567ebfd1f VPM: Assign correct required size for odd size destination frame.
Updates to spatial resampler unittest.
Review URL: https://webrtc-codereview.appspot.com/660006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2444 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-26 16:47:36 +00:00
astor@webrtc.org
bd7aeba8fb Expose a set of options to the OveruseDetector supporting experiments
Updated overuse_detector.* to use google style naming convention
Removed OveruseDetector::Reset
Review URL: https://webrtc-codereview.appspot.com/666005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2443 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-26 10:47:04 +00:00
hta@webrtc.org
f494fd0954 Use system-independent sleep in video_capture_unittest.
Another ifdef bites the dust!

BUG=603
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/674004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2441 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-25 11:33:34 +00:00
hta@webrtc.org
626dccc85b Use one OS-independent sleep function in a video test
Sleep using no compile flags

BUG=603
TEST=

Review URL: https://webrtc-codereview.appspot.com/668004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2440 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-25 11:30:33 +00:00
henrike@webrtc.org
643be71700 Adds variable for third party directory.
BUG=348
TEST=Manual testing in Chrome and WebRTC workspace.

Review URL: https://webrtc-codereview.appspot.com/674005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2439 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-25 10:48:58 +00:00
tnakamura@webrtc.org
b9c1833c2c Add channel info to the Actions->Codec Changes menu in the VoE test app.
Review URL: https://webrtc-codereview.appspot.com/665005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2438 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-22 16:29:38 +00:00
braveyao@webrtc.org
77e18124f9 Fix the flakiness in FileBeforeStreamingTest
BUG = 619
TEST = voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/658006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2437 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-22 10:41:11 +00:00
mflodman@webrtc.org
64f86fba19 Fix test app render bug.
Review URL: https://webrtc-codereview.appspot.com/669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2435 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-21 12:32:39 +00:00
mflodman@webrtc.org
8baed51f6e This CL is part of enabling cpplint check for video_engine uploads.
BUG=627
TEST=vie_auto_test

Review URL: https://webrtc-codereview.appspot.com/653006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2434 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-21 12:11:50 +00:00
mflodman@webrtc.org
9ba151bdf9 Removed cpplint warnings from all impl-files to be able to add this check as presubmit step. I don't want to change the API right now, will come later, so there are several NOLINT comments added to get around this for now.
BUG=627
TESTS=vie_auto_test

Review URL: https://webrtc-codereview.appspot.com/661005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2433 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-21 10:02:13 +00:00
hta@webrtc.org
2bd8d62d3b Sleep using no compile flags
BUG=603
TEST=

Review URL: https://webrtc-codereview.appspot.com/665004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2432 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-21 09:57:24 +00:00
mflodman@webrtc.org
67f98ec63a Removed flaky REMB test. This test is now covered by:
- RemoteBitrateEstimatorTest
- BitrateControllerTest
- RtcpFormatRembTest
- ViERembTest

BUG=477
TEST=See above.

Review URL: https://webrtc-codereview.appspot.com/667004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2431 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-21 09:29:53 +00:00
kma@webrtc.org
173538faa3 Refactored function WebRtcIsacfix_GetLpcCoef() in iSAC-fix.
One reason behind it is for further optimization of it in ARM.
Review URL: https://webrtc-codereview.appspot.com/646012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2429 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-20 17:17:15 +00:00
hta@webrtc.org
3168e5349c Working unit test for critical sections.
This extends unittest coverage, and allows to add more tests if these functions
ever are found to behave strangely.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/632005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2427 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-20 06:45:56 +00:00
kjellander@webrtc.org
5608fe9861 Disabling FileBeforeStreamingTest due to flakiness.
BUG=619
TBR=xians1
TEST=Tested on Linux, Mac and Windows.

Review URL: https://webrtc-codereview.appspot.com/654006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2426 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-20 06:14:31 +00:00
wu@webrtc.org
2259f855ea Remove unused member variables found by clang's -Wunused-private-field.
No intended behavior change.

On behavior of thakis@chromium.org.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/641011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2425 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-19 14:56:50 +00:00
hta@webrtc.org
72e3a89b52 Created a wrapper class for condition_variable that lets me write (hopefully) reliable tests for some of its properties.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/600005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2424 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-19 13:49:48 +00:00
bjornv@webrtc.org
b38fca1ec2 VAD Refactoring: API change of return value from int16_t to int.
This CL change the return int on Process() to meet Google Style. The change affects audio_coding and neteq.

Tests have been changed accordingly and the code has been tested on trybots, vad_unittests, audioproc_unittest, audio_coding_unittests, audio_coding_module_test and neteq_unittests.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/663005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2423 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-19 11:03:32 +00:00
vspasova@webrtc.org
f477aac844 Removed gflags header from vie_auto_test.
Removed gflags include file from src/video_engine/test/automated/
vie_video_verification.cc as it is no longer needed.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/645005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2422 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-19 09:20:33 +00:00
braveyao@webrtc.org
dfa6b697e2 Refine the error handling made in rev2373
Review URL: https://webrtc-codereview.appspot.com/644005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2421 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-19 06:38:59 +00:00
wu@webrtc.org
67f256fab4 Use 32 as the alignment if possible in VP8 wrapper.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/663004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2420 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 21:15:32 +00:00
bjornv@webrtc.org
df596ae444 VAD Refactoring of GMM test section
The CL is organized w.r.t. patch sets as follows:
1) Comments on functionality added.
2) Renamed local variable n to channel for clarity.
3) Dropped the extension _vector of variable |feature_vector| since it doesn't add anything new.
4) Minor comment update w.r.t. |feature|
5) Replaced an else if scheme with two if statements. This way we can use the same calculation for all sub cases which could be a source of error.
6) Moved two code lines to where they are used and rearranged such that avoiding tmp variable.
7) Instead of performing a bit-wise OR operation within an if statement we could perform the bit-wise OR at once.
8) Name change of |shifts0| to |shifts_h0| for clearer reading. Likewise for H1.
9) Renamed |nr| to |gaussian| for clearer reading.
10) Removed multiplication macro.
11) Re-organized local arrays to have the same structure as constants and member arrays used elsewhere in the code.
12) Changed locally declared variable to function declared.
13) Added array initialization at declaration.

Tested with trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/595006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2417 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 18:22:53 +00:00
tina.legrand@webrtc.org
50d5ca5bf2 Refactoring of TestAllCodecs
ACM testing consists of seven individual tests. Up til now we haven't used gtest everywhere, and many of the tests needs some rewriting to follow the style guide.

I've started with this tests, doing formatting, adding the test as a separate test which can now either succeed of fail in a proper way.

Still to do in this test is handling of input file, but that will be changed in a separate CL, because all tests uses the  PCMFile class that will be affected by the change.

BUG=none
TEST=audio_coding_module_test, ACM_AUTO_TEST and ACM_TEST_ALL_CODECS.

Review URL: https://webrtc-codereview.appspot.com/646011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2416 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 13:35:52 +00:00
hta@webrtc.org
db2f6cf878 Added missing define guard to sleep.h
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/656006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2415 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 13:23:48 +00:00
hta@webrtc.org
86a6aacaee Unittest utilities - starting out with an encapsulated trace-to-screen.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/655005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2414 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 13:22:08 +00:00
mflodman@webrtc.org
e3a0712f04 Deregister RTP module before deleting it.
BUG=617
TEST=

Review URL: https://webrtc-codereview.appspot.com/661004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2413 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 12:43:41 +00:00
hta@webrtc.org
41adcdbf13 An OS-independent sleep function, and one usage thereof.
BUG=603
TEST=none

Review URL: https://webrtc-codereview.appspot.com/659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2412 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 11:24:57 +00:00
henrika@webrtc.org
37198007ea GetRecPayloadType now logs a warning instead of and error when the user asks for the payload type while no packets have been received.
BUG=605
TEST=

Review URL: https://webrtc-codereview.appspot.com/660004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2411 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 11:00:12 +00:00
stefan@webrtc.org
190541578a Correct gypi files to match the actual filenames.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/656005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2410 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 10:57:05 +00:00
niklas.enbom@webrtc.org
d63d06a289 bump version to 3.8
Review URL: https://webrtc-codereview.appspot.com/657004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2408 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-18 08:36:36 +00:00
braveyao@webrtc.org
4de777ba2b Refine the error processing of StopRecordingMicrophone.
BUG = 
TEST = 
Review URL: https://webrtc-codereview.appspot.com/636007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2406 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-15 02:37:53 +00:00
turaj@webrtc.org
bdf7ee5bab This simple change should adress issue 471.
Previously I uploaded patch 640007 to address issue 471. Today, while discussing that patch with Andrew, we noticed this patch should do the job. Leo is not here to verify it, but Andrew did some test to verify it. I'll ask Leo to do some testing. 

We don't want to abandon patch 640007 as it will save some complexity. 
Review URL: https://webrtc-codereview.appspot.com/648004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-14 23:46:35 +00:00
marpan@webrtc.org
352d09ab28 Updates to videoprocessor_integration test:
-added metric for expected key frame size mismatch
   -fix to start bitrate
   -updates to some expected values in tests
Review URL: https://webrtc-codereview.appspot.com/641007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2404 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-14 18:35:00 +00:00
marpan@webrtc.org
f088448c37 Libyuv Scalerunittest: Added PSNR check to some tests in scaler unittest:
-for downsampling to 1/2x1/2
    -for the odd frame sizes cases
Review URL: https://webrtc-codereview.appspot.com/642009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2403 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-14 17:00:45 +00:00
mflodman@webrtc.org
139c4678c1 Fixed a/v sync issue.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2402 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-14 11:08:51 +00:00
leozwang@webrtc.org
46d83fa26c Use digital mode on mobile
Use fixed digital mode in test app on android

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/636010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2401 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-12 23:47:20 +00:00
marpan@webrtc.org
c35f1d26c5 FEC: Fix to coverity issue 14448: unintended sign extension.
Review URL: https://webrtc-codereview.appspot.com/647004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2400 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-12 20:12:13 +00:00
mflodman@webrtc.org
d41851480c Bumped version number to 3.7.
Review URL: https://webrtc-codereview.appspot.com/642007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2397 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-12 08:31:36 +00:00
bjornv@webrtc.org
b1c3276f5a VAD Refactoring: WebRtcVad_Process()
Code style: Indentation, braces

Tested with trybot, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/579012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2396 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-12 08:19:24 +00:00
tina.legrand@webrtc.org
5e7ca608d5 Use new fileutil functions for trace in ACM
I this CL I have changed to use filutil functions in the ACM tests. I have also reformated the file Tester.cc, and fixe one minor bug in TestAllCodecs.cc.

BUG=issue195
TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/636006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2394 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-12 07:16:24 +00:00
leozwang@webrtc.org
6724c4239b Add VoiceEngine apm settings to test application
Implement apm settings and add a small bug fix

BUG=
TEST=build and test on android
Review URL: https://webrtc-codereview.appspot.com/632008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2390 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-11 21:23:16 +00:00
andrew@webrtc.org
be581640c1 Add a variable for the libjpeg include directory.
- Also clean up the use of libjpeg_gyp_path. Both the Chromium and
  standalone builds can use it.

BUG=none
TEST=build with all combinations of use_libjpeg_turbo and build_libjpeg

Review URL: https://webrtc-codereview.appspot.com/640004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2389 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-11 20:38:48 +00:00
bjornv@webrtc.org
eec739f846 VAD Refactoring: Changed pointer structure in WebRtcVad_FindMinimum().
For easier code reading, a couple of structural changes together with name changes have been performed in the function WebRtcVad_FindMinimum():
- Removed temporary pointers
- Updated comments
- Pointer name changes
- Changed pointer nomenclature to array index
- Made local variable const

Tested with trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/594005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2386 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-11 07:57:57 +00:00
tina.legrand@webrtc.org
fa7138f889 Change CriticalSectionScoped to use pointer constructor
BUG=issue183
TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/638005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2384 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-08 10:51:28 +00:00
leozwang@webrtc.org
276dc1872a Add libremote_bitrate_estimator to android makefile
The order of libraries is bit messy, will clean up later.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/646007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2383 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-07 18:58:12 +00:00
kma@webrtc.org
f85b35a2f4 Refactored Neon code for AECM module, by using pure assembly code.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/447008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2382 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-07 16:17:17 +00:00
stefan@webrtc.org
d81ab1397b abs() was used instead of fabsf(), which returns int and not float and therefore truncated the return value.
Also fixes problems with the remote_bitrate_estimator_unittest.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/641006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2380 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-07 13:48:04 +00:00
tina.legrand@webrtc.org
90af7f841c Changing Celt to run on 20 msec frames
BUG=none
TEST=-

Review URL: https://webrtc-codereview.appspot.com/641004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2377 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-07 08:57:27 +00:00
stefan@webrtc.org
9354cc965c Refactoring the receive-side bandwidth estimation into its own module.
Each REMB group has one remote_bitrate_estimator object. For now the
estimator keeps one estimate for every SSRC. In a later commit this will
be unified and one estimate will be used for all SSRC in one group.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/637009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2375 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-07 08:10:14 +00:00
braveyao@webrtc.org
b0bcf13dd4 Trival fix to relative paths of audio files in voe_ui_win_test
BUG  = 
TEST = voe_ui_win_test
Review URL: https://webrtc-codereview.appspot.com/635005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2373 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-07 02:21:44 +00:00
marpan@webrtc.org
5f97232cac Removing a TODO in the FEC: renaming the exisiting packets mask to indicate random mode,
and refactored and renamed corresponding table file.
Review URL: https://webrtc-codereview.appspot.com/632007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2372 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-06 22:34:38 +00:00
wu@webrtc.org
cac603f390 Fix for the alignment problems/mismatch in ViECapture and VP8Encoder.
BUG=576
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/637010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2371 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 23:52:59 +00:00
marpan@webrtc.org
f4c2de9e2f Added some tests to videoprocessor_integrationtest, for testing:
-encooder response to changing bit rate and frame rate
   -frame dropper and spatial resize
   -temporal layers
Review URL: https://webrtc-codereview.appspot.com/613006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2370 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 21:07:28 +00:00
marpan@webrtc.org
8866bb1132 FEC: Added another set of packet masks for the FEC.
These FEC codes perform better for bursty (consecutive loss) 
than the existing set (which were designed for random loss). 
Updates to the unittests and test_fec accordingly.
Review URL: https://webrtc-codereview.appspot.com/581005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2369 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 16:42:20 +00:00
bjornv@webrtc.org
20e13edede New attempt to revert r2362, since drover failed.
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/640005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2368 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 13:07:56 +00:00
bjornv@webrtc.org
cb89c6f914 Revert 2363 - Refactoring the receive-side bandwidth estimation into its own module.
Each REMB group has one remote_bitrate_estimator object. For now the
estimator keeps one estimate for every SSRC. In a later commit this will
be unified and one estimate will be used for all SSRC in one group.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/605007

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/634006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2366 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 12:25:35 +00:00
stefan@webrtc.org
f72881406f Refactoring the receive-side bandwidth estimation into its own module.
Each REMB group has one remote_bitrate_estimator object. For now the
estimator keeps one estimate for every SSRC. In a later commit this will
be unified and one estimate will be used for all SSRC in one group.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/605007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2363 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 10:44:00 +00:00
bjornv@webrtc.org
d2acea6b30 Minor style changes
Original CL=577007

Tested on trybots.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/637007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2362 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-05 08:09:23 +00:00
marpan@webrtc.org
da7fdf4af8 Fix to scaler in libyuv for odd size frames.
Review URL: https://webrtc-codereview.appspot.com/633004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2360 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 21:56:13 +00:00
turaj@webrtc.org
ba108aee21 This CL contains some refactoring. Spectrum coding is main place that is affected. Therefore, I have bit-exactness test, test_spectrum_
coding.c, to be sure about the changelist. You can go through the test to be sure the changes are tested. However, I don't intend to commi
t the test, as it would be a source of confusion and requires hack to iSAC to be able to run the test. It is basically a one-time test. 

The part which not covered in this test is where we limit payload for super-wideband bit-stream. I'll add a test for that as well. 

I kept format changes at minimum in all files except isac.c, which was in bad shape, and coding changes were minimum. I'm planning to uplo
ad following patches to this CL where I try to address formatting issues. But I don't intend to change variable names, for the moment. 

The refactoring is not yet finished, so you would find part of the code which could be cleaned up, especially KLT transforms in entropy_co
ding.c
Review URL: https://webrtc-codereview.appspot.com/580004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2359 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 20:04:58 +00:00
andrew@webrtc.org
2cc55096d5 Fix syntax error in jpeg.gypi.
TBR=mflodman@webrtc.org
BUG=none
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2358 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 20:01:23 +00:00
mflodman@webrtc.org
ad6083f414 Added condition for which jpeg lib to use.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/638004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2357 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 19:10:43 +00:00
tina.legrand@webrtc.org
77fd39aa99 ACM PCM16B, fixing a copy-and-paste error.
Review URL: https://webrtc-codereview.appspot.com/631006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2355 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 11:47:49 +00:00
phoglund@webrtc.org
e6f235cfa5 Attempt to fix broken encoding.
TBR=niklase@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/637004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2353 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 11:04:05 +00:00
niklas.enbom@webrtc.org
9cf4d72d5d git-svn-id: http://webrtc.googlecode.com/svn/trunk@2352 4adac7df-926f-26a2-2b94-8c16560cd09d 2012-06-04 10:58:43 +00:00
niklas.enbom@webrtc.org
82bf033380 git-svn-id: http://webrtc.googlecode.com/svn/trunk@2351 4adac7df-926f-26a2-2b94-8c16560cd09d 2012-06-04 10:57:51 +00:00
niklas.enbom@webrtc.org
265e38c336 Fixing test gypi for bit rate controller
Review URL: https://webrtc-codereview.appspot.com/636004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2350 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 10:12:44 +00:00
braveyao@webrtc.org
ab12990b1b In the past we support calling StartPlayingFileLocally() before StartPlayout(), then when playout is started, the file would be played out immediately.
Now we would get a failure if we do the same thing and the file would not be played out. Then GTalk/Hangout also reported this failure to us. 
This CL is to restore the original function. 

BUG = Issue 490
TEST = Manual test and voe_auto_test->FileBeforeStreamingTest
Review URL: https://webrtc-codereview.appspot.com/569016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2347 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-04 03:26:39 +00:00
marpan@webrtc.org
899baa821b Temporarily disable first partition packet counting to avoid a bug in ProducerFec which doesn't properly handle important packets.
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/631005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2346 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-01 18:32:16 +00:00
leozwang@webrtc.org
354b0ed015 Check return result of fwrite [Audio Module]
Description:
On ChromeOS/ARM, compiler enforces to check return result of a function.
Currently, we don't check return result of fwrite, it causes building errors.

The following files need to patch. The patch should be similar, before I patch all
of them, I will start with 2 files, please take a quick look, if the patch is OK,
I will continue and upload a new patch that covers all of them.
it to all of them.
Review URL: https://webrtc-codereview.appspot.com/566016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2345 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-01 17:46:21 +00:00
kma@webrtc.org
c3b2683bf4 Refactored the pitch filter function in iSAC-fix. One important purpose is to prepare the function for assembly optimization in ARM platforms.
Note that,
(1) The main change is a new function PitchFilter() replacing a couple of common code blocks. Next step will be the assembly coding of this function in ARM.
(2) Resulted code is not bit exact with the original. The only reason is replacing two saturation blocks (lines 197 and 208) for the case of "type == 2" with the general case (line 147 and 159). The change makes the code more consistent, and I think the original code might just be a bug. I raised the issue in an email to Turaj and Bjorn last week.
Listening test might be needed. I will send the resulted files to Turaj for this purpose.
(3) I used Astyle to make the code more stylish, but didn't try extra effort to correct all the code style details.  Local code style consistency was considered for new code. So this is not a full and final refactor project (will leave that to future refactoring).
Review URL: https://webrtc-codereview.appspot.com/573009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2344 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-01 17:00:07 +00:00