generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
4,362 Commits 1 Branch 0 Tags 108 MiB
1871dd2fb7
Commit Graph

4362 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
tina.legrand@webrtc.org
a03e34e9ab Heap-use-after-free in WebRtcNetEQ_RecInRTPStruct 
Pointer to released memory was not set to NULL, which means
you could get a heap-us-after-free in the code. It happens if one of the slaves of NetEq is deleted, but we keep trying to decode packets.

BUG=
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4792 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 13:32:14 +00:00
andresp@webrtc.org
ab6549562b Refactor frame generation code so it can be used by multiple modules. 
R=pbos@webrtc.org, stefan@webrtc.org, pbos, stefan
BUG=

Review URL: https://webrtc-codereview.appspot.com/2240004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4791 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 12:14:03 +00:00
stefan@webrtc.org
7a30dfdc69 Disable NACK bandwidth statistics test due to being too flaky. 
Tests for new API currently provide partial coverage, and will soon
provide full coverage.

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2151005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4789 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 12:08:55 +00:00
stefan@webrtc.org
b5a191bfe7 Fixes a flake in network down tests. 
And reduces the flakiness in NACK tests.

TESTS=trybots
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2258004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4788 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 11:14:35 +00:00
kjellander@webrtc.org
d8a9b86671 Disable tests for TSan v2 
These are tests that fail and that I haven't been able to suppress.
I assume they're caused by the same bug in TSan v2 as described in
webrtc:2259.

BUG=2259,2334
TEST=Ran the tests similar to the instructions in the bugs, passed 100 iterations.
R=andrew@webrtc.org, hta@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2250004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4787 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 07:15:36 +00:00
wu@webrtc.org
967bfff54d Update talk to 52534915. 
R=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2251004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4786 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 05:49:50 +00:00
turaj@webrtc.org
532f3dc548 Compile ACM2 and ACM1. 
First patch set is the same as patch set 3 of http://review.webrtc.org/2237004/

-Make ACM1 to depend on ACM2.
-Remove APIs to set and get background noise mode. There is no VoE call to these
APIs.
-Remove APIs to set and get receive side VAD mode. There is no VoE call to these
APIs, and NetEq 4, doesn't support them.
-Remove callback for in-band DTMF detection. ACM doesn't support in-band DTMF
detection.
-Use acm_common_defs.h everywhere required.
-Complete ACM factory method.
-Update ACMCodecDatabase of ACM2. CNG full-band need to be define-guarded.
Remove dynamic payload-type assignment.

BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4785 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-19 00:12:23 +00:00
andrew@webrtc.org
f3930e941c Small refactoring of AudioProcessing use in channel.cc. 
- Apply consistent naming.
- Use a scoped_ptr for rx_audioproc_.
- Remove now unnecessary AudioProcessing::Destroy().

R=bjornv@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2184007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4784 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 22:37:32 +00:00
henrik.lundin@webrtc.org
0d5da25e6c NetEq4: Making a few more members scoped_ptrs 
This CL converts a few members in NetEqImpl form regular pointers
to scoped_ptrs.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2245004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4783 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 21:12:38 +00:00
henrik.lundin@webrtc.org
5a43370cdb Dedicated speed test for NetEq3 
This is the same test as was aleready implemented for NetEq3 in r4763.

BUG=1363
R=minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2234004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4782 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 20:58:33 +00:00
kjellander@webrtc.org
7a968a8f07 Add more TSan and Dr Memory suppressions for modules_unittests 
I'm trying to get these tests green on Windows in
http://build.chromium.org/p/client.webrtc.fyi

BUG=2319,2323
TEST=local runs passing
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2230004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4781 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 19:18:20 +00:00
wu@webrtc.org
8d1e4d6149 Increase the dtmfsender test toleration to 100ms to avoid flaky. 
BUG=2391
R=marpan@google.com

Review URL: https://webrtc-codereview.appspot.com/2248004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4780 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 18:01:07 +00:00
andrew@webrtc.org
8bf755d5c5 MIPS optimizations for the functions WebRtcSpl_SqrtFloor, WebRtcSpl_CrossCorrelation, WebRtcSpl_ScaleAndAddVectorsWithRound and the inline functions from signal_processing spl_inl.h file. 
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1791004

Patch from Ljubomir Papuga <lpapuga@mips.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4779 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 17:40:46 +00:00
stefan@webrtc.org
5f1051631a Fix disabling of tests. 
BUG=2378
R=pbos@webrtc.org
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2244005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4778 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 15:28:10 +00:00
stefan@webrtc.org
1c77dfd521 Revert r4772 "Compile ACM1 and ACM2." 
Breaks Android build.

TBR=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2244004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4777 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 12:34:05 +00:00
henrik.lundin@webrtc.org
40d3fc65f5 NetEq4: Make some DSP operation classes member variables 
This CL reduces the memory allocations by making the instances of
Accelerate, PreemptiveExpand, Normal and Merge member variables in
NetEqImpl.

This change reduced the allocation count by 20,000 in the bit-exactness
test.

BUG=Issue 1363
TEST=out/Debug/modules_unittests
--gtest_filter=NetEqDecodingTest.TestBitExactness

R=andrew@webrtc.org, minyue@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2158004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4776 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 12:19:50 +00:00
stefan@webrtc.org
8db81c5112 Fix races in vcm::Process(). 
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2241004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4775 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 11:57:34 +00:00
pbos@webrtc.org
e75a1bf45f Break out glue for old->new Transport. 
Reduces multiple inheritance and code duplication.

BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4774 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 11:52:42 +00:00
sjlee@webrtc.org
fe84fda488 Changing 'frame' method to 'bounds' method. 
BUG=2369
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2223004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4773 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 01:37:31 +00:00
turaj@webrtc.org
367baa6eb3 Compile ACM1 and ACM2. 
-Make ACM1 to depend on ACM2.
-Remove APIs to set and get background noise mode. There is no VoE call to these APIs.
-Remove APIs to set and get receive side VAD mode. There is no VoE call to these APIs, and NetEq 4, doesn't support them.
-Remove callback for in-band DTMF detection. ACM doesn't support in-band DTMF detection.
-Use acm_common_defs.h everywhere required.
-Complete ACM factory method.
-Update ACMCodecDatabase of ACM2. CNG full-band need to be define-guarded. Remove dynamic payload-type assignment.

BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2237004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4772 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-18 00:36:11 +00:00
henrike@webrtc.org
c8dea6a00f Use the native sample rate for OpenSL recording. 
BUG=N/A
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2219005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4771 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 18:44:51 +00:00
jiayl@webrtc.org
bf00740c92 Adds a new voice engine warning for the typing noise off state. 
The old VE_TYPING_NOISE_WARNING is unchanged and fired whenever typing noise is detected.
The new VE_TYPING_NOISE_OFF_WARNING is fired when typing noise was detected and is gone now.
This is necessary for converting the typing state to a PeerConnection stats.

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2209004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4770 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 18:09:20 +00:00
stefan@webrtc.org
da79008ab4 Disabling crashing or flaky tests in peerconnection_unittest. 
R=kjellander@webrtc.org
TBR=wu@webrtc.org
TESTS=trybots
BUG=2378

Review URL: https://webrtc-codereview.appspot.com/2227004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4767 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 13:11:38 +00:00
pbos@webrtc.org
32d640e03d Fix typo in r4765. 
Fixes compile error on all platforms.

BUG=
TEST=compile on tryboys
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2231004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4766 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 10:36:30 +00:00
pbos@webrtc.org
da2c4cede0 Fix dangling pointer _encoder in video_sender.cc. 
When _codecDataBase.SetSendCodec() fails, the encoder may be deleted.
This is however not reflected in _encoder, which then becomes a dangling
pointer to the deleted object.

BUG=2384
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4765 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 09:38:41 +00:00
pbos@webrtc.org
be63fd644f Initialize CodecInst structs in test_api_audio.cc. 
Fixes errors detected by DrMemory on Windows.

BUG=2382
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2228004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4764 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 09:33:17 +00:00
henrik.lundin@webrtc.org
d1fc5d4e17 Dedicated speed test for NetEq4 
This CL implements a new speed test application for NetEq4.
The application runs a minimum of overhead in order to
highlight the performance of NetEq itself.

BUG=1363
R=minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2177006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4763 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 08:38:02 +00:00
stefan@webrtc.org
28a331eede Add support for multiple report blocks. 
Use a weighted average of fraction loss for bandwidth estimation.

TEST=trybots and vie_auto_test --automated
BUG=1811
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2198004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4762 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 07:49:56 +00:00
sjlee@webrtc.org
fc10c5c97f This is related to https://code.google.com/p/webrtc/issues/detail?id=1341 
BUG=1341
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2225004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4761 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 05:15:37 +00:00
sjlee@webrtc.org
e6ac163145 This is related to https://code.google.com/p/webrtc/issues/detail?id=846 
BUG=846
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2224004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4760 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 05:15:19 +00:00
sjlee@webrtc.org
c3e51acb30 To use the channel_transport on the iOS platform, some #if directives are changed. 
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2178005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4759 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 05:14:32 +00:00
andrew@webrtc.org
15e979b571 Call AllowCommandLineReparsing in unit tests. 
Allows us to ignore flags passed on to us by Chromium build bots
without having to explicitly disable them. (Thanks pbos!)

TESTED=Running modules_unittests with a bogus flag did not result in an
error.
TBR=kjellander

Review URL: https://webrtc-codereview.appspot.com/2222005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4757 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 00:54:09 +00:00
mallinath@webrtc.org
b3af8aea3e Verify local and remote transport description before 
negotiation.

TBR=sergeyu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2221004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4756 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-17 00:11:05 +00:00
kjellander@webrtc.org
f6ae62ffa3 Add Win TSan exclude and Dr Memory suppressions 
To green up the FYI builders.

BUG=2323,2382
TEST=passing local run.
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/2218005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4755 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 21:16:48 +00:00
kjellander@webrtc.org
eddbfb8cf8 Add more Dr Memory suppressions for common_audio_unittests 
BUG=2321
TEST=passing local run.
TBR=andrew

Review URL: https://webrtc-codereview.appspot.com/2220004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4754 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 20:53:20 +00:00
andresp@webrtc.org
e401c2e391 Split video coding module unit tests into sender and receiver unit tests. 
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2199005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4753 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 20:29:13 +00:00
stefan@webrtc.org
ab800f64bc Disable flaky libjingle tests under tsan and memcheck. 
BUG=2380, 2379
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2218004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4752 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 15:22:32 +00:00
pbos@webrtc.org
5860de02aa Implement NACK over RTX for VideoSendStream. 
BUG=2231
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2197008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4751 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 13:01:47 +00:00
andresp@webrtc.org
8fa436bd65 Remove use of vcm->ResetDecoder from modules/utility. 
R=asapersson@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2203006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4750 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 11:26:35 +00:00
phoglund@webrtc.org
62b816afcf Fixed pylint warnings. 
Passing variables into the page template with vars() is how it's regularly done AFAIK, so I'll just disable the warnings.

BUG=2371
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2206005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4749 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-16 11:26:12 +00:00
andrew@webrtc.org
15b8871e4a Allocate float_buffer_ in the initializer list. 
This may fix a Dr. Memory error: "allocated with operator new, freed
with operator delete[]". I suspect this is a false positive; in the
existing implementation the reset causes a delete[] on NULL. This is
a no-op of course, but Dr. Memory might be flagging it. We shall see.

In any case, this change is an improvement.

BUG=2321
TBR=bjornv

Review URL: https://webrtc-codereview.appspot.com/2215004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4748 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-14 01:57:55 +00:00
sergeyu@chromium.org
8a1448950c Disable WebRtcSessionTest.TestCreateOfferWithSctpEnabledWithoutStreams 
BUG=2374
TBR=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2214004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4747 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-14 00:30:51 +00:00
andresp@webrtc.org
f7eb75be1a Split VideoCodingModuleImpl into VideoSender and VideoReceiver. 
Only implmentation is changed the interface to the module is unchanged for now.

R=mikhal@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2200008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4746 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-14 00:25:28 +00:00
sergeyu@chromium.org
a59696b2a5 Update libjingle to 52300956 
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2213004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4744 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 23:48:58 +00:00
turaj@webrtc.org
48af652ea5 Prepare to compile ACM1 and ACM2. 
ACM1 code is wrapped in namespace acm1. Inculde paths and define guards of ACM2 source codes are corrected. gypi file of ACM2 is changed so that ACM1 will later on depends on ACM2.

BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2206004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4743 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 23:06:59 +00:00
wu@webrtc.org
bc189fb3b9 * Prefer to send ISAC on clank. 
* Add url option asc and arc to allow setting preferred audio send/receive codec.

TESTED=mobile as caller and callee:
pc-n7: pc sends opus, n7 sends isac 
pc-n4: pc sends opus, n4 sends isac
pc-pc opus-opus

R=braveyao@webrtc.org, juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/2196006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4742 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 20:11:47 +00:00
sergeyu@chromium.org
6ab45b9dab Implement DesktopRegion subtraction. 
Region subtraction is used in chromoting client, so it's needed to
replace SkRegion.

R=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2205004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4741 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 19:53:16 +00:00
andresp@webrtc.org
1f09dbe353 Moving test-only code (stream_generator) out of vcm implemention. 
R=niklas.enbom@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2207004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4740 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 19:17:54 +00:00
andrew@webrtc.org
2553450959 Fix win trybot errors due to r4729. 
The addition of logging.h in r4729 was causing the win trybot to fail
with "#pragma deprecated" errors in standard library headers. This
turned out to be due to including strsafe.h (via audio_device_config.h)
before sstream (via logging.h).

strsafe.h was only being included for the unused DEBUG_PRINT macro. I
removed all references to it.

This incidentally removes a bunch of other unneeded headers discovered
while trying to track the problem down.

This didn't show up in the commitbots; my guess is that the trybots are
using the VC10 toolchain and the commitbots the VC11 toolchain.

TBR=pbos

Review URL: https://webrtc-codereview.appspot.com/2204004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4738 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 00:02:13 +00:00
sergeyu@chromium.org
6a5cc9d899 Fix crash in the window capturer on windows 
BUG=crbug.com/289753
R=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2203005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4737 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-12 19:17:26 +00:00