Commit Graph

233 Commits

Author SHA1 Message Date
stefan@webrtc.org
167328eab6 Disable libvpx partitions code for libvpx versions prior Cayuga.
Necessary for WebRTC to build with Chromium. 
Also fixes the decoder wrapper's Reset() function so that properly
reinitializes the decoder.
Review URL: http://webrtc-codereview.appspot.com/132012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@562 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:05:48 +00:00
stefan@webrtc.org
9e812fca9f Adding missing parts related to VP8 partitions
Review URL: http://webrtc-codereview.appspot.com/131017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@561 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 10:11:24 +00:00
stefan@webrtc.org
42ab82bf2f Disable independent partitions by default.
Review URL: http://webrtc-codereview.appspot.com/140006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@559 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 06:55:29 +00:00
stefan@webrtc.org
c3d891059e Adds support for VP8 partitions
This change adds support for VP8 partitions in the video jitter buffer and 
the VP8 encoder and decoder wrappers. The feature is currently disabled by
default since it requires a later version of libvpx.

With this change the jitter buffer will also start keeping track of each
packet header until decoding, and the VCMSessionInfo and VCMPacket objects 
will keep pointers into the encoded frame buffers.
Review URL: http://webrtc-codereview.appspot.com/137021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@558 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 06:50:28 +00:00
henrik.lundin@webrtc.org
dd07d5932a Let VP8 decoder handle NULL codecSpecificInfo
VP8Decoder::Decode() can now handle the case when
codecSpecificInfo is NULL. Previously, it would crash.

Review URL: http://webrtc-codereview.appspot.com/135015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@554 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:21:38 +00:00
henrik.lundin@webrtc.org
ea05973e68 Fixing VCM tests for VP8
Removing asserts since the PictureID (and other parameters)
is now piped through codecSpecific. Also made sure the VCM
send callbacks (test code) copies the appropriate paramters.
Finally, enabling I420 in tests.

Review URL: http://webrtc-codereview.appspot.com/137022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@553 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:20:17 +00:00
henrika@google.com
73d65513f1 Adds reference counting to the ADM.
This CL modifies the ADM interface to ensure that an external ADM
can't call Create and Destroy any longer.

It also contains some minor style nits to conform better with
the Chromium style guide.
Review URL: http://webrtc-codereview.appspot.com/133014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@552 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:11:18 +00:00
andrew@webrtc.org
b44172dab9 Fix "braces recommended" warning in audio_conference_mixer.
Review URL: http://webrtc-codereview.appspot.com/131014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@539 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 18:04:32 +00:00
perkj@google.com
ac75cab618 Fix reference counting assert.
Change assert("teo") to assert(!"teo") so that the assert is actually triggered.
Review URL: http://webrtc-codereview.appspot.com/133018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@533 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 13:58:34 +00:00
stefan@webrtc.org
269f8a14c6 Undoing change committed in r514 since it broke bandwidth estimation
Review URL: http://webrtc-codereview.appspot.com/132011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@531 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 09:51:59 +00:00
perkj@google.com
ea72c34fb9 Temporary add dummy implementation to RefCountModule. The reason is so that ADM and VideoCapture implementations can change to refcounted versions before forcing them.
Review URL: http://webrtc-codereview.appspot.com/139014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@527 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 11:11:04 +00:00
henrik.lundin@webrtc.org
1e53166569 Fix VP8 tests
These are changes that make the VP8 tests work again after the
wrapper was updated. The codec specific info is now propagated
properly through the encoder callback and into the queue struct.

Also added an fclose to get rid of a valgrind warning.
Review URL: http://webrtc-codereview.appspot.com/138011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@526 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 07:23:33 +00:00
zakkhoyt@google.com
fb298d3783 Modified path on speex lib
Review URL: http://webrtc-codereview.appspot.com/137018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@524 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:06:49 +00:00
andrew@webrtc.org
413b993166 Put some table size information in one place.
Motivated by fixing an unused variable warning in release mode.
Review URL: http://webrtc-codereview.appspot.com/132007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@523 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:03:56 +00:00
turajs@google.com
d7a41774ce header included twice.
Review URL: http://webrtc-codereview.appspot.com/139013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@522 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 20:52:47 +00:00
henrik.lundin@webrtc.org
2641fd1d19 Remove warnings in vp8_test
Most modifications are either reordering of the initializers in constructors, removed unused variables, or comparison mismatches taken care of. A few other special cases are commented.
Review URL: http://webrtc-codereview.appspot.com/132008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@518 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:09:07 +00:00
perkj@google.com
ef04cf4b2e Adding reference counted version of the module interface.
The reason for this is that we would like to have reference counting on the modules you can register externally with ViE and VoE.
Currently we plan to use this on the ADM, VideoCapture module and VideoRenderModule.
Review URL: http://webrtc-codereview.appspot.com/138010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@517 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 09:47:28 +00:00
andrew@webrtc.org
4d905f88c6 Fix clang warnings in rtp.
Review URL: http://webrtc-codereview.appspot.com/132006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@514 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 19:22:27 +00:00
andrew@webrtc.org
bbd8908664 Fix clang warnings in video coding.
Review URL: http://webrtc-codereview.appspot.com/138007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@511 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:30:01 +00:00
tina.legrand@webrtc.org
84519ec0a2 Fixing some inconsistencies in WebRTC audio coding module. I've added setup information for all codecs which are not part of WebRTC, but possible to hook in.
Please help me review.
Henrik: review neteq_defines.h
Turaj: review all files, but the one Henrik reviews.
Zakk: FYI only.
Review URL: http://webrtc-codereview.appspot.com/138004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@505 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 07:47:31 +00:00
marpan@google.com
243db12616 media_opt_util: Fixed an assert and some code cleanup for AvgRecoveryFEC function.
Review URL: http://webrtc-codereview.appspot.com/139007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@502 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 22:14:52 +00:00
turajs@google.com
ebb2744337 To fix warning for unused variable. And fix some warning in test.
Review URL: http://webrtc-codereview.appspot.com/131010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@500 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 21:28:08 +00:00
turajs@google.com
eaf3185105 Take care of unused variable.
Review URL: http://webrtc-codereview.appspot.com/137013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@499 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 21:27:53 +00:00
andrew@webrtc.org
9562a3664c Last fixes to build with gcc 4.6.
Set but unused parameter/variable warnings.
http://code.google.com/p/webrtc/issues/detail?id=52
Review URL: http://webrtc-codereview.appspot.com/139006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@498 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 18:50:12 +00:00
andrew@webrtc.org
830099eba4 Add a gyp flag to disable video functionality from dependencies shared by voice and video engine.
Currently, this is just the utility module. It relies on the already existing WEBRTC_MODULE_UTILITY_VIDEO define.
Review URL: http://webrtc-codereview.appspot.com/133007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@496 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 17:03:54 +00:00
pwestin@webrtc.org
e9f0e2eb20 Moved _rtpReceiver to protected
Review URL: http://webrtc-codereview.appspot.com/132005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@495 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 13:16:52 +00:00
tommi@webrtc.org
c7d5f6249b Fix build errors on Windows.
Since this is a C file, variables must be declared at the top of the function
so I'm moving the fix for the warning (inst = NULL) to the bottom of the funciton.
Otherwise, the compiler will complain when it sees int i; on systems that do
not have WEBRTC_BIG_ENDIAN defined.
Review URL: http://webrtc-codereview.appspot.com/139005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@494 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 12:11:24 +00:00
turajs@google.com
74c640aebb fix build break
Review URL: http://webrtc-codereview.appspot.com/132004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@493 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 20:44:24 +00:00
turajs@google.com
7796c02b42 Wrap encode, decode, PLC NB functions in #define to avoid warnings.
Review URL: http://webrtc-codereview.appspot.com/133005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@492 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 20:30:17 +00:00
turajs@google.com
8ecd0e8f3d Remove Clang warning for PCM16B.
Review URL: http://webrtc-codereview.appspot.com/137006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@491 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 20:29:50 +00:00
punyabrata@google.com
eba8c32840 Resolving a race condition issue related to using shared devices
(e.g. usb headsets) where we were not stopped the shared callback
until both StopPlayout() and StopRecording() are called. Google
internal bugid 4478351
Review URL: http://webrtc-codereview.appspot.com/130001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@489 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 14:32:22 +00:00
xians@google.com
e74a9ea303 AudioDeviceUtility::WaitForKey() pulls two characters if the first one is a newline, but discards the final value.
The current code assigns that second value to a local variable, which generates a set-but-unused warning on gcc 4.6.0. Instead, cast the result away.

I also refactor the code a bit by adding the right indentation and removing empty lines.

Bug=http://code.google.com/p/webrtc/issues/detail?id=53
Test=none
Review URL: http://webrtc-codereview.appspot.com/135005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@486 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 08:27:02 +00:00
xians@google.com
932096c84f Porting gtalk alsa impl from depot to webrtc
Review URL: http://webrtc-codereview.appspot.com/123002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@484 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 07:41:55 +00:00
mikhal@webrtc.org
46171cf546 video coding tests: Adding a Normal distribution to simulate packet arrival times
Review URL: http://webrtc-codereview.appspot.com/138003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@483 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 23:38:04 +00:00
henrik.lundin@webrtc.org
8571af7be6 Updating to new VP8 rtp format
The VP8 packetizer and tests have been updated to the new
RTP draft (http://tools.ietf.org/html/draft-ietf-payload-vp8-01).
The receive-side parser is also updated, and a new unit test
is implemented for it. Finally, some data traversing work to
get the parsed information into the decoder.
Review URL: http://webrtc-codereview.appspot.com/116011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@482 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 15:37:12 +00:00
hellner@google.com
09734086c6 Fixes build issue in http://code.google.com/p/webrtc/issues/detail?id=56.
Review URL: http://webrtc-codereview.appspot.com/131008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@481 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 14:10:01 +00:00
tina.legrand@webrtc.org
81fd2bfbba New ACM codec database, created at compile time.
Review URL: http://webrtc-codereview.appspot.com/127002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@480 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 11:18:44 +00:00
tina.legrand@webrtc.org
a41b4ce7da Changing iLBC to use the new improved SQRT, WebRtcSpl_SqrtFloor().
The bit-stream has not change with the new SQRT, but the output signal has. The change in output is small, and all test-files pass a subjective quality test.
New test-files will be committed to svn after this CL.
Review URL: http://webrtc-codereview.appspot.com/136001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@478 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 08:19:30 +00:00
tina.legrand@webrtc.org
2aa5d500af Issue reported in WebRTC. A variable is defined and set, but never used.
Review URL: http://webrtc-codereview.appspot.com/139001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@474 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 06:36:37 +00:00
henrik.lundin@webrtc.org
36450af2b3 Removing unsupported codecs from ptypes file
The file ptypes.txt tells test program NetEqRTPplay how to
map the RTP payload types in an RTP file. Now removing payload
types that are not supported in WebRTC.
Review URL: http://webrtc-codereview.appspot.com/119009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@473 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-27 01:25:35 +00:00
andrew@webrtc.org
bd4494cb20 Remove the divide-by-2 when mixing.
Review URL: http://webrtc-codereview.appspot.com/137007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@471 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 22:58:00 +00:00
mikhal@webrtc.org
b7ac56d92b video coding tests: updating quality tests following r466
Review URL: http://webrtc-codereview.appspot.com/131009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@470 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:35 +00:00
mikhal@webrtc.org
d24a97fae1 video coding test: deleting unused file(resampler_test.cc)
Review URL: http://webrtc-codereview.appspot.com/137008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@469 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:17 +00:00
mikhal@webrtc.org
2c3b1fb4f3 video_coding tests: removing unused functionality from test_util
Review URL: http://webrtc-codereview.appspot.com/137009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@468 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:04 +00:00
mikhal@webrtc.org
a057a9561c video_coding: Updating protection logic in media optimization utility:
1. Changing protection logic structure: Accepts only one method (not a list)
2. Removed unused code (unreferenced protection methods)
3. Removed inline constructors/destructors.  
Review URL: http://webrtc-codereview.appspot.com/120005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@467 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:17:34 +00:00
mikhal@webrtc.org
552f173979 video_coding: Moving video metrics computation to a designated file.
This is the first stage of a general clean-up to test_util. Will try to divide this clean-up to small changes, so it will be easier to review. 
Review URL: http://webrtc-codereview.appspot.com/120004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@466 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:38:09 +00:00
andrew@webrtc.org
e46d69f762 Fix gcc 4.6 set but unused warnings in AEC.
Review URL: http://webrtc-codereview.appspot.com/134003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@465 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:20:54 +00:00
andrew@webrtc.org
ffbe7a75fd Cast away the unused state argument value to silence gcc 4.6 warnings.
The WebRTC C wrapper for the G711 codec doesn't actually use the 'state' 
argument, but declares one anyway for API uniformity.

At the beginning of functions like WebRTCG711_EncodeA(), there's a stanza:

    // Set to avoid getting warnings
    state = NULL;

This might work around an unused parameter warning, but under gcc 4.6.0 
it ends up generating another warning, that state is set but not used.  

Casting the assignment to void silences the warning, restoring 
compilation under -Werror.

Reported as https://code.google.com/p/webrtc/issues/detail?id=50
Review URL: http://webrtc-codereview.appspot.com/135002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@463 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:16:30 +00:00
turajs@google.com
7f2bbbbefd To remove all calls involving scratch-memory
Review URL: http://webrtc-codereview.appspot.com/129001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@462 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 16:03:49 +00:00
turajs@google.com
ac55f7b33c Review URL: http://webrtc-codereview.appspot.com/115004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@461 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 16:02:16 +00:00