magjed@webrtc.org
afdd5dd372
Revert "Revert "Remove frame copy from cricket::VideoFrame to I420VideoFrame""
...
This reverts r8683 and is a reland of r8682.
Reason for revert: The thread checker in Chromium that crashed has been fixed now.
BUG=1128
TBR=tommi,pbos,pthatcher
Review URL: https://webrtc-codereview.appspot.com/40319004
Cr-Commit-Position: refs/heads/master@{#8696}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8696 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-12 13:11:43 +00:00
magjed@webrtc.org
b218ff5531
Revert "Remove frame copy from cricket::VideoFrame to I420VideoFrame"
...
This reverts r8682.
Reason for revert: Fails on Chromium FYI content_browsertests
BUG=1128
TBR=tommi,pbos,pthatcher
Review URL: https://webrtc-codereview.appspot.com/47529004
Cr-Commit-Position: refs/heads/master@{#8683}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8683 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-11 15:29:59 +00:00
magjed@webrtc.org
370a72cc3f
Remove frame copy from cricket::VideoFrame to I420VideoFrame
...
BUG=1128
R=pbos@webrtc.org , pthatcher@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/42249004
Cr-Commit-Position: refs/heads/master@{#8682}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8682 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-11 14:16:16 +00:00
guoweis@webrtc.org
f9a75d99b9
Revert "Add concept of whether video renderer supports rotation."
...
This reverts commit 0ad48935fc
.
TBR=guoweis@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/41199004
Cr-Commit-Position: refs/heads/master@{#8663}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8663 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-10 06:37:41 +00:00
guoweis@webrtc.org
60a2aa0652
Revert "Add concept of whether video renderer supports rotation."
...
This reverts commit 31d16467ac
.
TBR=guoweis@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/47489004
Cr-Commit-Position: refs/heads/master@{#8662}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8662 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-10 06:20:18 +00:00
guoweis@webrtc.org
31d16467ac
Add concept of whether video renderer supports rotation.
...
Rotation is best done when rendered in GPU, added the shader code which rotates the frame. For renderers which don't support rotation, the rotation will be done before sending down the frame to render. By default, assume renderer can't do rotation.
BUG=4145
R=glaznev@webrtc.org , pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8660
Review URL: https://webrtc-codereview.appspot.com/43569004
Cr-Commit-Position: refs/heads/master@{#8661}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8661 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-10 06:11:44 +00:00
guoweis@webrtc.org
0ad48935fc
Add concept of whether video renderer supports rotation.
...
Rotation is best done when rendered in GPU, added the shader code which rotates the frame. For renderers which don't support rotation, the rotation will be done before sending down the frame to render. By default, assume renderer can't do rotation.
BUG=4145
R=glaznev@webrtc.org , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43569004
Cr-Commit-Position: refs/heads/master@{#8660}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8660 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-10 02:43:40 +00:00
magjed@webrtc.org
f09e7b8a4f
WebRtcVideoFrame: DCHECK exclusive ownership for non-const pixel access
...
Add some const safety by DCHECK(HasOneRef()) in non-const GetYPlane. This CL also replaces all incorrect non-const calls with const calls for pixel data access in cricket::VideoFrame. It's easy to call the non-const version of e.g. GetYPlane by mistake, even if only const-access is needed. For example:
const scoped_ptr<cricket::VideoFrame> foo;
const uint8_t* y = foo->GetYPlane();
will actually call the non-const version of GetYPlane.
R=mflodman@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39079004
Cr-Commit-Position: refs/heads/master@{#8507}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8507 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-25 14:50:19 +00:00
magjed@webrtc.org
3864363e2c
cricket::VideoFrame: Refactor CopyToBuffer into base class
...
It’s possible to implement cricket::VideoFrame::CopyToBuffer using the virtual interface. This removes the need for subclasses to implement their own versions. This CL also fixes a bug in cricket::VideoFrame::CopyToPlanes which currently assumes that GetUPitch() == GetVPitch(), otherwise it may segfault.
I think this CL should land regardless, but the main purpose is to pave the way for for planned changes to I420VideoFrame. See https://review.webrtc.org/38879004 .
R=fbarchard@google.com , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39889004
Cr-Commit-Position: refs/heads/master@{#8403}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8403 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-18 09:19:45 +00:00
magjed@webrtc.org
dd4a8da68a
Remove DISABLE_YUV flag
...
R=fbarchard@google.com , pbos@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41979004
Cr-Commit-Position: refs/heads/master@{#8402}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8402 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-18 08:47:43 +00:00
magjed@webrtc.org
bdcf38c894
cricket::VideoFrame: Refactor ConvertToRgbBuffer into base class
...
There is also an implementation in Chromium that can be removed if/when this lands:
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
R=fbarchard@google.com , pbos@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32059004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7728 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-21 10:53:00 +00:00
fbarchard@google.com
7e31197cb2
Revert 7170 "Revert 7121 "ValidateFrame, When dumping the first ..."
...
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
> Revert 7121 "ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that."
>
> Breaks other repos.
>
> TBR=fbarchard@google.com
> BUG=N/A
>
> Review URL: https://webrtc-codereview.appspot.com/23639004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7173 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-13 00:52:42 +00:00
henrike@webrtc.org
3decd9b776
Revert 7121 "ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that."
...
Breaks other repos.
TBR=fbarchard@google.com
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/23639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7170 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 16:31:29 +00:00
fbarchard@google.com
54cf1505e2
ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that.
...
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7121 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 18:34:53 +00:00
buildbot@webrtc.org
a09a99950e
(Auto)update libjingle 73222930-> 73226398
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6891 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 17:26:08 +00:00
buildbot@webrtc.org
d4e598d57a
(Auto)update libjingle 72097588-> 72159069
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6799 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-29 17:36:52 +00:00
pbos@webrtc.org
371243dfa3
Remove std:: prefixes from C functions in talk/.
...
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.
BUG=
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5657 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:22:04 +00:00
henrike@webrtc.org
28654cbc22
Update talk folder to revision=49713299.
...
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1848004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4380 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-22 21:07:49 +00:00
henrike@webrtc.org
28e2075280
Adds trunk/talk folder of revision 359 from libjingles google code to
...
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00