Commit Graph

5373 Commits

Author SHA1 Message Date
bjornv@google.com
8e9e83b530 This CL adds guards against division by zero, that should fix http://b/issue?id=5278531
In addition a read outside memory event has been detected and removed.
Also an improper noise weighting has been corrected.
Review URL: http://webrtc-codereview.appspot.com/152001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@640 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 12:39:47 +00:00
kjellander@webrtc.org
9e7774f163 Added compare methods for TickInterval class.
This is useful to be able to sort them using the STL algorithm library.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/173002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@639 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 11:33:31 +00:00
kjellander@webrtc.org
dca57bddf8 Adding git ignore file.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/173001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@638 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 11:15:35 +00:00
bjornv@google.com
dc743a8bba Replaces a use of log2.
I've replaced a log2 operation so it works on Windows.
Review URL: http://webrtc-codereview.appspot.com/171002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@637 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 08:13:53 +00:00
leozwang@google.com
90eff6c7c6 Fix compilation error in build-in AEC test
Review URL: http://webrtc-codereview.appspot.com/164001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@636 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 18:02:03 +00:00
wu@webrtc.org
221b522118 Return the number of /dev/video* without trying to open it.
Consider the case when there're /dev/video0 and /dev/video1. But for somereason the video0 is not in a correct state and can't be open. As a result, current NumberOfDevices will return 1, which is fine. However, we will then never be able to get the device we really want - /dev/video1. Consider the code below, the GetCaptureDevice will fail because it calls into DeviceInfoLinux::GetDeviceName(0, ...) which will again try to open the /dev/video0. So the root cause is the mismatching of the NumberOfDevices and GetDeviceName.

Since we will open the device in DeviceInfoLinux::GetDeviceName anyway, I think we should return the number of /dev/video* in DeviceInfoLinux::NumberOfDevices without trying to open it. Otherwise the DeviceInfoLinux::NumberOfDevices should return more information like which /dev/video* is valid which is not.

bool found = false;
for (int i = 0; i < vie_capture->NumberOfCaptureDevices(); ++i) {
  if (vie_capture->GetCaptureDevice(i, ...) == 0) {
    found = true;
    break;
  }
}
Review URL: http://webrtc-codereview.appspot.com/148004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@635 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 16:57:15 +00:00
ronghuawu@google.com
c389aa2615 Fix the bad video issue on Window client by increasing the rtp recv buffer size.
Send buffer doesn't really matter, just to keep the same as talk does.

The same fix is submitted to libjingle for reivew. But I think it's worth to fix it here too as
it may take while for webrtc to get from libjingle. This patch is slightly different then that
one as I don't want to add the webrtcvideoengine.h back to webrtc.
Review URL: http://webrtc-codereview.appspot.com/166002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@634 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 16:53:45 +00:00
bjornv@google.com
65e6ab31eb Temporary log2 remove to build in chrome
git-svn-id: http://webrtc.googlecode.com/svn/trunk@633 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-21 11:56:46 +00:00
amyfong@webrtc.org
3be70ca17e Added mute, hold and typing detect to voe_cmd_test to increase functionality in the voe_cmd_test application.
Typing Detect is applicable only for Mac.  
Review URL: http://webrtc-codereview.appspot.com/156002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@632 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 23:41:06 +00:00
wu@webrtc.org
a1930427af When WEBRTC_VIDEO_EXTERNAL_CAPTURE_AND_RENDER is defined, we should never try to use _ptrCaptureDeviceInfo.
Review URL: http://webrtc-codereview.appspot.com/167001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@631 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 17:38:57 +00:00
leozwang@google.com
657f483c26 Fix compilation error
Review URL: http://webrtc-codereview.appspot.com/162003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@630 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 16:41:20 +00:00
leozwang@google.com
ec5e87614e Enable OPENELSE defination when compile voice engine
Review URL: http://webrtc-codereview.appspot.com/150005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@629 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 16:41:09 +00:00
pwestin@webrtc.org
741da942ec Added support for new RTCP message REMB (remote estimated max bitrate)
Review URL: http://webrtc-codereview.appspot.com/149001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@628 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 13:52:04 +00:00
perkj@webrtc.org
679e64d1fc Cleaning up of Peerconnection API.
Removing RemoteMediaStream. Adding one universal implementation of MediaStream that is used for both remote and local media streams.
Removed AudioDevice and VideoDevice since VideoCaptureModule and AudioDeviceModule now is reference counted.
Changes LocalAudioTrackImpl and LocalVideoTrackImpl to AudioTrackImpl and VideoTrackImpl so they can be used to repressent both remote and local tracks.
Renamed files to a better name.
Review URL: http://webrtc-codereview.appspot.com/151001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@627 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 08:21:22 +00:00
wu@webrtc.org
c49db5ea48 The files included in devicemanager.h/cc still have some conflict with chromium. Let's keep the devicemanager mods for now and I will see how can we solve this next.
Review URL: http://webrtc-codereview.appspot.com/166001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@626 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 00:40:52 +00:00
wu@webrtc.org
cb99f78653 * Update to use libjingle r85.
* Remove (most of) local libjingle mods. Only webrtcvideoengine and webrtcvoiceengine are left now, because the refcounted module has not yet been released to libjingle, so I can't submit the changes to libjingle at the moment.
* Update the peerconnection client sample app.
Review URL: http://webrtc-codereview.appspot.com/151004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@625 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 21:59:33 +00:00
andrew@webrtc.org
86b85db67e Add missing intrinsic casts for VS 2005.
Allows re-enabling SSE optimization on Windows.
Review URL: http://webrtc-codereview.appspot.com/161003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@623 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 18:48:25 +00:00
leozwang@google.com
522f42bb80 Add kPlatformAndroid to platform check function
Review URL: http://webrtc-codereview.appspot.com/161002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@622 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 17:39:05 +00:00
andrew@webrtc.org
ed083d4079 Modify the _vadActivity member of the AudioFrame passed to AudioProcessing.
This saves the user from having to explicitly check stream_has_voice(). It will allow typing detection to function, which relies on this behaviour.
Review URL: http://webrtc-codereview.appspot.com/144004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@621 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 15:28:51 +00:00
andrew@webrtc.org
94c7413b0d Allow echo metrics to be enabled in process_test.
Review URL: http://webrtc-codereview.appspot.com/155002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@620 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 15:17:57 +00:00
henrik.lundin@webrtc.org
4c36d3b424 Fixing windows warnings in rtp_utility
Adding explicit casting to bool to avoid warnings when compiling
in windows.

Review URL: http://webrtc-codereview.appspot.com/140002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@619 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 08:16:20 +00:00
stefan@webrtc.org
dba7a3abd6 Updating WATCHLIST with a video_coding watch and adding myself to it.
Review URL: http://webrtc-codereview.appspot.com/159001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@618 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 07:50:48 +00:00
andrew@webrtc.org
67812a4621 Temporarily disabling SSE2 on Windows again until we can build on VS 2005.
Skipping review because the build is broken on Windows.
Review URL: http://webrtc-codereview.appspot.com/156003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@617 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 02:28:49 +00:00
andrew@webrtc.org
d02dc6e682 Removing bwe_standalone from modules.gyp
Review URL: http://webrtc-codereview.appspot.com/144003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@614 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-17 00:44:23 +00:00
wjia@google.com
fdaee9c014 include build/common.gypi directly
Review URL: http://webrtc-codereview.appspot.com/153006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@613 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-17 00:06:08 +00:00
andrew@webrtc.org
7b7c045b75 Fix MSVC issues in AEC to enable SSE2 optimization on Windows.
Variables now declared at top of scope and replacing C casts with intrinsic cast functions.
Review URL: http://webrtc-codereview.appspot.com/160001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@611 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 22:51:57 +00:00
leozwang@google.com
b37ec71dbd Remove delay_estimator_float.c from android build
Review URL: http://webrtc-codereview.appspot.com/161001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@610 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 21:50:36 +00:00
andrew@webrtc.org
427ee41a58 Remove unneeded webrtc_trunk variable from DEPS.
Review URL: http://webrtc-codereview.appspot.com/153004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@609 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 21:16:29 +00:00
leozwang@google.com
a5700876c0 Add include path to auto test
Review URL: http://webrtc-codereview.appspot.com/155001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@608 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 20:38:31 +00:00
andrew@webrtc.org
416d702ace Fix autotest error on non-Win platforms.
Review URL: http://webrtc-codereview.appspot.com/149007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@607 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 14:22:39 +00:00
tina.legrand@webrtc.org
e126dbbce8 Adding audio coding module to watchlist.
Review URL: http://webrtc-codereview.appspot.com/156001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@606 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 08:02:21 +00:00
niklase@google.com
d15469eeed Fix typo in WATCHLISTS.
Review URL: http://webrtc-codereview.appspot.com/154004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@605 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 07:04:56 +00:00
andrew@webrtc.org
29f9159ad7 Use http (not https) to sync jsoncpp.
This is mainly to be consistent with the other repos, but there's also a slim chance it's triggering an issue on the buildbot
Review URL: http://webrtc-codereview.appspot.com/154005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@604 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-16 05:26:16 +00:00
leozwang@google.com
ce95069ade Fix buidling error
Review URL: http://webrtc-codereview.appspot.com/151002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@603 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 22:28:08 +00:00
wu@webrtc.org
fcd12b3b7d Add necessary spaces to log.
Review URL: http://webrtc-codereview.appspot.com/148002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@602 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 20:49:50 +00:00
andrew@webrtc.org
4537c2a464 Remove the UNCONSTR code path from AEC.
Leave the unconstrained filter adaptation in a commented out function. Consider using this for a low-complexity mode.
Review URL: http://webrtc-codereview.appspot.com/146001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@601 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 18:25:14 +00:00
tommi@webrtc.org
8dc3985a10 Fix windows build.
Review URL: http://webrtc-codereview.appspot.com/150001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@600 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 15:01:04 +00:00
bjornv@google.com
b47d4b287d This CL includes a move of the fixed point delay estimator from aecm to apm/utility. There has also been a code change that makes it possible to enable/disable the far end alignment, so that we save complexity when used as a quality metrics.
Review URL: http://webrtc-codereview.appspot.com/135014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@599 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 12:27:36 +00:00
henrik.lundin@webrtc.org
29fd9a5f30 Removing warnings in all NetEQ test targets
Now all targets in neteq.gypi builds again. Also added payload type to
the log produced by RTPanalyze.

Review URL: http://webrtc-codereview.appspot.com/148001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@598 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 08:25:45 +00:00
niklase@google.com
df587b220d Adding people to WATCHLISTS
Review URL: http://webrtc-codereview.appspot.com/147001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@597 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-15 07:30:21 +00:00
wu@webrtc.org
b27f3f16b6 Update to use the new opensource jsoncpp and remove jsoncpp mods.
Review URL: http://webrtc-codereview.appspot.com/145001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@596 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-14 23:26:00 +00:00
andrew@webrtc.org
19eefdc9f0 Add a unit testing framework.
Populate it with the beginnings of a resampler unit test to have it do someting.

Also fix a bug in resampler caught with the test ;)
Review URL: http://webrtc-codereview.appspot.com/135019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@595 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-14 17:02:44 +00:00
andrew@webrtc.org
b524f441d0 Correct some comment spelling errors. Skipping review.
Review URL: http://webrtc-codereview.appspot.com/144002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@594 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 18:04:30 +00:00
andrew@webrtc.org
7a585a7903 Correct voe_auto_test file path on Windows.
Needs to be changed due to the recent move of voice_engine.gyp.
Review URL: http://webrtc-codereview.appspot.com/144001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@593 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:46:36 +00:00
andrew@webrtc.org
a3c6d61c44 Integrate the built-in WASAPI AEC DMO to VoE.
Review URL: http://webrtc-codereview.appspot.com/108006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@592 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:17:49 +00:00
leozwang@google.com
b1b3e67c97 Fix compilation errors
Review URL: http://webrtc-codereview.appspot.com/142002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@591 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:16:24 +00:00
leozwang@google.com
803a5f2795 Add include path
Review URL: http://webrtc-codereview.appspot.com/141003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@590 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:15:22 +00:00
andrew@webrtc.org
2cef36fa98 Fix Windows gyp run.
On Windows, gyp seems to require valid source files. The matlab_plotting_test target was missing its one source file, so I removed the target.

Also moving bwe_standalone.gypi to the test include list.
Review URL: http://webrtc-codereview.appspot.com/143001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@589 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:03:15 +00:00
andrew@webrtc.org
f5fb095bf9 Fix audio processing tests gypi after recent changes.
Review URL: http://webrtc-codereview.appspot.com/137025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@588 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 01:04:59 +00:00
andrew@webrtc.org
1fc632e221 Add gmock 1.6.0 to DEPS.
Review URL: http://webrtc-codereview.appspot.com/132016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@587 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 22:41:39 +00:00