Commit Graph

63 Commits

Author SHA1 Message Date
perkj@webrtc.org
1305a1d05e Fix rendering in new PeerConnection API.
Fix MediaStreamHandler to make sure it releases the reference to a renderer when it is no longer needed.
Removes the use of the signaling thread in MediaStreamHandler.

Fix renderering in peerconnection_client_dev. It now uses the reference counted render wrapper.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/242001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@764 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-18 11:54:46 +00:00
henrike@webrtc.org
0d55c8f96d Adding peerconnection_unittest.
Review URL: http://webrtc-codereview.appspot.com/226004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@757 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-17 21:12:45 +00:00
mallinath@webrtc.org
5cb3064642 The change will separate the media tracks based on media type. MediaStreamInterface currently will have list for audio and video. This way we don't need to check for the track type before converting to respective mediatrack.
Review URL: http://webrtc-codereview.appspot.com/230003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@756 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-17 13:19:08 +00:00
perkj@webrtc.org
63257d4bd2 Implement proxy for both audio and video tracks.
The purpose of the proxy is that all calls to MediaStreamTracks should be done on the signaling thread.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/225004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@755 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-17 11:39:09 +00:00
mallinath@webrtc.org
ebc0a00197 One of Justin comment was to have XXXXInterface and XXXX, rather than XXXX and XXXXImpl. So here are the changes, i don't like to call some the classes as interfaces like MediaStreamTrackListInterface, but they fit the criteria to be called as interface.
Review URL: http://webrtc-codereview.appspot.com/226001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@743 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-14 07:04:02 +00:00
henrike@webrtc.org
03a86998cd Fixes for build errors introduced most likely earlier today.
Review URL: http://webrtc-codereview.appspot.com/228003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@742 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 23:36:38 +00:00
mallinath@webrtc.org
103f33b734 Changes after comments received from Justin and Harald. Few comments are not implemented like moving track implementation to base<> and then have child classes based on the type of track.
Review URL: http://webrtc-codereview.appspot.com/217004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@735 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 14:31:20 +00:00
perkj@webrtc.org
6a34d584b8 Implement MediaStreamProxy.
This implements a proxy for MediaStreams and MediaStreamTracklists.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/217003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@733 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 08:48:43 +00:00
perkj@webrtc.org
3a6d4f4268 Fix setting VideoCaptureModule and VideoRenderer for local and remote streams.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/205002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@701 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 16:10:10 +00:00
mallinath@webrtc.org
fa41d807a8 Fixes session state transition and registering observer.
Review URL: http://webrtc-codereview.appspot.com/203001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@697 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 22:49:59 +00:00
mallinath@webrtc.org
29787c71a0 Changes to WebRtcSession after Provider(s) interface addition.
Review URL: http://webrtc-codereview.appspot.com/201001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@695 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 18:52:26 +00:00
perkj@webrtc.org
487e401a27 Moving creation of sessiondescriptions to webrtcsession.
Fixing defect durin close down in peerconnectionmanager.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/193004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@693 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-05 17:15:36 +00:00
perkj@webrtc.org
cb4ab65dfc Moved creation of objects to the signaling thread.
Fixed defect of not initializing remote_media_streams in peerconnection_impl.cc
Fixed defect in glare case of peerconnectionsignaling.cc

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/196001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@690 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 17:54:34 +00:00
mallinath@webrtc.org
bafca109db Temp hook in WebRtcSession to VideoChannel.
Review URL: http://webrtc-codereview.appspot.com/195001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@689 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 17:45:21 +00:00
perkj@webrtc.org
1b6ff7adbe Connecting PeerConnectionImpl with WebrtcSession and MediaStreamHandlers.
This cl connects PeerConnectionImpl with WebrtcSession and MediaStreamHandlers.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/190005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@683 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:50:04 +00:00
perkj@webrtc.org
666f56bd41 MediaStreamHandler implements eventhandlers for streams and tracks.
Sets local and remote renderer and capture device.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/192002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@682 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 21:55:17 +00:00
wu@webrtc.org
236fcaa89a Interface changes after we have the Serialize and Deserialize.
Review URL: http://webrtc-codereview.appspot.com/186004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@681 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 21:34:19 +00:00
wu@webrtc.org
ed6d555775 * Add the crypto serialize and deserialize.
* Populate candidates test data.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/190004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@680 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 21:13:29 +00:00
mallinath@webrtc.org
ee2c391c15 more webrtc session changes. Transport and TransportChannel handling is complete. Need work on session state.
Review URL: http://webrtc-codereview.appspot.com/183005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@679 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 20:33:06 +00:00
wu@webrtc.org
c93e36346b * Add Deserize for PeerConnectionMessage
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/189001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@671 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-30 18:08:51 +00:00
perkj@webrtc.org
e804ee1a80 This patch hooks up PeerConnectionImpl to PeerConnectionSignaling.
Implements
virtual bool ProcessSignalingMessage(const std::string& msg);
virtual scoped_refptr<StreamCollection> remote_streams();
virtual void CommitStreamChanges();

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/187001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@669 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-29 22:27:54 +00:00
wu@webrtc.org
78083bf750 * Add Serialize functions to PeerConnectionMessage.
* Separated file for PeerConnectionMessage.
* Update to the latest and fix compiling errors
Review URL: http://webrtc-codereview.appspot.com/182002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@668 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-29 19:11:52 +00:00
mallinath@webrtc.org
9a1249d9e0 first cut of webrtcsession. Doesn't do much other than creating files and empty function bodies.
Review URL: http://webrtc-codereview.appspot.com/186002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@667 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-29 18:15:21 +00:00
perkj@webrtc.org
5045f671d0 Add SignalUpdateSessionDescription to PeerConnectionSignaling.
This is to allow webrtcsession to setup the mediachannels based on tracks.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/184001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@665 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-28 23:06:46 +00:00
perkj@webrtc.org
2f56ff48a4 Implementation of PcSignaling. A Class to handle signaling between peerconnections.
Review URL: http://webrtc-codereview.appspot.com/149002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@657 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 20:35:37 +00:00
perkj@webrtc.org
679e64d1fc Cleaning up of Peerconnection API.
Removing RemoteMediaStream. Adding one universal implementation of MediaStream that is used for both remote and local media streams.
Removed AudioDevice and VideoDevice since VideoCaptureModule and AudioDeviceModule now is reference counted.
Changes LocalAudioTrackImpl and LocalVideoTrackImpl to AudioTrackImpl and VideoTrackImpl so they can be used to repressent both remote and local tracks.
Renamed files to a better name.
Review URL: http://webrtc-codereview.appspot.com/151001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@627 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-20 08:21:22 +00:00
wu@webrtc.org
cb99f78653 * Update to use libjingle r85.
* Remove (most of) local libjingle mods. Only webrtcvideoengine and webrtcvoiceengine are left now, because the refcounted module has not yet been released to libjingle, so I can't submit the changes to libjingle at the moment.
* Update the peerconnection client sample app.
Review URL: http://webrtc-codereview.appspot.com/151004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@625 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 21:59:33 +00:00
wu@webrtc.org
b27f3f16b6 Update to use the new opensource jsoncpp and remove jsoncpp mods.
Review URL: http://webrtc-codereview.appspot.com/145001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@596 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-14 23:26:00 +00:00
mallinath@webrtc.org
c273019768 linking error after tommi's changes.
Review URL: http://webrtc-codereview.appspot.com/140008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@566 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 19:34:15 +00:00
tommi@webrtc.org
73f98aebc6 Temporarily switch the numeric locale formatting to 'classic' while we process the signaling message.
This is to avoid running into problems with jsoncpp and parts of libjingle
where we use STL and CRT routines that refer to the global locale for formatting.
If the current locale is e.g. Spanish, then numbers will be formatted as "12,34"
and not "12.34" as some parts (not all) of jsoncpp expect.

Code I noticed where we might run into this is here (but it's likely that there are
more places):

third_party\libjingle\source\talk\p2p\base\candidate.h (preference_str)
third_party_mods\libjingle\source\talk\app\webrtc\webrtc_json.cc
third_party\jsoncpp\src\lib_json\*writer*
third_party\jsoncpp\src\lib_json\*reader*

BUG=69
TEST=Verify that the signaling messages always contain numbers formatted as "1.23" and never "1,23" even though the regional settings on the machine specify otherwise (e.g. try setting it to Spanish).
Review URL: http://webrtc-codereview.appspot.com/140007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@564 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 17:46:46 +00:00
perkj@google.com
e5ea75254f New Peerconnection manager implementation. Ready for review.
Review URL: http://webrtc-codereview.appspot.com/134004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@540 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 07:25:56 +00:00
wu@webrtc.org
5a15ab9e36 Move the WebRtcDeviceManager and WebRtcMediaEngine to libjingle.
Review URL: http://webrtc-codereview.appspot.com/139009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@515 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 23:04:52 +00:00
mallinath@webrtc.org
f990eb3e88 Hi,
Removed OnLocalStreamInitialized callback from the PeerConnection callback list. After adding OnAddStream trigger at the originator this callback was redundant. Also other modification is to provide same stream label in OnAddStream callback at the originator which provided in AddStream API.
Review URL: http://webrtc-codereview.appspot.com/138002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@490 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 17:16:35 +00:00
perkj@google.com
3fcabbe45c Modified include path after after moving files to webrtc_dev.
Review URL: http://webrtc-codereview.appspot.com/137010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@485 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 07:44:18 +00:00
mallinath@webrtc.org
92bace1faf Hi,
This CL will support negotiation of RTCP Mux feature. Earlier we were by default enabling and assuming remote end point will support this feature as well. This will also remove the maintaining of transport channels in WebRtcSession. Its left to cricket::Transport
Review URL: http://webrtc-codereview.appspot.com/131005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@472 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-27 00:37:58 +00:00
mallinath@webrtc.org
b62c776eca moving all new version related files to webrtc_dev and removed from webrtc.
Review URL: http://webrtc-codereview.appspot.com/138001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@464 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:19:09 +00:00
hellner@google.com
b55c988b22 Updated peerconnection_unittest slightly. Also added it to the build.
Review URL: http://webrtc-codereview.appspot.com/133003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@456 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 23:01:40 +00:00
hellner@google.com
b2801f3a16 Added the remaining test cases for the webrtcsession unittest also some minor refactoring.
Review URL: http://webrtc-codereview.appspot.com/131003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@454 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 21:37:08 +00:00
hellner@google.com
40373cc184 Bugfix in unittest and some minor refactoring.
Review URL: http://webrtc-codereview.appspot.com/137003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@450 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 17:17:30 +00:00
wu@webrtc.org
eb9572e501 Add the new peerconnection factory to the scons file.
Review URL: http://webrtc-codereview.appspot.com/134001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@449 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 16:58:58 +00:00
hellner@google.com
3227ed567b Fixed potential memory leak in unit test and removed an unnecessary copy.
Review URL: http://webrtc-codereview.appspot.com/131001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@447 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 15:34:19 +00:00
tommi@webrtc.org
137ece4ac3 * Make GetReadyState accessible via the PeerConnection interface.
* Update PeerConnection implementations to include "virtual"
in the method declarations.
* Add a check for a valid signaling thread in webrtcsession.cc.
Review URL: http://webrtc-codereview.appspot.com/137001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@445 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 14:18:25 +00:00
mallinath@webrtc.org
1cdc6b5d79 This CL adding a factory class which has the responsibility of creating peerconnection objects. This is very basic class doesn't do any reference count, user has the responsibility to delete the object externally.
Review URL: http://webrtc-codereview.appspot.com/122006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@443 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 23:50:05 +00:00
hellner@google.com
d1015fe677 Replaced regular sleep with a talk_base::Thread::ProcessMessages(..) call so that Posts get some execution time from the main thread.
Review URL: http://webrtc-codereview.appspot.com/122007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@442 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 21:35:09 +00:00
perkj@google.com
accd686b31 Implementation of media streams. Work in progress.
Review URL: http://webrtc-codereview.appspot.com/117002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@436 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 15:43:42 +00:00
wu@webrtc.org
9788e18532 * Add PeerConnectionProxy to forward all the API calls to signaling thread.
* Use Send instead of Post so that we can report error.
Review URL: http://webrtc-codereview.appspot.com/113009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@432 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 23:49:44 +00:00
mallinath@webrtc.org
dec6aa57f3 This CL will remove sending any signal after calling Close and RemoveStream. I am thinking to remove Close method at all, since application can directly delete the object if it wants to end the call with all active streams. Will send that change later in a different CL.
Review URL: http://webrtc-codereview.appspot.com/119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@429 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 22:17:03 +00:00
wu@webrtc.org
87c9b74b11 * Use the current thread as the signaling thread and worker thread to keep the unit test simple and easier to debug.
* I also merged the issue 113007.

This will be uploaded to the libjingle patch, so you may comment there if you want.

There's failure in the tests now, but I will let you review the threading change at the same time I will try to resolve the failure.
Review URL: http://webrtc-codereview.appspot.com/120002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@426 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 20:57:29 +00:00
mallinath@webrtc.org
6f555dcafe Review URL: http://webrtc-codereview.appspot.com/119002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@413 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 18:33:51 +00:00
mallinath@webrtc.org
bca7fa09af Review URL: http://webrtc-codereview.appspot.com/118001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@406 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 16:39:18 +00:00