generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,615 Commits 1 Branch 0 Tags 108 MiB
0ed9c69711
Commit Graph

1992 Commits

Author SHA1 Message Date
bjornv@webrtc.org
2273f325b2 VAD refactoring: Code style changes of local function. 
Changes applied to local GmmProbability():
* Replaced shift macros with shift operations
* Indentation and braces
* Removed redundant code
* Removed unnecessary type casts
* Name changes
* Adjusted comments

Tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/475002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1991 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 10:22:02 +00:00
pwestin@webrtc.org
cac787842c New attempt to cleanup TMMBR. 
Review URL: https://webrtc-codereview.appspot.com/472007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1990 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 08:30:10 +00:00
cd@webrtc.org
70ed0a6f91 No casting and call lower precision trigonometric functions: 
* 2.2% AEC overall speedup for the straight C path.
* 2.4% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/477002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1989 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 00:38:55 +00:00
leozwang@webrtc.org
f3dc22f7d1 Reformat android related code 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/472004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1988 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 17:15:42 +00:00
tommi@webrtc.org
851becd00c Remove public virtual voe::SharedData inheritance. 
This is a fix for coverity issues: 10446, 10445, 10444, 10443.

Although the cl is rather big, there aren't many code changes:

* Instead of an implicit vtable pointer, there is now an explicit |_data| member to access the shared data.
* We don't access the member variables of SharedData directly.  There are accessors instead.
* SharedData setters that set values that must be freed, automatically free the previous value and 'addref' if required the new one.
* Lots and lots of 'rewrapping' due to search/replace after the above changes.

BUG=10446, 10445, 10444, 10443
TEST=Run all tests for VoE.
Review URL: https://webrtc-codereview.appspot.com/472009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1987 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 14:57:19 +00:00
pwestin@webrtc.org
ae19720982 Fixed assert strings where string literals are used as booleans. 
Review URL: https://webrtc-codereview.appspot.com/473002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1986 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 14:43:54 +00:00
pwestin@webrtc.org
27fe1b702e Added compile time support for direct tracing. 
Review URL: https://webrtc-codereview.appspot.com/469006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 08:08:30 +00:00
niklas.enbom@webrtc.org
06e722ae77 Adding parameter setting for typing detection 
Review URL: https://webrtc-codereview.appspot.com/476001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1984 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 07:44:27 +00:00
phoglund@webrtc.org
afc39731dc Rewrote NetEQ stats test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/466002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1982 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-03 23:09:42 +00:00
leozwang@webrtc.org
0dc8efe6e6 Fix wrong data type in ReadWavHeader 
BUG=409
TEST=media file unit test
Review URL: https://webrtc-codereview.appspot.com/474001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1980 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-03 15:11:01 +00:00
henrika@webrtc.org
afedb637df Revert 1974 - Optimizations on several SPL min max operations in ARM, and refactoring in C. 
Touched C and assembly functions are tested with a new unit test which is not in the code base yet.
Review URL: https://webrtc-codereview.appspot.com/428004

TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/475001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1975 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-02 07:12:08 +00:00
kma@webrtc.org
95c3d408f5 Optimizations on several SPL min max operations in ARM, and refactoring in C. 
Touched C and assembly functions are tested with a new unit test which is not in the code base yet.
Review URL: https://webrtc-codereview.appspot.com/428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1974 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-02 03:55:20 +00:00
phoglund@webrtc.org
f3bbc3e5b3 Temporarily disabled new test since it segfaults randomly. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/474002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1972 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 23:13:33 +00:00
phoglund@webrtc.org
9b96e02c20 Adjusted the deviation limit since the test seems to fail on the bot. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/471002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1971 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 22:20:48 +00:00
phoglund@webrtc.org
b5617869fc Fixed problem with previous commit. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/472002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1970 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 21:02:45 +00:00
phoglund@webrtc.org
e5f74bdbbc Rewrote the video sync test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/463001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1969 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 19:51:11 +00:00
henrike@webrtc.org
0ad51862dc Revert 1961 - Clean up TMMBR handling. 
Review URL: https://webrtc-codereview.appspot.com/465001

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/473001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1967 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 16:54:13 +00:00
marpan@webrtc.org
3a6080d4c0 FEC Decoding: Insert the received media packets directly into VCM without going 
through the recovered packet list. Avoids an issue with very old re-transmitted packets.

Updated the receiver_fec unittest accordingly.
Review URL: https://webrtc-codereview.appspot.com/465003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1966 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 16:16:21 +00:00
mflodman@webrtc.org
8fe17df6bc Build fix. 
TBR=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/472001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 14:52:38 +00:00
mflodman@webrtc.org
a6a9964346 Updating the mtu. 
Review URL: https://webrtc-codereview.appspot.com/470002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1962 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 14:35:51 +00:00
pwestin@webrtc.org
20f4440c73 Clean up TMMBR handling. 
Review URL: https://webrtc-codereview.appspot.com/465001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1961 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 11:40:15 +00:00
niklas.enbom@webrtc.org
3dc886561c Adding time since last typing 
Review URL: https://webrtc-codereview.appspot.com/471001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1960 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-30 09:53:54 +00:00
phoglund@webrtc.org
1b1a39fdef Rewrote external encryption test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/456009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1959 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-29 16:58:35 +00:00
xians@webrtc.org
010a4e8f0b Fix the converity warnings: 
CID 10177: Array compared against 0 (NO_EFFECT)
Comparing an array to null is not useful: "this->_paServerVersion".
Review URL: https://webrtc-codereview.appspot.com/466001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1956 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-29 14:05:04 +00:00
xians@webrtc.org
f35f54bf68 Fix coverity warning. 
Review URL: https://webrtc-codereview.appspot.com/465002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1955 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-29 13:59:24 +00:00
bjornv@webrtc.org
ac2ea030fc VAD Refactoring: Repalced WebRtc_ types with stdint 
BUG=
TEST=vad_unittests,audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/460009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1954 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-29 12:09:44 +00:00
braveyao@webrtc.org
d713143d99 To support playing mono file with stereo codec as mixing with microphone capture 
BUG=413
TEST=Manual test.
Review URL: https://webrtc-codereview.appspot.com/460004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1953 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-29 10:39:44 +00:00
marpan@webrtc.org
cf706c2b92 Removing the resetting/re-init of encoder from QMVideoSettingsCallback. 
This is not neeeded anymore as a change of frame size (down-sampling via QM callback) will trigger a new key frame in encoder.
Review URL: https://webrtc-codereview.appspot.com/456007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1950 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 21:04:13 +00:00
andrew@webrtc.org
952f601405 Fix Linux-release errors and Valgrind errors. 
BUG=
TEST=build on Linux release.
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/456008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1949 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 18:30:26 +00:00
andrew@webrtc.org
61b1b4b472 Fix neteq-rtpplay Linux build errors. 
BUG=
TEST=build on Linux.
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/457007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1948 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 17:33:29 +00:00
andrew@webrtc.org
f589dfede4 Merge header-only neteq-rtpplay changes. 
TEST=build

Review URL: https://webrtc-codereview.appspot.com/452003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1947 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 17:05:44 +00:00
leozwang@webrtc.org
258d1d4ce0 Update build support for android 
Review URL: https://webrtc-codereview.appspot.com/459007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1946 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 16:40:04 +00:00
mflodman@webrtc.org
620bae5442 ViE ChannelManager - added missing return. 
BUG=C10613
TEST=

Review URL: https://webrtc-codereview.appspot.com/458007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1944 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 13:06:30 +00:00
bjornv@webrtc.org
78f0cdc191 VAD refactoring 
* Added TODO comment
* Updated unit test
* Code style changes and added comments to set_mode()

BUG=
TEST=vad_unittests, audioproc_unittest, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/460006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1943 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 11:06:29 +00:00
mflodman@webrtc.org
534a435751 Removed RTP Keepalive from RTP module. 
Review URL: https://webrtc-codereview.appspot.com/455007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1942 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 06:57:41 +00:00
niklas.enbom@webrtc.org
40197d7b3b Fixing build issus on non-Win 
TBR: bjornv
Review URL: https://webrtc-codereview.appspot.com/460005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1940 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-26 08:45:47 +00:00
niklas.enbom@webrtc.org
5398d9583b Force commit of 449006' 
Review URL: https://webrtc-codereview.appspot.com/455006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1939 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-26 08:11:25 +00:00
stefan@webrtc.org
38f247d800 Fixes an issue in the FEC decoder where a big jump in sequence numbers may cause new packets to be discarded if there is a wrap around. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/455003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1934 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 22:34:14 +00:00
stefan@webrtc.org
af5ffd5bb9 Fixes for coverity warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/461001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1933 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 16:01:15 +00:00
tina.legrand@webrtc.org
196e491c46 Adding init decode slave to celt 
Minor rearanging of calls. Added a init function to the slave channel of CELT.

Review URL: https://webrtc-codereview.appspot.com/458005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1931 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 14:39:46 +00:00
tina.legrand@webrtc.org
c231e4cb03 Fixing bug in re-packing of stereo packets. 
BUG=341
TEST=voe_cmd_test, run G.722. First modify /src/modules/audio_coding_main/source/acm_codec_database.cc
@@ -149,7 +149,7 @@ const CodecInst ACMCodecDB::database_[] = {
   {kDynamicPayloadtypes[count_database++], "CELT", 32000, 320, 2, 64000},
 #endif
 #ifdef WEBRTC_CODEC_G722
-  {9, "G722", 16000, 320, 1, 64000},
+  {9, "G722", 16000, 320, 2, 64000},
 #endif
 #ifdef WEBRTC_CODEC_G722_1

Review URL: https://webrtc-codereview.appspot.com/454001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1930 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 10:01:11 +00:00
mflodman@webrtc.org
3e820e5109 Remove RTP Keep-alive from VoE and ViE. The RTP module functionality will be removed in a follow-up CL shortly. 
TEST=VoE autotest and ViE autotest

Review URL: https://webrtc-codereview.appspot.com/458002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1929 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 09:41:44 +00:00
pwestin@webrtc.org
1f569222b2 Clean up coverity warnings. 
Review URL: https://webrtc-codereview.appspot.com/456003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1928 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 09:04:16 +00:00
stefan@webrtc.org
710401bab2 Add timeout for REMB bandwidth estimates. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/458004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1925 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 01:23:55 +00:00
phoglund@webrtc.org
4aa57b4150 Extracted a helper library from vie_auto_test. 
This CL does not attempt to fix the style issues in the moved tb_ files, at least not yet. In general I've tried to avoid dependencies between the library and vie_auto_test: vie_auto_test depends on the library but not the other way around. I had to make some slight changes to achieve this. I had to remove some ViETest::Log statements in tb_interfaces.cc and I had to move knowledge of where to put output files to the library. I think it ended up being pretty clean in the end but let me know if I missed something. I tried to convert all paths I touched to src-relative paths, so look out if I missed something there.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/450004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1923 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-22 12:56:54 +00:00
stefan@webrtc.org
c8e4886774 Upgrade libvpx to 6b66c01 and enabling temporal denoising. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/448006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1921 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-21 16:52:03 +00:00
phoglund@webrtc.org
aaf62ac019 Temporarily disabled flaky tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/446010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1919 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-21 08:04:43 +00:00
marpan@webrtc.org
6503ecdc39 Fix to windows test from commit 1914. 
Review URL: https://webrtc-codereview.appspot.com/455002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1917 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-21 00:18:13 +00:00
marpan@webrtc.org
3fe3252cb3 Fix to windows build from commit 1914. 
Review URL: https://webrtc-codereview.appspot.com/456002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1916 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-20 22:13:24 +00:00
stefan@webrtc.org
e0d6fa4c66 Adding classes for handling multi-frame FEC. 
The FEC behavior is unchanged with this commit, we will still be
limited to FEC over one frame for now.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/450006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1915 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-20 22:10:56 +00:00
marpan@webrtc.org
e22d81ce4d Updates to resolution adpatation: 
-moved calculation of selected frame size & frame rate to qm_select class.

-various updates to qm_select class (switch to 1/2 from 2 stages of 3/4, 
include native frame rate for going up temporal, favor spatial action for temporal layers,..).

-updates to unittest.
Review URL: https://webrtc-codereview.appspot.com/450008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1914 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-20 18:21:53 +00:00
bjornv@webrtc.org
a496b03c78 VAD refactoring: Removed macro file. 
In this CL we've replaced the VAD macros with static const or enum.

Priority=low

BUG=
TEST=vad_unittest

Review URL: https://webrtc-codereview.appspot.com/453004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1913 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-20 12:53:06 +00:00
leozwang@webrtc.org
ac9fd8af09 Change folder name from Android to android 
Review URL: https://webrtc-codereview.appspot.com/447012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1912 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-19 21:09:42 +00:00
stefan@webrtc.org
b9c50b68bf Revert commit 1908. 
Review URL: https://webrtc-codereview.appspot.com/452009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1909 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-17 00:56:36 +00:00
stefan@webrtc.org
fb5944edf9 Upgrade libvpx to 6b66c01 and enabling temporal denoising. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/448006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1908 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-17 00:15:13 +00:00
leozwang@webrtc.org
a3736345dd Introduced WEBRTC_ANDROID_PLATFORM_BUILD and make test app build on all platforms 
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/446012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1907 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-16 21:36:00 +00:00
leozwang@webrtc.org
1c7d8827ee Enable video engine 
Review URL: https://webrtc-codereview.appspot.com/449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1906 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-16 18:09:10 +00:00
leozwang@webrtc.org
9a85d8e3dd Remove test apps from Android.mk in APM 
BUG=
TEST=build on android and pc platforms
Review URL: https://webrtc-codereview.appspot.com/448005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1905 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-16 18:03:18 +00:00
kma@webrtc.org
bb966ca835 Optimized function WebRtcSpl_ScaleAndAddVectorsWithRound() for ARM-NEON platforms, and refactor it for generic C. 
We removed it out of ilbc_specific_functions.c, since it's used not only in iLBC.

Passed the unit test.
Review URL: https://webrtc-codereview.appspot.com/426009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1904 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-16 16:29:37 +00:00
phoglund@webrtc.org
7e26ad3828 Disabled more flaky volume tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/451012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1902 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-16 09:46:52 +00:00
andrew@webrtc.org
61bf8e33c4 Flush far-end buffers when larger than system delay. 
Add a helper function to manage far-end buffer moves.

BUG=issue362
TEST=manually with audioproc

Review URL: https://webrtc-codereview.appspot.com/447007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1899 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-15 19:04:55 +00:00
leozwang@webrtc.org
3053702698 Remove -lasound and -lpulse linking flags 
BUG=365
TEST=build on linux
Review URL: https://webrtc-codereview.appspot.com/446007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1898 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-15 18:34:13 +00:00
xians@webrtc.org
5b6d3ce598 adding back external media api since it is used in chromium unittest 
Review URL: https://webrtc-codereview.appspot.com/452006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1896 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-15 14:40:00 +00:00
xians@webrtc.org
a0866c10dd adding back the file api for chromium unittests. 
Review URL: https://webrtc-codereview.appspot.com/451013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1894 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-15 13:06:41 +00:00
tina.legrand@webrtc.org
0e0390dc33 Flush NetEQ when receiving payload type switches between mono and stereo. 
TEST=voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/448004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1893 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-15 11:23:51 +00:00
pwestin@webrtc.org
2058fee396 Change call order. 
Review URL: https://webrtc-codereview.appspot.com/451011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1887 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-14 13:24:53 +00:00
andrew@webrtc.org
62283c0ebf Quick fix to avoid non-causal AEC signals on PulseAudio. 
BUG=340
TEST=manually with voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/451007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1884 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-13 19:43:47 +00:00
leozwang@webrtc.org
24c65840de Remove video from Android.mk 
Review URL: https://webrtc-codereview.appspot.com/453002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1883 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-13 17:22:44 +00:00
wu@webrtc.org
60c8b39ede Fix the WebRtc_Word8 and char mismatch for the chromium build. 
Review URL: https://webrtc-codereview.appspot.com/446005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1882 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 23:59:11 +00:00
leozwang@webrtc.org
3a39230fdf Further cleanup WebRtc_Word8 in external video capture 
Review URL: https://webrtc-codereview.appspot.com/450003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1881 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 21:03:38 +00:00
wu@webrtc.org
6e6ea04f9b Implement the TickTime::Now for mac using mach_absolute_time which is consistent even the user changes the system time. 
Review URL: https://webrtc-codereview.appspot.com/431004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1879 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 19:42:22 +00:00
leozwang@webrtc.org
c197b12d21 Typedef WebRtc_word8 to int8_t 
BUG=311
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/446002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1877 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 16:52:28 +00:00
perkj@webrtc.org
3d42eda962 Fix wrong usage of memset in vie_auto_test ViEAutoTest::ViENetworkAPITest. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/451006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1876 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 15:49:28 +00:00
perkj@webrtc.org
ebb2f7b6f6 Fix errors in ViEAutoTest::ViENetworkAPITest(). 
BUG=
TEST= ViEAutoTest::ViENetworkAPITest

Review URL: https://webrtc-codereview.appspot.com/451004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1875 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 12:26:53 +00:00
bjornv@webrtc.org
ed700db014 VAD refactor: Assign functions. Mostly style changes. 
Includes
- parameter order
- type changes
- variable name changes
- comment changes
- indentations
- test changes

In addition made minor style changes.
Review URL: https://webrtc-codereview.appspot.com/384001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1874 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 12:17:26 +00:00
tina.legrand@webrtc.org
ae1c4547ee Reregister of stereo receiver didn't work. 
This CL takes care of the re-registration of codecs, and tests unregistering stereo codecs.

One bug fixed in Celt too.

TEST=audio_coding_module_test: TestStereo.

Review URL: https://webrtc-codereview.appspot.com/436002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1871 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 08:41:30 +00:00
leozwang@webrtc.org
f5516240ad Prepare future change of WebRtc_Word8 in udp module 
Review URL: https://webrtc-codereview.appspot.com/439007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1870 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 22:07:18 +00:00
kjellander@webrtc.org
2050f84b98 audio_device_test_api failing cleaner failure for Linux without audio devices. 
BUG=None
TEST=audio_device_test_api on Linux.

Review URL: https://webrtc-codereview.appspot.com/447002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1869 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 14:22:27 +00:00
pwestin@webrtc.org
b594f4314a Fix for set local SSRC 
Review URL: https://webrtc-codereview.appspot.com/451002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1868 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 12:31:52 +00:00
tina.legrand@webrtc.org
0dab9e1523 Revert of r1859 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1866 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 10:03:09 +00:00
pwestin@webrtc.org
c637c40275 Removed deregister of default codec payload type. 
Review URL: https://webrtc-codereview.appspot.com/451001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1865 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 09:32:28 +00:00
henrika@webrtc.org
907bc55c19 Removes WebRtc_Word8 dependecy in the AudioDeviceModule. 
This CL also modifies the ADM callback interface and introduces void* instead of WebRtc_Word8*
as pointer types for data buffers. This change also affects the VoiceEngine.
Review URL: https://webrtc-codereview.appspot.com/443001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1863 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 08:59:19 +00:00
kjellander@webrtc.org
67fdd70e1b Refactoring audio_device_test_api for gtest and execution on all platforms. 
All the code that was previously in one single function is now broken up into 44 gtest tests. The creation of the Audio Device is done once (SetUpTestCase) and the audio device is initialized before each test (SetUp) and terminated after each test (TearDown). Doing this, the things that execute are basically the same since the test was structured as different sections separated by these calls:
TEST(audioDevice->Terminate() == 0);
TEST(audioDevice->Init() == 0);

I also cleaned up some unused helper functions and removed old test macros when replacing them by gtest macros.

The parts that are failing for Mac and Windows are excluded using #ifdef. Separate issues are filed for
this code to be fixed.

Formatting is updated to follow the WebRTC style guide.

BUG=None.
TEST=audio_device_test_api in Debug+Release on Linux, Mac and Windows. Test run audio_device_test_func on Linux.

Review URL: https://webrtc-codereview.appspot.com/437002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1861 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 08:11:04 +00:00
andrew@webrtc.org
8012474552 Use a const rather than macro for EcDefault. 
- This should be a better solution to the build error in
  https://webrtc-codereview.appspot.com/425005
- Ideally all of the similar macros should go away, but one thing at
  a time...

BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/438002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1860 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 17:54:24 +00:00
tina.legrand@webrtc.org
f1befad273 Reregister of stereo receiver didn't work. 
This CL takes care of the re-registration of codecs, and tests unregistering stereo codecs.

One bug fixed in Celt too.

TEST=audio_coding_module_test: TestStereo.

Review URL: https://webrtc-codereview.appspot.com/436002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1859 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 13:23:18 +00:00
phoglund@webrtc.org
0e8b52c012 Rolled back and re-adapted the codec test. 
I don't really think this solves the problem and it makes the code worse, but it seems to make the vie_auto_test binary usable again. I've never seen it chrash on the standard tests since I rewrote it. It can still chrash on the API tests and extended tests though, which indicates that there is a fundamental design / threading problem somewhere, like we suspected. I think this is a kind of progress for now since we can use vie_auto_test to detect new errors again.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/425003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1857 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 09:19:31 +00:00
mflodman@webrtc.org
7845d07bf8 VideoCapture now uses pointer constructor of CriticalSectionScoped. 
BUG=184
TEST=video_capture_module compiles on all platforms when removing ref ctor of CriticalSectionScoped.

Review URL: https://webrtc-codereview.appspot.com/434001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1855 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 08:09:17 +00:00
marpan@webrtc.org
accf607b3e Updates for resolution adaptation. 
1) added support for two additional modes: 
    -3/4 spatial down-sampling
    -2/3 frame rate reduction
2) updated unittest and added a few more tests
3) some code refactoring
Review URL: https://webrtc-codereview.appspot.com/429005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1854 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-07 17:16:10 +00:00
mflodman@webrtc.org
9a065d1eae VoiceEngine now uses pointer constructor of CriticalSectionScoped, instead of reference. 
BUG=184
TEST=Compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/436001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1853 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-07 08:12:21 +00:00
leozwang@webrtc.org
1d27039612 Disable CreateWindowManagerForCurrentPlatform on android 
Review URL: https://webrtc-codereview.appspot.com/436003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1852 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 22:48:43 +00:00
leozwang@webrtc.org
30185916aa Fix error in test app which was introduced when payload type was converted to int 
TBR=mflodman, phoglund
Review URL: https://webrtc-codereview.appspot.com/439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1851 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 21:43:55 +00:00
leozwang@webrtc.org
57da718734 Fix building errors on android 
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/441001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1850 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 21:28:48 +00:00
leozwang@webrtc.org
77fe431f57 Enable video render test on android 
Review URL: https://webrtc-codereview.appspot.com/428006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1849 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 20:59:55 +00:00
leozwang@webrtc.org
0975d2158c Cleanup messy data type of unknown_payload_type 
BUG=322
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/430002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1848 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 20:59:13 +00:00
andrew@webrtc.org
8b111eb3e6 Reformat voe_audio_processing_impl to Goog style. 
TBR=xians@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/439003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1847 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 19:50:12 +00:00
andrew@webrtc.org
6f9f817e06 Add an API to offset system delay. 
Plumb it through VoiceEngine.

BUG=
TEST=voe_auto_test,audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/428010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1846 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 19:03:39 +00:00
mflodman@webrtc.org
e22c5c3870 Disable REMB test when using vivi. 
BUG=321
TEST=vie_auto_test

Review URL: https://webrtc-codereview.appspot.com/435001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1844 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 12:49:33 +00:00
mflodman@webrtc.org
0e703f4d0d VideoRender now uses pointer constructor of CriticalSectionScoped. 
BUG=184
TEST=video_render_module compiles on all platforms when removing ref ctor of
CriticalSectionScoped.

Review URL: https://webrtc-codereview.appspot.com/427004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1843 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-06 12:02:20 +00:00
mflodman@webrtc.org
3e664faad6 Temporarily disabling flaky RTP test. 
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/430004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1842 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 20:30:35 +00:00
leozwang@webrtc.org
53ed5a41a2 Fix building errors and enable test app 
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/428008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1841 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 20:15:58 +00:00
leozwang@webrtc.org
db2de5b49f Fix building errors on android 
TBR=Tina

BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/430001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1840 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 19:53:24 +00:00
leozwang@webrtc.org
66487e1629 Enable video test on android 
Review URL: https://webrtc-codereview.appspot.com/429006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1839 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 19:34:06 +00:00
leozwang@webrtc.org
8ea37f4f26 Fix building error on windows 
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/427006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1838 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 18:05:08 +00:00
mflodman@webrtc.org
c7ae13da42 Update makefile. 
TBR=leozwang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/430003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1837 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 17:34:05 +00:00
mflodman@webrtc.org
9ec883e8bd Allow multiple REMB groups and introduce receive channels. 
BUG=312
TEST=ViE standard autotest and API test.

Review URL: https://webrtc-codereview.appspot.com/432005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1836 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 17:12:41 +00:00
leozwang@webrtc.org
855ced7336 Further cleanup WebRtc_Word8 
Review URL: https://webrtc-codereview.appspot.com/426008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1835 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 16:07:51 +00:00
leozwang@webrtc.org
e47efe291e Fix building error on android 
Review URL: https://webrtc-codereview.appspot.com/425005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1834 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 16:05:30 +00:00
mflodman@webrtc.org
fa6bc673b0 Changed default module condition for BW estimate. 
Review URL: https://webrtc-codereview.appspot.com/433001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1832 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 11:59:55 +00:00
leozwang@webrtc.org
42e362eee5 Fix compilation error on android 
Review URL: https://webrtc-codereview.appspot.com/426006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1830 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 17:14:09 +00:00
leozwang@webrtc.org
3197d48407 Enable audio device test on android 
Review URL: https://webrtc-codereview.appspot.com/428005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1829 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 17:12:14 +00:00
leozwang@webrtc.org
c868b99ff3 Remove building errors in autotest 
Review URL: https://webrtc-codereview.appspot.com/432004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1828 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 17:02:51 +00:00
marpan@webrtc.org
26762e3e40 Allow for spatial-downsampling without reinitializaing encoder. Change of frame 
size will automatically trigger new key frame in codec. This feature is set off
in video engine until we upgrade to a newer version of libvpx.
Review URL: https://webrtc-codereview.appspot.com/427003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1827 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 16:48:36 +00:00
leozwang@webrtc.org
fa8c9f7a4f Remove unused variable 
Review URL: https://webrtc-codereview.appspot.com/432003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1823 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-02 07:15:03 +00:00
andrew@webrtc.org
d62d7301f4 Remove TARGET_PC and cruft from typedefs.h. 
Additionally remove all TARGET defines (e.g. TARGET_MAC), which weren't used anyway.

BUG=
TEST=build on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/432001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1822 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 21:39:57 +00:00
andrew@webrtc.org
fa2f5627ca Change error code. 
TBR=henrika@webrtc.org
BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1821 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 21:19:01 +00:00
kma@webrtc.org
beb1851c2a Refactored and further optimized WebRtcSpl_MaxAbsValueW16() function in splib. 
Review URL: https://webrtc-codereview.appspot.com/395008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1820 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 20:03:26 +00:00
leozwang@webrtc.org
c9a3b81fd2 Further cleanup WebRtc_Word8 in video_capture on mac 
BUG=311
TBR=Wu, Mallinath
Review URL: https://webrtc-codereview.appspot.com/431002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1819 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 19:59:52 +00:00
leozwang@webrtc.org
4add6bc603 Fix building errors on window which caused by previous cl 
BUG=311
TBR=Wu, Mallinath
Review URL: https://webrtc-codereview.appspot.com/432002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1818 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 19:57:13 +00:00
leozwang@webrtc.org
09e771998c Correct WebRtc_word8 usage in media file module 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/427002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1817 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:35:54 +00:00
leozwang@webrtc.org
813e4b0af0 Correct WebRtc_Word8 in voice engine 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/425002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1816 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:34:25 +00:00
leozwang@webrtc.org
39e9659fc6 Correct wrong usage of WebRtc_Word8 in video enigne 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/428002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1815 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:22:48 +00:00
leozwang@webrtc.org
28f3913ca9 Correct WebRtc_Word8 in adm 
Correct WebRtc_Word8 usage in adm

BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=buidl on all platforms

Review URL: https://webrtc-codereview.appspot.com/428001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1814 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 18:01:48 +00:00
leozwang@webrtc.org
af1f792cc3 nits 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1813 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 16:31:06 +00:00
leozwang@webrtc.org
0689271d64 nits 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1812 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 16:31:00 +00:00
leozwang@webrtc.org
1745e932cc Correct wrong usage of WebRtc_Word8 in video capture 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1811 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 16:30:40 +00:00
tina.legrand@webrtc.org
1f2cabaecd Crash when deleting Celt. 
BUG=issue 6087770
TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/420001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1805 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 08:46:09 +00:00
kjellander@webrtc.org
c81012b8e5 Fixing invalid linking for Linux that obviously wasn't properly tested in the cleanup of http://webrtc-codereview.appspot.com/406002/ 
TBR=mflodman
BUG=None
TEST=Compiled on Linux Debug+Relase.

Review URL: https://webrtc-codereview.appspot.com/425001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1803 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 21:28:22 +00:00
kjellander@webrtc.org
132eccbb69 Renamed platform specific code to use GYP conventions. 
Restructured GYP files a bit to clean up things.
Removed copying of images to /tmp
Fixed output location of DumpFileName.rtp.

BUG=None
TEST=Tested compiling and running on Mac, Win, Linux.

Review URL: https://webrtc-codereview.appspot.com/406002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1802 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 20:55:25 +00:00
andrew@webrtc.org
eaefea665f Remove unused files from src/build. 
These files were intended for a standalone build without depending on
Chromium's build/. In some bright future we might use them, but for
the moment, they're just confusing.

BUG=
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/416002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1800 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 18:19:34 +00:00
andrew@webrtc.org
0e28566247 Only reset AudioProcessing if number of channels has changed. 
Calling SetSendCodec() would always reset AudioProcessing.

BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/417002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1799 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 17:00:56 +00:00
leozwang@webrtc.org
07c68b9c9d Correct wrong usage of WebRtc_Word8 in rtp and udp module 
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms

Review URL: https://webrtc-codereview.appspot.com/418001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1798 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 16:09:51 +00:00
phoglund@webrtc.org
2d124f3d88 Enabled the volume tests we believe are nonflaky and the vie_auto_test extended tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/422002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1797 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 14:34:06 +00:00
mflodman@webrtc.org
6a60dbe81f Correcting ViE RTP RTCP autotest. 
Review URL: https://webrtc-codereview.appspot.com/417003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1793 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 07:06:49 +00:00
marpan@webrtc.org
4788bf4256 Fix to warnings on windows. 
Review URL: https://webrtc-codereview.appspot.com/415004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1792 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-29 01:11:39 +00:00
marpan@webrtc.org
9d76b4ea54 Updates for resolution adaptation: 
1) code cleanup and some updates to selection logic for qm_select.
2) added unit test for the QmResolution class.
3) update codec frame size and reset/update frame rate in media-opt:
4) removed unused motion vector metrics and some related code of content metrics processing.
Review URL: https://webrtc-codereview.appspot.com/405008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1791 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 23:39:31 +00:00
andrew@webrtc.org
c3cb0ca726 Enable -Woverloaded-virtual for gcc. 
BUG=
TEST=build on Linux/gcc.

Review URL: https://webrtc-codereview.appspot.com/417001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1790 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 23:14:11 +00:00
leozwang@webrtc.org
785db5a2a5 Enable rw_lock_posix on andorid 
Review URL: https://webrtc-codereview.appspot.com/404002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1789 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 23:10:03 +00:00
andrew@webrtc.org
547c157a49 Temporarily use _Word8 to avoid clang error. 
BUG=issue311
TEST=build on clang

Review URL: https://webrtc-codereview.appspot.com/415003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1788 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 22:30:30 +00:00
leozwang@webrtc.org
91b359ea9b Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/407003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1787 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 17:26:14 +00:00
mflodman@webrtc.org
1a739bab59 Add StartSend check. 
Review URL: https://webrtc-codereview.appspot.com/414002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1783 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 16:11:33 +00:00
stefan@webrtc.org
4ce0ba00de Fix issue 310. 
BUG=310
TEST=session_info_unittest.cc

Review URL: https://webrtc-codereview.appspot.com/404004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1782 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 12:09:09 +00:00
pwestin@webrtc.org
14b0247f01 Silently ignore error from RegisteModule 
Review URL: https://webrtc-codereview.appspot.com/413001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1781 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 11:01:52 +00:00
henrike@webrtc.org
26085e18e0 Coverity fixes for module/media_file. 
BUG=Coverity report.
TEST=N/A.

Review URL: https://webrtc-codereview.appspot.com/397003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1780 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 21:50:40 +00:00
leozwang@webrtc.org
ead7d25c1a Revert r1775 which caused building errors. 
TBR=pwestin@webrtc.org, mflodman@webrtc.org

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1778 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:45:09 +00:00
leozwang@webrtc.org
2559cbf7b7 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/405003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1777 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:18:25 +00:00
leozwang@webrtc.org
3e9e0f0497 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/405004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1776 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:17:38 +00:00
leozwang@webrtc.org
adb89f56e0 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/405005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1775 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 19:12:19 +00:00
xians@webrtc.org
cf1b6aec30 iReduced the flakiness of the volume tests in linux pulseaudio 
Review URL: https://webrtc-codereview.appspot.com/390013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1774 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 17:22:49 +00:00
phoglund@webrtc.org
13e8528f32 Fixed silly error on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/408007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1773 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 16:27:50 +00:00
phoglund@webrtc.org
52b59d095e Implemented bit flipping fuzz test. 
Moved random encryption to its own file.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/392017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1771 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 15:29:52 +00:00
mflodman@webrtc.org
b4556cd29a Enabling mjpg for Windows. 
BUG=306
TEST=ViE loopback call on windows with resolution 960x720
Review URL: https://webrtc-codereview.appspot.com/411003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1770 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 14:02:12 +00:00
stefan@webrtc.org
1bb1da4c30 Enable MFQE if we are recieving temporal layers. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/411002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1769 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 13:52:34 +00:00
mflodman@webrtc.org
f3811194a5 Enable mjpg capture for Linux. 
BUG=306
TEST=ViE Loopback test using resolution larger than 640x480.

Review URL: https://webrtc-codereview.appspot.com/411001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1768 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-27 08:10:17 +00:00
punyabrata@webrtc.org
c29280d767 webrtc::CpuWindows::ProcessImpl() nullref crash resolution [6061101] 
Review URL: https://webrtc-codereview.appspot.com/410004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1766 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 19:17:25 +00:00
leozwang@webrtc.org
a68f05e841 Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/410001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1765 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 16:08:52 +00:00
mflodman@webrtc.org
c3a73bb182 Add null termination to test string. 
BUG=307
TEST=out/Debug/vie_auto_test --automated --gtest_filter=ViEExtendedIntegrationTest.RunsRtpRtcpTestWithoutErrors

Review URL: https://webrtc-codereview.appspot.com/408005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1764 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 14:25:10 +00:00
mflodman@webrtc.org
2f6104bb93 Relanding r1749. 
BUG=306
TEST=libyuv_unittests

Review URL: https://webrtc-codereview.appspot.com/410002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1762 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 11:53:49 +00:00
mflodman@webrtc.org
8df260023b Prepared for MJPG capture without using MJPG DirectShow filter. MJPG is temporarily disabled and will enabled as soon as MJPG->I420 conversion is available. 
Review URL: https://webrtc-codereview.appspot.com/397011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1761 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-24 10:06:30 +00:00
kma@webrtc.org
bfa7f96d1e Optimized WebRtcSpl_ComplexBitReverse() for general ARM platforms and generic C. 
In ARMv5, the cycles were reduced by 88% (weight in VoE reduced from 3.554% to 0.432%). The tradeoff is a memory increase of 704 bytes.
Review URL: https://webrtc-codereview.appspot.com/388003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1757 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 22:38:56 +00:00
andrew@webrtc.org
3cc03be51f Remove deleted file from vie_auto_test.gypi. 
TBR=phoglund@webrtc.org
BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/408002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1756 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 22:05:24 +00:00
marpan@webrtc.org
946601e408 Change default packetization mode to an equal size mode. 
This will produce equal size packets for each frame, which should be somewhat more favorable (less overhead/padding data) for the FEC.
Review URL: https://webrtc-codereview.appspot.com/396013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1754 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 18:52:53 +00:00
henrike@webrtc.org
70efc3250d Factory method for the ADM in the interface file. 
BUG=N/A
TEST=no

Review URL: https://webrtc-codereview.appspot.com/396017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1753 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 17:45:33 +00:00
xians@webrtc.org
6eb0ca2e75 Two problems are fixed: 
#1, avoid leaving the lock without entering the lock.
#2, race problems in variables like _playError, _recError, _recWarning, _playWarning.
Review URL: https://webrtc-codereview.appspot.com/400006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1751 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 10:39:53 +00:00
mflodman@webrtc.org
a556b0d193 Reverting r1749. 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1750 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 10:15:04 +00:00
mflodman@webrtc.org
cb57f9ba95 Updated libyuv revision to include mjpg and added mjpg to type conversion. 
BUG=306
TEST=libyuv_unittests

Review URL: https://webrtc-codereview.appspot.com/407001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1749 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 09:47:07 +00:00
mflodman@webrtc.org
4f9e44f5c5 Prepared for MJPG capturing on Linux. MJPG is conversion is not available in libyuv yet, so this CL is only made as preparation. 
When this is available in libyuv, I'll remove the ifdef.

BUG=306
TEST=Manual loopback test with a high resolution, verify high FR.

Review URL: https://webrtc-codereview.appspot.com/397008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1748 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 09:00:26 +00:00
leozwang@webrtc.org
682cd4e9d1 Add android target 
Review URL: https://webrtc-codereview.appspot.com/396016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1746 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 16:05:19 +00:00
leozwang@webrtc.org
4ad4c24092 Add android to audio device module 
Review URL: https://webrtc-codereview.appspot.com/402001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1745 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 16:04:59 +00:00
stefan@webrtc.org
0fe2171b59 Relax libyuv test threshold and upgrade to libyuv r182. 
BUG=http://code.google.com/p/webrtc/issues/detail?id=267
TEST=

Review URL: https://webrtc-codereview.appspot.com/391018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1742 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 11:21:18 +00:00
xians@webrtc.org
539ef94f20 Remove the deprecated kTraceModuleCall trace from audio coding module. 
Review URL: https://webrtc-codereview.appspot.com/399002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1741 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 08:35:03 +00:00
leozwang@webrtc.org
20e9cf274d Add android to video capture module 
Review URL: https://webrtc-codereview.appspot.com/399010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1740 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 00:40:45 +00:00
mallinath@webrtc.org
0d757b8610 Fixing coverity issues in capture module. 
Review URL: https://webrtc-codereview.appspot.com/399008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1736 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 16:47:55 +00:00
niklas.enbom@webrtc.org
7cb0c240cb Trying to free up hellner from review work, since he mainly works in libJingle. 
Review URL: https://webrtc-codereview.appspot.com/392020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1734 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 13:58:58 +00:00
xians@webrtc.org
8435e8e3d8 Remove the deprecated kTraceModuleCall trace from audio processing module. 
Review URL: https://webrtc-codereview.appspot.com/399003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1733 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 10:37:26 +00:00
stefan@webrtc.org
a475556f5a Assume 200 ms RTT if we're only receiving. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/396012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1730 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 09:53:55 +00:00
xians@webrtc.org
20aabbb0be Remove the deprecated kTraceModuleCall trace from audio device module. 
Review URL: https://webrtc-codereview.appspot.com/396011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1729 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 09:17:41 +00:00
xians@webrtc.org
9a798d3fca Remove the deprecated kTraceModuleCall trace from video processing module. 
Review URL: https://webrtc-codereview.appspot.com/395012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1728 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 09:00:35 +00:00
phoglund@webrtc.org
b45ceed9ef Rewrote the call report test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/399006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1726 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:55:04 +00:00
xians@webrtc.org
843c8c78ff Remove the deprecated kTraceModuleCall trace from video modules. 
Review URL: https://webrtc-codereview.appspot.com/391015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1725 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:45:02 +00:00
xians@webrtc.org
6bde7a88f1 Remove the deprecated kTraceModuleCall trace from utility module. 
Review URL: https://webrtc-codereview.appspot.com/401002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1724 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:39:25 +00:00
xians@webrtc.org
57fb09ac18 Remove the deprecated kTraceModuleCall trace from udp transport module. 
Review URL: https://webrtc-codereview.appspot.com/395011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1723 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:38:21 +00:00
xians@webrtc.org
03039d56e6 Remove the deprecated kTraceModuleCall trace from media file module. 
Review URL: https://webrtc-codereview.appspot.com/392016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1722 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:37:49 +00:00
xians@webrtc.org
56cfe80c74 Remove the deprecated kTraceModuleCall trace from conference mixer. 
Review URL: https://webrtc-codereview.appspot.com/396010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1721 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-20 08:35:37 +00:00
tina.legrand@webrtc.org
145f04f0c4 Changing Celt to use stereo as default. 
Review URL: https://webrtc-codereview.appspot.com/397009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1720 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-18 00:32:16 +00:00
marpan@webrtc.org
bd5648f2db Reverting 1718: failed linux video test. 
TBR=stefan, andrew, marpan.
Review URL: https://webrtc-codereview.appspot.com/392018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1719 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 23:16:58 +00:00
marpan@webrtc.org
883e716304 Removed unused motion vector metrics from VideoContentMetrics; 
also removed other related unused variables and code. 

Reset frame rate estimate in mediaOpt when frame rate reduction is decided.

Update content_metrics with frame rate and qm_resolution with frame size.
Review URL: https://webrtc-codereview.appspot.com/395007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1718 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 18:35:23 +00:00
henrike@webrtc.org
f3760dc8e9 Fixes coverity warning that I missed in system wrappers. 
BUG=Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/395005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1717 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 16:27:25 +00:00
phoglund@webrtc.org
b3172860d7 Added a retry mechanism to vie_auto_test's verifying tests to make them less flaky. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/392015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1716 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 13:08:57 +00:00
mflodman@webrtc.org
4cb060127c Disabled RTPModule VP8 packetizer assert. 
BUG=293

Review URL: https://webrtc-codereview.appspot.com/399005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1715 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 13:07:01 +00:00
phoglund@webrtc.org
8bfee84144 Initial revision of a ViE fuzz test. The idea is to inject randomized RTP packets and see what the video engine does. 
There are some small refactorings in here, but the real focus of this CL is in vie_autotest_rtp_fuzz.cc. This patch is mostly here to get a discussion going.

On my initial test the video engine doesn't recover, at least within 10 seconds of running with untampered packets. Not sure if this is according to specification though.

Ideas:
  - Generate random packets with correct RTP headers to get further into the code.
  - Don't generate fresh random data, but rather corrupt bits here and there in small amounts.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/383001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1714 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 09:32:48 +00:00
leozwang@webrtc.org
a52838b684 Update Android.mk and add test app 
Review URL: https://webrtc-codereview.appspot.com/388010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1713 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 01:16:43 +00:00
tina.legrand@webrtc.org
79e29e510f Adding option to change bitrate for Celt. 
I have updated the code so that Celt rate can be changed to any value between 48 and 128 kbps.
Tests for both mono and stereo are updated.Updated tests for Celt mono.

Review URL: https://webrtc-codereview.appspot.com/391014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1712 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 00:38:33 +00:00
mallinath@webrtc.org
ee628358f4 Updating the object-c++ file after change in the API 
GetBestMatchedCapability
Review URL: https://webrtc-codereview.appspot.com/396009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1710 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 19:30:37 +00:00
mallinath@webrtc.org
8b4a98d0f4 Change in the interface file for GetBestMatchedCapability method. Updating mac files. 
Review URL: https://webrtc-codereview.appspot.com/389013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1709 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 19:00:28 +00:00
wu@webrtc.org
69f8be3875 Change the ExternalRenderer to provide both rtp timestamp and the render time. 
Review URL: https://webrtc-codereview.appspot.com/394006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1708 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 18:32:02 +00:00
mallinath@webrtc.org
12984f0d02 Fixing Coverity issues 
Note: This doesn't address Google Code style guidelines issues.
Review URL: https://webrtc-codereview.appspot.com/391011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1707 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 18:18:21 +00:00
xians@webrtc.org
3ab6dda5cb Truncated the volume to 255 when the users set the volume above 100%. 
Allowed the users to set the volume above 100% when AGC is enabled, in this case AGC can gradually scale down the volume instead of jumping to 100% immediately.
Reduced the flakiness of the volume tests in linux.
Review URL: https://webrtc-codereview.appspot.com/387011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1706 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 18:15:54 +00:00
mflodman@webrtc.org
f7b6078f6f Allow multiple send channels for REMB. Current implementation splits the remote estimate evenly between all senders. 
This CL will be followed by a CL adding support for several REMB groups.

TEST=video_engine_core_unittests

Review URL: https://webrtc-codereview.appspot.com/394002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1705 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 14:50:24 +00:00
stefan@webrtc.org
439be29445 Add APIs for getting receive-side estimated bandwidth and codec target rate. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1704 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 14:45:37 +00:00
braveyao@webrtc.org
590e5eb283 Convert audio layer to WAV on Vista RTM(without any Service Pack) 
Review URL: https://webrtc-codereview.appspot.com/397001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1702 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 03:21:05 +00:00
henrike@webrtc.org
d6d014ff12 Fixes memory leaks introduced in 1698. 
Review URL: https://webrtc-codereview.appspot.com/387014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1701 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 02:18:09 +00:00
andrew@webrtc.org
cb333530fc Remove common_settings.gypi. 
Now fully replaced by src/build/common.gypi.

BUG=
TEST=build

Review URL: https://webrtc-codereview.appspot.com/395003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1699 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-16 01:16:28 +00:00
henrike@webrtc.org
f5da4da409 Removes a global non POD instance from the RTP_RTCP module that was introduced in https://code.google.com/p/webrtc/source/detail?r=1076. 
Review URL: https://webrtc-codereview.appspot.com/314001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1698 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 23:54:59 +00:00
leozwang@webrtc.org
0a272eb44b Disable SetAffinity on android 
CPU_ macros are only available in android source tree, not in NDK. Disable it for now. 
Review URL: https://webrtc-codereview.appspot.com/392008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1697 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 22:35:29 +00:00
henrike@webrtc.org
05e0601160 Fixes coverity warnings in the udp_transport module. 
BUG=Coverity warnings.
TEST=N/A.

Review URL: https://webrtc-codereview.appspot.com/392012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1696 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 19:43:51 +00:00
henrike@webrtc.org
6b9253eb4f Fixe issues reported by Coverity for modules/utility. 
BUG=From Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/389011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1695 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 18:48:16 +00:00
kjellander@webrtc.org
cd46385142 Fixing Android.mk for jpeg library 
TBR=leozwang
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1692 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 10:12:52 +00:00
kjellander@webrtc.org
0a57aae75b Converted old jpeg_test tool to gtest unit test. 
Restructured paths to new directory layout.

Stefan: common_video/*
Magnus: video_engine/*
Niklas: Android.mk

BUG=
TEST=jpeg_unittests on Debug+Release on Linux, Mac, Windows. Valgrind on Linux passes without warnings.

Review URL: https://webrtc-codereview.appspot.com/388007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1691 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 09:47:55 +00:00
andrew@webrtc.org
8bd6f19abe Disable flaky CpuTest.Usage on Windows. 
TBR=turaj@webrtc.org
BUG=290
TEST=system_wrapper_unittests

Review URL: https://webrtc-codereview.appspot.com/396005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1689 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 01:47:51 +00:00
henrike@webrtc.org
b38a66aaac Fixes a coverity warning in the mixer module. 
Review URL: https://webrtc-codereview.appspot.com/388009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1688 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-15 00:04:27 +00:00
marpan@webrtc.org
79a99de8e4 Reverting 1680: valgrind memory leak reported. 
TBR=marpan
Review URL: https://webrtc-codereview.appspot.com/392011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1686 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 22:37:10 +00:00
marpan@webrtc.org
738bcdc4ee Fix to coverity issue 10339. 
Review URL: https://webrtc-codereview.appspot.com/391010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1685 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 20:54:57 +00:00
andrew@webrtc.org
737c023e42 Properly disable sse2 source on non-x86. 
BUG=
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/387008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1684 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 19:57:50 +00:00
braveyao@webrtc.org
59d6cec291 Fix the crash at playing 48kHz stereo wav file. 
http://code.google.com/p/webrtc/issues/detail?id=208
Review URL: https://webrtc-codereview.appspot.com/396001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1681 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 18:17:16 +00:00
marpan@webrtc.org
4e34dcbd62 Allow for spatial-downsampling without reinitializaing encoder. Change of frame size will automatically trigger new key frame in codec. This feature is set off in vie_encoder until we upgrade to the new libvpx. 
Also reset frame rate estimate in mediaOpt when frame rate reduction is decided.
Review URL: https://webrtc-codereview.appspot.com/390006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1680 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 17:26:24 +00:00
mflodman@webrtc.org
d7d46887a6 Update receive only channels with RTT. 
vie_autotest_loopback.cc will not be part of the commit, it's only to show the test.

TEST=temporary with attached loopback test.

Review URL: https://webrtc-codereview.appspot.com/390007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1678 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-14 12:49:59 +00:00
pwestin@webrtc.org
c76c096c19 Bugfix issue 273, workaround for compiler issue. 
Review URL: https://webrtc-codereview.appspot.com/392005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1675 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-13 09:56:57 +00:00
pwestin@webrtc.org
52fd98d876 Removing encoder reset. Function did not make sence. 
Review URL: https://webrtc-codereview.appspot.com/391005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1674 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-13 09:03:53 +00:00
marpan@webrtc.org
567d507707 Fixes a bug when number of media packets in a frame is larger than maximum allowed for the generateFEC. 
Review URL: https://webrtc-codereview.appspot.com/391003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1673 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 18:56:14 +00:00
phoglund@webrtc.org
292da24166 New attempt. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1672 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 15:21:33 +00:00
phoglund@webrtc.org
dbe1e13b53 Fixed compilation error on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1670 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 14:03:44 +00:00
mflodman@webrtc.org
8224e19dd9 Fixed incorrect packet loss reported to encoder. 
BUG=275

Review URL: https://webrtc-codereview.appspot.com/394004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1669 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 12:41:57 +00:00
phoglund@webrtc.org
6b3bb89f12 Rewrote file test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1668 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 12:14:54 +00:00
pwestin@webrtc.org
5e954814a8 Clanup handling of key frame requests and FIR. 
Review URL: https://webrtc-codereview.appspot.com/387004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1667 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-10 12:13:12 +00:00
andrew@webrtc.org
75f1948b0e Restore AECM Coverity fix. 
Add a test which would have caught the crash introduced by r1628.

BUG=274
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/388002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1657 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 17:16:18 +00:00
phoglund@webrtc.org
aaa76f3ba8 Rewrote network test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/383003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1656 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 16:41:30 +00:00
stefan@webrtc.org
4b377414f1 Fix release build errors. 
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/394005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1654 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 13:50:57 +00:00
xians@webrtc.org
3dbed8597e This CL makes the playout delay value thread safe. 
With the patch, _sndCardPlayDelay is calculated in the DoRenderThread instead of capture thread, an capture thread only gets the _sndCardPlayDelay value.
And _sndCardPlayDelay and _sndCardRecDelay are only changed to be Atomic32 to make them to be accessed by multiple threads.


Test=None
Bug=256
Review URL: https://webrtc-codereview.appspot.com/394001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1653 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 13:50:48 +00:00
stefan@webrtc.org
9c84b0dc9f Fix build errors with GCC. 
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1652 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 13:14:04 +00:00
stefan@webrtc.org
7adab0922d This removes the knowledge of frame completeness from the FEC decoder. 
Therefore, with this change a recovered packet is only considered old,
and will be removed, if more than 48 recovered packets are stored.

Packets are immediately reconstructed and sent to the jitter
buffer. Before this CL packets were processed on a frame-by-frame
basis, and all packets belonging to a frame was sent to the
jitter buffer at the same time.

The number of FEC packets is also limited to 48. An FEC packet is
removed if all protected packets have been recovered or if the
FEC packet is considered old.

Lot's of tests added.

Patch-set 2:
- Fixed rtp_fec_unittest.cc to work with the new reconstruction.
- Added reference counting of Packet to be able to keep references to them from FecPacket between different reconstruction runs.
- Rewrote the packet search to use std::set_intersection.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/379005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1651 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 12:34:52 +00:00
kjellander@webrtc.org
cf6a295b13 Making video codecs test framework integration test execute in a reproducable fashion. 
Fixed reproducable random behavior in packet_manipulator.h.
Test is now fully reproducable (runs on only one core) so much tighter limits are now set for the SSIM/PSNR values for the encoding/decoding (verified on all platforms)

BUG=
TEST=out/Debug/video_codecs_test_framework_integrationtests in Debug+Release on Linux, Mac, Windows and in Linux Valgrind.

Review URL: https://webrtc-codereview.appspot.com/381005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1649 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-09 09:01:51 +00:00
henrike@webrtc.org
d5657c2f69 Refactored files according to google style since http://review.webrtc.org/314001/ is blocked on this and formatting changes should not be done with code changes. 
Review URL: https://webrtc-codereview.appspot.com/387005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1648 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 23:41:49 +00:00
andrew@webrtc.org
68da6adafe Remove WebRtc_ types. 
Allows us to avoid the "cast to UWord32" Coverity coverup.

BUG=
TEST=test_fec

Review URL: https://webrtc-codereview.appspot.com/379002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1647 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 22:24:14 +00:00
wu@webrtc.org
454a27c13d The pthread_t is non-pointer type. 
TBR=henrike
Review URL: https://webrtc-codereview.appspot.com/392004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1646 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 20:36:23 +00:00
henrike@webrtc.org
143abd95a3 Fixes coverity warnings in system_wrappers. 
Review URL: https://webrtc-codereview.appspot.com/389003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1645 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 19:39:38 +00:00
henrike@webrtc.org
0e7c060256 Linux logs were not displaying time at ms resolution. 
Review URL: https://webrtc-codereview.appspot.com/267012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1644 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 18:53:50 +00:00
wu@webrtc.org
a8084b07e3 Revert r1628 which causes the crash of voe_auto_test. 
With r1628, it's possible the second memcpy got a NULL nearendClean.

TBR=bjornv
Review URL: https://webrtc-codereview.appspot.com/390005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1643 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 17:56:39 +00:00
tina.legrand@webrtc.org
13ac430bef Adding missing timestamp calculation to RTPencode. 
Review URL: https://webrtc-codereview.appspot.com/392002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1641 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 13:20:36 +00:00
mflodman@webrtc.org
d2940f71e4 VCM::JB critsect fix. 
Review URL: https://webrtc-codereview.appspot.com/390004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1639 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 12:42:56 +00:00
stefan@webrtc.org
23307f7c4b Remove frame_list.cc from Andorid.mk. 
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1638 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:39:13 +00:00
xians@webrtc.org
594ab3ce4b remove vie file API to take away media_file and utility modules. 
This CL reduce the size of chrome in release build by 70KB.
With this patch and r1592 , sizes.py reports 92255640 bytes with webrtc, down from 92485792 bytes.
The size is 88839360 bytes without webrtc.

BR,
/SX
Review URL: https://webrtc-codereview.appspot.com/380007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1637 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:38:12 +00:00
tina.legrand@webrtc.org
df69775bfa Adding support for full-stereo codec. 
This is an experiment, letting Celt represent a full-stereo codec.

Review URL: https://webrtc-codereview.appspot.com/379013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1636 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:22:21 +00:00
stefan@webrtc.org
2979461595 Refactored the jitter buffer to use std::list. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/352016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1635 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 08:58:55 +00:00
stefan@webrtc.org
7dfa883954 Disable spatial subsampling for denoiser variance estimation. 
With subsampling there are sometimes quite visible trailing
artifacts.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/387002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1634 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 08:27:31 +00:00
pwestin@webrtc.org
95392e64ba Bugfix EnableIPV6 issue 255 
Review URL: https://webrtc-codereview.appspot.com/378005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1633 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 08:08:37 +00:00
kjellander@webrtc.org
1970b2fcb3 Fixing uninitialized codec settings struct in test. 
BUG=
TEST=video_codecs_test_framework_unittests passing in Debug+Release on Linux, Mac and Windows.

Review URL: https://webrtc-codereview.appspot.com/378004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1632 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 07:09:32 +00:00
andrew@webrtc.org
648af7423f Clean up MapSetting(). 
- Add assert(false) for "impossible" cases.
- Remove tests for invalid enum values.
- Modify MapError() to look the same way.

BUG=
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/386001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1631 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 01:57:29 +00:00
wu@webrtc.org
9143f774d1 Coverity fix for VideoRenderModule including issues 10084, 10226, 10267 and 10340. 
Review URL: https://webrtc-codereview.appspot.com/385001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1630 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 00:14:25 +00:00
kma@webrtc.org
551fcc04ec Optimized function WebRtcSpl_DownsampleFast for ARM-NEON platform. 
Review URL: https://webrtc-codereview.appspot.com/371001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1629 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 18:03:11 +00:00
bjornv@webrtc.org
236e842bca Removed memcpy of pointer to itself, triggering Valgrind warning. 
BUG=272
Review URL: https://webrtc-codereview.appspot.com/389002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1628 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 17:22:44 +00:00
kma@webrtc.org
59f16ec993 Introduced ARM version of WebRtcSpl_SqrtFloor(). Function cycles reduced by ~ 30% in a real time VOE test in an android device (Nexus-S, ARMv7a). 
// Fritz, I added you as a reviewer for the assembly files, just as a warm-up for future storms. :-) The assembly code was from public domain and there's little to touch.
Review URL: https://webrtc-codereview.appspot.com/369017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1627 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 17:15:15 +00:00
phoglund@webrtc.org
9d9ad88ba5 Fixed remaining warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/393001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1626 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 16:16:52 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 14:56:45 +00:00
niklas.enbom@webrtc.org
87885e8409 This CL will look a bit strange. Essentially I've removed sanity checks for > 1 channel and then fixed the bugs that remained. Will add testing in a separate CL. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1623 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 14:48:59 +00:00
bjornv@webrtc.org
530963925e Solves buffer overrun crash on Windows [issue 258]. 
Removed function calls not tested. Added a TODO on activating them when refactoring signal_processing.
Review URL: https://webrtc-codereview.appspot.com/379012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1620 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 08:10:46 +00:00
andrew@webrtc.org
daacee81b8 Use better reference files with audioproc_unittest. 
The files are shorter (7 s) with one set provided for each sample rate.

Will be accompanied by the following set of files in the resource bundle:
far8_stereo.pcm
far16_stereo.pcm
far32_stereo.pcm
near8_stereo.pcm
near16_stereo.pcm
near32_stereo.pcm

BUG=114
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/380003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1617 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 00:01:04 +00:00
henrike@webrtc.org
2660460b89 Fixes flakyness in CPU unittest 
Review URL: https://webrtc-codereview.appspot.com/377005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1616 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 23:33:54 +00:00
wu@webrtc.org
06c7dbae14 Disable flaky test AudioProcessingTest.TestVoiceActivityDetectionWithObserver. 
BUG=263
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/380009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1615 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 23:13:21 +00:00
wu@webrtc.org
50099af75f Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss. 
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001 Coverity fix for issues 10325,10326. 
Review URL: https://webrtc-codereview.appspot.com/377001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 19:02:54 +00:00
phoglund@webrtc.org
56b85c6ba8 Reduced potential for flakiness in voice detection tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1612 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 18:48:33 +00:00
wu@webrtc.org
13e0345b35 Fix uninitialized variable error in Relase mode. 
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/377007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1611 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 16:19:15 +00:00
mflodman@webrtc.org
517e5e3846 NetEQ switch fix. 
Review URL: https://webrtc-codereview.appspot.com/381006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1610 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 15:04:00 +00:00
stefan@webrtc.org
94355e0a59 Fix crash in SessionInfo::BuildSoftNackList. 
BUG=259
TEST=

Review URL: https://webrtc-codereview.appspot.com/377006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1609 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 14:06:39 +00:00
mflodman@webrtc.org
a39621ee1b Disabling APM test for invalid enum values. 
Review URL: https://webrtc-codereview.appspot.com/378006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1608 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 14:00:12 +00:00
mflodman@webrtc.org
ec31bc1321 Fixed APM tests. 
TEST=ApmTest.*

Review URL: https://webrtc-codereview.appspot.com/380008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1607 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 12:42:45 +00:00
mflodman@webrtc.org
657b2a4965 Added return due to gcc complaints in r1604. 
TBR=andrew

TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.

Review URL: https://webrtc-codereview.appspot.com/384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default. 
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 10:11:25 +00:00
andrew@webrtc.org
4942832928 Fix "may be used uninitialized" warning. 
TBR=marpan@webrtc.org
BUG=
TEST=build on Linux/Release and rtp_rtcp_unittests

Review URL: https://webrtc-codereview.appspot.com/381004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1602 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-04 05:23:51 +00:00
marpan@webrtc.org
b783a55df3 Unit test for forward_error_correction. 
Review URL: https://webrtc-codereview.appspot.com/358006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1601 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-04 02:46:35 +00:00
marpan@webrtc.org
307c1ff20c Fix for issue #254: windows crash of test_fec. 
Review URL: https://webrtc-codereview.appspot.com/379010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-04 02:45:22 +00:00
andrew@webrtc.org
dde977ec83 AudioFrame payload shouldn't be mutable. 
This requires making Mute() non-const, which is correct anyway.

BUG=
TEST=voe_auto_test on Linux

Review URL: https://webrtc-codereview.appspot.com/376001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1599 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 17:47:32 +00:00
kjellander@webrtc.org
ce0a6ff43d Restoring previous vie_auto_test.gypi structure due to problems on Mac 
Now the unit test is included in the vie_auto_test target and executed when the automated flag is used.

TBR=mflodman
BUG=
TEST=vie_auto_test --automated --gtest_filter=FrameDropPrimitivesTest.FixOutputFileForComparison

Review URL: https://webrtc-codereview.appspot.com/381003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1598 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 14:06:46 +00:00
kjellander@webrtc.org
918a8bf40c External transport is modified to never drop packets from the first frame. 
Refactoring of FrameDropHandler: It now also tracks when frames are leaving the encoder and is being sent to external transport.

Previous 'Sent' state is now renamed to 'Created'.

NOTICE: The test seems to be a little flaky on Linux so it's not ready for buildbots yet. Since this might be caused by unstable production code further investigation should be performed to clear out the flakiness. I will file an issue for this when this CL is submitted (since I don't have any code to refer to before that). Usually the flakiness is caused by a decoded/rendered callback that is left out for the last frame, but I have seen other flaky failures too, which means it's not as simple as ignoring the last frame.
These errors occur even if 400kbps bit rate and 0% PL and 0 delay is configured.

BUG=
TEST=vie_auto_test --automated --gtest_filter="ViEVideoVerificationTest.RunsFullStackWithoutErrors" in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1597 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 12:40:28 +00:00
henrik.lundin@webrtc.org
683833442a Fix for warning in GCC 4.6 
Upstream copy of a fix provided in http://codereview.chromium.org/9309007/.

BUG=none
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/383002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 12:33:50 +00:00
henrik.lundin@webrtc.org
82e1c8d0e7 Fix for issue 253 
Initializing a few arrays to avoid compiler warnings under
the O3 flag.

BUG=http://code.google.com/p/webrtc/issues/detail?id=253

Review URL: https://webrtc-codereview.appspot.com/380005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1595 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 09:46:01 +00:00
pwestin@webrtc.org
fdf21c8c55 Removed dead version code. 
Review URL: https://webrtc-codereview.appspot.com/377003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1594 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 12:46:58 +00:00
pwestin@webrtc.org
4ea57e5e26 Changed VP8 to follow the style guide a little bit more. 
Review URL: https://webrtc-codereview.appspot.com/379003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1593 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 12:21:47 +00:00
xians@webrtc.org
9b3474aff8 Disable the unused API interfaces for VoE chromium build. 
Review URL: https://webrtc-codereview.appspot.com/377002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1592 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 08:59:11 +00:00
stefan@webrtc.org
07b45a5dc4 Added API for getting the send-side estimated bandwidth. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/372006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-02 08:37:48 +00:00
leozwang@webrtc.org
ac7e89ff1c Correct and update LICENSE 
Review URL: https://webrtc-codereview.appspot.com/382001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1590 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 23:04:48 +00:00
kma@webrtc.org
de66b91274 In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl, 
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 18:39:44 +00:00
andrew@webrtc.org
7fe219f681 Add some additional checks for corrupt payload. 
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.

BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.

Review URL: https://webrtc-codereview.appspot.com/369015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 02:40:37 +00:00
kma@webrtc.org
727a0a03a1 Fixed a bug in assembly code in aecm_core.c (hasn't caused a problem yet). 
Did apm unit test. Bit exact.
Review URL: https://webrtc-codereview.appspot.com/366010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1583 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 00:05:22 +00:00
frkoenig@google.com
d8f58a4ab0 Cross platform build fix for SSIM (part 2) 
Data alignment fix for SSIM.

WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128.  By declaring the 
variable as __m128i it will always be 128 bytes aligned.

Related to issue 239013.
http://webrtc-codereview.appspot.com/239013/
Review URL: https://webrtc-codereview.appspot.com/375004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1582 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 17:49:38 +00:00
bjornv@webrtc.org
26e8a58130 VAD refactor: Create() and Free() 
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.

TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 14:42:50 +00:00
henrik.lundin@webrtc.org
dd478e2081 Fix for warning in GCC 4.6 
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/.

Review URL: https://webrtc-codereview.appspot.com/369024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 13:12:41 +00:00
xians@webrtc.org
79af734807 This patch fixes the converity warnings in voice engine. 
Review URL: https://webrtc-codereview.appspot.com/373017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1579 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 12:22:14 +00:00
stefan@webrtc.org
91c630851a Fix potential VCMReceiver crash. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 10:49:08 +00:00
henrika@webrtc.org
2919e95c2a Resolves Coverty issue #10347. 
Uninitialized member (UNINIT_CTOR).
Review URL: https://webrtc-codereview.appspot.com/369023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1577 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 08:45:03 +00:00
marpan@webrtc.org
cdba1a836b test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file. 
Review URL: https://webrtc-codereview.appspot.com/373016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 00:36:14 +00:00
andrew@webrtc.org
293d22b39b Add a new macro for bit-exact audioproc tests. 
Enable bit-exact test for all fixed-point configs.

BUG=114
TEST=audioproc_unittest on all platforms.

Review URL: https://webrtc-codereview.appspot.com/369018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1575 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 22:04:26 +00:00
andrew@webrtc.org
40654039cd Use pointer-based CriticalSectionScoped(). 
The reference-based constructor is deprecated.

BUG=185
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/373015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1573 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 20:51:15 +00:00
kma@webrtc.org
89a100092a A minor change in function WebRtcNetEQ_PacketBufferFindLowestTimestamp for 
NetEq, for performance reasons.
In Android platform, with an offline testing file, the function cycles was reduced by 25%.
This function was also reformatted.
Review URL: https://webrtc-codereview.appspot.com/367010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1571 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 15:37:33 +00:00
mflodman@webrtc.org
7627843352 Added NULL check in external transport test code. 
BUG=C-10246

Review URL: https://webrtc-codereview.appspot.com/367022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1570 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 13:21:26 +00:00
pwestin@webrtc.org
5dad00be52 Coverty fix: FEC unintended signed extension and resource leaks. 
Review URL: https://webrtc-codereview.appspot.com/368010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 13:05:29 +00:00
mflodman@webrtc.org
d3b22c9356 Resolved X11 shared memiory leak. 
BUG=248
TEST=See bug

Review URL: https://webrtc-codereview.appspot.com/367016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1568 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:44:28 +00:00
bjornv@webrtc.org
0c6f931420 Removed versions in module/audio_processing and common_audio/vad. 
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:39:08 +00:00
stefan@webrtc.org
2fd1e1e40d Add unittests for ReceiverFec. 
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:03:37 +00:00
pwestin@webrtc.org
04cf69a714 Coverty: cleanup CheckCSRC. 
Review URL: https://webrtc-codereview.appspot.com/369014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
2f7740973d Fixed C errors from GCC 4.6. 
Fixed errors in .c files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/373014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1563 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:44:26 +00:00
mflodman@webrtc.org
1f992807eb Fixed frame scaler bugs. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1562 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:42:53 +00:00
phoglund@webrtc.org
048eb7cda6 Finished rewriting the audio processing test. 
Partial rewrite of audio processing tests.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1561 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 11:58:41 +00:00
mflodman@webrtc.org
832adebca2 Removed MapWrapper from ViEFrameProviderBase. 
BUG=C-10189

Review URL: https://webrtc-codereview.appspot.com/356002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1560 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:31:34 +00:00
mflodman@webrtc.org
194a93ac66 Adding ViE NULL checks. 
BUG=C-10188, C-10246, C-10595

Review URL: https://webrtc-codereview.appspot.com/373013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1559 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:11:22 +00:00
tina.legrand@webrtc.org
cbe1de9aa6 This CL solves three remaining Coverity warnings. 
A few more members were left uninitialized, and one more size mismatch in a multiplication.

Review URL: https://webrtc-codereview.appspot.com/367001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:00:46 +00:00
mallinath@webrtc.org
a8c568f0a4 Fix external codec erase in destructor. 
Review URL: https://webrtc-codereview.appspot.com/368008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1555 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-26 16:19:03 +00:00
phoglund@webrtc.org
d1a860b415 Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans. 
Fixed remaining compilation errors in release, etc.

Fixed errors from GCC 4.6 compilation.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/366008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-26 14:49:28 +00:00
andrew@webrtc.org
42ae41e5a2 Fix enumeral comparison error. 
TBR=henrike
BUG=
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/372007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1553 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 19:38:16 +00:00
andrew@webrtc.org
b9d7d934de Rename interface/ to include/ in audio_processing. 
BUG=none
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/367007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1552 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 19:21:13 +00:00
andrew@webrtc.org
24bd58e689 Properly count anonymous mixing participants. 
When _amountOfMixableParticipants == 1, we skip mixing and saturation
protection. Without this fix, an anonymous participant would only be
properly counted if it was the last added.

For example, if an anonymous participant was added first, followed by
a regular participant, _amoutOfMixableParticipants would == 1 and the
regular participant would not be mixed.

BUG=issue209
TEST=New test added to voe_auto_test to verify, and used voe_cmd_test.

Review URL: https://webrtc-codereview.appspot.com/367006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1551 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 18:57:44 +00:00
henrik.lundin@webrtc.org
dcf006480c Fix typo in a comment 
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/369012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1548 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 16:48:00 +00:00
henrik.lundin@webrtc.org
4679652d57 Implemented a fix for Issue 88. 
NetEQ now checks for too early CNG packets, and modifies the CNG
sample counter to jump forward in time if needed to combat clock
drift.

Adding a new unittest to reproduce and solve the issue. The
unittest LongCngWithClockDrift verifies that the buffer delay
before and after a long CNG period is almost constant. The test
introduces a clock drift of 25 ms/s.

BUG=http://code.google.com/p/webrtc/issues/detail?id=88
TEST=neteq_unittests NetEqDecodingTest.LongCngWithClockDrift

Review URL: https://webrtc-codereview.appspot.com/372002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1547 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 16:37:41 +00:00
mflodman@webrtc.org
9b0a820624 Fixed double erase in ViEChannelManager channel map. 
Review URL: https://webrtc-codereview.appspot.com/369011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1546 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 16:00:49 +00:00
mflodman@webrtc.org
b11424bc11 Remove ViEShared inheritance for interface impl. 
Review URL: https://webrtc-codereview.appspot.com/357002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1545 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 13:42:03 +00:00
bjornv@webrtc.org
f4b77fd722 VAD refactor: Mode changed to "int". 
As part of style this CL includes changing the input aggressiveness mode from int16_t to int. No other style changes made.
Impact on:
- Audio Processing: Changed return value on MapSetting().
- Function test in audio_conference_mixer already uses int. No action.
- NetEq: Function pointer changes and input parameter changes in SetVADMode() and SetVADModeInternal().
- Audio Coding: Uses enum ACMVADMode which is type independent.
- VAD: Two unit tests.

TESTS=vad_unittests, neteq_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1544 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:40:00 +00:00
bjornv@webrtc.org
2a4dcd7d15 VAD refactor: WebRtcVad_InitCore(). 
Impact only locally.
- Replaced for loops with memset().
- Added guard against NULL pointer.
- Removed mode as input parameter (never really used).
- Updated unit tests.
- Made struct member init_flag "int".
- Updated function description.
- Updated Copyright notes with 2012.
- Removed some lint warnings.

TESTS=vad_unittests, audioproc_unitest
Review URL: https://webrtc-codereview.appspot.com/369005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1543 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:18:12 +00:00
henrike@webrtc.org
567b99be5f Coverity report: fixes an issue where the returnvalue of a function is not checked. 
Review URL: https://webrtc-codereview.appspot.com/347013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 23:43:54 +00:00
andrew@webrtc.org
f5d8c3bc3b Fix audioproc_unittest on Windows. 
On Windows, files have to be closed before they can be removed.

TBR=bjornv
BUG=none
TEST=audioproc_unittest on Windows.

Review URL: https://webrtc-codereview.appspot.com/369010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1541 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 21:35:39 +00:00
pwestin@webrtc.org
f6bb77a6f0 Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace. 
Review URL: https://webrtc-codereview.appspot.com/358001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 17:16:59 +00:00
mallinath@webrtc.org
218db3de20 Iterator was invalid while removing entries from codec db maps. 
Review URL: http://webrtc-codereview.appspot.com/373003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1534 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 17:11:44 +00:00
stefan@webrtc.org
9e332ab95b Make sure we check the return value from shmat(). 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/358007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1533 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 16:33:27 +00:00
pwestin@webrtc.org
b73c3d1f5d Bugfix android build. 
Review URL: https://webrtc-codereview.appspot.com/374003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1532 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 15:25:30 +00:00
pwestin@webrtc.org
28a5cb29ab Bugfix receive side only packet loss estimate with NACK. 
Review URL: https://webrtc-codereview.appspot.com/373006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1529 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 14:34:58 +00:00
perkj@webrtc.org
40d3c08be4 Changed max number of vie channels to 32. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/374002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1527 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 14:04:17 +00:00
mflodman@webrtc.org
ba09cf16ec Correcting uninitialized members. 
BUG=C-10344, C-10345, C-10346

Review URL: https://webrtc-codereview.appspot.com/345012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1525 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 07:49:33 +00:00
mflodman@webrtc.org
a5a5cbb992 Switched from WebRTC wrappers to stl in ChannelManager. 
BUG=C-10187

Review URL: https://webrtc-codereview.appspot.com/357001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1524 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 06:50:15 +00:00
andrew@webrtc.org
eeaf3d1fc1 Merge /branches/3.2:r1380 to /trunk 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1523 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 06:30:02 +00:00
mflodman@webrtc.org
6cf529d082 Changed REMB return value to int instead of bool. 
Review URL: https://webrtc-codereview.appspot.com/366001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1522 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 06:16:16 +00:00
andrew@webrtc.org
d3a0c1cb66 Merge /branches/3.2:r1378 to /trunk 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1521 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 03:20:53 +00:00
kma@webrtc.org
4bc24c4afa Optimized function WebRtcSpl_FilterARFastQ12 for ARM platform. 
Speed close to doubled for an offline test in NetEq.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/346001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1520 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 02:12:49 +00:00
punyabrata@webrtc.org
6da8eeb946 Removing an assert for a case that can occur 
when corrupt packets are injected into voice engine.
Review URL: https://webrtc-codereview.appspot.com/373004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1518 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 00:48:36 +00:00
leozwang@webrtc.org
f5cacdce8c Fix line aligement 
Review URL: https://webrtc-codereview.appspot.com/373002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1516 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 23:14:13 +00:00
leozwang@webrtc.org
f9cd693145 Enable vp8 and videoengine on android 
Review URL: https://webrtc-codereview.appspot.com/368003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1510 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:56:13 +00:00
leozwang@webrtc.org
a45d05a341 Add brighten.cc to makefile 
Review URL: https://webrtc-codereview.appspot.com/369003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1509 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:54:13 +00:00
leozwang@webrtc.org
376be6c904 Fix compilation error 
Review URL: https://webrtc-codereview.appspot.com/358005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1508 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:46:38 +00:00
pwestin@webrtc.org
b30f0edce6 Bugfix buffer usage out of scope. 
Review URL: https://webrtc-codereview.appspot.com/372001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1507 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:23:31 +00:00
phoglund@webrtc.org
12dbc23851 Rewrote volume test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1506 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 16:03:04 +00:00
stefan@webrtc.org
175fecde97 Fix clang build error. 
TBR=henrik.lundin@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1505 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 15:23:31 +00:00
stefan@webrtc.org
8fe03af674 Refactor to use std::list in the video rtp play tools. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/349013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1504 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 14:56:14 +00:00
bjornv@webrtc.org
152c34cf11 VAD-refactor. Changed to int as return value for WebRtcVad_set_mode(). 
Impact on NetEq function pointers. Other components already treat the output as int. These are:
* audio_processing
* funtion test in audio_conference_mixer
* audio_coding

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/367003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1503 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 12:36:46 +00:00
phoglund@webrtc.org
3b57ee0238 Rewrote DTMF test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1502 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 09:22:33 +00:00
leozwang@webrtc.org
31627fe82c Add vie_remb.cc to makefile 
Review URL: https://webrtc-codereview.appspot.com/358004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1501 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 23:10:26 +00:00
andrew@webrtc.org
e2ed5baf47 Enable audioproc_unittest on all platforms. 
But, for the time being, limit the bit-exact test to 64-bit Linux debug.

TEST=build and run all configs on Linux, and standard configs on Win and Mac.

Review URL: https://webrtc-codereview.appspot.com/343005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1500 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 19:06:38 +00:00
leozwang@webrtc.org
2638577f03 Add an argument in ANDROID_NOT_SUPPORT macro 
Review URL: https://webrtc-codereview.appspot.com/363003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1499 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 18:45:45 +00:00
stefan@webrtc.org
f27916a76a Remove use of MapWrapper in video_coding. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/344018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1498 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 14:04:13 +00:00
henrik.lundin@webrtc.org
d798953846 NetEqRTPplay modification 
Make the program look for the ptypes.txt file in the default trunk
path, if the path to the executable indicates that it sits in the
trunk/out/Debug folder.

Changing PT for CNG-WB to 98

Remove warnings when building NetEQ with NETEQ_DELAY_LOGGING

Review URL: https://webrtc-codereview.appspot.com/339003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1497 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 13:42:16 +00:00
phoglund@webrtc.org
d056abd62f Prepared tests for running on build bot. 
The changes will mostly clarify why PSNR and SSIM thresholds are chosen. I think those explanations will be good since these tests may well be a bit flaky.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/343017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1496 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 12:48:13 +00:00
mflodman@webrtc.org
c672d34ac7 Removed file duplicate added in r1312. 
Review URL: https://webrtc-codereview.appspot.com/357003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1495 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 12:30:42 +00:00
kjellander@webrtc.org
5e1625ed2d Fixing Valgrind problem detected by video_processing_unittests. 
Simple initialization of the allocated memory for the image buffer avoids reading uninitialized data in some special cases.

This fix is only intended for Linux, since the test is known to fail on Windows. But since we're currently only running Valgrind on Linux, this will give us improved control over memory issues.

BUG=
TEST=tools/valgrind-webrtc/webrtc_tests.sh -t cmdline out/Debug/video_processing_unittests

Review URL: http://webrtc-codereview.appspot.com/349012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1493 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 08:40:55 +00:00
pwestin@webrtc.org
56ee5d5d98 Bugfix 32 bit linux. 
Review URL: https://webrtc-codereview.appspot.com/353010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1490 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 07:47:38 +00:00
pwestin@webrtc.org
95cf47932d Remove list wrapper from FEC code. 
Review URL: https://webrtc-codereview.appspot.com/350013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1489 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 06:59:06 +00:00
leozwang@webrtc.org
9165f1fe91 Changed to use std::sort 
Review URL: https://webrtc-codereview.appspot.com/356003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1488 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 01:39:13 +00:00
andrew@webrtc.org
f33dfa89b9 Add target and config info to merged lib name. 
BUG=None
TEST=build merged_lib on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/344014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1487 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 01:32:16 +00:00
leozwang@webrtc.org
a191506ce9 Enable all modules without building errors 
Review URL: https://webrtc-codereview.appspot.com/360004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1485 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 22:11:37 +00:00
mflodman@webrtc.org
2d03b8b217 REMB now works for two consecutive calls with different channels but same ViE instance. 
BUG=241

Review URL: https://webrtc-codereview.appspot.com/361001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1484 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 21:21:15 +00:00
andrew@webrtc.org
300aed945d Use -Wextra on Linux for standalone builds. 
BUG=None
TEST=build on Linux, Mac, Windows

Review URL: https://webrtc-codereview.appspot.com/348009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1482 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 20:10:19 +00:00
mflodman@webrtc.org
0f4cb131c6 Added NULL check in ViEFileImpl. 
BUG=C-10188

Review URL: https://webrtc-codereview.appspot.com/344016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1480 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 18:41:39 +00:00
marpan@webrtc.org
20cd06123c For TL(temporal layers) = 2, the alt-ref frame should not be used as a reference. 
Correction for the last frame in the cycle.
Review URL: https://webrtc-codereview.appspot.com/343015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1479 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 18:25:23 +00:00
pwestin@webrtc.org
0074187436 Removed map_wrapper from rtp_sender 
Review URL: https://webrtc-codereview.appspot.com/343014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1478 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:56:10 +00:00
pwestin@webrtc.org
3c9be1bc4d Removed list wrapper fromr overuse detector. 
Review URL: https://webrtc-codereview.appspot.com/353004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1477 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:55:54 +00:00
pwestin@webrtc.org
d4adc5b26f removed unused include from remote rate control. 
Review URL: https://webrtc-codereview.appspot.com/350015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1476 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:55:30 +00:00
pwestin@webrtc.org
af6f15c1bf Changed RTP reveivers to use stl map and list. 
Review URL: https://webrtc-codereview.appspot.com/349010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1475 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:53:59 +00:00
pwestin@webrtc.org
38f4816737 Removed unused include from rtp sender audio. 
Review URL: https://webrtc-codereview.appspot.com/348012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1474 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:53:33 +00:00
pwestin@webrtc.org
26f8d9c7f3 Removed list and map wrappers, for RTCP handling. 
Review URL: https://webrtc-codereview.appspot.com/349011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1473 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:53:09 +00:00
tommi@webrtc.org
9ff87db5c0 Remove the diamond inheritance pattern from VoEVideoSyncImpl in attempt to see if this fixes coverity reports. 
CID=10446,10445,10444,10443
Review URL: https://webrtc-codereview.appspot.com/343018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1472 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 15:05:36 +00:00
tina.legrand@webrtc.org
d71a11c15e Fixing Coverity issues in Audio Coding Module 
10198: Out-of-bounds read in acm_isac.cc
10251: Unintended sign extension in acm_resampler.cc
10273: Uninitialized pointer field in acm_amr.cc
10274: Uninitialized pointer field in acm_amrwb.cc
10275: Uninitialized scalar field in acm_dtmf_detection.cc
10276: Uninitialized pointer field in acm_g722.cc
10277: Uninitialized pointer field in acm_g7221.cc
10278: Uninitialized pointer field in acm_g7221c.cc
10279: Uninitialized pointer field in acm_g729.cc
10280: Uninitialized pointer field in acm_g7291.cc
10281: Uninitialized pointer scalar in acm_generic_codec.cc
10282: Uninitialized pointer field in acm_gsmfr.cc
10283: Uninitialized scalar field in acm_isac.cc
10284: Uninitialized pointer field in acm_opus.cc
10285: Uninitialized scalar field in acm_resampler.cc
10286: Uninitialized pointer field in acm_speex.cc
10287: Uninitialized scalar field in audio_coding_module_impl.cc
10581: Unintended sign extension in audio_coding_module_impl.cc

Additional change: removed unused function and member from ACMResampler.

Review URL: https://webrtc-codereview.appspot.com/343016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1471 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 13:22:22 +00:00
henrik.lundin@webrtc.org
dcdb744eee Remove an old comment in vp8 wrapper 
The operation that the comment describes was removed in r482.

Review URL: https://webrtc-codereview.appspot.com/353008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1470 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 13:06:43 +00:00
pwestin@webrtc.org
1da2327473 Changing header extension to use stl map. 
Review URL: https://webrtc-codereview.appspot.com/350014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1469 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 12:58:53 +00:00
mflodman@webrtc.org
70111e69bf Switching to stl instead of WebRTC wrappers. 
BUG=C-10436, C-10437, C-10438

Review URL: https://webrtc-codereview.appspot.com/343012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1468 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 12:48:53 +00:00
stefan@webrtc.org
8e50693736 Fixes for code analysis warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/355004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1467 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 12:30:21 +00:00
bjornv@webrtc.org
6748087467 Incorrect pointer inputs in filter test. 
Two filter functions were called wrongly, which made us read from uninitialized values.
Added short comment.
No style changes. The tests will be revisited and extended during an upcoming refactor.

signal_processing_unittests now pass Valgrind.

TEST=signal_processing_unittests
Review URL: https://webrtc-codereview.appspot.com/344015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1466 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 10:41:39 +00:00
bjornv@webrtc.org
12cccddc63 NS-SWB: Actived SWB processing at once, i.e., no startup phase. 
Performance verified on a few 32 kHz files.
BUG=
TEST=audioproc, audioproc_unittest

Updated output_data_float.pb
Changes in SWB tests (3, 6, 9 and 12) as

Running test 3 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 1363
Expected: test->max_output_average()
Which is: 1386

Running test 6 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 2070
Expected: test->max_output_average()
Which is: 2109

Running test 9 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 1314
Expected: test->max_output_average()
Which is: 1336

Running test 12 of 12...
src/modules/audio_processing/test/unit_test.cc:1182: Failure
Value of: max_output_average
  Actual: 2049
Expected: test->max_output_average()
Which is: 2085
Review URL: https://webrtc-codereview.appspot.com/344013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1465 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 08:56:38 +00:00
andrew@webrtc.org
17585856f5 Merged /branches/3.2:r1381 to /trunk 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1464 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 00:15:08 +00:00
mflodman@webrtc.org
d5a83ce972 Changed to red and ULPFEC to ulpfec in GetCodec. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/355005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1462 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 22:39:32 +00:00
andrew@webrtc.org
267ca3162b Fix comparison-always-true warning with -Wextra. 
TEST=build on Linux with -Wextra.

Review URL: https://webrtc-codereview.appspot.com/353005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1456 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 19:41:40 +00:00
punyabrata@webrtc.org
ad1927d368 Changing the typing detection sensitivity as the current 
setting does not work well in some scenarios especially
using webcams with built-in microphones.
Review URL: https://webrtc-codereview.appspot.com/349009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1455 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 18:53:04 +00:00
bjornv@webrtc.org
ab2bb82ac9 VAD refactor: int return value for Init. 
For consistency and as part of style, the return value of WebRtcVad_Init() has been changed to int.

Impact:
 1) audio_processing, audio_coding, a test in CNG, functionTest in audio_conference_mixer, a test in net_eq all used int values. Hence, unaffected.
 2) Function pointers in net_eq changed.
 3) The VADInit in neteq/dsp.c boiled down to typecast into int anyhow, which now is removed.

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/355003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 14:51:02 +00:00
phoglund@webrtc.org
5badc7e969 Put system cpu tests back in, improved documentation. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/350011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1452 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 10:46:07 +00:00
henrik.lundin@webrtc.org
4407edc314 Bugfix in VP8 packetizer 
Handle the case with no small partitions in Vp8PartitionAggregator.
Also added a new unit test for the packetizer to verify that the
bug is fixed.

TEST=RtpFormatVp8Test.TestAggregateModeTwoLargePartitions
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/348011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1451 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 10:01:03 +00:00
mflodman@webrtc.org
8224451ee4 Add check for ftell return value. 
BUG=C-10170

Review URL: https://webrtc-codereview.appspot.com/355001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1450 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 09:36:46 +00:00
mflodman@webrtc.org
cdeb483c6a Fixed ignored return value. 
BUG=C-10011

Review URL: https://webrtc-codereview.appspot.com/353003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1449 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 09:00:04 +00:00
mflodman@webrtc.org
a768ca13f4 Removed dead code. 
BUG=C-10062, C-10063, C-10064, C-10065, C-10393, C-10394.

Review URL: https://webrtc-codereview.appspot.com/343013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1448 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 08:52:16 +00:00
henrik.lundin@webrtc.org
7f2c2a5db2 Adding optimized aggrgation to VP8 packetizer 
This change introduces a new algorithm for aggregating small
partitions into packets. The algorithm is based on a tree-search
to find an optimal allocation of the packets, such that the
difference in size between packets is minimized.

The new method is used when partition aggregation is allowed and
balanced packets are requested. Otherwise, the old method is used.

The new method is implemented using the new classes
Vp8PartitionAggregator and PartitionTreeNode. Both classes have
dedicated unit tests.

In order to facilitate the new algorithm, the packetizer was
redesigned to calculate all packet sizes when the first packet is
extracted. The information about all packets is stored in a packet
queue structure, which is then popped for each packet extracted.

Finally, a bug in the old packetizer algorithm was fixed. The bug
caused a +/-1 error in packet sizes when balanced packets were
produced. The unit test were updated accordingly.

TEST=rtp_rtcp_unittests: PartitionTreeNode.* Vp8PartitionAggregator.* RtpFormatVp8Test.*

Review URL: https://webrtc-codereview.appspot.com/345008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1447 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 08:21:15 +00:00
andrew@webrtc.org
975e4a33c6 Fix gcc warnings triggered by -Wextra. 
TEST=build and audio_coding_unittests and audio_coding_module_test on Linux

Review URL: https://webrtc-codereview.appspot.com/343010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1445 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 19:27:33 +00:00
bjornv@webrtc.org
4259fd725c Refactor VAD: Code restructure 
- Tests added for vad_core.
- Replaced two macros with constants.
- Made an internal function static.
- Replaced replicated code with function call.
Review URL: https://webrtc-codereview.appspot.com/354001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1444 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 14:37:59 +00:00
pwestin@webrtc.org
38e0a771d2 Bugfix removed MPEG4 from windows test. 
Review URL: https://webrtc-codereview.appspot.com/348010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1443 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 14:18:09 +00:00
pwestin@webrtc.org
5621057956 Removing unused code. 
Review URL: https://webrtc-codereview.appspot.com/349008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1442 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 12:45:47 +00:00
mflodman@webrtc.org
e5297d2aaa Big parameter passed as argument. 
BUG=C-10503, C-10504, C-10505

Review URL: https://webrtc-codereview.appspot.com/343011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1441 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 12:44:41 +00:00
mflodman@webrtc.org
2877bdc590 Cleaned up resource leaks. 
BUG=C-10059, C-10228, C-10229.

Review URL: https://webrtc-codereview.appspot.com/345013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1439 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 12:18:16 +00:00
mflodman@webrtc.org
7b3f3b1e42 CalcBufferSize can return -1, which wasn't handled by ViERenderer. 
BUG=C-10532

Review URL: https://webrtc-codereview.appspot.com/345010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1438 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 12:12:42 +00:00
pwestin@webrtc.org
df9bd9bdbd Removed dead code. 
Review URL: https://webrtc-codereview.appspot.com/352010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1437 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 11:42:02 +00:00
pwestin@webrtc.org
aafa5a331c Coverty report: Unititialized members 
Review URL: http://webrtc-codereview.appspot.com/349007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1436 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 07:07:37 +00:00
asapersson@webrtc.org
43b8fc5c0d Review URL: http://webrtc-codereview.appspot.com/345011 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1435 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 13:49:04 +00:00
phoglund@webrtc.org
c12f815de6 Rewrote hardware test and fixed broken tests on Windows. 
Fixed broken tests on Windows, including old tests.

Rewrote hardware test.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/347008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1434 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 12:40:18 +00:00
stefan@webrtc.org
8ddf9a4e18 Ported more jitter buffer tests to unit tests. 
BUG=
TEST=jitter_buffer_unittest

Review URL: http://webrtc-codereview.appspot.com/350009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1433 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 11:59:01 +00:00
asapersson@webrtc.org
869ce2d441 Review URL: http://webrtc-codereview.appspot.com/353002 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1432 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 11:58:36 +00:00
asapersson@webrtc.org
0b3c35a258 Review URL: http://webrtc-codereview.appspot.com/321011 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1431 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 11:06:31 +00:00
mflodman@webrtc.org
67cdc22e7e CpuLinux file handle leak. 
BUG=crbug.com/110165

Review URL: http://webrtc-codereview.appspot.com/353001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1429 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 09:31:39 +00:00
henrika@webrtc.org
f75901fa4c Resolves CID 10540: Copy into fixed size buffer (STRING_OVERFLOW). 
You might overrun the 32 byte fixed-size string "receiveCodec.plname" by copying "payloadName" without checking the length.
Note: This defect has an elevated risk because the source argument is a parameter of the current function.
Review URL: http://webrtc-codereview.appspot.com/352009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1428 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 08:45:42 +00:00
braveyao@webrtc.org
f5c6573725 fix defect http://code.google.com/p/webrtc/issues/detail?id=215, audio device is not stopped appropriately. 
Review URL: http://webrtc-codereview.appspot.com/350008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1427 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-16 03:04:46 +00:00
andrew@webrtc.org
c8d012fb32 Use -msse2 for SSE2 optimized code. 
When targeting 32-bit Linux, we need to pass -msse2 to gcc to compile
SSE2 intrinsics. However, -msse2 also gives gcc license to automatically
generate SSE2 instructions wherever it pleases. This will crash our code
on processors without SSE2 support.

This change breaks the files with SSE2 intrinsics into separate targets,
such that we can limit the scope of -msse2 to where it's needed.

We no longer need to employ the WEBRTC_USE_SSE2 define; the build system
decides when SSE2 is supported and compiles the appropriate files.

TBR=bjornv@webrtc.org
TEST=audioproc (performance testing), audioproc_unittest, video_processing_unittests, build on Linux (targeting ia32/x64, with disable_sse2==0/1), Mac, Windows

Review URL: http://webrtc-codereview.appspot.com/352008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1425 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-13 19:43:09 +00:00
andrew@webrtc.org
ee3fe5b982 Remove unused variable from mixer module. 
R=henrike@webrtc.org
BUG=coverity-10288

Review URL: http://webrtc-codereview.appspot.com/344010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1424 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-13 17:54:57 +00:00
braveyao@webrtc.org
5f9a7baaea Review URL: http://webrtc-codereview.appspot.com/347012 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1423 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-13 10:22:44 +00:00
mflodman@webrtc.org
117c119501 Only update REMB value if there is a calid bitrate estimate. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/352005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1421 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-13 08:52:58 +00:00
henrik.lundin@webrtc.org
33d5f69d5e Fix issue 218 with new solution 
This one is slightly more elegant and efficient.

BUG=http://code.google.com/p/webrtc/issues/detail?id=218
TEST=

Review URL: http://webrtc-codereview.appspot.com/344009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1420 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-13 07:46:50 +00:00
andrew@webrtc.org
7859e10985 Propagate decoding errors to the mixer module. 
Review URL: http://webrtc-codereview.appspot.com/348001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1417 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-13 00:30:11 +00:00
stefan@webrtc.org
c8277db7c8 Fix selective retransmissions after corrupt merge in r1373. 
BUG=228
TEST=

Review URL: http://webrtc-codereview.appspot.com/345006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1414 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 15:38:50 +00:00
pwestin@webrtc.org
9cbe6867e7 Removed experiment. 
Review URL: http://webrtc-codereview.appspot.com/345005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1413 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 15:35:28 +00:00
stefan@webrtc.org
ad4af57abd Fixes a jitter buffer NACK bug. 
If no frame has been decoded the jitter buffer might generate huge
erroneous NACK lists.

Adds a couple of new jitter buffer unittests (some ported from
jitter_buffer_test.cc).

Adds a test to the VCM robustness tests.

BUG=226
TEST=VCMRobustnessTest, TestJitterBufferFull, TestNackListFull, TestNackBeforeDecode, TestNormalOperation

Review URL: http://webrtc-codereview.appspot.com/352002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1412 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 15:16:49 +00:00
mflodman@webrtc.org
80d60420ff RTCPSender::_bitrate_observer not initialized. 
BUG=227
TEST=Valgrind

Review URL: http://webrtc-codereview.appspot.com/352004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1410 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 14:28:53 +00:00
perkj@webrtc.org
5735a63e5a Add video capture module to the list of dependent projects in video engine. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/348007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1409 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 14:22:58 +00:00
henrik.lundin@webrtc.org
053c7991e3 Add minimum waiting time to NetEQ metrics 
Adding minWaitingTimeMs to ACMNetworkStatistics and to
NetworkStatistics. Also adding unittest.

TEST=audio_coding_unittests

Review URL: http://webrtc-codereview.appspot.com/350006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1408 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 14:16:44 +00:00
bjornv@webrtc.org
40ea5106f6 Refactoring vad_filterbank 
Made internal function LogOfEnergy() more efficient.
Includes
- Name change "vector" -> "data"
- Complete refactor of LogOfEnergy()
- Removed lint warning

Major changes:
* Removed unnecessary variables
* Reduced number of shifts
* Removed one norm calculation


TEST=vad_unittests, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/347004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1407 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 12:47:42 +00:00
kjellander@webrtc.org
b39a3b4a7a Restoring unintentially renamed MS DirectShow source files in 
http://webrtc-codereview.appspot.com/348005/

BUG=
TEST=Compiling on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/352003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1406 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 12:22:03 +00:00
kjellander@webrtc.org
7f3c724e12 Renaming 47 files from .cpp to .cc 
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.

BUG=
TEST=Compiling on Linux.

Review URL: http://webrtc-codereview.appspot.com/348005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 10:23:41 +00:00
kjellander@webrtc.org
93546f8ed6 Removing unused file 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/347010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1404 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 10:00:33 +00:00
niklas.enbom@webrtc.org
553657b2f8 See http://codereview.chromium.org/9188022/ for details 
Review URL: http://webrtc-codereview.appspot.com/347009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1403 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 08:49:34 +00:00
punyabrata@webrtc.org
9a85b500c5 Minor tracing fix in ::IncomfingFrame and ::IncomfingFrameI420 
Review URL: http://webrtc-codereview.appspot.com/352001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1401 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 00:37:07 +00:00
andrew@webrtc.org
83c7f6db0e Add missing file to iSAC gyp. 
TBR=kma@webrtc.org
TEST=Linux build

Review URL: http://webrtc-codereview.appspot.com/344008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1394 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 20:16:32 +00:00
andrew@webrtc.org
921321ff62 Fix unused-variable warning in iSAC. 
TBR=kma@webrtc.org
TEST=build on Linux

Review URL: http://webrtc-codereview.appspot.com/348006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1393 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 19:50:20 +00:00
kma@webrtc.org
badf2b8044 Optimized an AR function in iSAC fix for ARMv7 (not Neon) platforms. 
Bit exact. Speed doubled.
Review URL: http://webrtc-codereview.appspot.com/327001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1392 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 18:01:39 +00:00
mflodman@webrtc.org
04c18cb37a Update all child modules of with received bandwidth estimate. 
BUG=224

Review URL: http://webrtc-codereview.appspot.com/347007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1391 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 14:18:33 +00:00
stefan@webrtc.org
cd8cea50a6 Fix decode error in NACK/FEC mode after network glitch. 
Caused when recyclingframes until the next key frame to
regain frame buffers when the jitter buffer is full.

BUG=http://code.google.com/p/webrtc/issues/detail?id=225
TEST=

Review URL: http://webrtc-codereview.appspot.com/350005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1390 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 14:17:44 +00:00
mflodman@webrtc.org
684c7b71c3 Fixed vie_defines.h typo. 
BUG=220
TEST=Mac debug build

Review URL: http://webrtc-codereview.appspot.com/347006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1389 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 13:52:06 +00:00
mflodman@webrtc.org
5007056767 Added REMB option to custom call. 
Review URL: http://webrtc-codereview.appspot.com/347003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1388 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 13:46:10 +00:00
perkj@webrtc.org
ce5990cb0b Fix defect http://code.google.com/p/webrtc/issues/detail?id=222 
"ViE GetSentRTCPStatistics fails on a sending channel if it don't receive rtp video packets.

BUG=222
TEST= tested in loopback. No new test added yet.

Review URL: http://webrtc-codereview.appspot.com/343003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1387 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 13:00:08 +00:00
phoglund@webrtc.org
01530a2ac2 Rewrote the rcp_rtcp test. 
Finished rewriting the rtp_rtcp test.

Rewrote first RTP RTCP test

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/342007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1386 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 12:26:34 +00:00
tina.legrand@webrtc.org
6b6ff558a8 Implementation if mono-to-stereo and vice versa in ACM. 
Added stereo-to-mono and mono-to-stereo tests to end of TestStereo.cpp.

BUG=Aim to resolve issue 207, "Investigate stereo capture handling in modules"
TEST=audio_coding_module_test

Review URL: http://webrtc-codereview.appspot.com/345002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1385 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 10:12:54 +00:00
pwestin@webrtc.org
df9866fedb Bugfix mac pid_t 
Review URL: http://webrtc-codereview.appspot.com/350004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1384 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 08:57:47 +00:00
pwestin@webrtc.org
b54d72778c Changed thread Id handling in trace. 
Review URL: http://webrtc-codereview.appspot.com/331020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1383 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 08:28:04 +00:00
braveyao@webrtc.org
e3eaf44ccf one logical enhancement in CoreAudio error handler. It should never happen, but so far the only suspect to a rare crash report. 
Review URL: http://webrtc-codereview.appspot.com/349002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1382 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-11 03:07:52 +00:00
stefan@webrtc.org
c5b73e3974 Further cleanup of OverUseDetector. Removed member no longer used. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/344007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1377 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 16:42:09 +00:00
pwestin@webrtc.org
a1783598a7 Bugfix for clang. 
Review URL: http://webrtc-codereview.appspot.com/351001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1375 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 15:33:40 +00:00
pwestin@webrtc.org
5d35ceb34a Bugfix array length in test. 
Review URL: http://webrtc-codereview.appspot.com/343007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1374 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 15:06:09 +00:00
pwestin@webrtc.org
8281e7dd4a Added RTX to ViE. 
Review URL: http://webrtc-codereview.appspot.com/336001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1373 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 14:09:18 +00:00
tina.legrand@webrtc.org
ac4eb046e3 Added registration of RED and CNG to NetEq slave. 
Bug found when working on issue 221. Missing registration of CNG was the cause of the bad audio (master and slave out of sync) reported in the issue.

NOTE! File has not been refactored to follow Google style.

BUG=http://code.google.com/p/webrtc/issues/detail?id=221

Review URL: http://webrtc-codereview.appspot.com/342006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1372 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 13:59:55 +00:00
bjornv@webrtc.org
d1f148da77 Refactor vad_filterbank: Some restructuring. 
- Removed unnecessary type casting.
- Added comments.
- Removed shift macros.
- Name change of _get_features() to _CalculateFeatures(). Affects vad_core.c and vad_filterbank_unittest.cc.
Review URL: http://webrtc-codereview.appspot.com/343002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1371 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 13:48:09 +00:00
henrik.lundin@webrtc.org
d4e8c0b3ff Fixing Issue 218 
Taking care of the case when the raw waiting times vector from
NetEQ is zero length.

Also adding a new unittest to cover this case.

BUG=http://code.google.com/p/webrtc/issues/detail?id=218
TEST=AcmNetEqTest.TestZeroLengthWaitingTimesVector

Review URL: http://webrtc-codereview.appspot.com/349003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1370 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 13:46:06 +00:00
phoglund@webrtc.org
caf39f335f Re-enabled RTP-RTCP test since it's not flaky anymore. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/345003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1369 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 13:43:33 +00:00
asapersson@webrtc.org
c5a1cee73e Review URL: http://webrtc-codereview.appspot.com/348004 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1367 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 12:54:44 +00:00
stefan@webrtc.org
727e1611ac Removes debug file writing. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/343006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1365 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 11:45:47 +00:00
stefan@webrtc.org
b07aa403b3 Fixes issue 210. Removes diff between two different arrays. 
Also fixes the FrameBuffer copy constructor.

BUG=210
TEST=

Review URL: http://webrtc-codereview.appspot.com/347002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1364 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 11:45:05 +00:00
stefan@webrtc.org
e21a8cf4d4 Fix issue 211: Make sure we always generate at least one FEC packet per frame if we need protection. 
BUG=211
TEST=

Review URL: http://webrtc-codereview.appspot.com/348002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1363 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 08:37:33 +00:00
marpan@webrtc.org
2dad3fbe49 Media-opt: Added a filter type mode for the filtering of the received packet loss. This makes the filter selection explicit and easier to modify/test. 
Removed the function UpdateLossPr(); the filter updates are done in the same function that returns the filtered loss.
Review URL: http://webrtc-codereview.appspot.com/333018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1361 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 18:18:36 +00:00
mflodman@webrtc.org
0ab8ba313b We now require a manually set sender to send REMB packets. 
BUG=
TEST=video_engine_unittests

Review URL: http://webrtc-codereview.appspot.com/348003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1358 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 16:16:49 +00:00
bjornv@webrtc.org
d9c87b2146 Refactor vad_filterbank: Local functions made static. 
Review URL: http://webrtc-codereview.appspot.com/342002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1357 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 13:11:29 +00:00
phoglund@webrtc.org
d8d85711c7 Temporarily disabled the standard rtp-rtcp test because of flakiness. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/349001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1356 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 12:06:42 +00:00
phoglund@webrtc.org
0aa7b32652 Finished rewriting the codec test. 
Rewrote more tests.

Rewrote most of the codec test and removed it from the regular test.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1355 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 11:15:46 +00:00
phoglund@webrtc.org
dc9536dd0e Made vie_auto_test more robust in Linux when the X environment is broken. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1354 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 10:49:23 +00:00
mflodman@webrtc.org
0c0216f3f6 Correcting typo in libyuv.h. 
Review URL: http://webrtc-codereview.appspot.com/333026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1353 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 10:27:46 +00:00
bjornv@webrtc.org
e6471ba8d2 VAD unittest updates. 
Split the local function tests into separate files.
Review URL: http://webrtc-codereview.appspot.com/330031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1352 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 09:54:07 +00:00
kma@webrtc.org
b0abbd353d Optimized spl function WebRtcSpl_CrossCorrelation for ARM Neon platforms. 
When used in Neteq, Neteq performance improved from 13 to 33% with different
test configurations.
Output is not bit-exact with generic C code in file cross_correlation.c, 
due to reduction of shift operations from using Neon registers, although in
theory now the result is more accurate than before.
Review URL: http://webrtc-codereview.appspot.com/333013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1350 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-06 19:50:20 +00:00
leozwang@webrtc.org
bccac66885 Use a more common macro to get thread id 
Review URL: http://webrtc-codereview.appspot.com/342004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1349 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-06 00:32:00 +00:00
mikhal@webrtc.org
a2026ba4c4 libyuv: Removing old unused functionality 
Review URL: http://webrtc-codereview.appspot.com/329020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1347 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-05 18:19:32 +00:00
pwestin@webrtc.org
12d97f6637 Made send pad data generic (audio and video) 
Review URL: http://webrtc-codereview.appspot.com/343001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1346 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-05 10:54:44 +00:00
bjornv@webrtc.org
8f4a4ce13b Refactoring vad_filterbank: Style changes. 
Consists of:
- variable names.
- variable initialization.
- ordered input/output parameters.

TEST=vad_unittest, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1345 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-05 08:42:39 +00:00
pwestin@webrtc.org
3aa25de346 Bugfix OnNetworkChanged not triggered for RTCP compund messages if TMMBR is higher than last value. 
TBR=mflodman
Review URL: http://webrtc-codereview.appspot.com/342001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1344 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-05 08:40:56 +00:00
wu@webrtc.org
d6b827a28e Fix for the build broken on Windows. 
Review URL: http://webrtc-codereview.appspot.com/335017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1341 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 22:38:05 +00:00
punyabrata@webrtc.org
a0211c38ca Updating video revision 
Review URL: http://webrtc-codereview.appspot.com/335016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1339 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 20:02:00 +00:00
mikhal@webrtc.org
a58888d382 Updating capture module following latest libyuv api changes 
Review URL: http://webrtc-codereview.appspot.com/337009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1338 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 19:23:24 +00:00
mikhal@webrtc.org
7d5ca2be1f Updating render module following latest libyuv api changes. 
Review URL: http://webrtc-codereview.appspot.com/331019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1337 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 19:01:48 +00:00
mikhal@webrtc.org
d61e1cab08 Updating video engine following latest libyuv api changes 
Review URL: http://webrtc-codereview.appspot.com/330026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1336 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 18:57:52 +00:00
kma@webrtc.org
746f9e31c0 Changed build settings for ARMv5 in Android. 
I found some issues in building ARMv5 with ICM. This CL includes fixes,
and a design change which now will exclude any NEON libraries unless 
the build is for dynamic detection or for Neon specifically.
Review URL: http://webrtc-codereview.appspot.com/330021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1335 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 17:47:57 +00:00
pwestin@webrtc.org
6c1d41583a Fix for RTP extension audio level. 
Review URL: http://webrtc-codereview.appspot.com/339002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1334 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 17:04:51 +00:00
andrew@webrtc.org
d77a6614fa Consts can't be used as C array size initializers. 
(Unless you happen to be using clang...)

TBR=bjornv@webrtc.org
TEST=build on gcc

Review URL: http://webrtc-codereview.appspot.com/333029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1333 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 16:22:24 +00:00
henrik.lundin@webrtc.org
d047b2e7f6 Enabling NetEQ unittest for more platforms 
Removing platform limitations for NetEqDecodingTest:TestBitExactness
and NetEqDecodingTest:TestNetworkStatistics. New reference files
where provided in revision 6 of the resources, which allows us
to enable these tests.

BUG=
TEST=neteq_unittests linux32/64, win32/64, mac32

Review URL: http://webrtc-codereview.appspot.com/329027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1332 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 16:10:23 +00:00
andrew@webrtc.org
3905b0c45d Protect against divide-by-zeros in AGC. 
TEST=audioproc_unittest

Review URL: http://webrtc-codereview.appspot.com/333024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1331 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 15:47:20 +00:00
pwestin@webrtc.org
c450a19669 Removed Version function from all modules. 
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 15:00:12 +00:00
kjellander@webrtc.org
94558d83bf Fixing Valgrind warnings caused by open files and undeleted memory. 
Restructured scaler_unittest.cc to focus tests on testing one thing.

BUG=
TEST=libyuv_unittests in Debug+Release at Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/329026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1329 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 13:51:50 +00:00
henrik.lundin@webrtc.org
d439870473 Adding two new network metrics to NetEQ 
Clock-drift (in parts-per-million) and peaky-jitter mode status.
Both metrics are propagated to the VoE API. Tests are added
in the NetEQ unittests, and to some extent in ACM unittests
and VoE tests.

Introducing a proper translation between structs NetworkStatistics
and ACMNetworkStatistics.

Note: The file neteq_network_stats.dat in resources must be updated
for the unittests to pass.

Review URL: http://webrtc-codereview.appspot.com/337005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1328 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 13:09:55 +00:00
bjornv@webrtc.org
80d28b22b9 Changed to new ring buffer in AECM. 
Replaced the old ring buffer in AECM with the new one. Also removed the old one from ring_buffer.
Changes are bit exact according to audioproc_unittest fixed.

TEST=audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/331022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1327 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 09:55:09 +00:00
bjornv@webrtc.org
226c5a1a95 Refactoring of vad_sp.[h/c] 
- define guard name change
- changed to stdint
- added unit test
- removed shift macros
- style changes
- comments
Review URL: http://webrtc-codereview.appspot.com/336004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1326 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 09:15:12 +00:00
kjellander@webrtc.org
cc33737a80 Changing all PSNR/SSIM calculations to use libyuv. 
Removed old PSNR/SSIM implementations in:
* test/testsupport/metrics/video_metrics.cc
* src/modules/video_coding/codecs/test_framework/test.cc
The functions in video_metrics.cc is now using code in libyuv instead. Old code in test.cc is using the same functions.
The code for video_metrics.h had to be moved into a separate GYP file to avoid circular dependency error on Mac (see issue 160 for more details). The reason for this is that libyuv's unittest target depends on test_support_main.

BUG=
TEST=metrics_unittests in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/333025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1325 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 08:09:32 +00:00
turaj@webrtc.org
a574b1c617 The inline implementation of WebRtcIsac_lrint(), which was implemented in several files, is now os_specific_inline.h. Define guards are modified according to WebRtc OS macros. 
This resolves BUG=issue137.
Review URL: http://webrtc-codereview.appspot.com/269014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1323 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 02:26:23 +00:00
mikhal@webrtc.org
cd64886a2f video_coding: Updating NACK functions naming 
Review URL: http://webrtc-codereview.appspot.com/329018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1322 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 23:59:42 +00:00
punyabrata@webrtc.org
8fa31bc4e5 Truncated messages, need a %S instead of $s for a double byte TCHAR 
Review URL: http://webrtc-codereview.appspot.com/333002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1321 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 22:34:15 +00:00
mflodman@webrtc.org
adec9271b0 Correcting VieChannelManager bug. 
Review URL: http://webrtc-codereview.appspot.com/337010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1320 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 21:43:15 +00:00
amyfong@webrtc.org
de5a10a044 Added in setting the minimum bit rate of a codec to ViE Custom Call 
Review URL: http://webrtc-codereview.appspot.com/333019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1319 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 21:06:26 +00:00
mikhal@webrtc.org
77c425b976 video_coding: Checking/updating seq num for an old packet regardless of size. 
Review URL: http://webrtc-codereview.appspot.com/330028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1318 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 20:35:25 +00:00
mikhal@webrtc.org
c00f91d62d Adding BGRA as a video type. 
This CL is a prerequisite for the capture module update CL. 
Review URL: http://webrtc-codereview.appspot.com/329021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1317 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 18:49:15 +00:00
andrew@webrtc.org
877c54e230 Fix unused-variable warning in Release. 
TBR=mflodman@webrtc.org
TEST=Build Debug/Release on Linux

Review URL: http://webrtc-codereview.appspot.com/338003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1316 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 18:32:01 +00:00
bjornv@webrtc.org
f175125e96 Refactoring vad_filterbank: Style changes. 
Includes:
- Correct header guard
- Indentations and white spaces
- Changed to stdint
Review URL: http://webrtc-codereview.appspot.com/330030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 15:07:42 +00:00
mflodman@webrtc.org
9c0aedc28b Removed constraint for changing resolution when using default encoder and added VP8 log. 
Review URL: http://webrtc-codereview.appspot.com/330029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1314 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 13:46:49 +00:00
henrik.lundin@webrtc.org
6c877363f7 Fix formatting for some NetEQ test tools 
Format and lint for RTPchange.cc, RTPcat.cc and RTPanalyze.cc.

Review URL: http://webrtc-codereview.appspot.com/329024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1313 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 10:03:19 +00:00
perkj@webrtc.org
60c9bbd976 Fix GetReceivedRTCPStatistics and GetSendRTCPStatistics. 
Comments where wrong and removed error message when trying to get RTT time from GetReceivedRTCPStatistics.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/335013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1312 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 09:54:29 +00:00
mflodman@webrtc.org
d5a4d9bce6 First refactoring of ViE interface. 
Review URL: http://webrtc-codereview.appspot.com/337003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1311 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-02 13:04:05 +00:00
kjellander@webrtc.org
a643d5c4ef Integration test for videoprocessor 
Added temporal layers number flag for video_quality_measurement tool.
This tool now also uses webrtc::VideoCodingModule::Codec() to get its
VideoCodec struct configuration instead of filling it in manually.

Updated paths for header files to use full directory paths.

Tested in Debug+Release on Linux, Mac and Windows. Passes Valgrind memcheck on Linux.

BUG=
TEST=video_codecs_test_framework_integrationtests. Also executed out/Debug/video_quality_measurement --input_filename=resources/foreman_cif.yuv  --width=352 --height=288

Review URL: http://webrtc-codereview.appspot.com/339001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1310 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-30 14:44:07 +00:00
mikhal@webrtc.org
62665b8cd3 video_coding: Adding a unit test to the decodableState class 
Review URL: http://webrtc-codereview.appspot.com/315001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1309 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-29 18:09:58 +00:00
mikhal@webrtc.org
9eeafbef3c Updating the frame buffer return value in InsertPacket: Return NoError when a packet is inserted to a frame which is being decoded. 
Review URL: http://webrtc-codereview.appspot.com/330027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1308 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-29 17:38:56 +00:00
mikhal@webrtc.org
bed34a341a video_coding: Updating seq number for old zero size packets. Updating function name to reflect zero size packets and not empty packets. 
Review URL: http://webrtc-codereview.appspot.com/333009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1307 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-29 17:37:39 +00:00
bjornv@webrtc.org
70adcd46b2 Delay estimator improvements. 
Robustness improvements to the delay estimator used in AECM and AEC. In AEC only for logging. Faster convergence.

TEST=audioproc_unittest + offline file tests.

output_data_fixed.pb updated despite unverified changes in r1112.
Review URL: http://webrtc-codereview.appspot.com/337006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1306 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-29 14:51:21 +00:00
stefan@webrtc.org
efd0a48c61 Add error resilient mode options to the VP8 specific VideoCodec struct. 
It is useful to disable error resilience when we know we won't decode
with errors.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1305 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-29 10:12:35 +00:00
mikhal@webrtc.org
67f294a48a Adding a return value to ConvertRotationMode 
Review URL: http://webrtc-codereview.appspot.com/333023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1304 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-28 23:28:45 +00:00
andrew@webrtc.org
6d6a43d6e3 Use char as ring-buffer data type. 
- Avoids a bunch of char* casts.
- Use enum type rather than char.

TEST=audioproc_unittest on Linux (float and fixed), build on Windows

Review URL: http://webrtc-codereview.appspot.com/336010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1303 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-28 22:40:15 +00:00
mikhal@webrtc.org
e2642494e4 libyuv: Updating API to use latest ConvertFrom/To functionality 
Review URL: http://webrtc-codereview.appspot.com/333020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1302 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-28 21:21:40 +00:00
bjornv@webrtc.org
267d0133ff Fixed pointer operations on void. 
This should fix the error on Win where pointer arithmetics are done on void pointers. Type cast to char to interpret a size.
Review URL: http://webrtc-codereview.appspot.com/329019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1300 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-28 10:26:17 +00:00
bjornv@webrtc.org
7270a6bcc2 Merged apm-buffer branch [r1293] back to trunk. 
This CL includes a larger structural change in how we handle buffers in AEC. We now perform FFT at once and move within blocks to compensate for system delays.

TEST=audioproc_unittest(float and fix), voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/335012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1299 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-28 08:44:17 +00:00
mikhal@webrtc.org
e39de16fa5 Moving video type convert functionality to libyuv. deleting vplibConversions as it is no longer needed. 
Review URL: http://webrtc-codereview.appspot.com/338002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1298 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-27 23:45:30 +00:00
stefan@webrtc.org
f6c6b1c5b5 Include the media packet FEC headers in the video bitrate. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/328014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1296 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-23 10:33:39 +00:00
stefan@webrtc.org
39670f6aa6 Only reset the last decoded sequence number after flushing until key frame. 
We can't reset the complete last decoded state when we recycle until a
key frame because that will allow any delta frame to be decoded afterwards,
and since the decoder isn't reset we will get decode errors.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/330003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1295 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-23 09:08:51 +00:00
mflodman@webrtc.org
1ce66e4dfb Don't report error when failing to send RTCP BYE. 
Review URL: http://webrtc-codereview.appspot.com/337002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1293 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 18:40:15 +00:00
amyfong@webrtc.org
ee2924cc56 Added vp8 codec temporal layer changing option to ViE AutoTest custom call. 
Review URL: http://webrtc-codereview.appspot.com/330018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1292 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 18:24:28 +00:00
mflodman@webrtc.org
d32c44738a Changed constructor used for CriticalSectionScoped in ViE. 
Only changed:
- Name of some of the critsects.
- All critsects (but one) are now scoped_ptr.
- Use of ptr constructor of CriticalSectionScoped instead of reference version.

BUG=184
TEST=vie_auto_test

Review URL: http://webrtc-codereview.appspot.com/330015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1291 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 14:17:53 +00:00
stefan@webrtc.org
6a4bef4e65 Implements selective retransmissions. 
Default is set to not retransmit VP8 non-base layer packets or FEC packets.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/323010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1290 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 12:52:41 +00:00
mflodman@webrtc.org
51faeed6be Fixed REMB unit test on Windows. 
TBR=pwestin

Review URL: http://webrtc-codereview.appspot.com/330022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1289 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 12:35:23 +00:00
pwestin@webrtc.org
f4d3b9d5a1 Cleaned up leaky symbols in NS. 
Review URL: http://webrtc-codereview.appspot.com/337001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1288 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 12:33:08 +00:00
pwestin@webrtc.org
ebcb6421b1 Cleaned up leaky symbols in G722. 
Review URL: http://webrtc-codereview.appspot.com/333017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1287 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 12:20:06 +00:00
pwestin@webrtc.org
d8f8b32521 Cleaned up leaky symbols in iSAC. 
Review URL: http://webrtc-codereview.appspot.com/329014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1286 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 12:19:43 +00:00
stefan@webrtc.org
2ae4c8cf44 Disable temporal toggling by default. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1285 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 10:30:42 +00:00
mflodman@webrtc.org
84dc3d134d Add REMB functionality to ViE. 
This CL only adds support for encoding one stream, but receiving multiple streams.

BUG=
TEST=video_engine_core_unittest + auto_test/loopback

Review URL: http://webrtc-codereview.appspot.com/333011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1284 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 10:26:13 +00:00
pwestin@webrtc.org
093ffad26b Removed unused function messing up the symbols. 
Review URL: http://webrtc-codereview.appspot.com/336006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 09:48:48 +00:00
pwestin@webrtc.org
43761beb47 Bugfix get thread ID for linux. 
Review URL: http://webrtc-codereview.appspot.com/331015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1282 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 09:40:28 +00:00
mflodman@webrtc.org
a4863dbdf0 Moved video_engine/main/interface to video_engine/include. 
Only changed include paths in files, gyp-files and Android.mk.

TEST=vie_auto_test and peerconnection_client builds.

Review URL: http://webrtc-codereview.appspot.com/330017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1281 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 08:51:52 +00:00
henrik.lundin@webrtc.org
1e28d3c2e1 Change VP8 packetizer to use a single max payload size 
The packetizer class is changed so that the max payload size is
provided on construction of the class rather than for each packet.
The tests are re-written to comply with the new design.

Also fixing a few errors in the tests.

Review URL: http://webrtc-codereview.appspot.com/335010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 08:49:31 +00:00
stefan@webrtc.org
f5edb923b1 Remove unused variable. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/333016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1279 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 08:34:31 +00:00
tina.legrand@webrtc.org
5c43b1b861 Updated resampler unit test with stereo. 
I needed to run valgrind on this particular test, to exclude from valgrind warnings in ACM. Test passes valgrind without problems.
Review URL: http://webrtc-codereview.appspot.com/332010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1278 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 08:28:05 +00:00
pwestin@webrtc.org
8edb39db30 Prevent sending empty RTCP packet. 
Review URL: http://webrtc-codereview.appspot.com/331009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1277 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 07:40:33 +00:00
henrik.lundin@webrtc.org
4a19030131 New VCM robustness API 
This CL defines and starts to implement a new robustness API for
video coding module. The API is partly implemented. Some of the
modes and methods are still TBD.

Also including a new unittest with mocking of decoder and callbacks,
and faking of system clock.

Review URL: http://webrtc-codereview.appspot.com/333006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1276 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 20:38:37 +00:00
andrew@webrtc.org
697bc43b67 Restore item deletions in Windows UDP. 
TEST=voe_auto_test on Windows.

Review URL: http://webrtc-codereview.appspot.com/331013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1275 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 19:58:11 +00:00
andrew@webrtc.org
71571c5446 Remove unneeded variables from windows UDP. 
TEST=build on Windows.

Review URL: http://webrtc-codereview.appspot.com/329013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1274 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 18:30:59 +00:00
andrew@webrtc.org
3192d655bd Fix for devices lacking stereo support. 
The number of capture channels can only be determined upon receiving the
first captured frame. We now assume stereo capture by default and set the
number of AudioProcessing input channels based on captured frames.

TEST=Windows mono-only device now runs AudioProcessing correctly (NS etc.), voe_auto_test (though some new, seemingly unrelated, tests are failing)

Review URL: http://webrtc-codereview.appspot.com/330013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1273 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 18:00:59 +00:00
andrew@webrtc.org
003044a6df Enable warnings-as-errors on Mac. 
TEST=build on Mac (make and XCode)

Review URL: http://webrtc-codereview.appspot.com/335007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1272 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 16:36:56 +00:00
kjellander@webrtc.org
173b7bbc16 Integration test that tracks dropped frames and compares video output. 
The recorded frame timestamps are used to modify the output video on a frame-per-frame so it can be compared with the reference video using PSNR. This code will make it possible to use vie_auto_test for full stack comparisons with network interference and similar interesting simulations.

There's some refactoring done in vie_comparison_test.cc to make it fit to the new test.

Compiled and executed in Debug+Release on Linux, Mac and Windows.

BUG=
TEST=vie_auto_test --automated --gtest_filter=ViEVideoVerificationTest.*

Review URL: http://webrtc-codereview.appspot.com/320002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1269 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 16:11:25 +00:00
mallinath@webrtc.org
03532b5f41 Fixing the double delete problem in UdpSocket2ManagerWindow. PopFront deletes the items, to there is no need to delete item explicitly. 
Review URL: http://webrtc-codereview.appspot.com/333014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1268 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 15:36:44 +00:00
henrik.lundin@webrtc.org
7d8c72e2db Re-implement dependency injection of TickTime into VCM and tests 
This change basicly re-enables the change of r1220, which was
reverted in r1235 due to Clang issues.

The difference from r1220 is that the TickTimeInterface was
renamed to TickTimeClass, and no longer inherits from TickTime.

Review URL: http://webrtc-codereview.appspot.com/335006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1267 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 15:24:01 +00:00
kjellander@webrtc.org
5490c71a1b Converted to gtest, writing output files properly and no longer uses exceptions. 
This test now runs and fails as a gtest should (previously it always
exited with 0 even if the tests failed).
The audio_coding_module_test target no longer uses exceptions in the generated project.
Output files are written to our global output folder, using
testsupport/fileutils.h.

BUG=
TEST=audio_coding_module_test on all platforms, in Debug+Release

Review URL: http://webrtc-codereview.appspot.com/334004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1266 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 13:34:18 +00:00
mflodman@webrtc.org
1fe2ada38d Fixed Win bug introduced when refactoring ViECodecImpl. 
TBR=perkj

Review URL: http://webrtc-codereview.appspot.com/328013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1264 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 12:23:15 +00:00
mflodman@webrtc.org
c12686c2d0 Refactored ViEEncryptionImpl, ViECodecImpl and removed unused SRTP hooks/APIs in ViEEncrption. 
Review URL: http://webrtc-codereview.appspot.com/331004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 09:29:28 +00:00
stefan@webrtc.org
898f881e32 Make sure the next frame to be decoded is cleaned up if it's empty. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/332001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1261 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 09:13:14 +00:00
niklas.enbom@webrtc.org
6c9be123ef Letting strncpy do its job. Landing and extending http://webrtc-codereview.appspot.com/329010/ on behalf of tbreisacher. 
Review URL: http://webrtc-codereview.appspot.com/335009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1260 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 08:59:31 +00:00
stefan@webrtc.org
8c5d24266e Fix VP8 layer 2 sync dependencies. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/333010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1259 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 08:56:04 +00:00
henrik.lundin@webrtc.org
00e730730e Refactoring RtpFormatVp8Test 
This is the first change in a series of changes to get new functionality
into the VP8 packetizer.

This first refactors the RtpFormatVp8Test class, without changing the
operation of the tested RtpFormatVp8 class. A test helper class
RtpFormatVp8TestHelper is introduced to reduce code duplication.

Review URL: http://webrtc-codereview.appspot.com/304009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1258 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 08:51:36 +00:00
niklas.enbom@webrtc.org
b2c115c460 Forcing external transport to be on in Chrome. 
Review URL: http://webrtc-codereview.appspot.com/330010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1257 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-21 07:38:54 +00:00
mikhal@webrtc.org
61045a4a03 video_coding/jitter_buffer: Account for layer info when searching for the next frame 
Review URL: http://webrtc-codereview.appspot.com/328003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1256 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 23:24:19 +00:00
andrew@webrtc.org
a38ce09919 Fix last Mac/clang compile error. 
Fixes "receiver is a forward class and corresponding @interface may
not exist" error.

TEST=build on Mac with -Werror enabled.
TBR=zakkhoyt@webrtc.org

Review URL: http://webrtc-codereview.appspot.com/333012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1255 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 22:23:21 +00:00
andrew@webrtc.org
e858d13ac6 Add a NOOP target for merge libs. 
Also allow certain components to not be built.

TEST=build merged_lib

Review URL: http://webrtc-codereview.appspot.com/328001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1254 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 22:07:48 +00:00
mikhal@webrtc.org
6f7fbc7fbe libyuv: Adding psnr/ssim to libyuv and updating unit tests according to latest conventions. 
Review URL: http://webrtc-codereview.appspot.com/331007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1253 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 17:38:28 +00:00
pwestin@webrtc.org
061fa5b828 Changed handling of padding data. 
Review URL: http://webrtc-codereview.appspot.com/331008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1252 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 15:56:17 +00:00
henrik.lundin@webrtc.org
dbba1f969f Packet waiting-time statistics 
Adding new statistics API to NetEQ, reporting the waiting time
for each frame. The output is raw waiting time for the frames
that have been decoded since the last statistics report (or
maximum 100 frames). The statistics are reset on each query.

Implemented functionality in ACM to query NetEQ for the raw
waiting times, and process it to produce max, average and
median.

Updating common_types.h and VoiceEngine tests to include the
new metrics.

Unit tests are also added for NetEQ and AcmNetEq.

Review URL: http://webrtc-codereview.appspot.com/328011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1251 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 15:45:05 +00:00
henrik.lundin@webrtc.org
219acc6cec Including Brighten function in namespace VideoProcessing 
This change is in response to Issue 173.

BUG=http://code.google.com/p/webrtc/issues/detail?id=173

Review URL: http://webrtc-codereview.appspot.com/328012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1250 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 15:33:49 +00:00
bjornv@webrtc.org
c68f80a70a Refactoring vad_gmm.[c/h]. 
- Changed to stdint.
- Replaced SHIFT macros.
- Variable name changes.
- Style changes.
- Comments updates.
- Added a unit test.
Review URL: http://webrtc-codereview.appspot.com/323011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1249 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 14:08:34 +00:00
mflodman@webrtc.org
42d07f0c58 Render impl fix from refactoring. 
Review URL: http://webrtc-codereview.appspot.com/329009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1248 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 13:20:36 +00:00
mflodman@webrtc.org
1bdf1dffb4 Refactored ViEImageProcess, ViEImpl and ViENetworkImpl. 
Review URL: http://webrtc-codereview.appspot.com/331005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1247 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 11:57:47 +00:00
mflodman@webrtc.org
813b4ef2ea Refactored ViEFileImpl and ViEExternalCodec. 
Review URL: http://webrtc-codereview.appspot.com/330007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1246 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 10:39:30 +00:00
phoglund@webrtc.org
f3cea2336b Added an empty voice engine unit test binary in order to get correct coverage measurements. This will make the voice engine show up in the coverage measurements. The empty test is necessary to get the coverage tool to pick it up (and it will be easier to start writing unit tests for the voice engine later). 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/334003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1245 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 10:14:53 +00:00
stefan@webrtc.org
62fdc42e9c Fix build issue with clang. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/330009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1244 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 09:27:09 +00:00
stefan@webrtc.org
8dc9e4760e Fixes for selective NACKing. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/332007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1243 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 09:12:50 +00:00
phoglund@webrtc.org
fda17c2b00 Rewrote NetEQ test, made standard suite run googletestified tests too. 
The standard suite will now also run the googletestified tests.

Removed NetEQ tests from the standard test.

Initial version of new neteq test. Moved fixtures to own folder.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/328010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1242 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 09:07:37 +00:00
tina.legrand@webrtc.org
5efcad1758 We used the wrong syntax for "new", which generated a warning/error building with clang. 
Review URL: http://webrtc-codereview.appspot.com/336003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1241 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 09:05:55 +00:00
mikhal@webrtc.org
9e4f3830a7 Removing vplib: Following the switch to Libyuv, this CL removes all vplib files. 
Review URL: http://webrtc-codereview.appspot.com/321003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1239 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 19:24:32 +00:00
mikhal@webrtc.org
0e7d9d862a Adding layer info consideration when applying FEC protection. In this first version, we hard code protection zero for non-base layer frames. As a future enhancement, an array should be passed from mediaOpt to set the protection per layer. A TODO was added in MediaOpt. 
Review URL: http://webrtc-codereview.appspot.com/330005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1238 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 19:04:49 +00:00
mikhal@webrtc.org
190e88a6d3 video_coding: When in hybrid mode, don't NACK non-base layer packets 
Review URL: http://webrtc-codereview.appspot.com/334002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1237 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 18:57:14 +00:00
mikhal@webrtc.org
884d8e7f4b video_coding: Updating sync state based on the layer flag 
Review URL: http://webrtc-codereview.appspot.com/333004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1236 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 18:53:05 +00:00
henrik.lundin@webrtc.org
303158588b Revert "Inject TickTimeInterface into VCM and tests" 
This CL reverts r1220.

Review URL: http://webrtc-codereview.appspot.com/336002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1235 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 17:55:45 +00:00
henrika@webrtc.org
e32c08a5a6 Removes usage of default parameters and fixes a bug which was found 
using Clang on Linux.

BUG=none
TEST=none
TBR=pwestin

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1234 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 17:39:48 +00:00
henrike@webrtc.org
4158c35820 Removed the WEBRTC_NO_TRACE macro since the style guide wants us to stear clear of macros and this one doesn't seem to have a purpose at this point. 
Review URL: http://webrtc-codereview.appspot.com/315006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1233 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 17:28:25 +00:00
mflodman@webrtc.org
8da2417c9d Refactored ViERenderImpl and ViERTP_RTCPImpl. 
Review URL: http://webrtc-codereview.appspot.com/329005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1232 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 14:18:41 +00:00
mflodman@webrtc.org
7752d11056 Fix test for external codec. 
Review URL: http://webrtc-codereview.appspot.com/328007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1231 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 12:29:56 +00:00
phoglund@webrtc.org
86a9f9b946 Fixed build error. 
Merge branch 'master' into voe_rewrites

Conflicts:
	src/voice_engine/main/test/auto_test/standard/after_streaming_fixture.cc

Revert "Rewrote network-before-streaming."

This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.

Rewrote network-before-streaming.

Fixed strange build error.

Merge branch 'master' into voe_rewrites

Revert "Rewrote network-before-streaming."

This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.

Rewrote network-before-streaming.

Nit fixes

Clarified some comments and method names.

Style fixes.

Removed tab characters.

Merge branch 'master' into voe_rewrites

Conflicts:
	src/voice_engine/main/test/auto_test/voe_standard_test.cc

Revert "Rewrote network-before-streaming."

This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.

Rewrote network-before-streaming.

Rewrote the hold test.

Abstracted out resource handling and created a new fixture for starting and stopping playing.

Rewrote network-before-streaming.

Revert "Rewrote network-before-streaming."

This reverts commit f1a07b813a90e4feef0a0737ebde9fb15acfd459.

Rewrote network-before-streaming.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/333007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1230 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 10:24:46 +00:00
stefan@webrtc.org
b33f9dccd6 Correction to how the VP8 wrapper generates picture ids. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1229 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 10:24:02 +00:00
phoglund@webrtc.org
188fc35e07 Rewrote the hold and netw-before-streaming tests. 
Rewrote the hold test.

Abstracted out resource handling and created a new fixture for starting and stopping playing.

Rewrote network-before-streaming.

BUG=
TEST=voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/331001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1228 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 09:36:03 +00:00
tina.legrand@webrtc.org
398af2337b Solving issue 178, errorbuild warnings on Mac. 
This CL continues the work of solving issue 178. A small change in one file.
Review URL: http://webrtc-codereview.appspot.com/330006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1227 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-19 07:36:07 +00:00
henrike@webrtc.org
cf5bcd1fd2 Removed usage of the deprecated critical section constructor in audio_conference_mixer. 
Review URL: http://webrtc-codereview.appspot.com/320007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 23:00:30 +00:00
andrew@webrtc.org
8a44259ea8 Move static consts out of class. 
Still causing a gtest error on non-Win platforms. This should fix it...

TBR=asapersson@webrtc.org
TEST=build on Linux

Review URL: http://webrtc-codereview.appspot.com/332006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1225 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 21:24:30 +00:00
andrew@webrtc.org
41192469f6 Switch enums to consts to fix gtest error. 
TBR=asapersson@webrtc.org
TEST=build on Windows

Review URL: http://webrtc-codereview.appspot.com/330008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1224 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 20:55:46 +00:00
henrike@webrtc.org
105e07193e Removed usage of the deprecated critical section constructor in modules/utility. 
Review URL: http://webrtc-codereview.appspot.com/321006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1223 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 19:53:46 +00:00
marpan@webrtc.org
57353a33f1 FEC Receiver: Fix to how old packets (e.g., re-tranmitted packets in hybird NACK-FEC mode) are treated. 
This change avoids having old packets end up on the current packet list for FEC decoding, and so they are immediately sent out to jitter buffer.
The current list of packets for FEC decoding are sent out only when new packet arrives (with time-stamp greater than current).
Review URL: http://webrtc-codereview.appspot.com/322009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1222 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 17:21:09 +00:00
henrik.lundin@webrtc.org
e7d8c56c56 Fix for dual decoder in VCM receiver 
In VCMReceiver::FrameForDecoding, one of the if-cases could sometimes
extract an incomplete frame without first copying the state to the
dual decoder.

Review URL: http://webrtc-codereview.appspot.com/328006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1221 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 15:40:52 +00:00
henrik.lundin@webrtc.org
a70f945086 Inject TickTimeInterface into VCM and tests 
The purpose of this change is to introduce dependency injection
of the timer into the video coding module.

Review URL: http://webrtc-codereview.appspot.com/332003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1220 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 14:40:05 +00:00
asapersson@webrtc.org
5249cc8f77 Review URL: http://webrtc-codereview.appspot.com/295010 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1219 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 14:31:37 +00:00
tina.legrand@webrtc.org
9775a30859 Added variable to catch return value. 
Review URL: http://webrtc-codereview.appspot.com/329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1218 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 11:15:46 +00:00
kjellander@webrtc.org
08dec7f449 Now using fileutils.h OutputPath to write output to the right directory and ResourcePath to read resource files from the resource bundle. 
Removed some Valgrind warnings by closing output files. There are still some Valgrind warnings left, that needs to be fixed by a developer with more insight.

Updated all include paths to contain full paths to header files.

Tested in Debug+Release on Linux, Mac and Windows.
All tests ran successfully except the VideoProcessingModuleTest.ContentAnalysis test that fails on Windows with the following error:
unknown file: error: SEH exception with code 0xc0000005
thrown in the test body.
Fixing that is out of scope for this CL.

Review URL: http://webrtc-codereview.appspot.com/266011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1217 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 10:31:38 +00:00
tina.legrand@webrtc.org
554ae1ad4e Changes to solve warnings on Mac, issue #178. 
Review URL: http://webrtc-codereview.appspot.com/320005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1216 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 10:09:04 +00:00
mflodman@webrtc.org
605972edfd Refactored ViECaptureImpl. 
Review URL: http://webrtc-codereview.appspot.com/332004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1215 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 08:59:24 +00:00
mflodman@webrtc.org
352dcd8b2d Refactored vie_file_image. 
Review URL: http://webrtc-codereview.appspot.com/332002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1214 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-16 08:52:41 +00:00
andrew@webrtc.org
04f5cba069 Switch to new critsect interface for DataLog. 
The introduction of the new interface broke DataLog in a release build
(with enable_data_logging=1).

TBR=henrike@webrtc.org
TEST=build Linux/Release with enable_data_logging=1

Review URL: http://webrtc-codereview.appspot.com/334001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1212 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 21:33:11 +00:00
henrike@webrtc.org
7136990a3f Removed usage of the deprecated critical section constructor in udp_transport. 
Review URL: http://webrtc-codereview.appspot.com/321005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1211 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 19:17:28 +00:00
andrew@webrtc.org
986fab1496 Clean up file wrapper a bit further. 
- Make error handling in Read, Write and WriteText consistent.
- Improve the interface comments a bit.

TEST=voe_auto_test, vie_auto_test

Review URL: http://webrtc-codereview.appspot.com/321012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1210 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 19:11:41 +00:00
leozwang@webrtc.org
0c839fe873 Add new source file to makefile 
Review URL: http://webrtc-codereview.appspot.com/322015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1209 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 19:10:24 +00:00
henrike@webrtc.org
bfa80ce95e Removed usage of the deprecated critical section constructor in system_wrappers. 
Review URL: http://webrtc-codereview.appspot.com/322004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1208 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 17:59:58 +00:00
henrik.lundin@webrtc.org
0a10e3c4b2 Fix order of include and guard in tick_time_interface.h 
Review URL: http://webrtc-codereview.appspot.com/331002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1207 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 16:08:36 +00:00
mflodman@webrtc.org
091029ba26 Refactored ViEFileRecorder. 
Types and arguments will be done in a  later CL.

Review URL: http://webrtc-codereview.appspot.com/317008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1206 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 15:31:47 +00:00
mflodman@webrtc.org
03c06505fb Refactored ViEChannel. 
Pointers/references and types will be in a future CL.

Review URL: http://webrtc-codereview.appspot.com/322016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1205 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 15:23:08 +00:00
henrik.lundin@webrtc.org
c74b2861f3 Fix the include in fake_tick_timer_interface.h 
The include was in error.

Review URL: http://webrtc-codereview.appspot.com/330002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1204 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 11:28:31 +00:00
phoglund@webrtc.org
610e90e910 Completed rewrite of codec test. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/324011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1203 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 10:40:19 +00:00
mflodman@webrtc.org
e8be22c192 Refactored ViEChannelManager ViEInputManager. 
Pointers/references and types will come in a future CL.

Review URL: http://webrtc-codereview.appspot.com/317012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1202 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 10:19:29 +00:00
leozwang@webrtc.org
e0e07bbaa0 Change file name because of r1199 
Review URL: http://webrtc-codereview.appspot.com/320013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1201 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 00:51:45 +00:00
kma@webrtc.org
ee36b9587d corrected android makefile for isac build. 
Review URL: http://webrtc-codereview.appspot.com/321013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1200 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 00:18:45 +00:00
andrew@webrtc.org
59ccd5c71f Rename _windows.h -> _win.h in system_wrappers. 
- Also rename _dummy -> no_op which states its purpose more clearly.
- Always use exclusion lists (i.e. sources! instead of sources)

TEST=builds and passes system_wrapper_unittest on Linux, Mac, Win

Review URL: http://webrtc-codereview.appspot.com/317007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1199 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-15 00:17:43 +00:00
kma@webrtc.org
6a17340db5 Review URL: http://webrtc-codereview.appspot.com/318014 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1197 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 22:16:57 +00:00
leozwang@webrtc.org
5fddbeb7e5 Build libyuv for webrtc 
Review URL: http://webrtc-codereview.appspot.com/322012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1196 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 20:03:26 +00:00
leozwang@webrtc.org
eda2da796e Fix compilation errors 
Review URL: http://webrtc-codereview.appspot.com/322014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1195 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 20:03:09 +00:00
kma@webrtc.org
a30093bb85 Added one file associated with check in in r1192. 
Review URL: http://webrtc-codereview.appspot.com/320012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1194 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 19:57:23 +00:00
leozwang@webrtc.org
9aa9f44ebc Add new source files because of r1174 
Review URL: http://webrtc-codereview.appspot.com/320011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1193 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 19:08:33 +00:00
kma@webrtc.org
f0a964dc0a Optimized WebRtcIsacfix_NormLatticeFilterMa() function for iSAC fix for ARM Neon 
architecture with intrinsics and assembly code. The total iSAC codec speech improved
about 3~5%.

Notes
(1) The Neon version after this optimization is not bit-exact with the generic
C version. The out quality, however, is not worse as verified by test vectors ouput,
and undertandably in theory (32bit x 32bit in Neon is more accurate than the approximation
C code in the generic version).
(2) In Android, a isac neon library will be built. Along with some new function structures,
it is partly for preparation of introducing a run time detection of Neon architecture soon.
Review URL: http://webrtc-codereview.appspot.com/268016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1192 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 18:59:43 +00:00
mflodman@webrtc.org
02afbeaca5 Refactored ViERenderManager. 
Will follow up with a new CL for pointer/references and functino arguments.

Review URL: http://webrtc-codereview.appspot.com/323013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1191 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 18:50:47 +00:00
kma@webrtc.org
6601902504 Introduced WebRtcSpl_SatW32ToW16 to iSAC fix, for Android platforms. 
Review URL: http://webrtc-codereview.appspot.com/315005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1190 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 18:41:07 +00:00
leozwang@webrtc.org
f147bbc878 Change codec test app lib dependency from webrtc lib to codec library 
Review URL: http://webrtc-codereview.appspot.com/317009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1189 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 18:22:41 +00:00
andrew@webrtc.org
7e5ddf5aa3 Restore behavior to FileWrapper::Read. 
- Returning the number of bytes read was mistakenly removed in r1175 in
  an overzealous attempt to unify the interface.
- Now both Read and WriteText return the number of bytes/characters
  processed. Write unfortunately cannot be easily changed due to the
  inheritance from OutStream.
- Improve the interface comments.

TBR=henrika@webrtc.org
BUG=issue196, issue198
TEST=voe_auto_test passes at last...

Review URL: http://webrtc-codereview.appspot.com/326001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1188 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 18:02:02 +00:00
henrike@webrtc.org
7cdcde3460 Removed usage of the deprecated critical section constructor in media_file. 
Review URL: http://webrtc-codereview.appspot.com/321004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1187 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 17:27:58 +00:00
stefan@webrtc.org
780a07a843 Fix infinite loop bug introduced in r1174. 
Merges CleanUpSizeZeroFrames with CleanUpOldFrames, and changes the
behavior to go through all frames looking for empty frames.

TBR=mikhals

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/318013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1186 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 15:55:19 +00:00
pwestin@webrtc.org
9fe3d51372 Set the new layer sync bit in the VP8 info struct. 
Review URL: http://webrtc-codereview.appspot.com/324010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1185 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 15:13:04 +00:00
phoglund@webrtc.org
667eca6290 Rewrote the hardware-before-streaming test. 
Restructured the test hierarchy somewhat - there is now a fixture for before-voe-init time and one for after-voe-init time.

Rewrote the hardware-before-streaming test.
Separated unrelated tests out from the rtp_rtcp tests.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/323009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1184 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 13:55:34 +00:00
henrik.lundin@webrtc.org
fbf5af444b Adding a mockable wrapper class for TickTime in VCM 
The class is called TickTimeInterface, with a fake implementation in FakeTickTime.

Review URL: http://webrtc-codereview.appspot.com/323012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1183 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 10:36:10 +00:00
stefan@webrtc.org
ef5247b5b1 Fix session_info_unittest error. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/324009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1182 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 10:25:38 +00:00
stefan@webrtc.org
0c40d3315f Fixes an assert triggered in jitter_buffer_test and disables deblocking. 
When deblocking is enabled the first frames can include uninitialized
memory. Disabling for now.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/320010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1181 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 09:39:30 +00:00
mflodman@webrtc.org
7991c0501f Refactor ViEFilePlayer. 
Types and arguments will be done in a  later CL.

Review URL: http://webrtc-codereview.appspot.com/324002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1180 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 08:38:37 +00:00
mflodman@webrtc.org
e6f64835a0 Refactored ViECapturer. 
Types and function arguments will come in a later CL.

Review URL: http://webrtc-codereview.appspot.com/322011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1179 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 08:36:01 +00:00
mflodman@webrtc.org
9a8fa4e65d Refactored vie_manager_base.*. 
The other files are only due to inheritance and will be refactored later. Same goes for pointer, references and function arguments.

Review URL: http://webrtc-codereview.appspot.com/318003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1178 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 08:18:42 +00:00
andrew@webrtc.org
6d609b59f3 Fix crashes due to static_instance. 
- Initialize a needed critsect in the constructor of
  UdpSocket2ManagerWindows.
- Don't return NULL when creating a static instance.

TEST=voe_auto_test on Windows.

Review URL: http://webrtc-codereview.appspot.com/324008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1177 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 02:36:33 +00:00
andrew@webrtc.org
5a9c6f26ab Fix max size and read-only errors in Write(). 
- A size of zero is now correctly interpreted as unlimited.
- The read-only flag is correctly checked.

TBR=henrika@webrtc.org
TEST=vie_auto_test (for real this time...)

Review URL: http://webrtc-codereview.appspot.com/315007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1176 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-14 00:53:30 +00:00
andrew@webrtc.org
5ae19de3ec Fix error in RtpDump::Start due to r1156. 
- r1156 fixed a check on the _text member of FileWrapper. Turns out this
  was incompatibile with the RTP dumps, which want to write both binary
  and text data. Writing text data to a file open as "b" isn't actually
  an error, so I simply removed the check.
- Also cleans up the interface, most notably removing all WebRtc types.

TEST=vie_auto_test

Review URL: http://webrtc-codereview.appspot.com/317005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1175 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 22:59:33 +00:00
mikhal@webrtc.org
832cacacff video-coding: Adding a decoded state to the JB logic (JB refactor). 
This new class stores the last decoded info, including temporal info. 
Review URL: http://webrtc-codereview.appspot.com/300005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1174 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 21:15:05 +00:00
henrike@webrtc.org
65573f2922 Removed usage of the deprecated critical section constructor in rtp_rtcp. 
Review URL: http://webrtc-codereview.appspot.com/315004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1173 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 19:17:27 +00:00
stefan@webrtc.org
f4c8286222 Pass NACK and FEC overhead rates through the ProtectionCallback to VCM. 
These overhead rates are used by the VCM to compensate the source
coding rate for NACK and FEC.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/323003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1171 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 15:38:14 +00:00
henrik.lundin@webrtc.org
1ced840893 Fixing a nit in the unittest 
This caused some of the build bots to fail.

Review URL: http://webrtc-codereview.appspot.com/324005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1170 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 14:59:00 +00:00
henrik.lundin@webrtc.org
eda86dc76b Adding a LayerSync bit to VP8 RTP header 
Updated RtpFormatVp8, ModuleRTPUtility, VP8Encoder and VP8Decoder
to support a new LayerSync ("Y") bit. Note, in VP8Encoder the bit
must be used together with a non-negative value for temporalIdx.
Fixing the plumbing between RTP module and and from VP8 wrapper.
Updating unit tests; all pass.

The new bit is yet to be used by the VP8 wrapper.

Review URL: http://webrtc-codereview.appspot.com/323008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1169 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 14:11:06 +00:00
henrik.lundin@webrtc.org
4aae0e489f Shaping up formatting of rtp_utility_test.cc 
Preparations for future work in this file.

Review URL: http://webrtc-codereview.appspot.com/318011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1168 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 09:15:21 +00:00
bjornv@webrtc.org
0edb25dcc9 Removed valgrind warnings in resampler_unittest. 
Valgrind complained on uninitialized values in resampler_unittest. Added initialization of the member variable data_in_ in the tests.
Review URL: http://webrtc-codereview.appspot.com/322006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1167 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 09:06:54 +00:00
stefan@webrtc.org
076fa6e674 The second step towards a list based SessionInfo. 
Added unittests for most of public functions of SessionInfo.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/301014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1166 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 07:54:56 +00:00
wjia@webrtc.org
c28e7980ef exclude trace_windows.cc and trace_posix.cc when building with Chromium. 
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/324004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1165 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 02:16:11 +00:00
mikhal@webrtc.org
71d6391716 libyuv: fixing a bug in RotateI420 and updating test 
Review URL: http://webrtc-codereview.appspot.com/324003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1164 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 00:56:11 +00:00
mikhal@webrtc.org
352ade7023 video_coding: Allocating encoded buffer based on length and not size 
Review URL: http://webrtc-codereview.appspot.com/318010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1163 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 00:54:28 +00:00
phoglund@webrtc.org
fe61bc3607 Merge branch 'master' into voe_create_test 
Fixed broken build.

Nit fix.

Fixed style issues.

Removed accidental comment-out.

Removed test that no longer makes sense.

Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/320009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1162 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-12 17:02:16 +00:00
phoglund@webrtc.org
6418a24795 Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/322003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1161 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-12 16:24:23 +00:00
stefan@webrtc.org
1480f02faf Fix VCM test build warnings on Mac with clang. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/318008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1160 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-12 13:45:59 +00:00
stefan@webrtc.org
7889a9b49a Remove use of CriticalSectionScoped(CriticalSectionWrapper& critsect) in VCM. 
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/318005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1159 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-12 08:18:24 +00:00
mikhal@webrtc.org
ea71440aec video_coding: Adding the non reference flag to the receive side logic. 
Review URL: http://webrtc-codereview.appspot.com/323005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1157 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-12 02:29:34 +00:00
andrew@webrtc.org
114c790be7 Remove character limit in WriteText(). 
- vfprintf can be used directly here, removing the need for the interim
  buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
  check was wrong.
- Remove asserts that should use real error checks.

TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().

Review URL: http://webrtc-codereview.appspot.com/323001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-10 02:33:33 +00:00
henrike@webrtc.org
2f47b5a70f Fixes a build error when disabling trace (which is done when building with chrome flag is set). 
Review URL: http://webrtc-codereview.appspot.com/318006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1155 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-10 00:44:47 +00:00
wjia@webrtc.org
c6b286fc04 add correct include paths for both chrome build and standalone build. 
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/320008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1154 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-10 00:20:54 +00:00
andrew@webrtc.org
bbea716117 Workaround for libyuv libjingle breakage. 
libjingle depends on ConvertFromI420. This was previously available
through vplib. libjingle still has access to the vplib header, but the
implementation is no longer built.

Fortunately, the libyuv wrapper can supply the implementation, if we
hack the signature to return to the unsigned int types. We'll remove
this once libjingle has been updated to use libyuv directly.

Also, roll libyuv to r100 which fixes a gyp warning on Windows.

TEST=build

Review URL: http://webrtc-codereview.appspot.com/323004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1151 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 19:43:12 +00:00
henrike@webrtc.org
315282c01a Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147. 
Review URL: http://webrtc-codereview.appspot.com/267023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 17:46:20 +00:00
mflodman@webrtc.org
d5651b98c5 Refactored ViEFrameProviderBase. 
Only style changes, ointers/references and functions will come in a later CL.

vie_capturer.cc and vie_file_player.cc are only changed du to inheriting protected members from ViEFrameProviderBase.

Review URL: http://webrtc-codereview.appspot.com/324001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1148 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 15:20:58 +00:00
xians@webrtc.org
0744ee563d Disable API tests on ALSA since the tests don't work for all the alsa devices. 
Review URL: http://webrtc-codereview.appspot.com/317004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1147 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 14:05:29 +00:00
henrik.lundin@webrtc.org
6198624815 Remove warnings on Mac (Issue 178) 
Remove an if-else that can never execute the else statement.
Remove double parenthesis.

BUG=http://code.google.com/p/webrtc/issues/detail?id=178
TEST=

Review URL: http://webrtc-codereview.appspot.com/318004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1146 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 13:58:17 +00:00
mflodman@webrtc.org
5cc4dc9e0c Remove warnings in VideoEngine, capture module and render module. 
BUG=164, 176, 180

Review URL: http://webrtc-codereview.appspot.com/303004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1145 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 10:12:57 +00:00
mflodman@webrtc.org
b19582b7dc Add pointer constructor to CriticalSectionScoped. 
Mainly added to simplyfy the code, e.g. when having critsect as scoped_ptr in classes.

Review URL: http://webrtc-codereview.appspot.com/302005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1144 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 10:02:16 +00:00
henrikg@webrtc.org
af225d6bf6 The change http://webrtc-codereview.appspot.com/299001 (commit 1062) does not do what it intends (exclude codecs from Chromium build). This is a fix for that. webrtc.gyp is not pulled in Chromium, hence it has no effect putting a define there. Moving it to src/build/common.gypi. 
Review URL: http://webrtc-codereview.appspot.com/315002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1143 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 09:58:39 +00:00
mflodman@webrtc.org
5885a4162a Refactored ViERenderer. 
Only style changes, function and type changes will come in a later CL.

Review URL: http://webrtc-codereview.appspot.com/321001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1142 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 05:52:32 +00:00
mikhal@webrtc.org
2ab104e6be Switching WebRtc to LibYuv. 
General Notes:
1. In general, API structure was not modified and is based on VPLIB. 
2. Modification to API: Return values are based on libyuv, i.e. 0 if ok, a negative value in case of an error (instead of length). 
3. All scaling (inteprolation) is now done via the scale interface. Crop/Pad is not being used.
4. VPLIB was completely removed. All tests are now part of the libyuv unit test (significantly more comprehensive and based on gtest).   
5. JPEG is yet to be implemented in LibYuv and therefore existing implementation remains.
Review URL: http://webrtc-codereview.appspot.com/258001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1140 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-09 02:46:22 +00:00
mikhal@webrtc.org
ffa0a9e9c9 updating libyuv to latest version (98). 
This CL also includes some additional adaptations to the code due to the upgrade. 
Review URL: http://webrtc-codereview.appspot.com/306001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1139 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 22:45:53 +00:00
mallinath@webrtc.org
7766e2a82d - This issue raised by the chromium team when clang compiler is used. This was not an error as in this case we were accessing IPV6 address with IPV4 struct which is defined as 14 bytes in the header file, but we had the runtime check to determine the address space. 
Now the solution is to use IPV6 structures instead of IPV4 when address space is determined.

I haven't put the new solution behind AF_INET6 flag, as i don't think it's necessary. 
Review URL: http://webrtc-codereview.appspot.com/291014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1138 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 21:37:19 +00:00
andrew@webrtc.org
b0be7aa7ae Remove deprecated OS X Core Audio APIs. 
We no longer support the 10.4 SDK, so we can remove the weak-leaking
feature and exclusively use the added-in-10.5 APIs.

BUG=issue143
TEST=voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/322001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1136 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 20:15:36 +00:00
marpan@webrtc.org
63b50f60d6 test_fec: Fix to valgrind warnings. 
Review URL: http://webrtc-codereview.appspot.com/304002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1135 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 19:05:39 +00:00
mikhal@webrtc.org
f5ee1dc3e6 video_coding: Adding temporal layer info support to receive side 
Review URL: http://webrtc-codereview.appspot.com/303005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1134 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 19:04:47 +00:00
xians@webrtc.org
832d7c6000 Disable typing detection for chromium since CGEventSourceKeyState is violating chromium sandbox. 
Review URL: http://webrtc-codereview.appspot.com/320003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1132 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 16:45:46 +00:00
phoglund@webrtc.org
dd094fd6ae Started extracting methods out of the main test. 
Started extracting methods out of the main test, which will hopefully make us able to make the tests independent.

Merge branch 'master' into voe_split_methods

Conflicts:
	src/voice_engine/main/test/auto_test/voe_extended_test.cc
	src/voice_engine/main/test/auto_test/voe_extended_test.h
	src/voice_engine/main/test/auto_test/voe_standard_test.cc
	src/voice_engine/main/test/auto_test/voe_standard_test.h

Extracted methods out of the standard test.

Added space before inheritance colons.

Rolled back some header file changes.

Fixed long lines.

Fixed long lines.

Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/313001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1131 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 15:07:59 +00:00
henrik.lundin@webrtc.org
d03718d1e4 Use ResourcePath in NetEQ unittest 
Review URL: http://webrtc-codereview.appspot.com/320001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1130 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-08 11:42:43 +00:00