generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,595 Commits 1 Branch 0 Tags 108 MiB
0a256acb67
Commit Graph

6595 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
pbos@webrtc.org
f520ea5eed Skip dlclose() on AddressSanitizer. 
AddressSanitizer can't symbolize parts of the stack that contains
dlclose()d modules. This makes some LSan suppressions not kick in and
blocks launching the LSan bot for WebRTC.
This "fix" excludes dlclose() in
webrtc/modules/audio_device/linux/latebindingsymboltable_linux.cc which
resolves this on the bot.

R=xians@webrtc.org
BUG=3402,chromium:375154

Review URL: https://webrtc-codereview.appspot.com/25499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7157 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 17:29:11 +00:00
henrike@webrtc.org
1d8f780779 Stop building talk/sound since it is no longer used. 
BUG=N/A
R=pbos@webrtc.org
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7156 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 17:16:56 +00:00
glaznev@webrtc.org
1d53f64b0f Disabling initializeAndroidGlobals when built with WEBRTC_CHROMIUM_BUILD. 
webrtc::VideoEngine::SetAndroidObjects and webrtc::VoiceEngine::SetAndroidObjects
are not compatible with WEBRTC_CHROMIUM_BUILD. Since neither VoiceEngine nor VideoEngine
are needed at the time it's better to disable it completely.

BUG=https://crbug.com/412276
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7155 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 16:58:25 +00:00
pbos@webrtc.org
b9906743da Split suppressons of thread.cc and messagequeue.cc. 
Most calls have either of these in the stack, meaning that pretty much
all races are suppressed.

BUG=
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17349004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7154 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 14:59:06 +00:00
aluebs@webrtc.org
4b049fcabe Remove developing code in ns_core 
This defines were hardcoded and the code inside of the ifdefs was never used.

BUG=webrtc:3763
R=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7153 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 11:19:56 +00:00
aluebs@webrtc.org
f5bdd54ac3 Add myself to common_audio and audio_processing watchlists 
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7152 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 10:11:43 +00:00
henrikg@webrtc.org
307d3dbdee Revert 7114 "Expose VideoEncoders with webrtc/video_encoder.h." 
Speculative revert, seems to be reason for flaky Win FYI bot compile break.

> Expose VideoEncoders with webrtc/video_encoder.h.
> 
> Exposes VideoEncoders as part of the public API and provides a factory
> method for creating them.
> 
> BUG=3070
> R=mflodman@webrtc.org, stefan@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/21929004

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7151 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 09:48:30 +00:00
kjellander@webrtc.org
665d861115 Restore webrtc_base target until r7140 is rolled into Chromium. 
In r7140 the webrtc_base target was renamed to rtc_base. This
breaks our FYI bots for rolling WebRTC in Chromium's DEPS.
By re-adding a None target named webrtc_base, this transition
should be smoother.

TBR=henrikg@webrtc.org,
TESTED=Passed build/gyp_chromium on a Chromium checkout with src/third_party/webrtc replaced by a mount like this:
cd /path/to/chromium/src
sudo mount --bind /path/to/webrtc/trunk/webrtc third_party/webrtc

Review URL: https://webrtc-codereview.appspot.com/23589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7150 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 09:22:13 +00:00
bjornv@webrtc.org
8dd60cc855 audio_processing_unittests: Enabled ApmTest.Process for all platforms but Android 
During porting some neon optimizations to sse2 the ApmTest.Process failed despite bit exact outputs. The reason is that with float data between component, as to previously truncating to int, we get small deviations in logged metrics. This affected a noise probability to a small fraction, which is not a particular bug.

This CL change the comparison from EXPECT_EQ() to EXPECT_NEAR() which then as a result makes the test run on Mac and Windows as well.

For int values a deviation of 1 is acceptable, which would include any rounding errors.
For float values a deviation of 0.0005 is chosen by looking at current test stats for the affected platforms/optimizations.

BUG=114
TESTED=locally on linux with and without sse2 optimizations and trybots
R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7149 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 08:36:35 +00:00
sprang@webrtc.org
c665dcb205 Revert 7145 "Stop building talk/sound since it is no longer used." 
> Stop building talk/sound since it is no longer used.
> 
> BUG=N/A
> R=pbos@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/22319004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7148 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 08:29:53 +00:00
minyue@webrtc.org
2b58a4433f Calculating round-trip-time in send-only channel in VoE. 
TESTS=built chromium and tested with 1:1 hangout call

BUG=
R=stefan@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7147 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 07:51:53 +00:00
henrik.lundin@webrtc.org
1972ff8a6e Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE. 
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.

This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions).  I've removed some of
these.

This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class.  Removed "virtual" in those
cases.

BUG=none
TEST=none
R=andrew@webrtc.org, henrik.lundin@webrtc.org, mallinath@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-11 06:20:28 +00:00
henrike@webrtc.org
4c876453c8 Stop building talk/sound since it is no longer used. 
BUG=N/A
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7145 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 22:18:04 +00:00
henrike@webrtc.org
47658f1269 Mark all virtual overrides in the hierarchy of AudioPacketizationCallback, 
RTPStream, and NetEq as such.  Also mark all other virtual overrides in the same
files.

This will make further changes to these classes safer by ensuring that the
compile breaks if the base class changes and not all overrides are fixed.

This also deletes ACMTest.cc, which existed solely to define ~ACMTest(), which
was marked pure virtual in the header.  (Pure virtual destructors still need a
definition.)  Because there is another pure virtual method in this class, the
class is already abstract, so there's no benefit to making the desturctor pure.
Making it non-pure allows removing the separate source file.

BUG=none
TEST=none
R=henrik.lundin@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7144 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 22:14:59 +00:00
henrike@webrtc.org
1711104b8a Fix MSVC warnings about value truncations, webrtc/base/ edition. 
BUG=chromium:81439
TEST=none
R=henrike@webrtc.org, marpan@google.com

Review URL: https://webrtc-codereview.appspot.com/20249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7143 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 22:10:24 +00:00
glaznev@webrtc.org
3472dcd7b0 Fix frame rate selection for Android camera. 
- Android camera supports multiple fps values for a single video
resolution - change video source default video format selection
to pick up best available fps.
- Change fps range calculation to better match target fps value.

BUG=2622
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7142 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 19:24:57 +00:00
tpsiaki@google.com
67eabc0938 Add schannel webrtc_base build using a new use_schannel gyp variable. 
R=henrike@webrtc.org, thorcarpenter@google.com

Review URL: https://webrtc-codereview.appspot.com/28409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7141 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 18:06:47 +00:00
henrike@webrtc.org
b2efb6771c Put base tests in webrtc_tests.gyp 
BUG=N/A
R=andrew@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7140 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 17:28:19 +00:00
kjellander@webrtc.org
a8d2ee7f3b Roll chromium_revision ea769fd..6455c69 (re-land) 
Mainly to pick up https://codereview.chromium.org/552013004

Summary of changes (git diff ea769fd..6455c69 DEPS):
* third_party/libvpx ceebbcc0..d95585f
* third_party/swarming e7d8b98..14b5fd82
* tools/gyp 1972:1973

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22349004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7139 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 16:51:37 +00:00
jiayl@webrtc.org
b6d69282f5 Enable shared socket for TurnPort. 
In AllocationSequence::OnReadPacket, we now hand the packet to both the TurnPort and StunPort if the remote address matches the server address.

TESTED=AppRtc loopback call generates both turn and stun candidates.

BUG=1746
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7138 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 16:31:34 +00:00
brettw@chromium.org
0867f69cc6 Convert GN visibility to be lists. 
This is a followup to my previous patch that missed this case.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7137 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 16:24:11 +00:00
pbos@webrtc.org
5c20bb27a0 Remove suppressions for VideoFrame::Validate. 
BUG=3789
R=sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7136 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 14:59:09 +00:00
andresp@webrtc.org
33aa095896 Simplify gyp rules on video_render_module. 
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7135 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 14:48:48 +00:00
houssainy@google.com
e0761d06b0 Fix printing of error stack in rtcbot when a test fails via test.fail(). 
R=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7134 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 14:35:35 +00:00
kjellander@webrtc.org
49fa212bcd Fix compile error on JDK 1.7. 
JDK 1.7 gives an error like this:
warning: [static] static method should be qualified by type name

R=pbos@webrtc.org
TBR=henrike@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/29399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7133 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 12:35:59 +00:00
pbos@webrtc.org
0fa04755af Roll gtest-parallel. 
Brings in change that eliminates Queues which shows significant speed
improvement for huge work lists.

R=andrew@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/26409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7132 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 09:29:12 +00:00
henrik.lundin@webrtc.org
23a5e3c3b0 Remove DestructEncoderInst and its codec-specific implementations. 
This method is seemingly never called.

BUG=none
TEST=none
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7131 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 08:52:26 +00:00
kjellander@webrtc.org
a2e6a52563 Revert 7128 "Roll chromium_revision ea769fd..6455c69" 
> Roll chromium_revision ea769fd..6455c69
> 
> Mainly to pick up https://codereview.chromium.org/552013004
> 
> Summary of changes (git diff ea769fd..6455c69 DEPS):
> * third_party/libvpx ceebbcc0..d95585f
> * third_party/swarming e7d8b98..14b5fd82
> * tools/gyp 1972:1973
> 
> R=pbos@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/29379004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7130 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 08:38:27 +00:00
buildbot@webrtc.org
5d639b3ef3 (Auto)update libjingle 75141932-> 75179475 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7129 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 07:57:12 +00:00
kjellander@webrtc.org
fdba9ee64a Roll chromium_revision ea769fd..6455c69 
Mainly to pick up https://codereview.chromium.org/552013004

Summary of changes (git diff ea769fd..6455c69 DEPS):
* third_party/libvpx ceebbcc0..d95585f
* third_party/swarming e7d8b98..14b5fd82
* tools/gyp 1972:1973

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7128 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 07:42:55 +00:00
andrew@webrtc.org
4ca66d691e include cstdlib for free() and abort() 
This previous CL added uses of free() and abort() without including cstdlib:
https://webrtc-codereview.appspot.com/22449004

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23559004

Patch from Mostyn Bramley-Moore <mostynb@opera.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7127 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-10 03:24:36 +00:00
guoweis@webrtc.org
fa603981f2 Add a new class InterfaceAddress inherited from IPAddress to keep track of IPv6 Address flags. 
Skeleton put in place in Network::GetFilterIPs() which will be used to
filter addresses

BUG=3773
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7126 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 23:42:40 +00:00
brettw@chromium.org
87ff9c8efa Fix up configs applying to GN build. 
The audio_processing target didn't have the build configs applying to it which led to some logging errors.

TBR=kjellander

Review URL: https://webrtc-codereview.appspot.com/22339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7125 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 23:34:56 +00:00
jiayl@webrtc.org
7d4891d3f1 Fixes two issues in how we handle OfferToReceiveX for CreateOffer: 
1. the options set in the first CreateOffer call should not affect the result of a second CreateOffer call, if SetLocalDescription is not called after the first CreateOffer. So the member var options_ of MediaStreamSignaling is removed to make each CreateOffer independent.
Instead, MediaSession is responsible to make sure that an m-line in the current local description is never removed from the newly created offer.

2. OfferToReceiveAudio used to default to true, i.e. always having m=audio line even if no audio track. This is changed so that by default m=audio is only added if there are any audio tracks.

BUG=2108
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7068

Review URL: https://webrtc-codereview.appspot.com/16309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7124 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 21:43:15 +00:00
fbarchard@google.com
a941970d4a Change explicit static cast from int to uint16_t to implicit cast of 0u. 
BUG=3663
TESTED=local windows build with VS2013.
R=harryjin@google.com, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7123 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 21:37:27 +00:00
brettw@chromium.org
9fe11010f7 Fix the RTC+Chromium GN build. 
LOGGING_INSIDE_WEBRTC was being set in the inherited config, whereas in the GYP build this define is not inherited. This caused duplicate logging macros to be defined in Chrome files dependening on WebRTC targets.

Move LOGGING_INSIDE_WEBRTC to the common config (non-inherited).

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7122 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 19:15:33 +00:00
fbarchard@google.com
54cf1505e2 ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that. 
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7121 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 18:34:53 +00:00
jiayl@webrtc.org
22406fcc9b TurnPort should retry allocation with a new address on error STUN_ERROR_ALLOCATION_MISMATCH. 
BUG=3570
R=juberti@webrtc.org, mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7070

Review URL: https://webrtc-codereview.appspot.com/20999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7120 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 15:44:05 +00:00
houssainy@google.com
04b853b56a Bot Browser files moved to /bot/browser/ 
because android files will be a different and will need to add more files for Android.

There was a CL to move the browser files form bot/browser/ to /bot/ as i thought it will be the same files used for Android.

R=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7119 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 14:50:09 +00:00
mallinath@webrtc.org
3d81b1b22a Relanding https://code.google.com/p/webrtc/source/detail?r=7093, after it got 
reverted due to some internal compile failures.

In this CL changes are done in portallocator_unittest.cc, in particular to EXPECT_EQ checking in new tests.

Original patch committed in https://code.google.com/p/webrtc/source/detail?r=7093

TBR=juberti@webrtc.org
BUG=1179

Review URL: https://webrtc-codereview.appspot.com/22329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7118 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 14:38:10 +00:00
guoweis@webrtc.org
4bbd3c83a8 fix a bug in the logic when new Networks are merged. This happens when 
we have 2 networks with the same key

BUG=410554 in chromium

http://code.google.com/p/chromium/issues/detail?id=410554

Corresponding change in chromium is
https://codereview.chromium.org/536133003/

R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19249005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7117 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 13:54:45 +00:00
sprang@webrtc.org
1b088ee316 More suppressions, uninitialized read in cricket::VideoFrame::Validate 
BUG=3789
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7116 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 11:50:19 +00:00
andresp@webrtc.org
4d19e05ab2 Peerconnection_jni to use webrtc/base/checks.h instead of implementing its own. 
This needs to happen sooner or later as if webrtc/base/checks.h happens to be included transitively here it would collide.

R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7115 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 11:45:44 +00:00
pbos@webrtc.org
b420191743 Expose VideoEncoders with webrtc/video_encoder.h. 
Exposes VideoEncoders as part of the public API and provides a factory
method for creating them.

BUG=3070
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7114 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-09 10:40:56 +00:00
andrew@webrtc.org
641bda6f9c Initialize ChannelBuffer's memory to avoid uninitialized reads. 
Removed the zero out memset in this change:
https://review.webrtc.org/24469004/

assuming it was unneeded. Dr. Memory taught me that assupmtion was
invalid. linux_memcheck try runs might have caught this, if they
weren't flaking out on unrelated stuff.

TBR=claguna@google.com

Review URL: https://webrtc-codereview.appspot.com/28429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7113 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-08 23:11:44 +00:00
henrike@webrtc.org
8b0b21161a Revert 7093: "Implementing ICE Transports type handling in libjingle transport." 
TBR=mallinath@webrtc.org
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/28419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7112 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-08 22:46:28 +00:00
brettw@chromium.org
519c9e207d Convert GN visibility to be a list. 
GN visibility currently allows either string or list types, but this is causing
some problems for some templates. I'm going to require it to be lists, so am
changing all callers before pushing the new binary.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7111 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-08 22:45:18 +00:00
pbos@webrtc.org
7118e61669 Finish work queue in SctpDataMediaChannelTest. 
Always finishing the work queue prevents memory leak detected in
LeakSanitizer (packet is deleted on the receiver side).

R=jiayl@webrtc.org
BUG=3608,chromium:375154

Review URL: https://webrtc-codereview.appspot.com/28399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7110 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-08 21:44:07 +00:00
jiayl@webrtc.org
0e52772aa9 Fix a bot-breaking memory leak from early returning in ParseMediaDescription. 
BUG=3791
R=henrike@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7109 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-08 21:43:43 +00:00
jiayl@webrtc.org
c172320bd2 Revert "Fixes two issues in how we handle OfferToReceiveX for CreateOffer:" because it broke content_browsertests on Android. 
This reverts commit r7068.

TBR=kjellander@webrtc.org
BUG=2108

Review URL: https://webrtc-codereview.appspot.com/23539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7108 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-08 20:44:36 +00:00