henrike@webrtc.org
c7bec8484b
(Auto)update libjingle 62948689-> 63019975
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5689 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-12 19:53:43 +00:00
henrike@webrtc.org
10bd88e2b5
(Auto)update libjingle 62871616-> 62948689
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5683 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-11 21:07:25 +00:00
henrike@webrtc.org
d3d6bce9ed
(Auto)update libjingle 62865357-> 62871616
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5674 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 20:41:22 +00:00
pbos@webrtc.org
371243dfa3
Remove std:: prefixes from C functions in talk/.
...
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.
BUG=
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5657 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:22:04 +00:00
henrike@webrtc.org
79047f99c1
(Auto)update libjingle 62691533-> 62713454
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5653 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-06 23:46:59 +00:00
henrike@webrtc.org
b90991dade
Update libjingle 62472237->62550414
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5640 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-04 19:54:57 +00:00
henrike@webrtc.org
40b3b68cdf
Update libjingle 62364298->62472237
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5632 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 18:30:11 +00:00
henrike@webrtc.org
1bbfb57d71
Rollback of r5629 "(Auto)update libjingle 62364298-> 62368661".
...
BUG=N/A
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9329004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5631 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 17:37:52 +00:00
henrike@webrtc.org
31413dc635
(Auto)update libjingle 62364298-> 62368661
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5629 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 16:47:01 +00:00
henrike@webrtc.org
b8395ebe14
(Auto)update libjingle 62293974-> 62364298
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5623 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-28 21:57:22 +00:00
henrike@webrtc.org
806768a6ca
(Auto)update libjingle 62281784-> 62293974
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5619 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-27 21:03:09 +00:00
henrike@webrtc.org
704bf9ebec
(Auto)update libjingle 62063505-> 62278774
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5617 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-27 17:52:04 +00:00
henrike@webrtc.org
d43aa9de7a
Update libjingle 61901702->61966318
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5596 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 23:43:24 +00:00
henrike@webrtc.org
a7b981843f
Unrevert 5590 "description"(=(Auto)update libjingle 61834300->61901702).
...
BUG=N/A
R=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9009004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5595 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 15:51:43 +00:00
xians@webrtc.org
ef2215110c
Revert 5590 "description"
...
> description
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8949006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5593 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 10:31:29 +00:00
henrike@webrtc.org
2643805a20
description
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5590 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-20 22:32:53 +00:00
fischman@webrtc.org
c2d75e0708
PeerConnection(java): account for thread shutdown vagaries.
...
Android's JVM requires threads to detach before they exit, but ONLY if
they needed to AttachCurrentThread. Conversly, threads that were
attached by the JVM (e.g. the result of making a native call from Java)
must NOT be detached by the application. This is bug 2441.
The fix for the above is to only pthread_setspecific() for threads that
Attach(), not for already-attached threads. To ensure that we only
detach Attached threads, added a GetEnv() call to ThreadDestructor(),
which revealed that Oracle's JVM can overly-eagerly clear TLS accounting
data, effectively detaching threads without their consent at shutdown.
Work around this with a specific check.
To guard against (some) regression, added a variant of PeerConnectionTest
that runs on a non-main thread. This revealed a bug in LinuxDeviceManager
which implicitly assumes its talk_base::Thread has already been
initialized. Fixed that here too.
BUG=2441
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5567 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-18 16:57:36 +00:00
mallinath@webrtc.org
92fdfebedd
Update talk to 61699344.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5560 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-17 18:49:41 +00:00
henrike@webrtc.org
b8c254abd6
(Auto)update libjingle 61549749-> 61608469
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5555 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 23:38:45 +00:00
wu@webrtc.org
b9a088b920
Update talk to 61538839.
...
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/8669005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5548 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 23:18:49 +00:00
wu@webrtc.org
0de29504ab
Revert 5545 "Update libjingle to 61514460"
...
> Update libjingle to 61514460
>
> TBR=tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/8649004
TBR=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5547 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 19:54:28 +00:00
xians@webrtc.org
e749c9ebdb
Update libjingle to 61514460
...
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5545 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 15:09:40 +00:00
sergeyu@chromium.org
9cf037b831
Update libjingle to 61168196
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 19:03:26 +00:00
mallinath@webrtc.org
67ee6b9a62
Update talk to 60923971
...
Review URL: https://webrtc-codereview.appspot.com/7909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 16:57:16 +00:00
jiayl@webrtc.org
808b99b111
Disable a test assert which fails due to usrsctp not cleaned up in SctpDataEngine.cc
...
BUG=2749
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7739005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5460 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 19:44:40 +00:00
jiayl@webrtc.org
a576faf82a
Enable SCTP and use OPENSSL on Anroid and NSS on other platforms.
...
It includes unit test fixes to properly initialize SSL if DTLS or SSL random number generator is used in the tests.
The private key and certificate constant strings used in some tests are updated to be compatible with NSS.
A few potentially overflow type conversions caused compiling warning on Windows and they are fixed by importing and using Chromium's checked_cast, which aborts the program if overflow occurs.
It also fixes a leak in nssstreamadapter.cc by releasing the PRFileDesc* in StreamClose.
BUG=2253
R=fischman@webrtc.org , juberti@google.com , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4679005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 17:45:53 +00:00
mallinath@webrtc.org
7433a088d2
Revert 5444 "Revert 5421 "Fix deadlock on register/unregister ob..."
...
We reverted the r5421 to allow us roll webrtc to chrome without any modifications
to libjingle. Since webrtc is rolled with r5444, we can add back the original CL
and changes to libjingle will be upstreamed in the next roll.
TBR=andresp@webrtc.org
> Revert 5421 "Fix deadlock on register/unregister observer while ..."
>
> Failure to compile on Chromium Internal bots, because of API changes.
>
> http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
>
> You need to follow the steps mentioned in
> https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
>
> Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
> as mentioned in the doc.
>
> > Fix deadlock on register/unregister observer while there is a an going callback.
> >
> > BUG=2835
> > R=mallinath@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/7119005
>
> TBR=andresp@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7679004
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7729005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5453 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 00:56:02 +00:00
mallinath@webrtc.org
0dac5378e5
Revert 5447 "Update talk to 60420316."
...
> Update talk to 60420316.
>
> TBR=wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7719005
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5448 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:58:42 +00:00
mallinath@webrtc.org
752a017809
Update talk to 60420316.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7719005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5447 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:45:52 +00:00
mallinath@webrtc.org
18586d38bc
Revert 5421 "Fix deadlock on register/unregister observer while ..."
...
Failure to compile on Chromium Internal bots, because of API changes.
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
You need to follow the steps mentioned in
https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
as mentioned in the doc.
> Fix deadlock on register/unregister observer while there is a an going callback.
>
> BUG=2835
> R=mallinath@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7119005
TBR=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5444 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-27 22:00:57 +00:00
wu@webrtc.org
256d0ada35
Remove the check for audio codec num in WebRtcVoiceEngineTest.HasCorrectCodecs.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5430 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-24 18:58:51 +00:00
andresp@webrtc.org
8d375c95b7
Fix deadlock on register/unregister observer while there is a an going callback.
...
BUG=2835
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7119005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5421 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 23:09:25 +00:00
wu@webrtc.org
a8910d2f88
Update talk to 60094938.
...
Review URL: https://webrtc-codereview.appspot.com/7489005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5420 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 22:12:45 +00:00
sergeyu@chromium.org
4b26e2eee3
Update libjingle to 59676287
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5390 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-15 23:15:54 +00:00
henrika@webrtc.org
aebb1ade9d
pRevert 5371 "Revert 5367 "Update talk to 59410372.""
...
> Revert 5367 "Update talk to 59410372."
>
> > Update talk to 59410372.
> >
> > R=jiayl@webrtc.org , wu@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/6929004
>
> TBR=mallinath@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/6999004
TBR=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7109004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5381 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 10:00:58 +00:00
henrika@webrtc.org
44461fa5cb
Revert 5367 "Update talk to 59410372."
...
> Update talk to 59410372.
>
> R=jiayl@webrtc.org , wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/6929004
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5371 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 09:35:02 +00:00
mallinath@webrtc.org
0f3356e20b
Update talk to 59410372.
...
R=jiayl@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5367 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-11 01:26:23 +00:00
wu@webrtc.org
e00265ed49
Fix a compile error on Android on sctpdataengine.cc.
...
TEST=try bots
BUG=
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5350 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-07 19:32:40 +00:00
wu@webrtc.org
f6d6ed0c66
Update talk to 59039880.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5339 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-03 22:08:47 +00:00
wu@webrtc.org
24301a67c6
Update talk to 58174641 together with http://review.webrtc.org/4319005/ .
...
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5287 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 19:17:43 +00:00
wu@webrtc.org
a9890800e0
Update talk to 58127566 together with
...
https://webrtc-codereview.appspot.com/5309005/ .
R=mallinath@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5277 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 00:21:03 +00:00
wu@webrtc.org
2018269dc3
Revert 5274 "Update talk to 58113193 together with https://webrt ..."
...
> Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/ .
>
> R=mallinath@webrtc.org , niklas.enbom@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5719004
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5275 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-12 22:54:25 +00:00
wu@webrtc.org
a129b6cd13
Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/ .
...
R=mallinath@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5274 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-12 22:40:39 +00:00
wu@webrtc.org
9caf2765b2
Update talk to 58037405.
...
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/5579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5267 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 18:25:07 +00:00
sergeyu@chromium.org
32f485b16a
Fix constants.[h|cc] to avoid static initializer in webrtcvideoengine.cc.
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5233 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 22:36:21 +00:00
sergeyu@chromium.org
57a5f64264
revert r5230
...
r5230 broke windows build.
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5232 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 22:14:46 +00:00
sergeyu@chromium.org
a1b21cd777
Fix constants.[h|cc] to avoid static initializer in webrtcvideoengine.cc.
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5230 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 21:28:34 +00:00
sergeyu@chromium.org
5bc25c41fc
Update libjingle to 57692857
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5217 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 00:24:06 +00:00
wu@webrtc.org
364f204d16
Update talk to 56698267.
...
TBR=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/4119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5143 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 21:49:41 +00:00
sergeyu@chromium.org
a23f0ca4ba
Update talk to 56619788
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3839005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5120 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-13 22:48:52 +00:00
wu@webrtc.org
16d6254e8c
Update talk to 56183333.
...
TEST=try bots
R=sheu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/3469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5087 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-05 23:45:14 +00:00
wu@webrtc.org
de305014c6
Update talk to 55906045.
...
Review URL: https://webrtc-codereview.appspot.com/3159005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5065 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 15:40:38 +00:00
wu@webrtc.org
f424cb8e13
Update talk to 55863981.
...
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/3089006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5056 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-30 17:57:33 +00:00
wu@webrtc.org
cecfd1832d
Update talk to 55821645.
...
TEST=try bots
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5053 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-30 05:18:12 +00:00
pbos@webrtc.org
850bcbe855
Remove frame_callback.h include in webrtcvie.h.
...
This file is about to be moved and it's not really needed. The class
I420FrameCallback is forward declared inside vie_image_process.h and
only used in talk/ for a no-op implementation that doesn't access the
pointer.
BUG=
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3039004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5041 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-28 15:41:17 +00:00
wu@webrtc.org
97077a3ab2
Update libjingle to 55618622.
...
Update libyuv to r826.
TEST=try bots
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5038 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-25 21:18:33 +00:00
wu@webrtc.org
4d7116be7a
Fix tsan failures on filevideocapturer.cc.
...
1) init start_time_ns_ before the file_read_thread_ is started to avoid data racing as the start_time_ns_ will also be read by the file_read_thread_.
2) add CriticalSection to protect |finished_| that is accessed by FileReadThread and the main thread
Also remove the suppression for filemediaengine.cc, which has already been fixed in other cl.
TBR=henrike@webrtc.org
TEST=try bots and manual tsan v2 test
BUG=2078
Review URL: https://webrtc-codereview.appspot.com/2509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5018 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22 18:41:17 +00:00
wu@webrtc.org
3c5d2b43ec
Thread::Stop() must be called before any subclass's destructor completes.
...
Update Thread documentation, fix all subclasses that had a problem.
This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.
For example:
[ RUN ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
Read of size 8 at 0x7d480000bd00 by thread T1:
#0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)
Previous write of size 8 at 0x7d480000bd00 by main thread:
#0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
#1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
...
RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2428004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-18 16:27:26 +00:00
wu@webrtc.org
1d1ffc9ad2
Update talk to 54898858.
...
TEST=try bots
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/2414004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4979 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 18:12:02 +00:00
wu@webrtc.org
40dfbc4d3d
Update talk to 53984350.
...
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/2376004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4947 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-09 17:58:06 +00:00
wu@webrtc.org
4551b793de
Update libjingle to 53920541.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2371004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4945 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-09 15:37:36 +00:00
wu@webrtc.org
7818752566
Update libjingle to 53856368.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2366004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4941 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-07 23:32:02 +00:00
mallinath@webrtc.org
7e809c323a
Update libjingle to CL 53496343.
...
Review URL: https://webrtc-codereview.appspot.com/2323005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4882 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-30 18:59:08 +00:00
mallinath@webrtc.org
a27be8e4a1
Update libjingle to CL 53398036.
...
Review URL: https://webrtc-codereview.appspot.com/2323004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4872 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-27 23:04:10 +00:00
andrew@webrtc.org
f832a551cc
Disable flaky TestPartialFrameHeader.
...
Example failure:
[http://chromegw/i/internal.client.webrtc/builders/Linux%20Asan/builds/657 ]
TBR=wu@webrtc.org
BUG=2409
Review URL: https://webrtc-codereview.appspot.com/2286004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4832 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-24 20:09:30 +00:00
andrew@webrtc.org
f0f92fae12
Disable flaky SendDataMultipleClocks.
...
Example failure:
[http://chromegw/i/internal.client.webrtc/builders/Linux32%20Debug/builds/719 ]
TBR=mallinath
BUG=2409
Review URL: https://webrtc-codereview.appspot.com/2270005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4828 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-24 16:26:41 +00:00
mallinath@webrtc.org
1112c30e1e
Update libjingle to 53057474.
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2274004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4818 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-23 20:34:45 +00:00
wu@webrtc.org
967bfff54d
Update talk to 52534915.
...
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/2251004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4786 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 05:49:50 +00:00
sergeyu@chromium.org
a59696b2a5
Update libjingle to 52300956
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2213004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4744 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-13 23:48:58 +00:00
mallinath@webrtc.org
ab5a0912a3
Fixing the build error on Windows.
...
Problem is in coversion from size_t to int.
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4698 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-07 00:12:57 +00:00
mallinath@webrtc.org
1b15f4226f
Update talk to 51960985.
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2188004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4696 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-06 22:56:28 +00:00
wu@webrtc.org
cadf9040cb
Update talk to 51664136.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2148004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4649 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-30 21:24:16 +00:00
elham@webrtc.org
d6fef9d380
Fixing SetDecodeErrorMode build error
...
- got introduced when reverting r4562
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2118004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4624 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-26 23:59:38 +00:00
sergeyu@chromium.org
0be6aa0665
Update talk to 51314459
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2100004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4608 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-23 23:21:25 +00:00
henrike@webrtc.org
7666db79fa
Update talk to 51242664.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2090005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4594 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-22 14:45:42 +00:00
wu@webrtc.org
822fbd8b68
Update talk to 50918584.
...
Together with Stefan's http://review.webrtc.org/1960004/ .
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2048004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4556 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-15 23:38:54 +00:00
wu@webrtc.org
91053e7c5a
Update libjingle to 50654631.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2000006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4519 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-10 07:18:04 +00:00
wu@webrtc.org
9dba525627
* Update libjingle to 50389769.
...
* Together with "Add texture support for i420 video frame." from
wuchengli@chromium.org .
https://webrtc-codereview.appspot.com/1413004
RISK=P1
TESTED=try bots
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1967004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4489 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 20:36:57 +00:00
wu@webrtc.org
d64719d895
Update libjingle to 50191337.
...
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1885005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4461 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 00:00:07 +00:00
henrike@webrtc.org
1e09a71126
Update talk folder to revision=49952949
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4413 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-26 19:17:59 +00:00
henrike@webrtc.org
28654cbc22
Update talk folder to revision=49713299.
...
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1848004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4380 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-22 21:07:49 +00:00
henrike@webrtc.org
9de257d00f
Update talk folder to revision=49470012. Same as 375 in libjingle's google code repository.
...
TBR=wu@webrtc.org
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/1824004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4364 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-17 14:42:53 +00:00
henrike@webrtc.org
723d683ecb
Update talk folder to revision=49260075. Same as 369 in libjingle's google code repository.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1797004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4338 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-12 16:04:50 +00:00
henrike@webrtc.org
28e2075280
Adds trunk/talk folder of revision 359 from libjingles google code to
...
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00