wu@webrtc.org
06c7dbae14
Disable flaky test AudioProcessingTest.TestVoiceActivityDetectionWithObserver.
...
BUG=263
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/380009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1615 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:13:21 +00:00
wu@webrtc.org
50099af75f
Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss.
...
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001
Coverity fix for issues 10325,10326.
...
Review URL: https://webrtc-codereview.appspot.com/377001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 19:02:54 +00:00
phoglund@webrtc.org
56b85c6ba8
Reduced potential for flakiness in voice detection tests.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367024
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1612 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 18:48:33 +00:00
wu@webrtc.org
13e0345b35
Fix uninitialized variable error in Relase mode.
...
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/377007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1611 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 16:19:15 +00:00
mflodman@webrtc.org
517e5e3846
NetEQ switch fix.
...
Review URL: https://webrtc-codereview.appspot.com/381006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1610 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 15:04:00 +00:00
stefan@webrtc.org
94355e0a59
Fix crash in SessionInfo::BuildSoftNackList.
...
BUG=259
TEST=
Review URL: https://webrtc-codereview.appspot.com/377006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1609 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:06:39 +00:00
mflodman@webrtc.org
a39621ee1b
Disabling APM test for invalid enum values.
...
Review URL: https://webrtc-codereview.appspot.com/378006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1608 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:00:12 +00:00
mflodman@webrtc.org
ec31bc1321
Fixed APM tests.
...
TEST=ApmTest.*
Review URL: https://webrtc-codereview.appspot.com/380008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1607 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 12:42:45 +00:00
mflodman@webrtc.org
657b2a4965
Added return due to gcc complaints in r1604.
...
TBR=andrew
TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.
Review URL: https://webrtc-codereview.appspot.com/384004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361
Removed default cases causing clang errors, -Wcovered-switch-default.
...
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)
Review URL: https://webrtc-codereview.appspot.com/379008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
andrew@webrtc.org
4942832928
Fix "may be used uninitialized" warning.
...
TBR=marpan@webrtc.org
BUG=
TEST=build on Linux/Release and rtp_rtcp_unittests
Review URL: https://webrtc-codereview.appspot.com/381004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1602 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 05:23:51 +00:00
marpan@webrtc.org
b783a55df3
Unit test for forward_error_correction.
...
Review URL: https://webrtc-codereview.appspot.com/358006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1601 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:46:35 +00:00
marpan@webrtc.org
307c1ff20c
Fix for issue #254 : windows crash of test_fec.
...
Review URL: https://webrtc-codereview.appspot.com/379010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:45:22 +00:00
andrew@webrtc.org
dde977ec83
AudioFrame payload shouldn't be mutable.
...
This requires making Mute() non-const, which is correct anyway.
BUG=
TEST=voe_auto_test on Linux
Review URL: https://webrtc-codereview.appspot.com/376001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1599 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 17:47:32 +00:00
kjellander@webrtc.org
ce0a6ff43d
Restoring previous vie_auto_test.gypi structure due to problems on Mac
...
Now the unit test is included in the vie_auto_test target and executed when the automated flag is used.
TBR=mflodman
BUG=
TEST=vie_auto_test --automated --gtest_filter=FrameDropPrimitivesTest.FixOutputFileForComparison
Review URL: https://webrtc-codereview.appspot.com/381003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1598 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 14:06:46 +00:00
kjellander@webrtc.org
918a8bf40c
External transport is modified to never drop packets from the first frame.
...
Refactoring of FrameDropHandler: It now also tracks when frames are leaving the encoder and is being sent to external transport.
Previous 'Sent' state is now renamed to 'Created'.
NOTICE: The test seems to be a little flaky on Linux so it's not ready for buildbots yet. Since this might be caused by unstable production code further investigation should be performed to clear out the flakiness. I will file an issue for this when this CL is submitted (since I don't have any code to refer to before that). Usually the flakiness is caused by a decoded/rendered callback that is left out for the last frame, but I have seen other flaky failures too, which means it's not as simple as ignoring the last frame.
These errors occur even if 400kbps bit rate and 0% PL and 0 delay is configured.
BUG=
TEST=vie_auto_test --automated --gtest_filter="ViEVideoVerificationTest.RunsFullStackWithoutErrors" in Debug+Release on Linux, Mac and Windows.
Review URL: http://webrtc-codereview.appspot.com/339005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1597 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 12:40:28 +00:00
henrik.lundin@webrtc.org
683833442a
Fix for warning in GCC 4.6
...
Upstream copy of a fix provided in http://codereview.chromium.org/9309007/ .
BUG=none
TEST=neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/383002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1596 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 12:33:50 +00:00
henrik.lundin@webrtc.org
82e1c8d0e7
Fix for issue 253
...
Initializing a few arrays to avoid compiler warnings under
the O3 flag.
BUG=http://code.google.com/p/webrtc/issues/detail?id=253
Review URL: https://webrtc-codereview.appspot.com/380005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1595 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 09:46:01 +00:00
pwestin@webrtc.org
fdf21c8c55
Removed dead version code.
...
Review URL: https://webrtc-codereview.appspot.com/377003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1594 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:46:58 +00:00
pwestin@webrtc.org
4ea57e5e26
Changed VP8 to follow the style guide a little bit more.
...
Review URL: https://webrtc-codereview.appspot.com/379003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1593 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:21:47 +00:00
xians@webrtc.org
9b3474aff8
Disable the unused API interfaces for VoE chromium build.
...
Review URL: https://webrtc-codereview.appspot.com/377002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1592 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:59:11 +00:00
stefan@webrtc.org
07b45a5dc4
Added API for getting the send-side estimated bandwidth.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/372006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:37:48 +00:00
leozwang@webrtc.org
ac7e89ff1c
Correct and update LICENSE
...
Review URL: https://webrtc-codereview.appspot.com/382001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1590 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 23:04:48 +00:00
kma@webrtc.org
de66b91274
In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl,
...
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 18:39:44 +00:00
andrew@webrtc.org
7fe219f681
Add some additional checks for corrupt payload.
...
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.
BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.
Review URL: https://webrtc-codereview.appspot.com/369015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 02:40:37 +00:00
kma@webrtc.org
727a0a03a1
Fixed a bug in assembly code in aecm_core.c (hasn't caused a problem yet).
...
Did apm unit test. Bit exact.
Review URL: https://webrtc-codereview.appspot.com/366010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1583 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 00:05:22 +00:00
frkoenig@google.com
d8f58a4ab0
Cross platform build fix for SSIM (part 2)
...
Data alignment fix for SSIM.
WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128. By declaring the
variable as __m128i it will always be 128 bytes aligned.
Related to issue 239013.
http://webrtc-codereview.appspot.com/239013/
Review URL: https://webrtc-codereview.appspot.com/375004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1582 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 17:49:38 +00:00
bjornv@webrtc.org
26e8a58130
VAD refactor: Create() and Free()
...
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.
TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 14:42:50 +00:00
henrik.lundin@webrtc.org
dd478e2081
Fix for warning in GCC 4.6
...
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/ .
Review URL: https://webrtc-codereview.appspot.com/369024
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 13:12:41 +00:00
xians@webrtc.org
79af734807
This patch fixes the converity warnings in voice engine.
...
Review URL: https://webrtc-codereview.appspot.com/373017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1579 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 12:22:14 +00:00
stefan@webrtc.org
91c630851a
Fix potential VCMReceiver crash.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/368012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 10:49:08 +00:00
henrika@webrtc.org
2919e95c2a
Resolves Coverty issue #10347 .
...
Uninitialized member (UNINIT_CTOR).
Review URL: https://webrtc-codereview.appspot.com/369023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1577 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 08:45:03 +00:00
marpan@webrtc.org
cdba1a836b
test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file.
...
Review URL: https://webrtc-codereview.appspot.com/373016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 00:36:14 +00:00
andrew@webrtc.org
293d22b39b
Add a new macro for bit-exact audioproc tests.
...
Enable bit-exact test for all fixed-point configs.
BUG=114
TEST=audioproc_unittest on all platforms.
Review URL: https://webrtc-codereview.appspot.com/369018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1575 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 22:04:26 +00:00
andrew@webrtc.org
40654039cd
Use pointer-based CriticalSectionScoped().
...
The reference-based constructor is deprecated.
BUG=185
TEST=audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1573 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 20:51:15 +00:00
kma@webrtc.org
89a100092a
A minor change in function WebRtcNetEQ_PacketBufferFindLowestTimestamp for
...
NetEq, for performance reasons.
In Android platform, with an offline testing file, the function cycles was reduced by 25%.
This function was also reformatted.
Review URL: https://webrtc-codereview.appspot.com/367010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1571 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 15:37:33 +00:00
mflodman@webrtc.org
7627843352
Added NULL check in external transport test code.
...
BUG=C-10246
Review URL: https://webrtc-codereview.appspot.com/367022
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1570 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:21:26 +00:00
pwestin@webrtc.org
5dad00be52
Coverty fix: FEC unintended signed extension and resource leaks.
...
Review URL: https://webrtc-codereview.appspot.com/368010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:05:29 +00:00
mflodman@webrtc.org
d3b22c9356
Resolved X11 shared memiory leak.
...
BUG=248
TEST=See bug
Review URL: https://webrtc-codereview.appspot.com/367016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1568 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:44:28 +00:00
bjornv@webrtc.org
0c6f931420
Removed versions in module/audio_processing and common_audio/vad.
...
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:39:08 +00:00
stefan@webrtc.org
2fd1e1e40d
Add unittests for ReceiverFec.
...
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:03:37 +00:00
pwestin@webrtc.org
04cf69a714
Coverty: cleanup CheckCSRC.
...
Review URL: https://webrtc-codereview.appspot.com/369014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
2f7740973d
Fixed C errors from GCC 4.6.
...
Fixed errors in .c files.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/373014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1563 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:44:26 +00:00
mflodman@webrtc.org
1f992807eb
Fixed frame scaler bugs.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1562 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:42:53 +00:00
phoglund@webrtc.org
048eb7cda6
Finished rewriting the audio processing test.
...
Partial rewrite of audio processing tests.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1561 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 11:58:41 +00:00
mflodman@webrtc.org
832adebca2
Removed MapWrapper from ViEFrameProviderBase.
...
BUG=C-10189
Review URL: https://webrtc-codereview.appspot.com/356002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1560 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:31:34 +00:00
mflodman@webrtc.org
194a93ac66
Adding ViE NULL checks.
...
BUG=C-10188, C-10246, C-10595
Review URL: https://webrtc-codereview.appspot.com/373013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1559 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:11:22 +00:00
tina.legrand@webrtc.org
cbe1de9aa6
This CL solves three remaining Coverity warnings.
...
A few more members were left uninitialized, and one more size mismatch in a multiplication.
Review URL: https://webrtc-codereview.appspot.com/367001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1558 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:00:46 +00:00
mallinath@webrtc.org
a8c568f0a4
Fix external codec erase in destructor.
...
Review URL: https://webrtc-codereview.appspot.com/368008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1555 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 16:19:03 +00:00