Commit Graph

2 Commits

Author SHA1 Message Date
kwiberg@webrtc.org
67186fe00c Fix clang style warnings in webrtc/base
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.

Not inlining virtual functions with simple bodies such as

  { return false; }

strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.

BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47429004

Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:24:25 +00:00
henrike@webrtc.org
7b2f955e56 Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README.
BUG=1935
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1805005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4356 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-16 18:04:56 +00:00