From fae6bc4106e0894d87c1005d5e0ea8b3837a2826 Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Fri, 10 Oct 2014 08:45:03 +0000 Subject: [PATCH] Remove talk_base from suppressions. This namespace doesn't exist anymore, so remove all suppressions that include it in the call stack. R=kjellander@webrtc.org BUG= Review URL: https://webrtc-codereview.appspot.com/31639005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7419 4adac7df-926f-26a2-2b94-8c16560cd09d --- tools/lsan/suppressions.txt | 8 - .../valgrind-webrtc/drmemory/suppressions.txt | 181 ------------------ .../valgrind-webrtc/memcheck/suppressions.txt | 100 ---------- 3 files changed, 289 deletions(-) diff --git a/tools/lsan/suppressions.txt b/tools/lsan/suppressions.txt index 319aed705..1d0120c07 100644 --- a/tools/lsan/suppressions.txt +++ b/tools/lsan/suppressions.txt @@ -87,12 +87,4 @@ leak:PingTaskTest::SetUp leak:PingXmppClient::SendStanza leak:PubSubClientTest::PubSubClientTest leak:PubSubTasksTest::PubSubTasksTest -leak:talk_base::HttpData::changeHeader -leak:talk_base::HttpParser::ProcessLine -leak:talk_base::HttpServer::Connection::BeginProcess -leak:talk_base::IdTimeoutTask::IdTimeoutTask -leak:talk_base::OpenSSLCertificate::FromPEMString -leak:talk_base::OpenSSLIdentity::FromPEMStrings -leak:talk_base::TaskParent::TaskParent -leak:talk_base::unstarted_task_test_DoNotDeleteTask2_Test::TestBody diff --git a/tools/valgrind-webrtc/drmemory/suppressions.txt b/tools/valgrind-webrtc/drmemory/suppressions.txt index e76a8e850..f4feb44c5 100644 --- a/tools/valgrind-webrtc/drmemory/suppressions.txt +++ b/tools/valgrind-webrtc/drmemory/suppressions.txt @@ -346,20 +346,6 @@ libjingle_peerconnection_unittes!rtc::LogMessage::GetLogToStream libjingle_peerconnection_unittes!rtc::LogMessage::ConfigureLogging libjingle_peerconnection_unittes!main -UNINITIALIZED READ -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (4_tmp) -*!_towlower_l -*!towlower -*!tolowercase -*!talk_base::IsDefaultBrowserFirefox -*!talk_base::GetProxySettingsForUrl -*!talk_base::AutoDetectProxy::GetProxyForUrl -*!talk_base::AutoDetectProxy::DoWork -*!talk_base::SignalThread::Run -*!talk_base::SignalThread::Worker::Run -*!talk_base::Thread::PreRun -KERNEL32.dll!BaseThreadInitThunk - UNINITIALIZED READ name=https://code.google.com/p/webrtc/issues/detail?id=3158 (5) drmemorylib.dll!replace_memcmp @@ -410,23 +396,6 @@ libjingle_peerconnection_unittes!webrtc::AudioDeviceWindowsCore::DoRenderThread libjingle_peerconnection_unittes!webrtc::AudioDeviceWindowsCore::WSAPIRenderThread KERNEL32.dll!BaseThreadInitThunk -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (12_tmp) -ntdll.dll!RtlIntegerToUnicodeString -ntdll.dll!RtlIntegerToUnicodeString -libjingle_peerconnection_unittes!talk_base::CriticalSection::Enter -libjingle_peerconnection_unittes!talk_base::CritScope::CritScope -libjingle_peerconnection_unittes!talk_base::LogMessage::~LogMessage -libjingle_peerconnection_unittes!cricket::WebRtcVideoEngine::Print -libjingle_peerconnection_unittes!webrtc::TraceImpl::WriteToFile -libjingle_peerconnection_unittes!webrtc::TraceImpl::Process -libjingle_peerconnection_unittes!webrtc::TraceImpl::Run -libjingle_peerconnection_unittes!webrtc::ThreadWindows::Run -libjingle_peerconnection_unittes!webrtc::ThreadWindows::StartThread -libjingle_peerconnection_unittes!_callthreadstartex -libjingle_peerconnection_unittes!_threadstartex -KERNEL32.dll!BaseThreadInitThunk - UNADDRESSABLE ACCESS name=https://code.google.com/p/webrtc/issues/detail?id=3158 (13) libjingle_peerconnection_unittes!webrtc::AudioDeviceWindowsCore::_Lock @@ -434,64 +403,6 @@ libjingle_peerconnection_unittes!webrtc::AudioDeviceWindowsCore::DoRenderThread libjingle_peerconnection_unittes!webrtc::AudioDeviceWindowsCore::WSAPIRenderThread KERNEL32.dll!BaseThreadInitThunk -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (14_tmp) -libjingle_peerconnection_unittes!std::list<>::begin -libjingle_peerconnection_unittes!talk_base::LogMessage::~LogMessage -libjingle_peerconnection_unittes!cricket::WebRtcVideoEngine::Construct -libjingle_peerconnection_unittes!cricket::WebRtcVideoEngine::WebRtcVideoEngine -libjingle_peerconnection_unittes!cricket::CompositeMediaEngine<>::CompositeMediaEngine<> -libjingle_peerconnection_unittes!cricket::WebRtcMediaEngine::WebRtcMediaEngine -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize_s -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::OnMessage -libjingle_peerconnection_unittes!talk_base::Thread::Send -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize -libjingle_peerconnection_unittes!webrtc::CreatePeerConnectionFactory -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::SetUp -libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> - -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (15_tmp) -ntdll.dll!RtlIntegerToUnicodeString -ntdll.dll!RtlIntegerToUnicodeString -libjingle_peerconnection_unittes!talk_base::CriticalSection::Enter -libjingle_peerconnection_unittes!talk_base::CritScope::CritScope -libjingle_peerconnection_unittes!talk_base::LogMessage::~LogMessage -libjingle_peerconnection_unittes!TestInvalidParameterHandler -libjingle_peerconnection_unittes!_invalid_parameter -... -libjingle_peerconnection_unittes!cricket::WebRtcVideoEngine::Construct -libjingle_peerconnection_unittes!cricket::WebRtcVideoEngine::WebRtcVideoEngine -libjingle_peerconnection_unittes!cricket::CompositeMediaEngine<>::CompositeMediaEngine<> -libjingle_peerconnection_unittes!cricket::WebRtcMediaEngine::WebRtcMediaEngine -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize_s -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::OnMessage -libjingle_peerconnection_unittes!talk_base::Thread::Send -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize -libjingle_peerconnection_unittes!webrtc::CreatePeerConnectionFactory -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::SetUp -libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> - -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (16_tmp) -ntdll.dll!RtlIntegerToUnicodeString -ntdll.dll!RtlIntegerToUnicodeString -libjingle_peerconnection_unittes!talk_base::CriticalSection::Enter -libjingle_peerconnection_unittes!talk_base::CritScope::CritScope -libjingle_peerconnection_unittes!talk_base::LogMessage::~LogMessage -libjingle_peerconnection_unittes!cricket::WebRtcVoiceEngine::ConstructCodecs -libjingle_peerconnection_unittes!cricket::WebRtcVoiceEngine::Construct -libjingle_peerconnection_unittes!cricket::WebRtcVoiceEngine::WebRtcVoiceEngine -libjingle_peerconnection_unittes!cricket::CompositeMediaEngine<>::CompositeMediaEngine<> -libjingle_peerconnection_unittes!cricket::WebRtcMediaEngine::WebRtcMediaEngine -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize_s -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::OnMessage -libjingle_peerconnection_unittes!talk_base::Thread::Send -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize -libjingle_peerconnection_unittes!webrtc::CreatePeerConnectionFactory -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::SetUp -libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> - UNADDRESSABLE ACCESS name=https://code.google.com/p/webrtc/issues/detail?id=3158 (17) libjingle_peerconnection_unittes!testing::Test::HasSameFixtureClass @@ -649,18 +560,6 @@ libjingle_peerconnection_unittes!testing::TestResult::HasFatalFailure libjingle_peerconnection_unittes!testing::Test::HasFatalFailure libjingle_peerconnection_unittes!testing::Test::Run -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (32_tmp) -ntdll.dll!RtlIntegerToUnicodeString -ntdll.dll!RtlIntegerToUnicodeString -libjingle_peerconnection_unittes!talk_base::CriticalSection::Enter -libjingle_peerconnection_unittes!talk_base::CritScope::CritScope -... -libjingle_peerconnection_unittes!testing::internal::CountIf<> -libjingle_peerconnection_unittes!testing::TestResult::HasFatalFailure -libjingle_peerconnection_unittes!testing::Test::HasFatalFailure -libjingle_peerconnection_unittes!testing::Test::Run - UNADDRESSABLE ACCESS name=https://code.google.com/p/webrtc/issues/detail?id=3158 (33) libjingle_peerconnection_unittes!testing::internal::DefaultGlobalTestPartResultReporter::ReportTestPartResult @@ -669,73 +568,6 @@ libjingle_peerconnection_unittes!testing::UnitTest::AddTestPartResult libjingle_peerconnection_unittes!testing::internal::ReportFailureInUnknownLocation libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (34_tmp) -ntdll.dll!RtlIntegerToUnicodeString -ntdll.dll!RtlIntegerToUnicodeString -libjingle_peerconnection_unittes!talk_base::CriticalSection::Enter -libjingle_peerconnection_unittes!talk_base::CritScope::CritScope -... -libjingle_peerconnection_unittes!TestPureCallHandler -libjingle_peerconnection_unittes!_purecall -libjingle_peerconnection_unittes!testing::internal::DefaultGlobalTestPartResultReporter::ReportTestPartResult -libjingle_peerconnection_unittes!testing::internal::DefaultPerThreadTestPartResultReporter::ReportTestPartResult -libjingle_peerconnection_unittes!testing::UnitTest::AddTestPartResult -libjingle_peerconnection_unittes!testing::internal::ReportFailureInUnknownLocation -libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> - -HANDLE LEAK -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (35_tmp) -system call NtCreateEvent -KERNELBASE.dll!CreateEventExW -KERNELBASE.dll!CreateEventW -libjingle_peerconnection_unittes!webrtc::EventWindows::EventWindows -libjingle_peerconnection_unittes!webrtc::EventWrapper::Create -libjingle_peerconnection_unittes!webrtc::ProcessThreadImpl::ProcessThreadImpl -libjingle_peerconnection_unittes!webrtc::ProcessThread::CreateProcessThread -libjingle_peerconnection_unittes!webrtc::voe::SharedData::SharedData -libjingle_peerconnection_unittes!webrtc::VoiceEngineImpl::VoiceEngineImpl -libjingle_peerconnection_unittes!webrtc::GetVoiceEngine -libjingle_peerconnection_unittes!webrtc::VoiceEngine::Create -libjingle_peerconnection_unittes!cricket::VoEWrapper::VoEWrapper -libjingle_peerconnection_unittes!cricket::WebRtcVoiceEngine::WebRtcVoiceEngine -libjingle_peerconnection_unittes!cricket::CompositeMediaEngine<>::CompositeMediaEngine<> -libjingle_peerconnection_unittes!cricket::WebRtcMediaEngine::WebRtcMediaEngine -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize_s -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::OnMessage -libjingle_peerconnection_unittes!talk_base::Thread::Send -libjingle_peerconnection_unittes!webrtc::PeerConnectionFactory::Initialize -libjingle_peerconnection_unittes!webrtc::CreatePeerConnectionFactory -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::SetUp -libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> - -UNINITIALIZED READ -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (36_tmp) -libjingle_peerconnection_unittes!webrtc::WebRtcSessionDescriptionFactory::InternalCreateAnswer -libjingle_peerconnection_unittes!webrtc::WebRtcSessionDescriptionFactory::CreateAnswer -libjingle_peerconnection_unittes!webrtc::WebRtcSession::CreateAnswer -libjingle_peerconnection_unittes!webrtc::PeerConnection::CreateAnswer -libjingle_peerconnection_unittes!webrtc::ReturnType<>::Invoke<> -libjingle_peerconnection_unittes!webrtc::MethodCall2<>::OnMessage -libjingle_peerconnection_unittes!talk_base::Thread::Send -libjingle_peerconnection_unittes!webrtc::MethodCall2<>::Marshal -libjingle_peerconnection_unittes!webrtc::PeerConnectionProxy::CreateAnswer -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::DoCreateOfferAnswer -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::DoCreateAnswer -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest::CreateAnswerAsLocalDescription -libjingle_peerconnection_unittes!PeerConnectionInterfaceTest_ReceiveOfferCreatePrAnswerAndAnswer_Test::TestBody -libjingle_peerconnection_unittes!testing::internal::HandleSehExceptionsInMethodIfSupported<> - -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3158 (37_tmp) -ntdll.dll!RtlIntegerToUnicodeString -ntdll.dll!RtlIntegerToUnicodeString -libjingle_peerconnection_unittes!talk_base::CriticalSection::Enter -libjingle_peerconnection_unittes!talk_base::CritScope::CritScope -libjingle_peerconnection_unittes!talk_base::LogMessage::GetLogToStream -libjingle_peerconnection_unittes!talk_base::LogMessage::ConfigureLogging -libjingle_peerconnection_unittes!main - UNINITIALIZED READ name=https://code.google.com/p/webrtc/issues/detail?id=3158 (38) libjingle_peerconnection_unittes!webrtc::WebRtcSessionDescriptionFactory::InternalCreateAnswer @@ -858,19 +690,6 @@ name=https://code.google.com/p/webrtc/issues/detail?id=3184 (7) *!webrtc::MouseCursorMonitorTest_ShapeOnly_Test::TestBody *!testing::internal::HandleSehExceptionsInMethodIfSupported<> -UNINITIALIZED READ -name=https://code.google.com/p/webrtc/issues/detail?id=3490 (1) -drmemorylib.dll!replace_memcmp -*!talk_base::AsyncWriteTest_TestWrite_Test::TestBody -*!testing::internal::HandleSehExceptionsInMethodIfSupported<> - -UNINITIALIZED READ -name=https://code.google.com/p/webrtc/issues/detail?id=3490 (2) -*!testing::internal::CmpHelperEQ<> -*!testing::internal::EqHelper<>::Compare<> -*!talk_base::AsyncWriteTest_TestWrite_Test::TestBody -*!testing::internal::HandleSehExceptionsInMethodIfSupported<> - UNINITIALIZED READ name=https://code.google.com/p/webrtc/issues/detail?id=3490 (3) drmemorylib.dll!replace_memcmp diff --git a/tools/valgrind-webrtc/memcheck/suppressions.txt b/tools/valgrind-webrtc/memcheck/suppressions.txt index 8281eb5a6..30d537a33 100644 --- a/tools/valgrind-webrtc/memcheck/suppressions.txt +++ b/tools/valgrind-webrtc/memcheck/suppressions.txt @@ -479,29 +479,6 @@ #----------------------------------------------------------------------- # 2. libjingle stuff (talk folder) -{ - bug_1976_1_tmp - Memcheck:Unaddressable - fun:pthread_mutex_unlock - fun:_ZN9talk_base15CriticalSection5LeaveEv - fun:_ZN9talk_base9CritScopeD1Ev - ... - fun:_ZN9talk_base6Thread15ProcessMessagesEi - fun:_ZN9talk_base6Thread3RunEv - fun:_ZN9talk_base6Thread6PreRunEPv -} -{ - bug_1976_2_tmp - Memcheck:Leak - fun:calloc - obj:/usr/lib/x86_64-linux-gnu/libnss3.so - ... - fun:NSS_NoDB_Init - fun:_ZN9talk_base10NSSContext13InitializeSSLEPFbPvE - fun:_ZN9talk_base13InitializeSSLEPFbPvE - fun:_ZN9talk_base10RandomTest13SetUpTestCaseEv - fun:_ZN7testing8TestCase16RunSetUpTestCaseEv -} { bug_2056_1 Memcheck:Leak @@ -530,75 +507,6 @@ fun:_ZN23SSLStreamAdapterTestTLS12TestTransferEi ... } -{ - bug_2100_3_tmp - Memcheck:Uninitialized - fun:tls1_enc - fun:ssl3_get_record - fun:ssl3_read_bytes - fun:ssl3_read_internal - fun:ssl3_read - fun:SSL_read - fun:_ZN9talk_base20OpenSSLStreamAdapter4ReadEPvmPmPi - ... -} -{ - bug_2100_4_tmp - Memcheck:Uninitialized - fun:_ZN7testing8internal11CmpHelperEQIjhEENS_15AssertionResultEPKcS4_RKT_RKT0_ - fun:_ZN7testing8internal8EqHelperILb0EE7CompareIjhEENS_15AssertionResultEPKcS6_RKT_RKT0_ - fun:_ZN24SSLStreamAdapterTestDTLS8ReadDataEPN9talk_base15StreamInterfaceE - ... -} -{ - bug_2100_5_tmp - Memcheck:Uninitialized - fun:dtls1_process_record - fun:dtls1_get_record - fun:dtls1_read_bytes - fun:ssl3_read_internal - fun:ssl3_read - fun:SSL_read - fun:_ZN9talk_base20OpenSSLStreamAdapter4ReadEPvmPmPi - ... -} -# For BIO_new_mem_buf -# http://www.openssl.org/support/faq.html#PROG13 -{ - BIO_new_mem_buf_1_tmp - Memcheck:Leak - fun:malloc - fun:default_malloc_ex - fun:CRYPTO_malloc - fun:BUF_MEM_new - fun:mem_new - fun:BIO_set - fun:BIO_new - fun:BIO_new_mem_buf - fun:_ZN9talk_base18OpenSSLCertificate13FromPEMStringERKSs - ... -} -{ - BIO_new_mem_buf_2_tmp - Memcheck:Leak - fun:malloc - fun:default_malloc_ex - fun:CRYPTO_malloc - fun:BUF_MEM_new - fun:mem_new - fun:BIO_set - fun:BIO_new - fun:BIO_new_mem_buf - fun:_ZN9talk_base15OpenSSLIdentity14FromPEMStringsERKSsS2_ -} -# For HttpServer.SignalsCloseAfterForcedCloseAll -{ - SignalsCloseAfterForcedCloseAll_tmp - Memcheck:Leak - fun:_Znw* - fun:_ZN9talk_base10HttpServer10Connection12BeginProcessEPNS_15StreamInterfaceE - ... -} # For tests that create XMPPClient which can only be deleted by task runner. { HangoutPubSubClientTest @@ -648,14 +556,6 @@ fun:_Znw* fun:_ZN*PubSubTasksTest*Ev } -# For tests that leaks by design. -{ - DoNotDeleteTask2_tmp - Memcheck:Leak - fun:_Znw* - ... - fun:_ZN9talk_base41unstarted_task_test_DoNotDeleteTask2_Test8TestBodyEv -} # failures which can't be reproduced locally { bug_2153_1