generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

AudioProcessing is not a Module.

Browse Source 
Remove Module as the base class of AudioProcessing. The inherited
methods were all no-ops.

TBR=bjornv

Review URL: https://webrtc-codereview.appspot.com/8779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5556 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
andrew@webrtc.org 2014-02-15 04:22:49 +00:00
parent b8c254abd6
commit f92aaff104
3 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/modules/audio_processing/audio_processing_impl.cc
View File

@ -71,9 +71,6 @@ AudioProcessing* AudioProcessing::Create(const Config& config) {
return apm;
}
int32_t AudioProcessing::TimeUntilNextProcess() { return -1; }
int32_t AudioProcessing::Process() { return -1; }
AudioProcessingImpl::AudioProcessingImpl(const Config& config)
: echo_cancellation_(NULL),
echo_control_mobile_(NULL),
@ -692,10 +689,6 @@ VoiceDetection* AudioProcessingImpl::voice_detection() const {
return voice_detection_;
}
int32_t AudioProcessingImpl::ChangeUniqueId(const int32_t id) {
return kNoError;
}
bool AudioProcessingImpl::is_data_processed() const {
int enabled_count = 0;
std::list<ProcessingComponent*>::const_iterator it;

3
webrtc/modules/audio_processing/audio_processing_impl.h
View File

@ -92,9 +92,6 @@ class AudioProcessingImpl : public AudioProcessing {
virtual NoiseSuppression* noise_suppression() const OVERRIDE;
virtual VoiceDetection* voice_detection() const OVERRIDE;
// Module methods.
virtual int32_t ChangeUniqueId(const int32_t id) OVERRIDE;
protected:
virtual int InitializeLocked();

7
webrtc/modules/audio_processing/include/audio_processing.h
View File

@ -15,7 +15,6 @@
#include <stdio.h> // FILE
#include "webrtc/common.h"
#include "webrtc/modules/interface/module.h"
#include "webrtc/typedefs.h"
struct AecCore;
@ -134,7 +133,7 @@ struct ExperimentalAgc {
// // Close the application...
// delete apm;
//
class AudioProcessing : public Module {
class AudioProcessing {
public:
// Creates an APM instance. Use one instance for every primary audio stream
// requiring processing. On the client-side, this would typically be one
@ -305,10 +304,6 @@ class AudioProcessing : public Module {
// will continue, but the parameter may have been truncated.
kBadStreamParameterWarning = -13
};
// Inherited from Module.
virtual int32_t TimeUntilNextProcess() OVERRIDE;
virtual int32_t Process() OVERRIDE;
};
// The acoustic echo cancellation (AEC) component provides better performance