generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add PRESUBMIT check for GYP files including source files above itself.

Browse Source 
This is needed because some tools does not support files
located above the project generated.

BUG=4185
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34069004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8166 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org 2015-01-27 13:13:24 +00:00
parent 76e5e207ad
commit f68ffca050
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
PRESUBMIT.py
View File

@ -123,6 +123,31 @@ def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api):
items=violating_files)] items=violating_files)]
return [] return []
def _CheckNoSourcesAboveGyp(input_api, gyp_files, output_api):
# Disallow referencing source files with paths above the GYP file location.
source_pattern = input_api.re.compile(r'sources.*?\[(.*?)\]',
re.MULTILINE | re.DOTALL)
file_pattern = input_api.re.compile(r"'(\.\./.*?)'")
violating_gyp_files = set()
violating_source_entries = []
for gyp_file in gyp_files:
contents = input_api.ReadFile(gyp_file)
for source_block_match in source_pattern.finditer(contents):
# Find all source list entries starting with ../ in the source block.
for file_list_match in file_pattern.finditer(source_block_match.group(0)):
violating_source_entries.append(file_list_match.group(0))
violating_gyp_files.add(gyp_file)
if violating_gyp_files:
return [output_api.PresubmitError(
'Referencing source files above the directory of the GYP file is not '
'allowed. Please introduce new GYP targets and/or GYP files in the '
'proper location instead.\n'
'Invalid source entries:\n'
'%s\n'
'Violating GYP files:' % '\n'.join(violating_source_entries),
items=violating_gyp_files)]
return []
def _CheckGypChanges(input_api, output_api): def _CheckGypChanges(input_api, output_api):
source_file_filter = lambda x: input_api.FilterSourceFile( source_file_filter = lambda x: input_api.FilterSourceFile(
x, white_list=(r'.+\.(gyp|gypi)$',)) x, white_list=(r'.+\.(gyp|gypi)$',))
@ -139,6 +164,7 @@ def _CheckGypChanges(input_api, output_api):
'BUILD.gn files are also updated.\nChanged GYP files:', 'BUILD.gn files are also updated.\nChanged GYP files:',
items=gyp_files)) items=gyp_files))
result.extend(_CheckNoRtcBaseDeps(input_api, gyp_files, output_api)) result.extend(_CheckNoRtcBaseDeps(input_api, gyp_files, output_api))
result.extend(_CheckNoSourcesAboveGyp(input_api, gyp_files, output_api))
return result return result
def _CheckUnwantedDependencies(input_api, output_api): def _CheckUnwantedDependencies(input_api, output_api):