generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PeerConnectionClient.createPeerConnectionClient was calling new PeerConnectionParameters and PeerConnectionClient.createPeerConnectionFactory, .createPeerConnection with invalid arguments.

Browse Source 
This CL makes sure the project compiles, it does not ensure the parameters now used are correct!

There may be something strange going on with the build files. I was previously able to recompile the whole project despite of the incorrect code, until I changed the file and tried again.
The changes made are just so that it will compile. The code should likely be updated by someone who knows what he/she is doing.

TBR=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45369004

Cr-Commit-Position: refs/heads/master@{#8526}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8526 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
hbos@webrtc.org 2015-02-27 12:42:48 +00:00
parent c68e0c9dfe
commit f296859c83
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
talk/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java
View File

@ -235,13 +235,18 @@ public class PeerConnectionClientTest extends InstrumentationTestCase
MockRenderer remoteRenderer) {
SignalingParameters signalingParameters = getTestSignalingParameters();
PeerConnectionParameters peerConnectionParameters =
new PeerConnectionParameters(0, 0, 0, 0, false);
new PeerConnectionParameters(
true, false, // adding whatever parameters to make it compile
0, 0, 0, 0,
"VP8", true,
0, "opus", // random audio codec
false);
PeerConnectionClient client = new PeerConnectionClient();
client.createPeerConnectionFactory(
getInstrumentation().getContext(), "VP8", true, null, this);
client.createPeerConnection(localRenderer, remoteRenderer,
signalingParameters, peerConnectionParameters);
client.createPeerConnectionFactory( // changed params to make it compile
getInstrumentation().getContext(), null, null, null);
client.createPeerConnection(null, null,
signalingParameters); // changed paramaters to make it compile
client.createOffer();
return client;
}