From e77c9c8df54d6a14a27e7c5e16bf55fb121426ef Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Wed, 11 Mar 2015 10:49:33 +0000 Subject: [PATCH] Build WebRtcMediaEngine2 outside of Chromium. Removes #ifdef WEBRTC_CHROMIUM_BUILD from talk/media/webrtc/webrtcmediaengine.cc. WebRtcVideoEngine2 is built on all platforms so there's no longer any need to guard this code under ifdefs. BUG=1788 R=sprang@webrtc.org Review URL: https://webrtc-codereview.appspot.com/42719004 Cr-Commit-Position: refs/heads/master@{#8679} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8679 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/media/webrtc/webrtcmediaengine.cc | 33 ++++++++++---------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/talk/media/webrtc/webrtcmediaengine.cc b/talk/media/webrtc/webrtcmediaengine.cc index 0f3a24079..71a77acda 100644 --- a/talk/media/webrtc/webrtcmediaengine.cc +++ b/talk/media/webrtc/webrtcmediaengine.cc @@ -25,38 +25,32 @@ * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#if defined(LIBPEERCONNECTION_LIB) || \ - defined(LIBPEERCONNECTION_IMPLEMENTATION) +#if defined(LIBPEERCONNECTION_LIB) || defined(LIBPEERCONNECTION_IMPLEMENTATION) #include "talk/media/webrtc/webrtcmediaengine.h" #include "talk/media/webrtc/webrtcvideoengine.h" -#ifdef WEBRTC_CHROMIUM_BUILD #include "talk/media/webrtc/webrtcvideoengine2.h" -#endif #include "talk/media/webrtc/webrtcvoiceengine.h" -#ifdef WEBRTC_CHROMIUM_BUILD #include "webrtc/system_wrappers/interface/field_trial.h" -#endif namespace cricket { -class WebRtcMediaEngine : - public CompositeMediaEngine { +class WebRtcMediaEngine + : public CompositeMediaEngine { public: WebRtcMediaEngine() {} WebRtcMediaEngine(webrtc::AudioDeviceModule* adm, - webrtc::AudioDeviceModule* adm_sc, - WebRtcVideoEncoderFactory* encoder_factory, - WebRtcVideoDecoderFactory* decoder_factory) { + webrtc::AudioDeviceModule* adm_sc, + WebRtcVideoEncoderFactory* encoder_factory, + WebRtcVideoDecoderFactory* decoder_factory) { voice_.SetAudioDeviceModule(adm, adm_sc); video_.SetExternalEncoderFactory(encoder_factory); video_.SetExternalDecoderFactory(decoder_factory); } }; -#ifdef WEBRTC_CHROMIUM_BUILD -class WebRtcMediaEngine2 : - public CompositeMediaEngine { +class WebRtcMediaEngine2 + : public CompositeMediaEngine { public: WebRtcMediaEngine2(webrtc::AudioDeviceModule* adm, webrtc::AudioDeviceModule* adm_sc, @@ -67,7 +61,6 @@ class WebRtcMediaEngine2 : video_.SetExternalEncoderFactory(encoder_factory); } }; -#endif // WEBRTC_CHROMIUM_BUILD } // namespace cricket @@ -77,14 +70,12 @@ cricket::MediaEngineInterface* CreateWebRtcMediaEngine( webrtc::AudioDeviceModule* adm_sc, cricket::WebRtcVideoEncoderFactory* encoder_factory, cricket::WebRtcVideoDecoderFactory* decoder_factory) { -#ifdef WEBRTC_CHROMIUM_BUILD if (webrtc::field_trial::FindFullName("WebRTC-NewVideoAPI") == "Enabled") { - return new cricket::WebRtcMediaEngine2( - adm, adm_sc, encoder_factory, decoder_factory); + return new cricket::WebRtcMediaEngine2(adm, adm_sc, encoder_factory, + decoder_factory); } -#endif // WEBRTC_CHROMIUM_BUILD - return new cricket::WebRtcMediaEngine( - adm, adm_sc, encoder_factory, decoder_factory); + return new cricket::WebRtcMediaEngine(adm, adm_sc, encoder_factory, + decoder_factory); } WRME_EXPORT