generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Big parameter passed as argument.

Browse Source 
BUG=C-10503, C-10504, C-10505

Review URL: https://webrtc-codereview.appspot.com/343011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1441 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
mflodman@webrtc.org 2012-01-17 12:44:41 +00:00
parent bd88f39767
commit e5297d2aaa
7 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/video_engine/include/vie_capture.h
View File

@ -191,7 +191,7 @@ class WEBRTC_DLLEXPORT ViECapture {
// Makes a capture device start capturing video frames. // Makes a capture device start capturing video frames.
virtual int StartCapture( virtual int StartCapture(
const int capture_id, const int capture_id,
const CaptureCapability capture_capability = CaptureCapability()) = 0; const CaptureCapability& capture_capability = CaptureCapability()) = 0;
// Stops a started capture device from capturing video frames. // Stops a started capture device from capturing video frames.
virtual int StopCapture(const int capture_id) = 0; virtual int StopCapture(const int capture_id) = 0;

2
src/video_engine/vie_capture_impl.cc
View File

@ -279,7 +279,7 @@ int ViECaptureImpl::DisconnectCaptureDevice(const int video_channel) {
} }
int ViECaptureImpl::StartCapture(const int capture_id, int ViECaptureImpl::StartCapture(const int capture_id,
const CaptureCapability capture_capability) { const CaptureCapability& capture_capability) {
WEBRTC_TRACE(kTraceApiCall, kTraceVideo, ViEId(instance_id_), WEBRTC_TRACE(kTraceApiCall, kTraceVideo, ViEId(instance_id_),
"%s(capture_id: %d)", __FUNCTION__, capture_id); "%s(capture_id: %d)", __FUNCTION__, capture_id);

2
src/video_engine/vie_capture_impl.h
View File

@ -45,7 +45,7 @@ class ViECaptureImpl
virtual int DisconnectCaptureDevice(const int video_channel); virtual int DisconnectCaptureDevice(const int video_channel);
virtual int StartCapture( virtual int StartCapture(
const int capture_id, const int capture_id,
const CaptureCapability capture_capability = CaptureCapability()); const CaptureCapability& capture_capability = CaptureCapability());
virtual int StopCapture(const int capture_id); virtual int StopCapture(const int capture_id);
virtual int SetRotateCapturedFrames(const int capture_id, virtual int SetRotateCapturedFrames(const int capture_id,
const RotateCapturedFrame rotation); const RotateCapturedFrame rotation);

2
src/video_engine/vie_capturer.cc
View File

@ -211,7 +211,7 @@ int ViECapturer::FrameCallbackChanged() {
return 0; return 0;
} }
WebRtc_Word32 ViECapturer::Start(const CaptureCapability capture_capability) { WebRtc_Word32 ViECapturer::Start(const CaptureCapability& capture_capability) {
WEBRTC_TRACE(kTraceInfo, kTraceVideo, ViEId(engine_id_, capture_id_), "%s", WEBRTC_TRACE(kTraceInfo, kTraceVideo, ViEId(engine_id_, capture_id_), "%s",
__FUNCTION__); __FUNCTION__);
int width; int width;

2
src/video_engine/vie_capturer.h
View File

@ -78,7 +78,7 @@ class ViECapturer
// Start/Stop. // Start/Stop.
WebRtc_Word32 Start( WebRtc_Word32 Start(
const CaptureCapability capture_capability = CaptureCapability()); const CaptureCapability& capture_capability = CaptureCapability());
WebRtc_Word32 Stop(); WebRtc_Word32 Stop();
bool Started(); bool Started();

2
src/video_engine/vie_file_recorder.cc
View File

@ -40,7 +40,7 @@ int ViEFileRecorder::StartRecording(const char* file_nameUTF8,
const VideoCodec& codec_inst, const VideoCodec& codec_inst,
AudioSource audio_source, AudioSource audio_source,
int audio_channel, int audio_channel,
const CodecInst audio_codec_inst, const CodecInst& audio_codec_inst,
VoiceEngine* voe_ptr, VoiceEngine* voe_ptr,
const FileFormats file_format) { const FileFormats file_format) {
CriticalSectionScoped lock(*recorder_cs_); CriticalSectionScoped lock(*recorder_cs_);

2
src/video_engine/vie_file_recorder.h
View File

@ -28,7 +28,7 @@ class ViEFileRecorder : protected OutStream {
int StartRecording(const char* file_nameUTF8, int StartRecording(const char* file_nameUTF8,
const VideoCodec& codec_inst, const VideoCodec& codec_inst,
AudioSource audio_source, int audio_channel, AudioSource audio_source, int audio_channel,
const CodecInst audio_codec_inst, const CodecInst& audio_codec_inst,
VoiceEngine* voe_ptr, VoiceEngine* voe_ptr,
const FileFormats file_format = kFileFormatAviFile); const FileFormats file_format = kFileFormatAviFile);
int StopRecording(); int StopRecording();