generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up StatsObserver's OnComplete methods (address TODOs).

Browse Source 
R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7898 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
tommi@webrtc.org
2014-12-15 13:22:54 +00:00
parent 3440fe1bc5
commit e2e199b894
3 changed files with 14 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
talk/app/webrtc/peerconnectioninterface.h
View File

@@ -113,18 +113,7 @@ class StreamCollectionInterface : public rtc::RefCountInterface {
class StatsObserver : public rtc::RefCountInterface {
public:
// TODO(tommi): Remove.
virtual void OnComplete(const std::vector<StatsReport>& reports) {}
// TODO(tommi): Make pure virtual and remove implementation.
virtual void OnComplete(const StatsReports& reports) {
std::vector<StatsReportCopyable> report_copies;
for (size_t i = 0; i < reports.size(); ++i)
report_copies.push_back(StatsReportCopyable(*reports[i]));
std::vector<StatsReport>* r =
reinterpret_cast<std::vector<StatsReport>*>(&report_copies);
OnComplete(*r);
}
virtual void OnComplete(const StatsReports& reports) = 0;
protected:
virtual ~StatsObserver() {}