generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Solve TSan warning about unlocking an unlocked mutex.

Browse Source 
In my previous cl, https://webrtc-codereview.appspot.com/52479004/, there is 'UnLock()' left when we switched to scoped lock, which will cause TSan warning sometimes.
===========================================================
WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (pid=9981)
#0 pthread_mutex_unlock <null> (libjingle_peerconnection_unittest+0x00000046836f)
#1 webrtc::CriticalSectionPosix::Leave() webrtc/system_wrappers/source/critical_section_posix.cc:39:10 (libjingle_peerconnection_unittest+0x000000bc368d)
#2 ~CriticalSectionScoped webrtc/system_wrappers/interface/critical_section_wrapper.h:46:48 (libjingle_peerconnection_unittest+0x000000a61fcb)
#3 webrtc::AudioDeviceLinuxPulse::RecThreadProcess() webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:3003 (libjingle_peerconnection_unittest+0x000000a61fcb)
===========================================================

BUG=3056
TEST=bots
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/56439004

Cr-Commit-Position: refs/heads/master@{#9282}
This commit is contained in:
Brave Yao 2015-05-26 16:29:16 +08:00
parent f09e09c7ee
commit e14e5f4468
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc
View File

@ -2986,7 +2986,6 @@ bool AudioDeviceLinuxPulse::RecThreadProcess()
// Read data and provide it to VoiceEngine // Read data and provide it to VoiceEngine
if (ReadRecordedData(sampleData, sampleDataSize) == -1) if (ReadRecordedData(sampleData, sampleDataSize) == -1)
{ {
UnLock();
return true; return true;
} }
PaLock(); PaLock();