From dd14b2add1c067c4af0ebfc89cb00030ae8ef15e Mon Sep 17 00:00:00 2001
From: "fischman@webrtc.org"
 <fischman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d>
Date: Mon, 12 Aug 2013 18:06:29 +0000
Subject: [PATCH] libjingle gyp: signal errors during gyp time to avoid cryptic
 failures during build time.

- $JAVA_HOME / java_home missing or not pointing to a JDK
- Multiple or zero mac codesigning identities

BUG=2206
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2012004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4527 4adac7df-926f-26a2-2b94-8c16560cd09d
---
 talk/build/common.gypi      | 14 +++++++++-----
 talk/libjingle_examples.gyp | 15 +++++++++++++--
 2 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/talk/build/common.gypi b/talk/build/common.gypi
index edbf0f3ca..a8fcd57aa 100644
--- a/talk/build/common.gypi
+++ b/talk/build/common.gypi
@@ -29,18 +29,22 @@
 
 {
   'variables': {
-   'webrtc_root%': '<(DEPTH)/webrtc',
+    'webrtc_root%': '<(DEPTH)/webrtc',
     # TODO(ronghuawu): Chromium build will need a different libjingle_root.
     'libjingle_root%': '<(DEPTH)',
     # TODO(ronghuawu): For now, disable the Chrome plugins, which causes a
     # flood of chromium-style warnings.
     'clang_use_chrome_plugins%': 0,
     'libpeer_target_type%': 'static_library',
-    # TODO(henrike): make sure waterfall bots have $JAVA_HOME configured
-    # properly and remove the default value below. See issue 2113.
-    'java_home%': '<!(python -c "import os; print os.getenv(\'JAVA_HOME\', \'/usr/lib/jvm/java-6-sun\');")',
     # Whether or not to build the ObjectiveC PeerConnection API & tests.
-    'libjingle_objc%' : 0,
+    'libjingle_objc%': 0,
+    'conditions': [
+      ['OS=="android" or OS=="linux"', {
+        # TODO(henrike): make sure waterfall bots have $JAVA_HOME configured
+        # properly and remove the default value below. See issue 2113.
+        'java_home%': '<!(python -c "import os; dir=os.getenv(\'JAVA_HOME\', \'/usr/lib/jvm/java-6-sun\'); assert os.path.exists(os.path.join(dir, \'include/jni.h\')), \'Point \\$JAVA_HOME or the java_home gyp variable to a directory containing include/jni.h!\'; print dir")',
+      }],
+    ],
   },
   'target_defaults': {
     'include_dirs': [
diff --git a/talk/libjingle_examples.gyp b/talk/libjingle_examples.gyp
index cc252b2a9..78bfe654f 100755
--- a/talk/libjingle_examples.gyp
+++ b/talk/libjingle_examples.gyp
@@ -266,9 +266,20 @@
               # Ideally app signing would be a part of gyp.
               # Delete if/when that comes to pass.
               'postbuild_name': 'Sign AppRTCDemo',
+              'variables': {
+                'variables': {
+                  'key_id%': '<!(security find-identity -p codesigning -v | grep "iPhone Developer" | awk \'{print $2}\')',
+                },
+                'key_id%': '<(key_id)',
+                # Total HACK to give a more informative message when multiple
+                # codesigning keys are present in the default keychain.  Ideally
+                # we could pick more intelligently among the keys, but as a
+                # first cut just tell the developer to specify a key identity
+                # explicitly.
+                'ensure_single_key': '<!(python -c "assert len(\'\'\'<(key_id)\'\'\') > 0 and \'\\n\' not in \'\'\'<(key_id)\'\'\', \'key_id gyp variable needs to be set explicitly because there are multiple codesigning keys, or none!\'")',
+              },
               'action': [
-                '/usr/bin/codesign', '-v', '--force', '--sign',
-                '<!(security find-identity -p codesigning -v | grep "iPhone Developer" | awk \'{print $2}\')',
+                '/usr/bin/codesign', '-v', '--force', '--sign', '<(key_id)',
                 '${BUILT_PRODUCTS_DIR}/AppRTCDemo.app',
               ],
             },