From db313b667a1ba7986aa87fab0f65b74e2de7b17b Mon Sep 17 00:00:00 2001 From: Henrik Kjellander Date: Thu, 2 Apr 2015 08:45:41 +0200 Subject: [PATCH] Disable EndToEndTest.ReceivedFecPacketsNotNacked on all platforms. The test seems to flake on all platforms. See webrtc:4328 for more info. BUG=4328 TBR=asapersson@webrtc.org Review URL: https://webrtc-codereview.appspot.com/43029004 Cr-Commit-Position: refs/heads/master@{#8919} --- webrtc/video/end_to_end_tests.cc | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc index 8fdde5687..110ab86a7 100644 --- a/webrtc/video/end_to_end_tests.cc +++ b/webrtc/video/end_to_end_tests.cc @@ -543,13 +543,8 @@ TEST_F(EndToEndTest, CanReceiveFec) { RunBaseTest(&test); } -// Flacky on ASan and TSan. See webrtc:4328. -#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER) -#define MAYBE_ReceivedFecPacketsNotNacked DISABLED_ReceivedFecPacketsNotNacked -#else -#define MAYBE_ReceivedFecPacketsNotNacked ReceivedFecPacketsNotNacked -#endif -TEST_F(EndToEndTest, MAYBE_ReceivedFecPacketsNotNacked) { +// Flacky on all platforms. See webrtc:4328. +TEST_F(EndToEndTest, DISABLED_ReceivedFecPacketsNotNacked) { // At low RTT (< kLowRttNackMs) -> NACK only, no FEC. // Configure some network delay. const int kNetworkDelayMs = 50;