generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable tests for TSan v2

Browse Source 
These are tests that fail and that I haven't been able to suppress.
I assume they're caused by the same bug in TSan v2 as described in
webrtc:2259.

BUG=2259,2334
TEST=Ran the tests similar to the instructions in the bugs, passed 100 iterations.
R=andrew@webrtc.org, hta@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2250004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4787 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org
2013-09-19 07:15:36 +00:00
parent 967bfff54d
commit d8a9b86671
3 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/system_wrappers/source/thread_unittest.cc
View File

@@ -20,6 +20,10 @@ bool NullRunFunction(void* obj) {
return true; return true;
} }
// Disable for TSan v2, see
// https://code.google.com/p/webrtc/issues/detail?id=2259 for details.
#if !defined(THREAD_SANITIZER)
TEST(ThreadTest, StartStop) { TEST(ThreadTest, StartStop) {
ThreadWrapper* thread = ThreadWrapper::CreateThread(&NullRunFunction, NULL); ThreadWrapper* thread = ThreadWrapper::CreateThread(&NullRunFunction, NULL);
unsigned int id = 42; unsigned int id = 42;
@@ -50,4 +54,6 @@ TEST(ThreadTest, RunFunctionIsCalled) {
delete thread; delete thread;
} }
#endif // if !defined(THREAD_SANITIZER)
} // namespace webrtc } // namespace webrtc

6
webrtc/test/channel_transport/udp_socket_manager_unittest.cc
View File

@@ -23,6 +23,10 @@
namespace webrtc { namespace webrtc {
namespace test { namespace test {
// Disable for TSan v2, see
// https://code.google.com/p/webrtc/issues/detail?id=2334 for details.
#if !defined(THREAD_SANITIZER)
TEST(UdpSocketManager, CreateCallsInitAndDoesNotLeakMemory) { TEST(UdpSocketManager, CreateCallsInitAndDoesNotLeakMemory) {
int32_t id = 42; int32_t id = 42;
uint8_t threads = 1; uint8_t threads = 1;
@@ -80,5 +84,7 @@ TEST(UdpSocketManager, UnremovedSocketsGetCollectedAtManagerDeletion) {
#endif #endif
} }
#endif // if !defined(THREAD_SANITIZER)
} // namespace test } // namespace test
} // namespace webrtc } // namespace webrtc

6
webrtc/test/channel_transport/udp_transport_unittest.cc
View File

@@ -108,6 +108,10 @@ private:
std::vector<MockUdpSocketWrapper*> sockets_created_; std::vector<MockUdpSocketWrapper*> sockets_created_;
}; };
// Disable for TSan v2, see
// https://code.google.com/p/webrtc/issues/detail?id=2334 for details.
#if !defined(THREAD_SANITIZER)
TEST_F(UDPTransportTest, CreateTransport) { TEST_F(UDPTransportTest, CreateTransport) {
int32_t id = 0; int32_t id = 0;
uint8_t threads = 1; uint8_t threads = 1;
@@ -115,6 +119,8 @@ TEST_F(UDPTransportTest, CreateTransport) {
UdpTransport::Destroy(transport); UdpTransport::Destroy(transport);
} }
#endif // if !defined(THREAD_SANITIZER)
// This test verifies that the mock_socket is not called from the constructor. // This test verifies that the mock_socket is not called from the constructor.
TEST_F(UDPTransportTest, ConstructorDoesNotCreateSocket) { TEST_F(UDPTransportTest, ConstructorDoesNotCreateSocket) {
int32_t id = 0; int32_t id = 0;