From ce2b44532ec2fe49e2dbb2aa5106e09ad6d6bd03 Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Sun, 9 Feb 2014 18:21:00 +0000 Subject: [PATCH] Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux" According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2 r5505 was committed to resolve exactly these flakes. Let's revert the disabling and see. BUG=2907 TBR=mallinath@webrtc.org > Disable failing libjingle_p2p_unittest test on Linux > > I realize this diables 84 test cases and for all platforms, which > I'm not really comfortable with. I tried finding a better way but > couldn't without doing significant changes to the file. > I think the tests either needs to be fixed or otherwise refactored > in order to make more fine-grained disabling possible. > > Another (too) large disabling was done by holmer@ in > https://webrtc-codereview.appspot.com/2227004 where he should only have > disabled them on Windows, if the failures in webrtc:2383 was all that > caused those flakes. > > BUG=2907 > TEST=Verified this ran 0 tests: > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay > TBR=wu@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/8309004 TBR=kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/8329004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5511 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/p2p/base/p2ptransportchannel_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/talk/p2p/base/p2ptransportchannel_unittest.cc b/talk/p2p/base/p2ptransportchannel_unittest.cc index 7fff3dad3..216c22e82 100644 --- a/talk/p2p/base/p2ptransportchannel_unittest.cc +++ b/talk/p2p/base/p2ptransportchannel_unittest.cc @@ -1079,7 +1079,7 @@ const P2PTransportChannelTest::Result* P2P_TEST(x, OPEN) \ FLAKY_P2P_TEST(x, NAT_FULL_CONE) \ FLAKY_P2P_TEST(x, NAT_ADDR_RESTRICTED) \ - FLAKY_P2P_TEST(x, NAT_PORT_RESTRICTED) \ + P2P_TEST(x, NAT_PORT_RESTRICTED) \ P2P_TEST(x, NAT_SYMMETRIC) \ FLAKY_P2P_TEST(x, NAT_DOUBLE_CONE) \ P2P_TEST(x, NAT_SYMMETRIC_THEN_CONE) \