generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Mark virtual overrides of ViENetwork and VoENetwork as such.

Browse Source 
This will make further changes to these classes safer by ensuring that the
compile breaks if the base class changes and not all overrides are fixed.

BUG=none
TEST=none
R=henrikg@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7305 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
henrikg@webrtc.org 2014-09-26 11:09:08 +00:00
parent 8b2e50cf83
commit ca110b808f
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
webrtc/video_engine/vie_network_impl.h
View File

@ -24,26 +24,29 @@ class ViENetworkImpl
public ViERefCount {
public:
// Implements ViENetwork.
virtual int Release();
virtual int Release() OVERRIDE;
virtual void SetNetworkTransmissionState(const int video_channel,
const bool is_transmitting);
const bool is_transmitting) OVERRIDE;
virtual int RegisterSendTransport(const int video_channel,
Transport& transport);
virtual int DeregisterSendTransport(const int video_channel);
Transport& transport) OVERRIDE;
virtual int DeregisterSendTransport(const int video_channel) OVERRIDE;
virtual int ReceivedRTPPacket(const int video_channel,
const void* data,
const int length,
const PacketTime& packet_time);
const PacketTime& packet_time) OVERRIDE;
virtual int ReceivedRTCPPacket(const int video_channel,
const void* data,
const int length);
virtual int SetMTU(int video_channel, unsigned int mtu);
const int length) OVERRIDE;
virtual int SetMTU(int video_channel, unsigned int mtu) OVERRIDE;
virtual int ReceivedBWEPacket(const int video_channel,
int64_t arrival_time_ms, int payload_size, const RTPHeader& header);
int64_t arrival_time_ms,
int payload_size,
const RTPHeader& header) OVERRIDE;
virtual bool SetBandwidthEstimationConfig(int video_channel,
const webrtc::Config& config);
virtual bool SetBandwidthEstimationConfig(
int video_channel,
const webrtc::Config& config) OVERRIDE;
protected:
explicit ViENetworkImpl(ViESharedData* shared_data);

11
webrtc/voice_engine/voe_network_impl.h
View File

@ -22,21 +22,22 @@ namespace webrtc
class VoENetworkImpl: public VoENetwork
{
public:
virtual int RegisterExternalTransport(int channel, Transport& transport);
virtual int RegisterExternalTransport(int channel,
Transport& transport) OVERRIDE;
virtual int DeRegisterExternalTransport(int channel);
virtual int DeRegisterExternalTransport(int channel) OVERRIDE;
virtual int ReceivedRTPPacket(int channel,
const void* data,
unsigned int length);
unsigned int length) OVERRIDE;
virtual int ReceivedRTPPacket(int channel,
const void* data,
unsigned int length,
const PacketTime& packet_time);
const PacketTime& packet_time) OVERRIDE;
virtual int ReceivedRTCPPacket(int channel,
const void* data,
unsigned int length);
unsigned int length) OVERRIDE;
protected:
VoENetworkImpl(voe::SharedData* shared);