generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed Version function from all modules.

Browse Source 
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
pwestin@webrtc.org
2012-01-04 15:00:12 +00:00
parent 94558d83bf
commit c450a19669
42 changed files with 5 additions and 979 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/modules/video_coding/main/source/video_coding_impl.cc
View File

@@ -229,51 +229,6 @@ VideoCodingModuleImpl::Process()
return returnValue;
}
// Returns version of the module and its components
WebRtc_Word32
VideoCodingModuleImpl::Version(WebRtc_Word8* version,
WebRtc_UWord32& remainingBufferInBytes,
WebRtc_UWord32& position) const
{
WEBRTC_TRACE(webrtc::kTraceModuleCall,
webrtc::kTraceVideoCoding,
VCMId(_id),
"Version()");
if (version == NULL)
{
WEBRTC_TRACE(webrtc::kTraceWarning,
webrtc::kTraceVideoCoding,
VCMId(_id),
"Invalid buffer pointer in argument to Version()");
return VCM_PARAMETER_ERROR;
}
WebRtc_Word8 ourVersion[] = "VideoCodingModule 1.1.0\n";
WebRtc_UWord32 ourLength = (WebRtc_UWord32)strlen(ourVersion);
if (remainingBufferInBytes < ourLength)
{
return VCM_MEMORY;
}
memcpy(&version[position], ourVersion, ourLength);
remainingBufferInBytes -= ourLength;
position += ourLength;
// Safe to truncate here.
WebRtc_Word32 ret = _codecDataBase.Version(version,
remainingBufferInBytes,
position);
if (ret < 0)
{
return ret;
}
// Ensure the strlen call is safe by terminating at the end of version.
version[position + remainingBufferInBytes - 1] = '\0';
ourLength = (WebRtc_UWord32)strlen(&version[position]);
remainingBufferInBytes -= (ourLength + 1); // include null termination.
position += (ourLength + 1);
return VCM_OK;
}
WebRtc_Word32
VideoCodingModuleImpl::Id() const
{

5
src/modules/video_coding/main/source/video_coding_impl.h
View File

@@ -63,11 +63,6 @@ public:
virtual ~VideoCodingModuleImpl();
// Returns version of the module and its components
WebRtc_Word32 Version(WebRtc_Word8* version,
WebRtc_UWord32& remainingBufferInBytes,
WebRtc_UWord32& position) const;
WebRtc_Word32 Id() const;
// Change the unique identifier of this object