generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Ensure build_demo.py run subprocesses with bash shell.

Browse Source 
It turns out the default shell becomes /bin/sh on Lucid. By specifying the shell for subprocess.check_call we ensure bash is used.

Thanks to yujie.mao@intel.com for pointing this out.

BUG=1659
TEST=Successful build with build_demo.py both on Ubuntu Lucid and Precise.
TBR=leozwang

Review URL: https://webrtc-codereview.appspot.com/1343004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3875 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org 2013-04-19 11:50:42 +00:00
parent a39a8fec16
commit c41478f7eb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/video_engine/test/android/build_demo.py
View File

@ -54,7 +54,8 @@ def main():
cmd = RunInAndroidEnv('ndk-build') cmd = RunInAndroidEnv('ndk-build')
print cmd print cmd
try: try:
subprocess.check_call(cmd, cwd=_CURRENT_DIR, shell=True) subprocess.check_call(cmd, cwd=_CURRENT_DIR, executable='/bin/bash',
shell=True)
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
print 'NDK build failed: %s' % e print 'NDK build failed: %s' % e
print '@@@STEP_FAILURE@@@' print '@@@STEP_FAILURE@@@'
@ -64,7 +65,8 @@ def main():
cmd = RunInAndroidEnv('ant %s' % options.target.lower()) cmd = RunInAndroidEnv('ant %s' % options.target.lower())
print cmd print cmd
try: try:
subprocess.check_call(cmd, cwd=_CURRENT_DIR, shell=True) subprocess.check_call(cmd, cwd=_CURRENT_DIR, executable='/bin/bash',
shell=True)
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
print 'Ant build failed: %s' % e print 'Ant build failed: %s' % e
print '@@@STEP_FAILURE@@@' print '@@@STEP_FAILURE@@@'