generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Prepare for removal of PeerConnectionObserver::OnError.

Browse Source 
Prepare for removal of constraints to PeerConnection::AddStream.

OnError has never been implemented and has been removed from the spec.
Also, constraints to PeerConnection::AddStream has also been removed from the spec and have never been implemented.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7605 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
perkj@webrtc.org
2014-11-04 11:31:29 +00:00
parent f37145f685
commit c2dd5ee2c0
23 changed files with 40 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
talk/app/webrtc/peerconnectioninterface.h
View File

@@ -252,11 +252,17 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
virtual rtc::scoped_refptr<StreamCollectionInterface>
remote_streams() = 0;
// Deprecated:
// TODO(perkj): Remove once its not used by Chrome.
virtual bool AddStream(MediaStreamInterface* stream,
const MediaConstraintsInterface* constraints) {
return AddStream(stream);
}
// Add a new MediaStream to be sent on this PeerConnection.
// Note that a SessionDescription negotiation is needed before the
// remote peer can receive the stream.
virtual bool AddStream(MediaStreamInterface* stream,
const MediaConstraintsInterface* constraints) = 0;
virtual bool AddStream(MediaStreamInterface* stream) = 0;
// Remove a MediaStream from this PeerConnection.
// Note that a SessionDescription negotiation is need before the
@@ -344,7 +350,9 @@ class PeerConnectionObserver {
kIceState,
};
virtual void OnError() = 0;
// Deprecated.
// TODO(perkj): Remove once its not used by Chrome.
virtual void OnError() {}
// Triggered when the SignalingState changed.
virtual void OnSignalingChange(
@@ -361,8 +369,7 @@ class PeerConnectionObserver {
virtual void OnRemoveStream(MediaStreamInterface* stream) = 0;
// Triggered when a remote peer open a data channel.
// TODO(perkj): Make pure virtual.
virtual void OnDataChannel(DataChannelInterface* data_channel) {}
virtual void OnDataChannel(DataChannelInterface* data_channel) = 0;
// Triggered when renegotiation is needed, for example the ICE has restarted.
virtual void OnRenegotiationNeeded() = 0;