From b5e60b6ca7746df6fddb45e12402fa2cdd8bfe59 Mon Sep 17 00:00:00 2001 From: "glaznev@webrtc.org" Date: Wed, 25 Feb 2015 19:18:29 +0000 Subject: [PATCH] Remove non necessary check from WebSocket send function. Peer connection may generate answer and ICE candidates before websocket client is registered. Remove check from sendAnswer() and sendLocalIceCandidate() functions and allow websocket client to accumulate messages and send them later once it will be registered. R=wzh@webrtc.org Review URL: https://webrtc-codereview.appspot.com/44379004 Cr-Commit-Position: refs/heads/master@{#8508} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8508 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../src/org/appspot/apprtc/WebSocketRTCClient.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/talk/examples/android/src/org/appspot/apprtc/WebSocketRTCClient.java b/talk/examples/android/src/org/appspot/apprtc/WebSocketRTCClient.java index 1142533f2..c05543550 100644 --- a/talk/examples/android/src/org/appspot/apprtc/WebSocketRTCClient.java +++ b/talk/examples/android/src/org/appspot/apprtc/WebSocketRTCClient.java @@ -233,10 +233,6 @@ public class WebSocketRTCClient implements AppRTCClient, Log.e(TAG, "Sending answer in loopback mode."); return; } - if (wsClient.getState() != WebSocketConnectionState.REGISTERED) { - reportError("Sending answer SDP in non registered state."); - return; - } JSONObject json = new JSONObject(); jsonPut(json, "sdp", sdp.description); jsonPut(json, "type", "answer"); @@ -268,10 +264,6 @@ public class WebSocketRTCClient implements AppRTCClient, } } else { // Call receiver sends ice candidates to websocket server. - if (wsClient.getState() != WebSocketConnectionState.REGISTERED) { - reportError("Sending ICE candidate in non registered state."); - return; - } wsClient.send(json.toString()); } }