From b3e5acfb663c43a34825ffda205bde29ee2aa468 Mon Sep 17 00:00:00 2001 From: "hclam@chromium.org" Date: Thu, 16 May 2013 21:13:02 +0000 Subject: [PATCH] Cleanup traces in WebRTC Remove some unused traces and add a trace counter for encoded video size. R=holmer@google.com, mflodman@webrtc.org, stefan@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1476004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4050 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc | 1 + webrtc/modules/video_coding/main/source/generic_encoder.cc | 3 --- webrtc/video_engine/vie_encoder.cc | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc index 4e737f23b..8aa76d0cd 100644 --- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc +++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc @@ -465,6 +465,7 @@ int VP8EncoderImpl::GetEncodedPartitions(const I420VideoFrame& input_image) { } } if (encoded_image_._length > 0) { + TRACE_COUNTER1("webrtc", "EncodedFrameSize", encoded_image_._length); encoded_image_._timeStamp = input_image.timestamp(); encoded_image_.capture_time_ms_ = input_image.render_time_ms(); encoded_image_._encodedHeight = raw_->h; diff --git a/webrtc/modules/video_coding/main/source/generic_encoder.cc b/webrtc/modules/video_coding/main/source/generic_encoder.cc index 490bcccc2..e10bccd90 100644 --- a/webrtc/modules/video_coding/main/source/generic_encoder.cc +++ b/webrtc/modules/video_coding/main/source/generic_encoder.cc @@ -12,7 +12,6 @@ #include "generic_encoder.h" #include "media_optimization.h" #include "../../../../engine_configurations.h" -#include "trace_event.h" namespace webrtc { @@ -178,8 +177,6 @@ VCMEncodedFrameCallback::Encoded( const CodecSpecificInfo* codecSpecificInfo, const RTPFragmentationHeader* fragmentationHeader) { - TRACE_EVENT2("webrtc", "VCM::Encoded", "timestamp", encodedImage._timeStamp, - "length", encodedImage._length); FrameType frameType = VCMEncodedFrame::ConvertFrameType(encodedImage._frameType); uint32_t encodedBytes = 0; diff --git a/webrtc/video_engine/vie_encoder.cc b/webrtc/video_engine/vie_encoder.cc index 32a6f2a71..f5e738944 100644 --- a/webrtc/video_engine/vie_encoder.cc +++ b/webrtc/video_engine/vie_encoder.cc @@ -813,9 +813,6 @@ int32_t ViEEncoder::SendData( const RTPVideoHeader* rtp_video_hdr) { { CriticalSectionScoped cs(data_cs_.get()); - TRACE_EVENT2("webrtc", "VE::SendData", - "timestamp", time_stamp, - "capture_time_ms", capture_time_ms); if (channels_dropping_delta_frames_ && frame_type == webrtc::kVideoFrameKey) { WEBRTC_TRACE(webrtc::kTraceStream, webrtc::kTraceVideo,