generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add dummy audio NACK APIs

Browse Source 
R=pwestin@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1579006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4151 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
niklas.enbom@webrtc.org 2013-05-31 21:13:52 +00:00
parent b1bba167f4
commit b35d2e3abc
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/voice_engine/include/voe_rtp_rtcp.h
View File

@ -220,6 +220,14 @@ public:
virtual int GetFECStatus( virtual int GetFECStatus(
int channel, bool& enabled, int& redPayloadtype) = 0; int channel, bool& enabled, int& redPayloadtype) = 0;
// This function enables Negative Acknowledgment (NACK) using RTCP,
// implemented based on RFC 4585. NACK retransmits RTP packets if lost on
// the network. This creates a lossless transport at the expense of delay.
// If using NACK, NACK should be enabled on both endpoints in a call.
virtual int SetNACKStatus(int channel,
bool enable,
int maxNoPackets) = 0;
// Enables capturing of RTP packets to a binary file on a specific // Enables capturing of RTP packets to a binary file on a specific
// |channel| and for a given |direction|. The file can later be replayed // |channel| and for a given |direction|. The file can later be replayed
// using e.g. RTP Tools rtpplay since the binary file format is // using e.g. RTP Tools rtpplay since the binary file format is

13
webrtc/voice_engine/voe_rtp_rtcp_impl.cc
View File

@ -568,6 +568,19 @@ int VoERTP_RTCPImpl::GetFECStatus(int channel,
#endif #endif
} }
int VoERTP_RTCPImpl::SetNACKStatus(int channel,
bool enable,
int maxNoPackets)
{
WEBRTC_TRACE(kTraceApiCall, kTraceVoice, VoEId(_shared->instance_id(), -1),
"SetNACKStatus(channel=%d, enable=%d, maxNoPackets=%d)",
channel, enable, maxNoPackets);
// Dummy for now
return 0;
}
int VoERTP_RTCPImpl::StartRTPDump(int channel, int VoERTP_RTCPImpl::StartRTPDump(int channel,
const char fileNameUTF8[1024], const char fileNameUTF8[1024],
RTPDirections direction) RTPDirections direction)

5
webrtc/voice_engine/voe_rtp_rtcp_impl.h
View File

@ -94,6 +94,11 @@ public:
virtual int GetFECStatus(int channel, bool& enabled, int& redPayloadtype); virtual int GetFECStatus(int channel, bool& enabled, int& redPayloadtype);
//NACK
virtual int SetNACKStatus(int channel,
bool enable,
int maxNoPackets);
// Store RTP and RTCP packets and dump to file (compatible with rtpplay) // Store RTP and RTCP packets and dump to file (compatible with rtpplay)
virtual int StartRTPDump(int channel, virtual int StartRTPDump(int channel,
const char fileNameUTF8[1024], const char fileNameUTF8[1024],