generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixes a bug causing NACKs to be dropped excessively at the send-side.

Browse Source 
This was introduced in r6472 where the target bitrate was changed to be stored in bits/s instead of kbits/s, but the storage type was accidentally left as uint16_t. This caused the bitrate to be truncated, which at times causes NACKs to be dropped due to insufficient bitrate available.

BUG=3518
TEST=Tested in Chrome, trybots and verified that it fixes the bug in vie_auto_test loopback test.
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6544 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
stefan@webrtc.org 2014-06-26 11:44:49 +00:00
parent 269605ce45
commit aa0e56e8e8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/rtp_rtcp/source/rtp_sender.h
View File

@ -397,7 +397,7 @@ class RTPSender : public RTPSenderInterface, public Bitrate::Observer {
// that by the time the function returns there is no guarantee // that by the time the function returns there is no guarantee
// that the target bitrate is still valid. // that the target bitrate is still valid.
scoped_ptr<CriticalSectionWrapper> target_bitrate_critsect_; scoped_ptr<CriticalSectionWrapper> target_bitrate_critsect_;
uint16_t target_bitrate_ GUARDED_BY(target_bitrate_critsect_); uint32_t target_bitrate_ GUARDED_BY(target_bitrate_critsect_);
}; };
} // namespace webrtc } // namespace webrtc