generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix WebRTC IP leaks.

Browse Source 
WebRTC binds to individual NICs and listens for incoming Stun packets. Sending stun through this specific NIC binding could make OS route the packet differently hence exposing non-VPN public IP.

The fix here is
1. to bind to any address (0:0:0:0) instead. This way, the routing will be the same as how chrome/http is.
2. also, remove the any all 0s addresses which happens when we bind to all 0s.

BUG=4276
R=juberti@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8418

Committed: https://code.google.com/p/webrtc/source/detail?r=8419

Review URL: https://webrtc-codereview.appspot.com/39129004

Cr-Commit-Position: refs/heads/master@{#8420}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8420 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
guoweis@webrtc.org 2015-02-18 20:27:17 +00:00
parent 931e0cf4b1
commit 9dfe7aac2e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/base/network.h
View File

@ -83,7 +83,8 @@ class NetworkManager {
// IP address. (i.e. INADDR_ANY for IPv4 or in6addr_any for IPv6). This is // IP address. (i.e. INADDR_ANY for IPv4 or in6addr_any for IPv6). This is
// useful as binding to such interfaces allow default routing behavior like // useful as binding to such interfaces allow default routing behavior like
// http traffic. // http traffic.
virtual void GetAnyAddressNetworks(NetworkList* networks) = 0; // TODO(guoweis): remove this body when chromium implements this.
virtual void GetAnyAddressNetworks(NetworkList* networks) {}
// Dumps a list of networks available to LS_INFO. // Dumps a list of networks available to LS_INFO.
virtual void DumpNetworks(bool include_ignored) {} virtual void DumpNetworks(bool include_ignored) {}