generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed CleanUp call in Windows, since I couldn't find a call to it.

Browse Source 
This solves Coverity issue 14424 by deleting the code.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2194 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
hta@webrtc.org 2012-05-08 11:40:06 +00:00
parent e553031580
commit 9cc186405f
2 changed files with 0 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/modules/udp_transport/source/udp_socket_windows.cc
View File

@ -301,59 +301,6 @@ void UdpSocketWindows::HasIncoming()
} }
} }
void UdpSocketWindows::CleanUp()
{
WEBRTC_TRACE(kTraceDebug, kTraceTransport, _id,
"UdpSocketWindows::CleanUp()");
_wantsIncoming = false;
if(_clientHandle != INVALID_HANDLE_VALUE)
{
assert(_filterHandle != INVALID_HANDLE_VALUE);
assert(_flowHandle != INVALID_HANDLE_VALUE);
if (_gtc)
{
_gtc->TcDeleteFilter(_filterHandle);
_gtc->TcDeleteFlow(_flowHandle);
_gtc->TcDeregisterClient(_clientHandle);
}
_clientHandle = INVALID_HANDLE_VALUE;
_filterHandle = INVALID_HANDLE_VALUE;
_flowHandle = INVALID_HANDLE_VALUE;
}
while(!_notSentPackets.Empty())
{
UDPPacket* packet = (UDPPacket*)_notSentPackets.First()->GetItem();
if(!packet)
{
break;
}
delete packet;
_notSentPackets.PopFront();
}
if (_socket != INVALID_SOCKET)
{
if (closesocket(_socket) == SOCKET_ERROR)
{
WEBRTC_TRACE(kTraceError, kTraceTransport, _id,
"closesocket() => error = %d", WSAGetLastError());
}
WEBRTC_TRACE(kTraceDebug, kTraceTransport, _id,
"WinSock::closesocket() done");
if(_addedToMgr)
{
WEBRTC_TRACE(kTraceDebug, kTraceTransport, _id,
"calling UdpSocketManager::RemoveSocket()");
_mgr->RemoveSocket(this);
}
}
}
void UdpSocketWindows::SetWritable() void UdpSocketWindows::SetWritable()
{ {
// Try to send packets that have been queued up. // Try to send packets that have been queued up.

1
src/modules/udp_transport/source/udp_socket_windows.h
View File

@ -53,7 +53,6 @@ public:
virtual WebRtc_Word32 SetTOS(const WebRtc_Word32 serviceType); virtual WebRtc_Word32 SetTOS(const WebRtc_Word32 serviceType);
protected: protected:
void CleanUp();
void HasIncoming(); void HasIncoming();
// Socket is free to process pending packets. // Socket is free to process pending packets.
void SetWritable(); void SetWritable();