Reorganize modules/video_capture.

- The usual elimination of main/source etc.
- Fully qualify "public" includes.
- Use lowercase for all directory names.

Review URL: https://webrtc-codereview.appspot.com/933010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3025 4adac7df-926f-26a2-2b94-8c16560cd09d

webrtc/modules/modules.gyp

@@ -24,14 +24,14 @@
     'bitrate_controller/bitrate_controller.gypi',
     'media_file/source/media_file.gypi',
     'remote_bitrate_estimator/remote_bitrate_estimator.gypi',
+    'rtp_rtcp/source/rtp_rtcp.gypi',
     'udp_transport/source/udp_transport.gypi',
     'utility/source/utility.gypi',
     'video_coding/codecs/i420/main/source/i420.gypi',
     'video_coding/main/source/video_coding.gypi',
-    'video_capture/main/source/video_capture.gypi',
+    'video_capture/video_capture.gypi',
     'video_processing/main/source/video_processing.gypi',
     'video_render/main/source/video_render.gypi',
-    'rtp_rtcp/source/rtp_rtcp.gypi',
   ],
   'conditions': [
     ['include_opus==1', {

webrtc/modules/video_capture/include/video_capture.h

@@ -8,11 +8,11 @@
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#ifndef WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_H_
+#ifndef WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_H_
-#define WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_H_
+#define WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_H_
 
-#include "modules/interface/module.h"
+#include "webrtc/modules/interface/module.h"
-#include "modules/video_capture/main/interface/video_capture_defines.h"
+#include "webrtc/modules/video_capture/include/video_capture_defines.h"
 
 namespace webrtc {
 
@@ -155,4 +155,4 @@ protected:
 };
 
 } // namespace webrtc
-#endif  // WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_H_
+#endif  // WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_H_

webrtc/modules/video_capture/include/video_capture_defines.h

@@ -8,13 +8,12 @@
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#ifndef WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_DEFINES_H_
+#ifndef WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_DEFINES_H_
-#define WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_DEFINES_H_
+#define WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_DEFINES_H_
 
-// Includes
+#include "webrtc/typedefs.h"
-#include "typedefs.h"
+#include "webrtc/modules/interface/module_common_types.h"
-#include "modules/interface/module_common_types.h"
+#include "webrtc/common_video/interface/i420_video_frame.h"
-#include "common_video/interface/i420_video_frame.h"
 
 namespace webrtc
 {
@@ -153,5 +152,6 @@ protected:
     virtual ~VideoCaptureFeedBack(){}
 };
 
-} //namespace webrtc
+}  // namespace webrtc
-#endif  // WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_DEFINES_H_
+
+#endif  // WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_DEFINES_H_

webrtc/modules/video_capture/include/video_capture_factory.h

@@ -11,10 +11,10 @@
 // This file contains interfaces used for creating the VideoCaptureModule
 // and DeviceInfo.
 
-#ifndef WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_FACTORY_H_
+#ifndef WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_FACTORY_H_
-#define WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_FACTORY_H_
+#define WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_FACTORY_H_
 
-#include "modules/video_capture/main/interface/video_capture.h"
+#include "webrtc/modules/video_capture/include/video_capture.h"
 
 namespace webrtc {
 
@@ -46,4 +46,4 @@ class VideoCaptureFactory {
 
 } // namespace webrtc
 
-#endif  // WEBRTC_MODULES_VIDEO_CAPTURE_MAIN_INTERFACE_VIDEO_CAPTURE_FACTORY_H_
+#endif  // WEBRTC_MODULES_VIDEO_CAPTURE_INCLUDE_VIDEO_CAPTURE_FACTORY_H_

webrtc/modules/video_capture/test/video_capture_unittest.cc

@@ -12,8 +12,8 @@
 
 #include "gtest/gtest.h"
 #include "modules/utility/interface/process_thread.h"
-#include "modules/video_capture/main/interface/video_capture.h"
+#include "webrtc/modules/video_capture/include/video_capture.h"
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "common_video/interface/i420_video_frame.h"
 #include "common_video/libyuv/include/webrtc_libyuv.h"
 #include "system_wrappers/interface/critical_section_wrapper.h"

webrtc/modules/video_capture/video_capture.gypi

@@ -10,77 +10,65 @@
   'targets': [
     {
       'target_name': 'video_capture_module',
-      'type': '<(library)',
+      'type': 'static_library',
       'dependencies': [
         'webrtc_utility',
         '<(webrtc_root)/common_video/common_video.gyp:common_video',
         '<(webrtc_root)/system_wrappers/source/system_wrappers.gyp:system_wrappers',
       ],
       'include_dirs': [
+        'include',
         '../interface',
-        '../../../interface',
         '<(webrtc_root)/common_video/libyuv/include',
       ],
-      'direct_dependent_settings': {
-        'include_dirs': [
-          '../interface',
-          '../../../interface',
-          '<(webrtc_root)/common_video/libyuv/include',
-        ],
-      },
       'sources': [
-        # interfaces
+        'device_info_impl.cc',
-        '../interface/video_capture.h',
+        'device_info_impl.h',
-        '../interface/video_capture_defines.h',
+        'include/video_capture.h',
-        '../interface/video_capture_factory.h',
+        'include/video_capture_defines.h',
-        # headers
+        'include/video_capture_factory.h',
         'video_capture_config.h',
         'video_capture_delay.h',
         'video_capture_impl.h',
-        'device_info_impl.h',
-
-        # DEFINE PLATFORM INDEPENDENT SOURCE FILES
         'video_capture_factory.cc',
         'video_capture_impl.cc',
-        'device_info_impl.cc',
       ],
       'conditions': [
         ['include_internal_video_capture==0', {
           'sources': [
-            'External/device_info_external.cc',
+            'external/device_info_external.cc',
-            'External/video_capture_external.cc',
+            'external/video_capture_external.cc',
           ],
         },{  # include_internal_video_capture == 1
           'conditions': [
-            # DEFINE PLATFORM SPECIFIC SOURCE FILES
             ['OS=="linux"', {
               'include_dirs': [
-                'Linux',
+                'linux',
               ],
               'sources': [
-                'Linux/device_info_linux.h',
+                'linux/device_info_linux.h',
-                'Linux/video_capture_linux.h',
+                'linux/video_capture_linux.h',
-                'Linux/device_info_linux.cc',
+                'linux/device_info_linux.cc',
-                'Linux/video_capture_linux.cc',
+                'linux/video_capture_linux.cc',
               ],
             }],  # linux
             ['OS=="mac"', {
               'sources': [
-                'Mac/QTKit/video_capture_recursive_lock.h',
+                'mac/qtkit/video_capture_recursive_lock.h',
-                'Mac/QTKit/video_capture_qtkit.h',
+                'mac/qtkit/video_capture_qtkit.h',
-                'Mac/QTKit/video_capture_qtkit_info.h',
+                'mac/qtkit/video_capture_qtkit_info.h',
-                'Mac/QTKit/video_capture_qtkit_info_objc.h',
+                'mac/qtkit/video_capture_qtkit_info_objc.h',
-                'Mac/QTKit/video_capture_qtkit_objc.h',
+                'mac/qtkit/video_capture_qtkit_objc.h',
-                'Mac/QTKit/video_capture_qtkit_utility.h',
+                'mac/qtkit/video_capture_qtkit_utility.h',
-                'Mac/video_capture_mac.mm',
+                'mac/qtkit/video_capture_qtkit.mm',
-                'Mac/QTKit/video_capture_qtkit.mm',
+                'mac/qtkit/video_capture_qtkit_objc.mm',
-                'Mac/QTKit/video_capture_qtkit_objc.mm',
+                'mac/qtkit/video_capture_recursive_lock.mm',
-                'Mac/QTKit/video_capture_recursive_lock.mm',
+                'mac/qtkit/video_capture_qtkit_info.mm',
-                'Mac/QTKit/video_capture_qtkit_info.mm',
+                'mac/qtkit/video_capture_qtkit_info_objc.mm',
-                'Mac/QTKit/video_capture_qtkit_info_objc.mm',
+                'mac/video_capture_mac.mm',
               ],
               'include_dirs': [
-                'Mac',
+                'mac',
               ],
               'link_settings': {
                 'xcode_settings': {
@@ -92,22 +80,22 @@
             }],  # mac
             ['OS=="win"', {
               'dependencies': [
-                '<(webrtc_root)/modules/video_capture/main/source/Windows/direct_show_base_classes.gyp:direct_show_base_classes',
+                '<(webrtc_root)/modules/video_capture/windows/direct_show_base_classes.gyp:direct_show_base_classes',
               ],
               'include_dirs': [
-                'Windows',
+                'windows',
               ],
               'sources': [
-                'Windows/help_functions_windows.h',
+                'windows/help_functions_windows.h',
-                'Windows/sink_filter_windows.h',
+                'windows/sink_filter_windows.h',
-                'Windows/video_capture_windows.h',
+                'windows/video_capture_windows.h',
-                'Windows/device_info_windows.h',
+                'windows/device_info_windows.h',
-                'Windows/capture_delay_values_windows.h',
+                'windows/capture_delay_values_windows.h',
-                'Windows/help_functions_windows.cc',
+                'windows/help_functions_windows.cc',
-                'Windows/sink_filter_windows.cc',
+                'windows/sink_filter_windows.cc',
-                'Windows/video_capture_windows.cc',
+                'windows/video_capture_windows.cc',
-                'Windows/device_info_windows.cc',
+                'windows/device_info_windows.cc',
-                'Windows/video_capture_factory_windows.cc',
+                'windows/video_capture_factory_windows.cc',
               ],
               'msvs_settings': {
                 'VCLibrarianTool': {
@@ -138,20 +126,19 @@
           'target_name': 'video_capture_module_test',
           'type': 'executable',
           'dependencies': [
-           'video_capture_module',
+            'video_capture_module',
-           'webrtc_utility',
+            'webrtc_utility',
-           '<(webrtc_root)/system_wrappers/source/system_wrappers.gyp:system_wrappers',
+            '<(webrtc_root)/system_wrappers/source/system_wrappers.gyp:system_wrappers',
-           '<(DEPTH)/testing/gtest.gyp:gtest',
+            '<(DEPTH)/testing/gtest.gyp:gtest',
           ],
           'include_dirs': [
-            '../interface',
+            'include',
           ],
           'sources': [
-            '../test/video_capture_unittest.cc',
+            'test/video_capture_unittest.cc',
-            '../test/video_capture_main_mac.mm',
+            'test/video_capture_main_mac.mm',
           ],
           'conditions': [
-           # DEFINE PLATFORM SPECIFIC INCLUDE AND CFLAGS
             ['OS=="mac" or OS=="linux"', {
               'cflags': [
                 '-Wno-write-strings',
@@ -192,8 +179,3 @@
   ],
 }
 
-# Local Variables:
-# tab-width:2
-# indent-tabs-mode:nil
-# End:
-# vim: set expandtab tabstop=2 shiftwidth=2:

webrtc/video_engine/test/auto_test/primitives/base_primitives.cc

@@ -12,7 +12,7 @@
 
 #include "vie_autotest.h"
 #include "vie_autotest_defines.h"
-#include "video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 
 void TestI420CallSetup(webrtc::ViECodec* codec_interface,
                        webrtc::VideoEngine* video_engine,

webrtc/video_engine/test/auto_test/primitives/codec_primitives.cc

@@ -14,7 +14,7 @@
 #include "vie_autotest.h"
 #include "vie_autotest_defines.h"
 #include "vie_to_file_renderer.h"
-#include "video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "tb_interfaces.h"
 
 // Helper functions.

webrtc/video_engine/test/auto_test/primitives/framedrop_primitives.cc

@@ -11,7 +11,7 @@
 #include <cassert>
 #include <string>
 
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "system_wrappers/interface/tick_util.h"
 #include "testsupport/fileutils.h"
 #include "testsupport/frame_reader.h"

webrtc/video_engine/test/auto_test/primitives/general_primitives.cc

@@ -10,7 +10,7 @@
 
 #include "general_primitives.h"
 
-#include "video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "vie_autotest.h"
 #include "vie_autotest_defines.h"
 #include "vie_to_file_renderer.h"

webrtc/video_engine/test/auto_test/source/vie_autotest_base.cc

@@ -8,7 +8,7 @@
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "video_engine/test/auto_test/interface/vie_autotest.h"
 #include "video_engine/test/auto_test/interface/vie_autotest_defines.h"
 #include "video_engine/test/auto_test/primitives/base_primitives.h"

webrtc/video_engine/test/auto_test/source/vie_autotest_capture.cc

@@ -11,7 +11,7 @@
 #include "common_types.h"  // NOLINT
 #include "engine_configurations.h"  // NOLINT
 #include "gflags/gflags.h"
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "system_wrappers/interface/tick_util.h"
 #include "video_engine/include/vie_base.h"
 #include "video_engine/include/vie_capture.h"

webrtc/video_engine/test/libvietest/include/tb_capture_device.h

@@ -13,7 +13,7 @@
 
 #include <string>
 
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 
 class TbInterfaces;
 

webrtc/video_engine/vie_capturer.cc

@@ -13,7 +13,7 @@
 #include "common_video/libyuv/include/webrtc_libyuv.h"
 #include "modules/interface/module_common_types.h"
 #include "modules/utility/interface/process_thread.h"
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "modules/video_processing/main/interface/video_processing.h"
 #include "modules/video_render/main/interface/video_render_defines.h"
 #include "system_wrappers/interface/critical_section_wrapper.h"

webrtc/video_engine/vie_capturer.h

@@ -15,7 +15,7 @@
 
 #include "common_types.h"  // NOLINT
 #include "engine_configurations.h"  // NOLINT
-#include "modules/video_capture/main/interface/video_capture.h"
+#include "webrtc/modules/video_capture/include/video_capture.h"
 #include "modules/video_coding/codecs/interface/video_codec_interface.h"
 #include "modules/video_coding/main/interface/video_coding.h"
 #include "modules/video_processing/main/interface/video_processing.h"

webrtc/video_engine/vie_impl.cc

@@ -18,7 +18,7 @@
 #include "system_wrappers/interface/trace.h"
 
 #ifdef WEBRTC_ANDROID
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "modules/video_render/main/interface/video_render.h"
 #endif
 

webrtc/video_engine/vie_input_manager.cc

@@ -13,7 +13,7 @@
 #include <cassert>
 
 #include "common_types.h"  // NOLINT
-#include "modules/video_capture/main/interface/video_capture_factory.h"
+#include "webrtc/modules/video_capture/include/video_capture_factory.h"
 #include "modules/video_coding/main/interface/video_coding.h"
 #include "modules/video_coding/main/interface/video_coding_defines.h"
 #include "system_wrappers/interface/critical_section_wrapper.h"

webrtc/video_engine/vie_input_manager.h

@@ -11,7 +11,7 @@
 #ifndef WEBRTC_VIDEO_ENGINE_VIE_INPUT_MANAGER_H_
 #define WEBRTC_VIDEO_ENGINE_VIE_INPUT_MANAGER_H_
 
-#include "modules/video_capture/main/interface/video_capture.h"
+#include "webrtc/modules/video_capture/include/video_capture.h"
 #include "system_wrappers/interface/map_wrapper.h"
 #include "system_wrappers/interface/scoped_ptr.h"
 #include "typedefs.h"  // NOLINT