generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make PCM16 available in Chromium builds.

Browse Source 
PCM16 can be useful for unit tests in Chromium. In particular Mikhal
would like to use it for ChromeCast.

This currently (r222592) has no impact on Chrome binary size, presumably
because PCM16 is unused and the linker strips the symbols.

To measure the potential impact, I looked at the size (bytes) of
out/Release/vie_auto_test on Linux with various codecs removed:
r4724    : 4567384
No PCM16 : 4565936
No ILBC  : 4500424
No G722  : 4555800
No RED   : 4565880

Giving the following size increases of adding each codec:
PCM16 :  1.4 kB (0.03%)
ILBC  : 70.0 kB (1.49%)
G722  : 11.6 kB (0.25%)
RED   :  1.5 kB (0.03%)

R=mikhal@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2195005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4732 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
andrew@webrtc.org
2013-09-12 01:30:30 +00:00
parent 89df092807
commit 8fa03a15ab
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/engine_configurations.h
View File

@@ -34,12 +34,14 @@
// (which are mandatory and don't have any defines).
#define WEBRTC_CODEC_AVT
// iLBC, G.722, PCM16B and Redundancy coding are excluded from Chromium and
// Mozilla builds.
// PCM16 is useful for testing and incurs only a small binary size cost.
#define WEBRTC_CODEC_PCM16
// iLBC, G.722, and Redundancy coding are excluded from Chromium and Mozilla
// builds to reduce binary size.
#if !defined(WEBRTC_CHROMIUM_BUILD) && !defined(WEBRTC_MOZILLA_BUILD)
#define WEBRTC_CODEC_ILBC
#define WEBRTC_CODEC_G722
#define WEBRTC_CODEC_PCM16
#define WEBRTC_CODEC_RED
#endif // !WEBRTC_CHROMIUM_BUILD && !WEBRTC_MOZILLA_BUILD