generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Adding an equals method for KeyValuePair for easier testing.

Browse Source 
With this we can write stuff like

assertThat(result.mandatory,
    hasItem(new KeyValuePair("minWidth", "1280")));

The above will currently fail because the object falls back to ==.

BUG=None

Review URL: https://codereview.webrtc.org/1193883006

Cr-Commit-Position: refs/heads/master@{#9494}
This commit is contained in:
phoglund 2015-06-24 01:11:46 -07:00 committed by Commit bot
parent 66f920ea57
commit 7ab5f801dd
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
talk/app/webrtc/java/src/org/webrtc/MediaConstraints.java
View File

@ -56,8 +56,24 @@ public class MediaConstraints {
public String toString() { public String toString() {
return key + ": " + value; return key + ": " + value;
} }
@Override
public boolean equals(Object other) {
if (this == other) {
return true;
}
if (other == null || getClass() != other.getClass()) {
return false;
}
KeyValuePair that = (KeyValuePair)other;
return key.equals(that.key) && value.equals(that.value);
} }
@Override
public int hashCode() {
return key.hashCode() + value.hashCode();
}
}
public final List<KeyValuePair> mandatory; public final List<KeyValuePair> mandatory;
public final List<KeyValuePair> optional; public final List<KeyValuePair> optional;