From 7a968a8f0727f337a9071189e78a65744d80be61 Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Wed, 18 Sep 2013 19:18:20 +0000 Subject: [PATCH] Add more TSan and Dr Memory suppressions for modules_unittests I'm trying to get these tests green on Windows in http://build.chromium.org/p/client.webrtc.fyi BUG=2319,2323 TEST=local runs passing R=phoglund@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2230004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4781 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../valgrind-webrtc/drmemory/suppressions.txt | 4 +- .../tsan/suppressions_win32.txt | 96 +++++++++---------- 2 files changed, 50 insertions(+), 50 deletions(-) diff --git a/tools/valgrind-webrtc/drmemory/suppressions.txt b/tools/valgrind-webrtc/drmemory/suppressions.txt index fb11db285..68181039c 100644 --- a/tools/valgrind-webrtc/drmemory/suppressions.txt +++ b/tools/valgrind-webrtc/drmemory/suppressions.txt @@ -25,7 +25,7 @@ system call NtGdiDeleteObjectApp GDI32.dll!DeleteDC GDI32.dll!DeleteDC *!webrtc::`anonymous namespace'::WindowCapturerWin::Capture -*!webrtc::WindowCapturerTest_Capture_Test::TestBody +... *!testing::internal::HandleSehExceptionsInMethodIfSupported UNINITIALIZED READ @@ -36,7 +36,7 @@ system call NtUserGetThreadDesktop parameter value #1 *!webrtc::`anonymous namespace'::ScreenCapturerWin::ScreenCapturerWin *!webrtc::ScreenCapturer::CreateWithDisableAero *!webrtc::ScreenCapturer::Create -*!webrtc::ScreenCapturerTest_StartCapturer_Test::TestBody +... *!testing::internal::HandleSehExceptionsInMethodIfSupported UNINITIALIZED READ diff --git a/tools/valgrind-webrtc/tsan/suppressions_win32.txt b/tools/valgrind-webrtc/tsan/suppressions_win32.txt index b63e452f9..defe2cf49 100644 --- a/tools/valgrind-webrtc/tsan/suppressions_win32.txt +++ b/tools/valgrind-webrtc/tsan/suppressions_win32.txt @@ -1,48 +1,48 @@ -# Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. -# -# Use of this source code is governed by a BSD-style license -# that can be found in the LICENSE file in the root of the source -# tree. An additional intellectual property rights grant can be found -# in the file PATENTS. All contributing project authors may -# be found in the AUTHORS file in the root of the source tree. - -# This file is used in addition to the one already maintained in Chrome. -# It acts as a place holder for future additions for WebRTC. -# It must exist for the Python wrapper script to work properly. - -{ - bug_2319_1 - ThreadSanitizer:Race - fun:webrtc::ThreadWindows::Run - fun:webrtc::ThreadWindows::StartThread - fun:_callthreadstartex - fun:_threadstartex - fun:BaseThreadInitThunk -} -{ - bug_2319_2 - ThreadSanitizer:Race - fun:TlsGetValue - fun:__set_flsgetvalue - fun:_threadstartex - fun:BaseThreadInitThunk -} -{ - bug_2319_3 - ThreadSanitizer:Race - fun:webrtc::ThreadWindows::SetNotAlive - ... -} -{ - bug_2319_4 - ThreadSanitizer:Race - fun:webrtc::ThreadWindows::Start - ... -} -{ - bug_2319_5 - ThreadSanitizer:Race - fun:webrtc::ThreadWindows::Stop - ... -} - +# Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. +# +# Use of this source code is governed by a BSD-style license +# that can be found in the LICENSE file in the root of the source +# tree. An additional intellectual property rights grant can be found +# in the file PATENTS. All contributing project authors may +# be found in the AUTHORS file in the root of the source tree. + +# This file is used in addition to the one already maintained in Chrome. +# It acts as a place holder for future additions for WebRTC. +# It must exist for the Python wrapper script to work properly. + +{ + bug_2319_1 + ThreadSanitizer:Race + ... + fun:webrtc::ThreadWindows::Run + fun:webrtc::ThreadWindows::StartThread + ... + fun:BaseThreadInitThunk +} +{ + bug_2319_2 + ThreadSanitizer:Race + fun:TlsGetValue + fun:__set_flsgetvalue + fun:_threadstartex + fun:BaseThreadInitThunk +} +{ + bug_2319_3 + ThreadSanitizer:Race + fun:webrtc::ThreadWindows::SetNotAlive + ... +} +{ + bug_2319_4 + ThreadSanitizer:Race + fun:webrtc::ThreadWindows::Start + ... +} +{ + bug_2319_5 + ThreadSanitizer:Race + fun:webrtc::ThreadWindows::Stop + ... +} +