generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove rtc::Buffer::length(), since no one uses it anymore

Browse Source 
Chromium now uses size() instead, just like WebRTC.

This CL also fixes a new length() call that had crept in.

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44119004

Cr-Commit-Position: refs/heads/master@{#9024}
This commit is contained in:
Karl Wiberg 2015-04-16 21:49:00 +02:00
parent d4e80146e3
commit 61c2a6f241
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/base/buffer.h
View File

@ -34,10 +34,6 @@ class Buffer {
size_t size() const { return size_; } size_t size() const { return size_; }
size_t capacity() const { return capacity_; } size_t capacity() const { return capacity_; }
// For backwards compatibility. TODO(kwiberg): Remove once Chromium doesn't
// need it anymore.
size_t length() const { return size(); }
Buffer& operator=(const Buffer& buf) { Buffer& operator=(const Buffer& buf) {
if (&buf != this) { if (&buf != this) {
Construct(buf.data(), buf.size(), buf.size()); Construct(buf.data(), buf.size(), buf.size());

2
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
View File

@ -1361,7 +1361,7 @@ TEST_F(RtpSenderVideoTest, SendVideoWithCVO) {
// Verify that this packet does have CVO byte. // Verify that this packet does have CVO byte.
VerifyCVOPacket( VerifyCVOPacket(
reinterpret_cast<uint8_t*>(transport_.sent_packets_[0]->data()), reinterpret_cast<uint8_t*>(transport_.sent_packets_[0]->data()),
transport_.sent_packets_[0]->length(), true, &map, kSeqNum, hdr.rotation); transport_.sent_packets_[0]->size(), true, &map, kSeqNum, hdr.rotation);
// Verify that this packet does have CVO byte. // Verify that this packet does have CVO byte.
VerifyCVOPacket( VerifyCVOPacket(