Splitted FileHandler into FrameReader and FrameWriter classes and moved them to testsupport in test.gyp.
Fixed unit tests so they don't use ASSERT_DEATH since that doesn't work with Valgrind. Fixed all Valgrind warnings except the one caused by CriticalSectionWrapper in system_wrappers. Reworked all includes and GYP include paths to use full directory paths. Removed util.h for logging, since it rendered warnings in Valgrind because of gflags. Replaced it with a verbose flag and a new function in video_quality_measurement.cc BUG= TEST=Passed test_support_unittests and video_codecs_test_framework_unittests on Linux, Mac and Windows. Review URL: http://webrtc-codereview.appspot.com/311001 git-svn-id: http://webrtc.googlecode.com/svn/trunk@1126 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
@@ -15,6 +15,9 @@
|
||||
{
|
||||
'target_name': 'test_support',
|
||||
'type': 'static_library',
|
||||
'include_dirs': [
|
||||
'.',
|
||||
],
|
||||
'direct_dependent_settings': {
|
||||
'include_dirs': [
|
||||
'.', # Some includes are hierarchical
|
||||
@@ -34,8 +37,16 @@
|
||||
'test_suite.h',
|
||||
'testsupport/fileutils.h',
|
||||
'testsupport/fileutils.cc',
|
||||
'testsupport/frame_reader.h',
|
||||
'testsupport/frame_reader.cc',
|
||||
'testsupport/frame_writer.h',
|
||||
'testsupport/frame_writer.cc',
|
||||
'testsupport/packet_reader.h',
|
||||
'testsupport/packet_reader.cc',
|
||||
'testsupport/metrics/video_metrics.h',
|
||||
'testsupport/metrics/video_metrics.cc',
|
||||
'testsupport/mock/mock_frame_reader.h',
|
||||
'testsupport/mock/mock_frame_writer.h',
|
||||
],
|
||||
},
|
||||
{
|
||||
@@ -58,7 +69,11 @@
|
||||
'<(webrtc_root)/../testing/gtest.gyp:gtest',
|
||||
],
|
||||
'sources': [
|
||||
'testsupport/unittest_utils.h',
|
||||
'testsupport/fileutils_unittest.cc',
|
||||
'testsupport/frame_reader_unittest.cc',
|
||||
'testsupport/frame_writer_unittest.cc',
|
||||
'testsupport/packet_reader_unittest.cc',
|
||||
'testsupport/metrics/video_metrics_unittest.cc',
|
||||
],
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user